215426 2020-08-12 13:32:45 -0700 [PlayStation] Build fix for !ENABLE(ACCESSIBILITY) after r265514 2020-08-12 16:44:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo stephan.szabo aboxhall apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1679802 0 stephan.szabo 2020-08-12 13:32:45 -0700 r265514 changed a name but not a reference in the !ENABLE(ACCESSIBILITY) code in AXObjectCache.h. 1679807 1 406471 stephan.szabo 2020-08-12 13:38:02 -0700 Created attachment 406471 Patch 1679828 2 ews-feeder 2020-08-12 14:31:50 -0700 Committed r265564: <https://trac.webkit.org/changeset/265564> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406471. 1679829 3 webkit-bug-importer 2020-08-12 14:32:40 -0700 <rdar://problem/66934803> 1679869 4 darin 2020-08-12 16:14:07 -0700 Two thoughts: 1) Seems like we should find a cleaner way to support !ENABLE(ACCESSIBILITY). The current way is complex to maintain. Or get rid of the notion entirely and intentionally write a platform-specific stub rather than having the platform-independent code contain a stub. There are *so* many functions stubbed out! 2) None of the EWS builds are !ENABLE(ACCESSIBILITY). What can we do about that? 1679877 5 stephan.szabo 2020-08-12 16:44:18 -0700 For #1, I was also wondering if having the enable flag actually made sense any more. I wasn't really sure if there were other targets for set top boxes or anything that might have it off, because even for PlayStation, it will be getting enabled, so it could end up on everywhere. 406471 2020-08-12 13:38:02 -0700 2020-08-12 14:31:51 -0700 Patch 215426.1.diff text/plain 1794 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OGZjMmM3ZWM3YWIuLjZmZGQ2YmJmMGM2YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIwLTA4LTEyICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bz b255LmNvbT4KKworICAgICAgICBbUGxheVN0YXRpb25dIEJ1aWxkIGZpeCBmb3IgIUVOQUJMRShB Q0NFU1NJQklMSVRZKSBhZnRlciByMjY1NTE0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU0MjYKKworICAgICAgICBBWE9iamVjdENhY2hlOjpnZXRP ckNyZWF0ZShBY2Nlc3NpYmlsaXR5Um9sZSkgY2hhbmdlZCBuYW1lcworICAgICAgICBpbiB0aGUg YWJvdmUsIGJ1dCB0aGUgc2hvcnQgZGVmaW5pdGlvbiBmb3IKKyAgICAgICAgIUVOQUJMRShBQ0NF U1NJQklMSVRZKSBkaWRuJ3QgdXBkYXRlLgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4 LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmg6IFVwZGF0ZSBuYW1l IHRvIG1hdGNoIG5ldyBuYW1lCisKIDIwMjAtMDgtMTIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRyZXNzIHBvc3QtbGFuZGluZyByZXZp ZXcgY29tbWVudCBmcm9tIFNhbSBXZWluaWcgZm9yIHIyNjU1MzYuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaCBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oCmluZGV4IGZjZDE3NmIzZmQ2Ni4uNDE1Yzgz NGMxNThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0 Q2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUu aApAQCAtNTQ2LDcgKzU0Niw3IEBAIGlubGluZSBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBBWE9iamVj dENhY2hlOjpnZXQoUmVuZGVyT2JqZWN0KikgeyByZXR1cm4gbnVsbHB0cjsKIGlubGluZSBBY2Nl c3NpYmlsaXR5T2JqZWN0KiBBWE9iamVjdENhY2hlOjpnZXQoTm9kZSopIHsgcmV0dXJuIG51bGxw dHI7IH0KIGlubGluZSBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBBWE9iamVjdENhY2hlOjpnZXQoV2lk Z2V0KikgeyByZXR1cm4gbnVsbHB0cjsgfQogaW5saW5lIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFY T2JqZWN0Q2FjaGU6OmdldE9yQ3JlYXRlKFJlbmRlck9iamVjdCopIHsgcmV0dXJuIG51bGxwdHI7 IH0KLWlubGluZSBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBBWE9iamVjdENhY2hlOjpnZXRPckNyZWF0 ZShBY2Nlc3NpYmlsaXR5Um9sZSkgeyByZXR1cm4gbnVsbHB0cjsgfQoraW5saW5lIEFjY2Vzc2li aWxpdHlPYmplY3QqIEFYT2JqZWN0Q2FjaGU6OmNyZWF0ZShBY2Nlc3NpYmlsaXR5Um9sZSkgeyBy ZXR1cm4gbnVsbHB0cjsgfQogaW5saW5lIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFYT2JqZWN0Q2Fj aGU6OmdldE9yQ3JlYXRlKE5vZGUqKSB7IHJldHVybiBudWxscHRyOyB9CiBpbmxpbmUgQWNjZXNz aWJpbGl0eU9iamVjdCogQVhPYmplY3RDYWNoZTo6Z2V0T3JDcmVhdGUoV2lkZ2V0KikgeyByZXR1 cm4gbnVsbHB0cjsgfQogaW5saW5lIEFYQ29yZU9iamVjdCogQVhPYmplY3RDYWNoZTo6cm9vdE9i amVjdCgpIHsgcmV0dXJuIG51bGxwdHI7IH0K