215393 2020-08-11 14:34:24 -0700 REGRESSION(r?): build-webkit --inspector-frontend always builds ImageDiff 2020-08-12 10:23:47 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg darin jbedard pnormand webkit-bug-importer oldest_to_newest 1679567 0 bburg 2020-08-11 14:34:24 -0700 --inspector-frontend is for engineers' use and should not compile non-inspector stuff. 1679568 1 webkit-bug-importer 2020-08-11 14:37:01 -0700 <rdar://problem/66862975> 1679580 2 406422 bburg 2020-08-11 15:00:17 -0700 Created attachment 406422 Patch 1679590 3 406422 darin 2020-08-11 15:08:20 -0700 Comment on attachment 406422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406422&action=review > Tools/Scripts/build-webkit:372 > + if (isInspectorFrontend()) { > + exit exitStatus($result); > + } This *is* perl, so you could us the perl one-liner style. 1679591 4 406422 darin 2020-08-11 15:08:52 -0700 Comment on attachment 406422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406422&action=review >> Tools/Scripts/build-webkit:372 >> + } > > This *is* perl, so you could us the perl one-liner style. use (or not, or rewrite the script in Python) 1679642 5 jbedard 2020-08-11 16:29:01 -0700 This should be fine, WebInspector's front-end is a configuration I overlooked when adding the code Brian is skipping, this should be safe! 1679654 6 bburg 2020-08-11 16:51:56 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 406422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406422&action=review > > >> Tools/Scripts/build-webkit:372 > >> + } > > > > This *is* perl, so you could us the perl one-liner style. > > use > > (or not, or rewrite the script in Python) I have successfully resisted the urge for 8 years. 😅 1679657 7 ews-feeder 2020-08-11 16:57:20 -0700 Committed r265537: <https://trac.webkit.org/changeset/265537> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406422. 1679714 8 406422 pnormand 2020-08-12 02:09:20 -0700 Comment on attachment 406422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406422&action=review >>>> Tools/Scripts/build-webkit:372 >>>> + } >>> >>> This *is* perl, so you could us the perl one-liner style. >> >> use >> >> (or not, or rewrite the script in Python) > > I have successfully resisted the urge for 8 years. 😅 I haven't ;) I'm using a local Python port of build-webkit. It's very minimal though. Re-implementing all the features of the Perl version would be a large task :( 1679759 9 bburg 2020-08-12 10:23:47 -0700 (In reply to Philippe Normand from comment #8) > Comment on attachment 406422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406422&action=review > > >>>> Tools/Scripts/build-webkit:372 > >>>> + } > >>> > >>> This *is* perl, so you could us the perl one-liner style. > >> > >> use > >> > >> (or not, or rewrite the script in Python) > > > > I have successfully resisted the urge for 8 years. 😅 > > I haven't ;) I'm using a local Python port of build-webkit. It's very > minimal though. Re-implementing all the features of the Perl version would > be a large task :( I don't think anyone would object to checking in what you have (as long as it's named something else and clearly marked as experimental). It's easier to improve once it's been shared ;-) 406422 2020-08-11 15:00:17 -0700 2020-08-11 16:57:20 -0700 Patch bug-215393-20200811150016.patch text/plain 1414 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODMyZDNjYWIzMzE2NWRkZGI4YjczNThhZTliN2QyY2Q4 MGY0Mjc2Yy4uN2NhMDhmNzE0YWYxNzFjN2I4NTc4MDZiZGEwYmE0ZjdhNGExNjI2NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTA4LTExICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocj8pOiBidWlsZC13ZWJraXQgLS1pbnNwZWN0b3ItZnJvbnRlbmQgYWx3YXlz IGJ1aWxkcyBJbWFnZURpZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNTM5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjY4NjI5NzU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1 aWxkLXdlYmtpdDogZXhpdCBhZnRlciBidWlsZGluZyBwcm9qZWN0cyBpZiAtLWluc3BlY3Rvci1m cm9udGVuZCBpcyBwYXNzZWQuCisgICAgICAgIFRoaXMgZmxhZyBpcyBmb3IgZGVzayBidWlsZHMg b25seSBhbmQgbm90IHVzZWQgYnkgYnVpbGQgaW5mcmFzdHJ1Y3R1cmUuIFdlIGRvbid0IG5lZWQg dG8gYnVpbGQgSW1hZ2VEaWZmCisgICAgICAgIHdoZW4gaXRlcmF0aW5nIG9uIHRoZSBXZWIgSW5z cGVjdG9yIGZyb250ZW5kLgorCiAyMDIwLTA4LTEwICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBvcmRlcmluZyBvZiBjb250cmlidXRvcnMu CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0CmluZGV4IDA1MDAwOTdiMmQ0OTM1OTA5ODQwYjI3OGE0NzYwMDBkMDI4N2Ey MGMuLjVmNTBjNWFlZGQzMmIxN2IzNzFmZWM3YWJiZmZlZTBiOTc2Y2QxZjEgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CkBAIC0zNjcsNiArMzY3LDEwIEBAIGlmIChpc0FwcGxlV2luV2ViS2l0KCkgfHwgaXNXaW5D YWlybygpIHx8IGlzUGxheVN0YXRpb24oKSB8fCBpc0ZUVygpKSB7CiAgICAgICAgIH0KICAgICB9 CiAKKyAgICBpZiAoaXNJbnNwZWN0b3JGcm9udGVuZCgpKSB7CisgICAgICAgIGV4aXQgZXhpdFN0 YXR1cygkcmVzdWx0KTsKKyAgICB9CisKICAgICAjIEJ1aWxkIEltYWdlRGlmZiBmb3IgaG9zdAog ICAgIG15IEBjb21tYW5kID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZShnZXRjd2QoKSwgIi9Ub29scy9T Y3JpcHRzL2J1aWxkLWltYWdlZGlmZiIpOwogICAgIGNoZGlyV2ViS2l0KCk7Cg==