21538 2008-10-10 17:19:49 -0700 Transitions between apparently matching transform values don't always work 2008-10-10 17:36:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser cmarrin dino oldest_to_newest 94957 0 simon.fraser 2008-10-10 17:19:49 -0700 Sometimes, transitions between different values of -webkit-transform don't work, even when they appear that they should. The problem is that the TransformOperations blendFunc() is changing the transform ops list out from under us; it is inserting identity operations in place of other operations that happen to be identity (like "rotate(0)"). Because of this, the transform operation lists in the old and new states no longer match by type, and the transition fails to run. 94959 1 24285 simon.fraser 2008-10-10 17:24:37 -0700 Created attachment 24285 Patch, testcase, changelog 94961 2 24285 darin 2008-10-10 17:25:59 -0700 Comment on attachment 24285 Patch, testcase, changelog r=me 94963 3 simon.fraser 2008-10-10 17:35:36 -0700 M WebCore/ChangeLog M WebCore/page/animation/AnimationBase.cpp M LayoutTests/ChangeLog A LayoutTests/transitions/matched-transform-functions.html A LayoutTests/transitions/matched-transform-functions-expected.txt r37496 = 72df8f02cd52c2446f5196f55b0af4e069d8d817 (trunk) 94964 4 simon.fraser 2008-10-10 17:35:45 -0700 Fooey 24285 2008-10-10 17:24:37 -0700 2008-10-10 17:25:59 -0700 Patch, testcase, changelog 21538_patch.txt text/plain 5093 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlOTJlOTBiLi4xMTVjOTIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTAt MTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxNTM4CisKKyAgICAgICAgVGVzdGNhc2UgdGhhdCBoYXMgYSBy b3RhdGUoMCkgaW4gdGhlIGxpc3Qgb2YgdHJhbnNmb3JtIG9wZXJhdGlvbnMsCisgICAgICAgIHRv IHRlc3QgYnVnIDIxNTM4LgorCisgICAgICAgICogdHJhbnNpdGlvbnMvbWF0Y2hlZC10cmFuc2Zv cm0tZnVuY3Rpb25zLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogdHJhbnNpdGlvbnMv bWF0Y2hlZC10cmFuc2Zvcm0tZnVuY3Rpb25zLmh0bWw6IEFkZGVkLgorCiAyMDA4LTEwLTEwICBU aW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBMYXlvdXQgdGVz dCBmb3IgcGxhY2Vob2xkZXIgYXR0cmlidXRlIGNoYW5nZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy90cmFuc2l0aW9ucy9tYXRjaGVkLXRyYW5zZm9ybS1mdW5jdGlvbnMtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvbWF0Y2hlZC10cmFuc2Zvcm0tZnVuY3Rpb25zLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5jZGMwYjdhCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvbWF0Y2hlZC10cmFuc2Zv cm0tZnVuY3Rpb25zLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK0JveCBzaG91bGQgc3Rh cnQgbW92aW5nIHJpZ2h0LCB0aGVuIG1vdmUgZG93bgorCitQQVNTCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy90cmFuc2l0aW9ucy9tYXRjaGVkLXRyYW5zZm9ybS1mdW5jdGlvbnMuaHRtbCBiL0xh eW91dFRlc3RzL3RyYW5zaXRpb25zL21hdGNoZWQtdHJhbnNmb3JtLWZ1bmN0aW9ucy5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjlmM2M4NDMKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy90cmFuc2l0aW9ucy9tYXRjaGVkLXRyYW5zZm9ybS1mdW5jdGlvbnMu aHRtbApAQCAtMCwwICsxLDYyIEBACis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFRE IEhUTUwgNC4wMSBUcmFuc2l0aW9uYWwvL0VOIgorICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0 bWw0L2xvb3NlLmR0ZCI+CisKKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorICA8bWV0YSBodHRw LWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCI+ CisgIDx0aXRsZT5DaGFuZ2UgdHJhbnNmb3JtIHdoaWxlIGFuaW1hdGluZzwvdGl0bGU+CisgIDxz dHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CisgICAgI2JveCB7CisgICAgICBo ZWlnaHQ6IDEwMHB4OworICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgYmFja2dyb3VuZC1jb2xv cjogYmx1ZTsKKyAgICAgIC13ZWJraXQtdHJhbnNpdGlvbi1wcm9wZXJ0eTogLXdlYmtpdC10cmFu c2Zvcm07CisgICAgICAtd2Via2l0LXRyYW5zaXRpb24tZHVyYXRpb246IDVzOworICAgICAgLXdl YmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZSgwLCAwKSByb3RhdGUoMCk7CisgICAgfQorICAgIAor ICA8L3N0eWxlPgorICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRm LTgiPgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVy LndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiB0ZXN0KCkKKyAgICB7Cisg ICAgICB2YXIgdCA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdib3gnKSkud2Via2l0VHJhbnNmb3JtOworICAgICAgLy8gZ3JhYiB0aGUgbGFzdCB2YWx1 ZSBmcm9tIHRoZSBtYXRyaXgoKQorICAgICAgdmFyIGxhc3RWYWx1ZVJFID0gLyhcZCspXCkkLzsK KyAgICAgIHZhciB5VHJhbnNsYXRlID0gcGFyc2VJbnQobGFzdFZhbHVlUkUuZXhlYyh0KSk7Cisg ICAgICAKKyAgICAgIHZhciByZXN1bHQgPSAoeVRyYW5zbGF0ZSA8IDIwMCkgPyAnUEFTUycgOiAn RkFJTDogdHJhbnNpdGlvbiBzaG91bGQgc3RpbGwgYmUgcnVubmluZywgc28geSA8IDIwMCc7Cisg ICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gcmVzdWx0 OworCisgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICB9CisgICAgCisgICAgZnVuY3Rp b24gc3RhcnRUZXN0KCkKKyAgICB7CisgICAgICB2YXIgYm94ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2JveCcpOworICAgICAgYm94LnN0eWxlLndlYmtpdFRyYW5zZm9ybSA9ICd0cmFuc2xh dGUoMTAwcHgsIDApIHJvdGF0ZSgwKSc7CisgICAgICAKKyAgICAgIHdpbmRvdy5zZXRUaW1lb3V0 KGZ1bmN0aW9uKCkgeworICAgICAgICBib3guc3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3RyYW5z bGF0ZSgwLCAyMDBweCkgcm90YXRlKDEwZGVnKSc7CisgICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0 KGZ1bmN0aW9uKCkgeworICAgICAgICAgIHRlc3QoKTsKKyAgICAgICAgfSwgMjAwKTsKKyAgICAg IH0sIDMwMCk7CisgICAgfQorICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgc3Rh cnRUZXN0LCBmYWxzZSkKKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPkJveCBzaG91 bGQgc3RhcnQgbW92aW5nIHJpZ2h0LCB0aGVuIG1vdmUgZG93bjwvcD4KKzxkaXYgaWQ9ImJveCI+ Cis8L2Rpdj4KKworPGRpdiBpZD0icmVzdWx0Ij4KKzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBk MjUxNWI5Li5jYTk5ODFkIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA4LTEwLTEwICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTUzOAorICAgICAgICAKKyAgICAgICAgVGhlIGJsZW5kRnVuYygpIGZvciBUcmFuc2Zvcm1P cGVyYXRpb25zIHNob3VsZCBuZXZlciBtZXNzIHdpdGggdGhlCisgICAgICAgIG9wZXJhdGlvbiBs aXN0cyBieSByZXBsYWNpbmcgc29tZSBvcHMgd2l0aCBpZGVudGl0eSwgb3RoZXJ3aXNlIHRoZSBs aXN0cworICAgICAgICBubyBsb25nZXIgbWF0Y2ggYW5kIHRyYW5zaXRpb25zIGJyZWFrLgorCisg ICAgICAgIFRlc3Q6IHRyYW5zaXRpb25zL21hdGNoZWQtdHJhbnNmb3JtLWZ1bmN0aW9ucy5odG1s CisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmJsZW5kRnVuYyk6CisKIDIwMDgtMTAtMTAgIERhdmlkIEh5YXR0ICA8aHlhdHRA YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGV4dGFyZWFzIHdvcmsgd2l0aCBjdXN0b20gQ1NT IHNjcm9sbGJhcnMgYW5kIHJlc2l6ZXJzLiAgTmVlZCB0byBhY2Nlc3MgdGhlIGNvcnJlY3QgcmVu ZGVyZXIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5j cHAgYi9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwCmluZGV4IDJmNWJm MzAuLmYwOWZmMGUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9u QmFzZS5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcApA QCAtMTIxLDggKzEyMSw4IEBAIHN0YXRpYyBpbmxpbmUgVHJhbnNmb3JtT3BlcmF0aW9ucyBibGVu ZEZ1bmMoY29uc3QgQW5pbWF0aW9uQmFzZSogYW5pbSwgY29uc3QgVHJhCiAgICAgICAgIHVuc2ln bmVkIHRvU2l6ZSA9IHRvLm9wZXJhdGlvbnMoKS5zaXplKCk7CiAgICAgICAgIHVuc2lnbmVkIHNp emUgPSBtYXgoZnJvbVNpemUsIHRvU2l6ZSk7CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7 IGkgPCBzaXplOyBpKyspIHsKLSAgICAgICAgICAgIFJlZlB0cjxUcmFuc2Zvcm1PcGVyYXRpb24+ IGZyb21PcCA9IChpIDwgZnJvbVNpemUgJiYgIWZyb20ub3BlcmF0aW9ucygpW2ldLT5pc0lkZW50 aXR5KCkpID8gZnJvbS5vcGVyYXRpb25zKClbaV0uZ2V0KCkgOiAwOwotICAgICAgICAgICAgUmVm UHRyPFRyYW5zZm9ybU9wZXJhdGlvbj4gdG9PcCA9IChpIDwgdG9TaXplICYmICF0by5vcGVyYXRp b25zKClbaV0tPmlzSWRlbnRpdHkoKSkgPyB0by5vcGVyYXRpb25zKClbaV0uZ2V0KCkgOiAwOwor ICAgICAgICAgICAgUmVmUHRyPFRyYW5zZm9ybU9wZXJhdGlvbj4gZnJvbU9wID0gKGkgPCBmcm9t U2l6ZSkgPyBmcm9tLm9wZXJhdGlvbnMoKVtpXS5nZXQoKSA6IDA7CisgICAgICAgICAgICBSZWZQ dHI8VHJhbnNmb3JtT3BlcmF0aW9uPiB0b09wID0gKGkgPCB0b1NpemUpID8gdG8ub3BlcmF0aW9u cygpW2ldLmdldCgpIDogMDsKICAgICAgICAgICAgIFJlZlB0cjxUcmFuc2Zvcm1PcGVyYXRpb24+ IGJsZW5kZWRPcCA9IHRvT3AgPyB0b09wLT5ibGVuZChmcm9tT3AuZ2V0KCksIHByb2dyZXNzKSA6 IChmcm9tT3AgPyBmcm9tT3AtPmJsZW5kKDAsIHByb2dyZXNzLCB0cnVlKSA6IDApOwogICAgICAg ICAgICAgaWYgKGJsZW5kZWRPcCkKICAgICAgICAgICAgICAgICByZXN1bHQub3BlcmF0aW9ucygp LmFwcGVuZChibGVuZGVkT3ApOwo=