215378 2020-08-11 09:02:26 -0700 Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit 2020-08-11 10:06:36 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson webkit-bug-importer youennf oldest_to_newest 1679412 0 youennf 2020-08-11 09:02:26 -0700 Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit 1679413 1 youennf 2020-08-11 09:03:10 -0700 <rdar://problem/66788144> 1679414 2 406384 youennf 2020-08-11 09:04:06 -0700 Created attachment 406384 Patch 1679416 3 406384 eric.carlson 2020-08-11 09:07:03 -0700 Comment on attachment 406384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406384&action=review > Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c:722 > + return; Nit: the indentation is strange. 1679420 4 406384 youennf 2020-08-11 09:18:07 -0700 Comment on attachment 406384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406384&action=review >> Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c:722 >> + return; > > Nit: the indentation is strange. Ah, I used space but this file is using tabs... 1679422 5 406385 youennf 2020-08-11 09:20:17 -0700 Created attachment 406385 Patch 1679435 6 ews-feeder 2020-08-11 10:06:35 -0700 Committed r265500: <https://trac.webkit.org/changeset/265500> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406385. 406384 2020-08-11 09:04:06 -0700 2020-08-11 09:20:12 -0700 Patch bug-215378-20200811180405.patch text/plain 1729 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA1M2Y4OTliYjA2NjMxODAzZGNjOTRiYWMzOWQ5Y2YwMDhkY2Y4YjVlLi5lMTMw ODJlNGYyODMyOWZlYTZjZDQyNjRhYmMyOTU1NmM3ZWYyZTM0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOC0xMSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlcnJ5LXBpY2sgdXNyc2N0cCAy NjRjZTQ1Mjg4NWJmZWQ3MzM0OGJhNmI2ZjYzNjkzYmMyZjUyYTZlIGNvbW1pdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1Mzc4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82Njc4ODE0ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNvdXJjZS90aGlyZF9wYXJ0eS91c3JzY3RwL3VzcnNjdHBsaWIv dXNyc2N0cGxpYi9uZXRpbmV0L3NjdHBfYXNjb25mLmM6CisgICAgICAgIChzY3RwX2hhbmRsZV9h c2NvbmYpOgorCiAyMDIwLTA4LTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBFbmFibGUgSDI2NCBsb3cgbGF0ZW5jeSBjb2RlIHBhdGggYnkgZGVmYXVsdCBm b3IgTWFjT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uv dGhpcmRfcGFydHkvdXNyc2N0cC91c3JzY3RwbGliL3VzcnNjdHBsaWIvbmV0aW5ldC9zY3RwX2Fz Y29uZi5jIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS90aGlyZF9wYXJ0eS91 c3JzY3RwL3VzcnNjdHBsaWIvdXNyc2N0cGxpYi9uZXRpbmV0L3NjdHBfYXNjb25mLmMKaW5kZXgg NzA0ZGZkZTAxMGMxNDZhOTg0ZWY2MjU4NjVkNWUyYzg5NDk0NmZkYy4uNjkxYmZmYmVmZWI0ZmVh NDk5MjdjMzI1ODNjNTU0NmJlMDY0ODMzNiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL1NvdXJjZS90aGlyZF9wYXJ0eS91c3JzY3RwL3VzcnNjdHBsaWIvdXNyc2N0cGxp Yi9uZXRpbmV0L3NjdHBfYXNjb25mLmMKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L1NvdXJjZS90aGlyZF9wYXJ0eS91c3JzY3RwL3VzcnNjdHBsaWIvdXNyc2N0cGxpYi9uZXRpbmV0 L3NjdHBfYXNjb25mLmMKQEAgLTcxOSw2ICs3MTksNyBAQCBzY3RwX2hhbmRsZV9hc2NvbmYoc3Ry dWN0IG1idWYgKm0sIHVuc2lnbmVkIGludCBvZmZzZXQsCiAJCWlmIChwYXJhbV9sZW5ndGggPD0g c2l6ZW9mKHN0cnVjdCBzY3RwX3BhcmFtaGRyKSkgewogCQkJU0NUUERCRyhTQ1RQX0RFQlVHX0FT Q09ORjEsICJoYW5kbGVfYXNjb25mOiBwYXJhbSBsZW5ndGggKCV1KSB0b28gc2hvcnRcbiIsIHBh cmFtX2xlbmd0aCk7CiAJCQlzY3RwX21fZnJlZW0obV9hY2spOworICAgICAgICAgICAgcmV0dXJu OwogCQl9CiAJCS8qIGdldCB0aGUgZW50aXJlIHBhcmFtZXRlciAqLwogCQlhcGggPSAoc3RydWN0 IHNjdHBfYXNjb25mX3BhcmFtaGRyICopc2N0cF9tX2dldHB0cihtLCBvZmZzZXQsIHBhcmFtX2xl bmd0aCwgYXBhcmFtX2J1Zik7Cg== 406385 2020-08-11 09:20:17 -0700 2020-08-11 10:06:35 -0700 Patch bug-215378-20200811182015.patch text/plain 1720 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCA1M2Y4OTliYjA2NjMxODAzZGNjOTRiYWMzOWQ5Y2YwMDhkY2Y4YjVlLi5lMTMw ODJlNGYyODMyOWZlYTZjZDQyNjRhYmMyOTU1NmM3ZWYyZTM0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOC0xMSAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlcnJ5LXBpY2sgdXNyc2N0cCAy NjRjZTQ1Mjg4NWJmZWQ3MzM0OGJhNmI2ZjYzNjkzYmMyZjUyYTZlIGNvbW1pdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1Mzc4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82Njc4ODE0ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNvdXJjZS90aGlyZF9wYXJ0eS91c3JzY3RwL3VzcnNjdHBsaWIv dXNyc2N0cGxpYi9uZXRpbmV0L3NjdHBfYXNjb25mLmM6CisgICAgICAgIChzY3RwX2hhbmRsZV9h c2NvbmYpOgorCiAyMDIwLTA4LTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBFbmFibGUgSDI2NCBsb3cgbGF0ZW5jeSBjb2RlIHBhdGggYnkgZGVmYXVsdCBm b3IgTWFjT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uv dGhpcmRfcGFydHkvdXNyc2N0cC91c3JzY3RwbGliL3VzcnNjdHBsaWIvbmV0aW5ldC9zY3RwX2Fz Y29uZi5jIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS90aGlyZF9wYXJ0eS91 c3JzY3RwL3VzcnNjdHBsaWIvdXNyc2N0cGxpYi9uZXRpbmV0L3NjdHBfYXNjb25mLmMKaW5kZXgg NzA0ZGZkZTAxMGMxNDZhOTg0ZWY2MjU4NjVkNWUyYzg5NDk0NmZkYy4uZjY1NWY2M2MyNzI0ODI4 MjcyMmEyMmJjMTI4NjJlMDEzYjQyOWQ4MSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkv bGlid2VicnRjL1NvdXJjZS90aGlyZF9wYXJ0eS91c3JzY3RwL3VzcnNjdHBsaWIvdXNyc2N0cGxp Yi9uZXRpbmV0L3NjdHBfYXNjb25mLmMKKysrIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L1NvdXJjZS90aGlyZF9wYXJ0eS91c3JzY3RwL3VzcnNjdHBsaWIvdXNyc2N0cGxpYi9uZXRpbmV0 L3NjdHBfYXNjb25mLmMKQEAgLTcxOSw2ICs3MTksNyBAQCBzY3RwX2hhbmRsZV9hc2NvbmYoc3Ry dWN0IG1idWYgKm0sIHVuc2lnbmVkIGludCBvZmZzZXQsCiAJCWlmIChwYXJhbV9sZW5ndGggPD0g c2l6ZW9mKHN0cnVjdCBzY3RwX3BhcmFtaGRyKSkgewogCQkJU0NUUERCRyhTQ1RQX0RFQlVHX0FT Q09ORjEsICJoYW5kbGVfYXNjb25mOiBwYXJhbSBsZW5ndGggKCV1KSB0b28gc2hvcnRcbiIsIHBh cmFtX2xlbmd0aCk7CiAJCQlzY3RwX21fZnJlZW0obV9hY2spOworCQkJcmV0dXJuOwogCQl9CiAJ CS8qIGdldCB0aGUgZW50aXJlIHBhcmFtZXRlciAqLwogCQlhcGggPSAoc3RydWN0IHNjdHBfYXNj b25mX3BhcmFtaGRyICopc2N0cF9tX2dldHB0cihtLCBvZmZzZXQsIHBhcmFtX2xlbmd0aCwgYXBh cmFtX2J1Zik7Cg==