215372 2020-08-11 06:30:01 -0700 [GTK] Do not accept drag operations when the matched target list is empty 2020-08-13 23:00:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1679379 0 cgarcia 2020-08-11 06:30:01 -0700 The drag doesn't really happen in the end, but we shouldn't change the cursor to the accept one. 1679380 1 406379 cgarcia 2020-08-11 06:32:13 -0700 Created attachment 406379 Patch 1679381 2 ews-watchlist 2020-08-11 06:32:55 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1680225 3 cgarcia 2020-08-13 23:00:40 -0700 Committed r265649: <https://trac.webkit.org/changeset/265649> 406379 2020-08-11 06:32:13 -0700 2020-08-13 15:39:25 -0700 Patch wk2-cancel-dnd.diff text/plain 2269 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzZmOWEyYmI3MjUyLi45YWM2NGY5NDczYTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjAtMDgtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIERvIG5vdCBhY2NlcHQgZHJhZyBvcGVyYXRpb25zIHdo ZW4gdGhlIG1hdGNoZWQgdGFyZ2V0IGxpc3QgaXMgZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTM3MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBpbml0aWFsaXplIG1fc2VsZWN0aW9u RGF0YSBpZiB3ZSBkb24ndCBoYXZlIHZhbGlkIHRhcmdldHMuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL2d0ay9Ecm9wVGFyZ2V0R3RrMy5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRyb3BUYXJn ZXQ6OmFjY2VwdCk6CisgICAgICAgIChXZWJLaXQ6OkRyb3BUYXJnZXQ6OmxlYXZlVGltZXJGaXJl ZCk6CisKIDIwMjAtMDgtMDkgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxl LmNvbT4KIAogICAgICAgICBbbWFjT1NdIERyYWcvZHJvcCBhbiBpbWFnZSBvZiBhIHVuc3VwcG9y dGVkIGZvcm1hdCB0byBhbiBmaWxlIGlucHV0IGVsZW1lbnQgc2hvdWxkIGNvbnZlcnQgaXQgdG8g YSBzdXBwb3J0ZWQgZm9ybWF0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL0Ryb3BUYXJnZXRHdGszLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n dGsvRHJvcFRhcmdldEd0azMuY3BwCmluZGV4IGVkYTQ4YTQwODVmZC4uYThhN2ZmODcwM2Q4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL0Ryb3BUYXJnZXRHdGsz LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL0Ryb3BUYXJnZXRHdGsz LmNwcApAQCAtMTAzLDcgKzEwMyw3IEBAIHZvaWQgRHJvcFRhcmdldDo6YWNjZXB0KHVuc2lnbmVk IHRpbWUpCiAgICAgfQogCiAgICAgbV9kYXRhUmVxdWVzdENvdW50ID0gMDsKLSAgICBtX3NlbGVj dGlvbkRhdGEgPSBTZWxlY3Rpb25EYXRhKCk7CisgICAgbV9zZWxlY3Rpb25EYXRhID0gV1RGOjpu dWxsb3B0OwogCiAgICAgLy8gV2ViQ29yZSBuZWVkcyB0aGUgc2VsZWN0aW9uIGRhdGEgdG8gZGVj aWRlLCBzbyB3ZSBuZWVkIHRvIHByZWxvYWQgdGhlCiAgICAgLy8gZGF0YSBvZiB0YXJnZXRzIHdl IHN1cHBvcnQuIE9uY2UgYWxsIGRhdGEgcmVxdWVzdHMgYXJlIGRvbmUgd2Ugc3RhcnQKQEAgLTEy OCw3ICsxMjgsMTEgQEAgdm9pZCBEcm9wVGFyZ2V0OjphY2NlcHQodW5zaWduZWQgdGltZSkKICAg ICAgICAgfQogICAgIH0KIAorICAgIGlmICh0YXJnZXRzLmlzRW1wdHkoKSkKKyAgICAgICAgcmV0 dXJuOworCiAgICAgbV9kYXRhUmVxdWVzdENvdW50ID0gdGFyZ2V0cy5zaXplKCk7CisgICAgbV9z ZWxlY3Rpb25EYXRhID0gU2VsZWN0aW9uRGF0YSgpOwogICAgIGZvciAoYXV0byogYXRvbSA6IHRh cmdldHMpCiAgICAgICAgIGd0a19kcmFnX2dldF9kYXRhKG1fd2ViVmlldywgbV9kcm9wLmdldCgp LCBhdG9tLCB0aW1lKTsKIH0KQEAgLTIyOSw3ICsyMzMsOCBAQCB2b2lkIERyb3BUYXJnZXQ6Omxl YXZlVGltZXJGaXJlZCgpCiAgICAgYXV0byogcGFnZSA9IHdlYmtpdFdlYlZpZXdCYXNlR2V0UGFn ZShXRUJLSVRfV0VCX1ZJRVdfQkFTRShtX3dlYlZpZXcpKTsKICAgICBBU1NFUlQocGFnZSk7CiAK LSAgICBEcmFnRGF0YSBkcmFnRGF0YSgmbV9zZWxlY3Rpb25EYXRhLnZhbHVlKCksICptX3Bvc2l0 aW9uLCBjb252ZXJ0V2lkZ2V0UG9pbnRUb1NjcmVlblBvaW50KG1fd2ViVmlldywgKm1fcG9zaXRp b24pLCB7IH0pOworICAgIFNlbGVjdGlvbkRhdGEgZW1wdHlEYXRhOworICAgIERyYWdEYXRhIGRy YWdEYXRhKG1fc2VsZWN0aW9uRGF0YSA/ICZtX3NlbGVjdGlvbkRhdGEudmFsdWUoKSA6ICZlbXB0 eURhdGEsICptX3Bvc2l0aW9uLCBjb252ZXJ0V2lkZ2V0UG9pbnRUb1NjcmVlblBvaW50KG1fd2Vi VmlldywgKm1fcG9zaXRpb24pLCB7IH0pOwogICAgIHBhZ2UtPmRyYWdFeGl0ZWQoZHJhZ0RhdGEp OwogICAgIHBhZ2UtPnJlc2V0Q3VycmVudERyYWdJbmZvcm1hdGlvbigpOwogCg==