215370 2020-08-11 05:53:07 -0700 Add JS console log message in case of capture failure 2020-08-14 13:51:33 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn hi hta jer.noble mkwst philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1679368 0 youennf 2020-08-11 05:53:07 -0700 Add JS console log message in case of capture failure 1679369 1 406376 youennf 2020-08-11 05:59:15 -0700 Created attachment 406376 Patch 1679387 2 406376 eric.carlson 2020-08-11 07:14:05 -0700 Comment on attachment 406376 Patch Thanks! 1679438 3 ews-feeder 2020-08-11 10:07:35 -0700 Committed r265501: <https://trac.webkit.org/changeset/265501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406376. 1679439 4 webkit-bug-importer 2020-08-11 10:08:16 -0700 <rdar://problem/66846429> 1680424 5 406376 hi 2020-08-14 13:51:33 -0700 Comment on attachment 406376 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406376&action=review > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:539 > + scriptExecutionContext()->addConsoleMessage(MessageSource::JS, MessageLevel::Error, "A MediaStreamTrack ended due to a capture failure"_s); For future reference, this probably should've used `MessageSource::Media` or `MessageSource::MediaStream`. `MessageSource::JS` is supposed to be for "this comes from JavaScript language logic". 406376 2020-08-11 05:59:15 -0700 2020-08-11 10:07:35 -0700 Patch bug-215370-20200811145914.patch text/plain 2716 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTIzMTBkMWRhYWRjYWFi ZDRjNDgyOTg2NDMxMzQyYTUxNzI2Yjc4NS4uZTMyYzZiMmI2NThhNGNlODMwMWJmZDAzN2ZhZTRi ZmE4YTg5OTA1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA4LTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgSlMgY29uc29sZSBs b2cgbWVzc2FnZSBpbiBjYXNlIG9mIGNhcHR1cmUgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1MzcwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSByZWJhc2VkIHRlc3QuCisK KyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2suY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFTdHJlYW1UcmFjazo6dHJhY2tFbmRlZCk6CisKIDIwMjAtMDgt MTEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEBQcm9taXNl LkByZXNvbHZlKG9iamVjdCkgaXMgb2JzZXJ2YWJsZSBieSB0aGUgcGFnZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrLmNwcCBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW1UcmFjay5jcHAK aW5kZXggZDk3MzkyY2UxMTY5ZGFiMjkyNTcyMjk3MjIyMDIyNDQ0YmJhNmZhOC4uMmI5YmQzNjI3 MmFlODkyYjFkM2I3NzgyZTg5NzIzYWYzZDE5YTY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbVRyYWNrLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhU3RyZWFtVHJhY2suY3BwCkBAIC01MzUs NiArNTM1LDkgQEAgdm9pZCBNZWRpYVN0cmVhbVRyYWNrOjp0cmFja0VuZGVkKE1lZGlhU3RyZWFt VHJhY2tQcml2YXRlJikKICAgICBpZiAobV9lbmRlZCkKICAgICAgICAgcmV0dXJuOwogCisgICAg aWYgKG1faXNDYXB0dXJlVHJhY2sgJiYgbV9wcml2YXRlLT5zb3VyY2UoKS5jYXB0dXJlRGlkRmFp bCgpKQorICAgICAgICBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPmFkZENvbnNvbGVNZXNzYWdl KE1lc3NhZ2VTb3VyY2U6OkpTLCBNZXNzYWdlTGV2ZWw6OkVycm9yLCAiQSBNZWRpYVN0cmVhbVRy YWNrIGVuZGVkIGR1ZSB0byBhIGNhcHR1cmUgZmFpbHVyZSJfcyk7CisKICAgICAvLyAyLiBTZXQg dHJhY2sncyByZWFkeVN0YXRlIGF0dHJpYnV0ZSB0byBlbmRlZC4KICAgICBtX2VuZGVkID0gdHJ1 ZTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IDdiOTk5M2RjMDljMmNkNzFhM2E1M2ExODEzYzQxYTExODZkNzczYzguLjI1 NTlkMmFlZjA1YmM2MTY5NGJjYmJhYmRjOWI2NTJlMzdkODQ5ZTYgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MiBAQAorMjAyMC0wOC0xMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAg ICAgICAgQWRkIEpTIGNvbnNvbGUgbG9nIG1lc3NhZ2UgaW4gY2FzZSBvZiBjYXB0dXJlIGZhaWx1 cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTM3 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFz dC9tZWRpYXN0cmVhbS9tZWRpYS1zdHJlYW0tdHJhY2stc291cmNlLWZhaWx1cmUtZXhwZWN0ZWQu dHh0OgorCiAyMDIwLTA4LTExICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBAUHJvbWlzZS5AcmVzb2x2ZShvYmplY3QpIGlzIG9ic2VydmFibGUgYnkgdGhlIHBh Z2UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vbWVkaWEtc3RyZWFt LXRyYWNrLXNvdXJjZS1mYWlsdXJlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbWVk aWFzdHJlYW0vbWVkaWEtc3RyZWFtLXRyYWNrLXNvdXJjZS1mYWlsdXJlLWV4cGVjdGVkLnR4dApp bmRleCBkNjk5YzI2ZWM1MjE5YjE5MWI0ODQ3YzhmNjYxNGIyM2MwOTA5NTQxLi42MWI1MGU3ZWE1 N2Q2OWRjYjJhZThmOWNiYmE4NThmMTkyNzliMmFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9m YXN0L21lZGlhc3RyZWFtL21lZGlhLXN0cmVhbS10cmFjay1zb3VyY2UtZmFpbHVyZS1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9tZWRpYS1zdHJlYW0tdHJh Y2stc291cmNlLWZhaWx1cmUtZXhwZWN0ZWQudHh0CkBAIC0xLDMgKzEsNSBAQAorQ09OU09MRSBN RVNTQUdFOiBBIE1lZGlhU3RyZWFtVHJhY2sgZW5kZWQgZHVlIHRvIGEgY2FwdHVyZSBmYWlsdXJl CitDT05TT0xFIE1FU1NBR0U6IEEgTWVkaWFTdHJlYW1UcmFjayBlbmRlZCBkdWUgdG8gYSBjYXB0 dXJlIGZhaWx1cmUKIAogCiBQQVNTIENyZWF0ZSBzdHJlYW0gCg==