215369 2020-08-11 04:43:17 -0700 [css-flexbox] Only update the intrinsic height if we don't have override height 2020-08-11 08:23:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar svillar changseok clopez darin esprehn+autocc ews-watchlist glenn graouts jfernandez kondapallykalyan pdr svillar webkit-bug-importer zalan oldest_to_newest 1679363 0 svillar 2020-08-11 04:43:17 -0700 [css-flexbox] Don't update the intrinsic height if we don't have override height 1679365 1 406375 svillar 2020-08-11 04:58:10 -0700 Created attachment 406375 Patch 1679367 2 406375 jfernandez 2020-08-11 05:12:55 -0700 Comment on attachment 406375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406375&action=review > Source/WebCore/rendering/RenderBox.cpp:2781 > + if (isFloatingOrOutOfFlowPositioned() || !parent() || !parent()->isFlexibleBox() || hasOverrideContentLogicalHeight()) I think Grid items with stretch alignment will have the same problem with this cache. Wouldn't make more sense to just check for the HasOverrideContentLogicalHeight and remove the clauses about flexible box ? 1679389 3 svillar 2020-08-11 07:40:37 -0700 *** Bug 210088 has been marked as a duplicate of this bug. *** 1679393 4 svillar 2020-08-11 07:56:31 -0700 (In reply to Javier Fernandez from comment #2) > Comment on attachment 406375 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406375&action=review > > > Source/WebCore/rendering/RenderBox.cpp:2781 > > + if (isFloatingOrOutOfFlowPositioned() || !parent() || !parent()->isFlexibleBox() || hasOverrideContentLogicalHeight()) > > I think Grid items with stretch alignment will have the same problem with > this cache. Wouldn't make more sense to just check for the > HasOverrideContentLogicalHeight and remove the clauses about flexible box ? Right, we might eventually need it for grid too. However we cannot remove the checks now beause that triggers an infinite recursion between layoutBlock() <-> relayoutToAvoidWidows() that should be fixed as part of another patch. I could include a FIXME if you want. 1679394 5 406375 jfernandez 2020-08-11 08:03:17 -0700 Comment on attachment 406375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406375&action=review >>> Source/WebCore/rendering/RenderBox.cpp:2781 >>> + if (isFloatingOrOutOfFlowPositioned() || !parent() || !parent()->isFlexibleBox() || hasOverrideContentLogicalHeight()) >> >> I think Grid items with stretch alignment will have the same problem with this cache. Wouldn't make more sense to just check for the HasOverrideContentLogicalHeight and remove the clauses about flexible box ? > > Right, we might eventually need it for grid too. However we cannot remove the checks now beause that triggers an infinite recursion between > > layoutBlock() <-> relayoutToAvoidWidows() > > that should be fixed as part of another patch. I could include a FIXME if you want. Yes, please, add that FIXME. 1679395 6 406375 jfernandez 2020-08-11 08:03:50 -0700 Comment on attachment 406375 Patch r=me 1679397 7 svillar 2020-08-11 08:22:35 -0700 Committed r265497: <https://trac.webkit.org/changeset/265497> 1679398 8 webkit-bug-importer 2020-08-11 08:23:19 -0700 <rdar://problem/66840803> 406375 2020-08-11 04:58:10 -0700 2020-08-11 08:03:17 -0700 Patch bug-215369-20200811135808.patch text/plain 4519 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY0MzgzYjIyMTE1Mzg3 MWJlYjczOWNkZjQ0M2IxMjNkZTUwZDgxNi4uMjg1OTAxMTBmZTJhNmM4MTkzN2U3ZTc1OGRhZmI3 ZDRiMTIyMmUzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA4LTExICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxl eGJveF0gT25seSB1cGRhdGUgdGhlIGludHJpbnNpYyBoZWlnaHQgaWYgd2UgZG9uJ3QgaGF2ZSBh biBvdmVycmlkZSBoZWlnaHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNTM2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIElmIHdlIGRvIGhhdmUgYW4gb3ZlcnJpZGUgaGVpZ2h0LCBjaGlsZHJlbiB3aWxs IHNpemUgdGhlbXNlbHZlcyByZWxhdGl2ZSB0byB0aGUgb3ZlcnJpZGUgaGVpZ2h0CisgICAgICAg IChlLmcuIGZsZXhib3ggZmxleGluZy9zdHJldGNoaW5nLCBwZXJjZW50YWdlIGhlaWdodHMpLiBC ZWNhdXNlIGZsZXggaW50cmluc2ljIGhlaWdodCBpcyBiYXNlZCBvbgorICAgICAgICBpdHMgY2hp bGRyZW4sIGl0IHdvdWxkIHRoZW4gc3RvcmUgYW4gaW5jb3JyZWN0IGludHJpbnNpYyBoZWlnaHQu CisKKyAgICAgICAgVGhpcyBpcyBzcGVjaWFsbHkgcHJvYmxlbWF0aWMgd2l0aCBtaW4taGVpZ2h0 OmF1dG8gaXMgbmVzdGVkIGNvbHVtbiBmbGV4Ym94ZXMgd2hlcmUgZmxleGJveGVzIGFyZQorICAg ICAgICBmbGV4IGl0ZW1zIGF0IHRoZSBzYW1lIHRpbWUuCisKKyAgICAgICAgQmFzZWQgb24gQmxp bmsncyBodHRwczovL2NycmV2LmNvbS9jLzEyODM0ODIgYnkgPGNiaWVzaW5nZXJAY2hyb21pdW0u b3JnPgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJCb3g6OmNhY2hlSW50cmluc2ljQ29udGVudExvZ2ljYWxIZWlnaHRGb3JGbGV4 SXRlbSBjb25zdCk6IEVhcmx5IHJldHVybiBpZiB0aGVyZQorICAgICAgICBpcyBhbiBvdmVycmlk ZSBoZWlnaHQuCisKIDIwMjAtMDgtMTEgIEFsaWNpYSBCb3lhIEdhcmPDrWEgIDxhYm95YUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtNU0VdW0dTdHJlYW1lcl0gUmVtb3ZlIG1fc291cmNlQnVmZmVy UHJpdmF0ZUNsaWVudCBjaGVja3MgaW4gU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCA4ZmE2ZGZiMzQ5ZTJmM2NjZGZj NzdiZTVkMTFjMjg5YzdlMDRmNTExLi5lYTU0MmMxOWQwYWIxZDcyZTQwMWM3NTk2ZjEwOTYyM2Y0 OGRmZTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtMjc3OCw3 ICsyNzc4LDcgQEAgc3RhdGljIGJvb2wgc2hvdWxkRmxpcEJlZm9yZUFmdGVyTWFyZ2lucyhjb25z dCBSZW5kZXJTdHlsZSYgY29udGFpbmluZ0Jsb2NrU3R5bGUKIAogdm9pZCBSZW5kZXJCb3g6OmNh Y2hlSW50cmluc2ljQ29udGVudExvZ2ljYWxIZWlnaHRGb3JGbGV4SXRlbShMYXlvdXRVbml0IGhl aWdodCkgY29uc3QKIHsKLSAgICBpZiAoaXNGbG9hdGluZ09yT3V0T2ZGbG93UG9zaXRpb25lZCgp IHx8ICFwYXJlbnQoKSB8fCAhcGFyZW50KCktPmlzRmxleGlibGVCb3goKSkKKyAgICBpZiAoaXNG bG9hdGluZ09yT3V0T2ZGbG93UG9zaXRpb25lZCgpIHx8ICFwYXJlbnQoKSB8fCAhcGFyZW50KCkt PmlzRmxleGlibGVCb3goKSB8fCBoYXNPdmVycmlkZUNvbnRlbnRMb2dpY2FsSGVpZ2h0KCkpCiAg ICAgICAgIHJldHVybjsKICAgICBkb3duY2FzdDxSZW5kZXJGbGV4aWJsZUJveD4ocGFyZW50KCkp LT5zZXRDYWNoZWRDaGlsZEludHJpbnNpY0NvbnRlbnRMb2dpY2FsSGVpZ2h0KCp0aGlzLCBoZWln aHQpOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggNTcwMTYwZTNkYzBlZDQ0 OWU2ZmYwYWUzZWQ4NGQwOThhNzczYTEzZC4uMTRiODgzNDQ0OTc4YjJiMmUwYzVmNzE0MmQ2MmQ4 YzI4ZTZiNzA2NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMjAtMDgtMTEgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW2Nzcy1mbGV4Ym94XSBPbmx5IHVwZGF0ZSB0aGUgaW50cmluc2ljIGhlaWdo dCBpZiB3ZSBkb24ndCBoYXZlIG92ZXJyaWRlIGhlaWdodAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1MzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1m bGV4Ym94L2ZsZXgtbWluaW11bS1oZWlnaHQtZmxleC1pdGVtcy0wMTAtZXhwZWN0ZWQudHh0OiBS ZXBsYWNlZCBmYWlsdXJlcworICAgICAgICBieSBQQVNTIGV4cGVjdGF0aW9ucy4KKwogMjAyMC0w OC0xMCAgQ2xhcmsgV2FuZyAgPGNsYXJrX3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBB dWRpb1Byb2Nlc3NpbmdFdmVudCBDb25zdHJ1Y3RvcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleC1taW5p bXVtLWhlaWdodC1mbGV4LWl0ZW1zLTAxMC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4LW1pbmltdW0t aGVpZ2h0LWZsZXgtaXRlbXMtMDEwLWV4cGVjdGVkLnR4dAppbmRleCA5MWNiN2YyYmRjMGZjZThm NmM4YTgzMDEwZDU2YzU2YWI3YWNjZDRmLi5mOTg5ZGE5YjMxOGU4MWNmZDU5ZDZmYWZhNDNmNGJl OGE5MjQ3NDgzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4LW1pbmltdW0taGVpZ2h0LWZsZXgtaXRlbXMt MDEwLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4LW1pbmltdW0taGVpZ2h0LWZsZXgtaXRlbXMt MDEwLWV4cGVjdGVkLnR4dApAQCAtMSwzMiArMSw2IEBACiBHcmVlbiByZWN0YW5nbGUgc2hvdWxk IGJlIGVudGlyZWx5IHdpdGhpbiB0aGUgYmxhY2sgcmVjdGFuZ2xlCiAKIAotRkFJTCAuY29udGFp bmVyIDEgYXNzZXJ0X2VxdWFsczogCi08ZGl2IGlkPSJjb250YWluZXIiIGNsYXNzPSJjb250YWlu ZXIiIHN0eWxlPSJoZWlnaHQ6IDgwcHg7Ij4KLSAgPGRpdiBjbGFzcz0iZmxleGJveCBjb2x1bW4i IHN0eWxlPSJoZWlnaHQ6IDEwMCU7Ij4KLSAgICA8ZGl2IGNsYXNzPSJmbGV4Ym94IGZsZXgtb25l Ij4KLSAgICAgICAgPGRpdiBjbGFzcz0iZmxleGJveCBjb2x1bW4iPgotICAgICAgICAgIDxkaXYg Y2xhc3M9ImZsZXhib3ggY29sdW1uIGZsZXgtb25lIj4KLSAgICAgICAgICAgIDxkaXYgY2xhc3M9 ImlubmVyIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iODAiPgotICAgICAgICAgICAgPC9kaXY+Ci0g ICAgICAgICAgPC9kaXY+Ci0gICAgICAgIDwvZGl2PgotICAgIDwvZGl2PgotICA8L2Rpdj4KLTwv ZGl2PgotaGVpZ2h0IGV4cGVjdGVkIDgwIGJ1dCBnb3QgMzAwCi1GQUlMIC5jb250YWluZXIgMiBh c3NlcnRfZXF1YWxzOiAKLTxkaXYgaWQ9ImNvbnRhaW5lcjIiIGNsYXNzPSJjb250YWluZXIiIHN0 eWxlPSJoZWlnaHQ6IDgwcHg7Ij4KLSAgPGRpdiBjbGFzcz0iZmxleGJveCBjb2x1bW4iIHN0eWxl PSJoZWlnaHQ6IDEwMCU7Ij4KLSAgICA8ZGl2IGNsYXNzPSJmbGV4Ym94IGZsZXgtb25lIj4KLSAg ICAgICAgPGRpdiBjbGFzcz0iZmxleGJveCBjb2x1bW4iPgotICAgICAgICAgIDxkaXYgY2xhc3M9 ImZsZXhib3ggY29sdW1uIGZsZXgtb25lIj4KLSAgICAgICAgICAgIDxkaXYgY2xhc3M9ImlubmVy IiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iODAiPgotICAgICAgICAgICAgPC9kaXY+Ci0gICAgICAg ICAgPC9kaXY+Ci0gICAgICAgIDwvZGl2PgotICAgIDwvZGl2PgotICA8L2Rpdj4KLTwvZGl2Pgot aGVpZ2h0IGV4cGVjdGVkIDgwIGJ1dCBnb3QgMzAwCitQQVNTIC5jb250YWluZXIgMSAKK1BBU1Mg LmNvbnRhaW5lciAyIAogCg==