215342 2020-08-10 15:51:28 -0700 Web Inspector: add aria-label for [>>] overflow tab picker 2020-08-14 11:24:59 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED GoodFirstBug, InRadar P2 Normal --- 1 hi pangle hi inspector-bugzilla-changes nvasilyev pangle webkit-bug-importer oldest_to_newest 1679221 0 hi 2020-08-10 15:51:28 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. detach/undock Web Inspector 3. make the Web Inspector window very small horizontally/width-wis 4. hover over the [>>] overflow tab picker => [>>] overflow tab picker has no tooltip 1679222 1 webkit-bug-importer 2020-08-10 15:51:47 -0700 <rdar://problem/66804113> 1679224 2 nvasilyev 2020-08-10 15:55:22 -0700 On Big Sur, Safari and Finder both show ">>" icon for their toolbars and it doesn't have a tooltip. 1680163 3 nvasilyev 2020-08-13 16:49:20 -0700 When VoiceOver is enabled, it reads "More toolbar items". I think we should add aria-label with "More tab items" or, perhaps, "More tabs". 1680167 4 hi 2020-08-13 17:06:07 -0700 (In reply to Nikita Vasilyev from comment #2) > On Big Sur, Safari and Finder both show ">>" icon for their toolbars and it doesn't have a tooltip. Regardless of whether the rest of the system has a tooltip, I think we should have one. Our tab bar is different enough from the rest of the system that we should be as clear as possible wherever we can be. 1680278 5 406593 pangle 2020-08-14 08:31:29 -0700 Created attachment 406593 Patch 1680310 6 406593 hi 2020-08-14 10:11:23 -0700 Comment on attachment 406593 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406593&action=review > Source/WebInspectorUI/ChangeLog:9 > + * UserInterface/Views/PinnedTabBarItem.js: `displayName` is now used to set the `aria-label` for pinned tabs This is going to "clash" with the Search Tab and Settings Tab which already have `title` attributes. I think a simpler solution would just be to provide a `title` argument when creating the overflow tab picker: ```diff -this._tabPickerTabBarItem = new WI.PinnedTabBarItem(tabPickerRepresentedObject, "Images/TabPicker.svg", WI.UIString("Show hidden tabs")); +const tabPickerDisplayName = null; +this._tabPickerTabBarItem = new WI.PinnedTabBarItem(tabPickerRepresentedObject, "Images/TabPicker.svg", tabPickerDisplayName, WI.UIString("Show hidden tabs")); ``` 1680348 7 406607 pangle 2020-08-14 10:51:39 -0700 Created attachment 406607 Patch 1680358 8 406607 hi 2020-08-14 10:57:50 -0700 Comment on attachment 406607 Patch r=me, thanks for iterating :) 1680366 9 406607 nvasilyev 2020-08-14 11:10:09 -0700 Comment on attachment 406607 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406607&action=review > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: add aria-label for [>>] overflow tab picker This doesn't correspond to the actual change. Please retitle the bug in Bugzilla before generating the changelog going forward. 1680370 10 ews-feeder 2020-08-14 11:24:59 -0700 Committed r265682: <https://trac.webkit.org/changeset/265682> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406607. 406593 2020-08-14 08:31:29 -0700 2020-08-14 10:51:38 -0700 Patch bug-215342-20200814113128.patch text/plain 1941 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm NTdkNjcyYWNiMjFiMjIwNTI2YThlYzg1NzgyMDM3ZTM5N2RiNGYzLi5mMGNhYTZjNWI5ZTk5OTVl ODI0YjhjMmMyYzYwM2NmYjA5MTMxYTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wOC0xNCAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIGFyaWEtbGFiZWwgZm9yIFs+Pl0gb3ZlcmZs b3cgdGFiIHBpY2tlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE1MzQyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NjgwNDExMz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvUGlubmVkVGFiQmFySXRlbS5qczogYGRpc3BsYXlOYW1lYCBpcyBub3cgdXNlZCB0byBz ZXQgdGhlIGBhcmlhLWxhYmVsYCBmb3IgcGlubmVkIHRhYnMKKyAgICAgICAgKFdJLlBpbm5lZFRh YkJhckl0ZW0uZ2V0IGRpc3BsYXlOYW1lKToKKyAgICAgICAgKFdJLlBpbm5lZFRhYkJhckl0ZW0u cHJvdG90eXBlLnNldCBkaXNwbGF5TmFtZSk6CisgICAgICAgIChXSS5QaW5uZWRUYWJCYXJJdGVt KToKKwogMjAyMC0wOC0xMiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjU5MTcwKTogdGV4dCBpbnB1dHMgaW4g Ym94LXNoYWRvdyBlZGl0b3IgcHVzaCBzbGlkZXJzIG9mZnNjcmVlbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUGlubmVkVGFiQmFySXRlbS5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Bpbm5lZFRhYkJh ckl0ZW0uanMKaW5kZXggMzQyYzY3OTg4NDkxOTRjZTNkZGQ4MWU1OWE1ODExMzJmMDRkYmU0OS4u OWI1NzM2MGM0NDA1YTE1MzExZDAyMjU0ODViOTJjYWU5NTViZjU3NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUGlubmVkVGFiQmFySXRlbS5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9QaW5uZWRU YWJCYXJJdGVtLmpzCkBAIC00MSw0ICs0MSwyMSBAQCBXSS5QaW5uZWRUYWJCYXJJdGVtID0gY2xh c3MgUGlubmVkVGFiQmFySXRlbSBleHRlbmRzIFdJLlRhYkJhckl0ZW0KICAgICAgICAgbGV0IHtp bWFnZSwgZGlzcGxheU5hbWUsIHRpdGxlfSA9IHRhYkNvbnRlbnRWaWV3LmNvbnN0cnVjdG9yLnRh YkluZm8oKTsKICAgICAgICAgcmV0dXJuIG5ldyBXSS5QaW5uZWRUYWJCYXJJdGVtKHRhYkNvbnRl bnRWaWV3LCBpbWFnZSwgZGlzcGxheU5hbWUsIHRpdGxlKTsKICAgICB9CisgICAgCisgICAgLy8g UHVibGljCisKKyAgICBnZXQgZGlzcGxheU5hbWUoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHN1 cGVyLmRpc3BsYXlOYW1lOworICAgIH0KKworICAgIHNldCBkaXNwbGF5TmFtZShkaXNwbGF5TmFt ZSkKKyAgICB7CisgICAgICAgIGlmIChkaXNwbGF5TmFtZSkKKyAgICAgICAgICAgIHRoaXMuX2Vs ZW1lbnQuc2V0QXR0cmlidXRlKCJhcmlhLWxhYmVsIiwgZGlzcGxheU5hbWUpOworICAgICAgICBl bHNlCisgICAgICAgICAgICB0aGlzLl9lbGVtZW50LnJlbW92ZUF0dHJpYnV0ZSgiYXJpYS1sYWJl bCIpOworCisgICAgICAgIHN1cGVyLmRpc3BsYXlOYW1lID0gZGlzcGxheU5hbWU7CisgICAgfQog fTsK 406607 2020-08-14 10:51:39 -0700 2020-08-14 11:24:59 -0700 Patch bug-215342-20200814135139.patch text/plain 1912 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm NTdkNjcyYWNiMjFiMjIwNTI2YThlYzg1NzgyMDM3ZTM5N2RiNGYzLi5kZTNiMThjZDIyYmJmMTEw ZGFhNWI4ZmIzNWE5MjIxNGY2Nzk5NzQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wOC0xNCAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIGFyaWEtbGFiZWwgZm9yIFs+Pl0gb3ZlcmZs b3cgdGFiIHBpY2tlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE1MzQyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NjgwNDExMz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvVGFiQmFyLmpzOiBNb3ZlZCB0aXRsZSBmb3IgYHRhYlBpY2tlclRhYkJhckl0ZW1gIHRv IGB0aXRsZWAgYXR0cmlidXRlIGluc3RlYWQgb2YgdGhlIHVudXNlZCBgZGlzcGxheU5hbWVgIGFy Z3VtZW50CisgICAgICAgIChXSS5UYWJCYXIpOgorCiAyMDIwLTA4LTEyICBEZXZpbiBSb3Vzc28g IDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9O KHIyNTkxNzApOiB0ZXh0IGlucHV0cyBpbiBib3gtc2hhZG93IGVkaXRvciBwdXNoIHNsaWRlcnMg b2Zmc2NyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UYWJCYXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UYWJCYXIuanMKaW5kZXggNDNlNGQ0M2Y0Y2FmNGViY2Q1MjkxNzIwNGZmMDc0NDkzNDBl ZWViZi4uZmVmMDQxOGMxZDZhMTNiNmY1MmIwYjA4YWRkZDRkNTcxNTA5NDBhNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFiQmFyLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYkJhci5qcwpA QCAtNjIsNyArNjIsOCBAQCBXSS5UYWJCYXIgPSBjbGFzcyBUYWJCYXIgZXh0ZW5kcyBXSS5WaWV3 CiAgICAgICAgIHRoaXMuX2hpZGRlblRhYkJhckl0ZW1zID0gW107CiAKICAgICAgICAgY29uc3Qg dGFiUGlja2VyUmVwcmVzZW50ZWRPYmplY3QgPSBudWxsOwotICAgICAgICB0aGlzLl90YWJQaWNr ZXJUYWJCYXJJdGVtID0gbmV3IFdJLlBpbm5lZFRhYkJhckl0ZW0odGFiUGlja2VyUmVwcmVzZW50 ZWRPYmplY3QsICJJbWFnZXMvVGFiUGlja2VyLnN2ZyIsIFdJLlVJU3RyaW5nKCJTaG93IGhpZGRl biB0YWJzIikpOworICAgICAgICBjb25zdCB0YWJQaWNrZXJEaXNwbGF5TmFtZSA9IG51bGw7Cisg ICAgICAgIHRoaXMuX3RhYlBpY2tlclRhYkJhckl0ZW0gPSBuZXcgV0kuUGlubmVkVGFiQmFySXRl bSh0YWJQaWNrZXJSZXByZXNlbnRlZE9iamVjdCwgIkltYWdlcy9UYWJQaWNrZXIuc3ZnIiwgdGFi UGlja2VyRGlzcGxheU5hbWUsIFdJLlVJU3RyaW5nKCJTaG93IGhpZGRlbiB0YWJzIikpOwogICAg ICAgICB0aGlzLl90YWJQaWNrZXJUYWJCYXJJdGVtLmhpZGRlbiA9IHRydWU7CiAgICAgICAgIHRo aXMuX3RhYlBpY2tlclRhYkJhckl0ZW0uZWxlbWVudC5jbGFzc0xpc3QuYWRkKCJ0YWItcGlja2Vy Iik7CiAgICAgICAgIHRoaXMuYWRkVGFiQmFySXRlbSh0aGlzLl90YWJQaWNrZXJUYWJCYXJJdGVt LCB7c3VwcHJlc3NBbmltYXRpb25zOiB0cnVlfSk7Cg==