21534 2008-10-10 15:52:00 -0700 Radio button without name cannot be selected 2009-01-11 02:25:08 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED https://www.switchyourhomeloan.co.nz/promo/SwitchHomeLoan.aspx P2 Normal --- 1 jon gwilson ap oldest_to_newest 94932 0 jon 2008-10-10 15:52:00 -0700 Blocking Chromium, see bug http://code.google.com/p/chromium/issues/detail?id=3138 Seems like a strange thing to do but it turns out that in IE and FF you can select a radio button without a name. 94933 1 hyatt 2008-10-10 15:55:32 -0700 You sure about IE? Not letting you select a radio button without a name was deliberately copying IE. Maybe they changed it in IE7 or 8. 94960 2 mrowe 2008-10-10 17:24:45 -0700 What does it mean to be "Blocking Chromium"? 95183 3 jon 2008-10-13 11:47:51 -0700 I checked IE 7 and it does allow you to select the radio buttons at the top of the example page which do not have names so they must have changed IE. When I said Blocking Chromium I just meant that this is a copy from the Chromium bug database. Perhaps I should pick different words to reflect different priorities? 100498 4 25546 gwilson 2008-11-26 18:15:10 -0800 Created attachment 25546 in-process patch for issue 21534 IE7 and IE8 Beta (and Firefox) allow the user to check the radio button even if the name is not set. Here's an in-progress patch that simply removes logic that returns when the radio button name is not set. I need to run more layout tests to see if this has any other adverse effects. 101618 5 25804 gwilson 2008-12-05 17:50:46 -0800 Created attachment 25804 Possible patch for issue 21534 IE6 (and an earlier version of 7) had a quirk where they would not allow unnamed radio buttons to be selected. WebKit mimicked this behavior. However, now IE7 and 8 do allow the user to select unnamed radio buttons. This patch modifies HTMLInputElement's behavior to treat named and unnamed radio buttons the same. That is, this patch removes the checks that explicitly look for unnamed radios. The only check that remains is in HTMLFormElement, which checks for radio button naming for grouping. Unnamed radio buttons should not be grouped and can be selected ("on") simultaneously. IE and FF behave this way, so I didn't modify this behavior. This patch brings WebKit's behavior to parity with FF/IE7&8. 101619 6 25804 darin 2008-12-05 17:52:26 -0800 Comment on attachment 25804 Possible patch for issue 21534 r=me 101721 7 ap 2008-12-07 02:02:45 -0800 *** Bug 16337 has been marked as a duplicate of this bug. *** 105197 8 ap 2009-01-11 02:25:08 -0800 Committed revision 39791. 25546 2008-11-26 18:15:10 -0800 2008-12-05 17:50:46 -0800 in-process patch for issue 21534 patch21534-2.txt text/plain 5874 gwilson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODc5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEtMjYgIEdsZW5uIFdpbHNvbiAgPGd3aWxzb25AZ29vZ2xl LmNvbT4KKworICAgICAgICBDaGFuZ2VzIHJhZGlvIGJ1dHRvbnMgc28gdGhleSBjYW4gYmUgJ2No ZWNrZWQnIGV2ZW4gaWYgdGhleQorICAgICAgICBkb24ndCBoYXZlIHRoZSBuYW1lIGF0dHJpYnV0 ZSBzZXQuCisKKyAgICAgICAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTUzNAorCisgICAgICAgIFRlc3Q6IGZhc3QvaHRtbC9zZWxlY3QtdW5uYW1lZC1yYWRp by5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6cHJlRGlzcGF0Y2hFdmVudEhhbmRsZXIpOgorCiAy MDA4LTExLTI2ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuaWtvbGFzLnppbW1lcm1hbm5AdG9yY2ht b2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCShyZXZpc2lvbiAzODc1MikKKysrIFdlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg4LDkgKzE4OCw2IEBAIGJv b2wgSFRNTElucHV0RWxlbWVudDo6aXNLZXlib2FyZEZvY3VzYWIKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCiAgICAgaWYgKGlucHV0VHlwZSgpID09IFJBRElPKSB7Ci0gICAgICAgIC8vIFVubmFt ZWQgcmFkaW8gYnV0dG9ucyBhcmUgbmV2ZXIgZm9jdXNhYmxlIChtYXRjaGVzIFdpbklFKS4KLSAg ICAgICAgaWYgKG5hbWUoKS5pc0VtcHR5KCkpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICAgICAgLy8gTmV2ZXIgYWxsb3cga2V5Ym9hcmQgdGFiYmluZyB0byBsZWF2ZSB5b3UgaW4g dGhlIHNhbWUgcmFkaW8gZ3JvdXAuICBBbHdheXMKICAgICAgICAgLy8gc2tpcCBhbnkgb3RoZXIg ZWxlbWVudHMgaW4gdGhlIGdyb3VwLgpAQCAtMTExNSwxMSArMTExMiw2IEBAIHZvaWQqIEhUTUxJ bnB1dEVsZW1lbnQ6OnByZURpc3BhdGNoRXZlbnQKICAgICAgICAgICAgIH0KICAgICAgICAgfSBl bHNlIHsKICAgICAgICAgICAgIC8vIEZvciByYWRpbyBidXR0b25zLCBzdG9yZSB0aGUgY3VycmVu dCBzZWxlY3RlZCByYWRpbyBvYmplY3QuCi0gICAgICAgICAgICBpZiAobmFtZSgpLmlzRW1wdHko KSB8fCBjaGVja2VkKCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIDA7IC8vIE1hdGNoIFdpbklF IGFuZCBkb24ndCBhbGxvdyB1bm5hbWVkIHJhZGlvIGJ1dHRvbnMgdG8gYmUgY2hlY2tlZC4KLSAg ICAgICAgICAgICAgICAgICAgICAgICAgLy8gQ2hlY2tlZCBidXR0b25zIGp1c3Qgc3RheSBjaGVj a2VkLgotICAgICAgICAgICAgICAgICAgICAgICAgICAvLyBGSVhNRTogTmVlZCB0byBsZWFybiB0 byB3b3JrIHdpdGhvdXQgYSBmb3JtLgotCiAgICAgICAgICAgICAvLyBXZSByZWFsbHkgd2FudCBy YWRpbyBncm91cHMgdG8gZW5kIHVwIGluIHNhbmUgc3RhdGVzLCBpLmUuLCB0byBoYXZlIHNvbWV0 aGluZyBjaGVja2VkLgogICAgICAgICAgICAgLy8gVGhlcmVmb3JlIGlmIG5vdGhpbmcgaXMgY3Vy cmVudGx5IHNlbGVjdGVkLCB3ZSB3b24ndCBhbGxvdyB0aGlzIGFjdGlvbiB0byBiZSAidW5kb25l Iiwgc2luY2UKICAgICAgICAgICAgIC8vIHdlIHdhbnQgc29tZSBvYmplY3QgaW4gdGhlIHJhZGlv IGdyb3VwIHRvIGFjdHVhbGx5IGdldCBzZWxlY3RlZC4KQEAgLTExNTUsOCArMTE0Nyw3IEBAIHZv aWQgSFRNTElucHV0RWxlbWVudDo6cG9zdERpc3BhdGNoRXZlbnQKICAgICAgICAgICAgICAgICAv LyBNYWtlIHN1cmUgaXQgaXMgc3RpbGwgYSByYWRpbyBidXR0b24gYW5kIG9ubHkgZG8gdGhlIHJl c3RvcmF0aW9uIGlmIGl0IHN0aWxsCiAgICAgICAgICAgICAgICAgLy8gYmVsb25ncyB0byBvdXIg Z3JvdXAuCiAKLSAgICAgICAgICAgICAgICAvLyBNYXRjaCBXaW5JRSBhbmQgZG9uJ3QgYWxsb3cg dW5uYW1lZCByYWRpbyBidXR0b25zIHRvIGJlIGNoZWNrZWQuCi0gICAgICAgICAgICAgICAgaWYg KGlucHV0LT5mb3JtKCkgPT0gZm9ybSgpICYmIGlucHV0LT5pbnB1dFR5cGUoKSA9PSBSQURJTyAm JiAhbmFtZSgpLmlzRW1wdHkoKSAmJiBpbnB1dC0+bmFtZSgpID09IG5hbWUoKSkgeworICAgICAg ICAgICAgICAgIGlmIChpbnB1dC0+Zm9ybSgpID09IGZvcm0oKSAmJiBpbnB1dC0+aW5wdXRUeXBl KCkgPT0gUkFESU8gJiYgaW5wdXQtPm5hbWUoKSA9PSBuYW1lKCkpIHsKICAgICAgICAgICAgICAg ICAgICAgLy8gT2ssIHRoZSBvbGQgcmFkaW8gYnV0dG9uIGlzIHN0aWxsIGluIG91ciBmb3JtIGFu ZCBpbiBvdXIgZ3JvdXAgYW5kIGlzIHN0aWxsIGEgCiAgICAgICAgICAgICAgICAgICAgIC8vIHJh ZGlvIGJ1dHRvbiwgc28gaXQncyBzYWZlIHRvIHJlc3RvcmUgc2VsZWN0aW9uIHRvIGl0LgogICAg ICAgICAgICAgICAgICAgICBpbnB1dC0+c2V0Q2hlY2tlZCh0cnVlKTsKQEAgLTEzMzMsOSArMTMy NCw4IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGwKICAgICAgICAg ICAgICAgICAgICAgaWYgKGVsdC0+Zm9ybSgpICE9IGZvcm0oKSkKICAgICAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBpZiAobi0+aGFzVGFnTmFtZShpbnB1 dFRhZykpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIE1hdGNoIFdpbklFIGFuZCBkb24n dCBhbGxvdyB1bm5hbWVkIHJhZGlvIGJ1dHRvbnMgdG8gYmUgY2hlY2tlZC4KICAgICAgICAgICAg ICAgICAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0RWx0ID0gc3RhdGljX2Nhc3Q8SFRN TElucHV0RWxlbWVudCo+KG4pOwotICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGlucHV0RWx0 LT5pbnB1dFR5cGUoKSA9PSBSQURJTyAmJiAhbmFtZSgpLmlzRW1wdHkoKSAmJiBpbnB1dEVsdC0+ bmFtZSgpID09IG5hbWUoKSAmJiBpbnB1dEVsdC0+aXNGb2N1c2FibGUoKSkgeworICAgICAgICAg ICAgICAgICAgICAgICAgaWYgKGlucHV0RWx0LT5pbnB1dFR5cGUoKSA9PSBSQURJTyAmJiBpbnB1 dEVsdC0+bmFtZSgpID09IG5hbWUoKSAmJiBpbnB1dEVsdC0+aXNGb2N1c2FibGUoKSkgewogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGlucHV0RWx0LT5zZXRDaGVja2VkKHRydWUpOwogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50KCktPnNldEZvY3VzZWROb2RlKGlucHV0 RWx0KTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnB1dEVsdC0+ZGlzcGF0Y2hTaW11 bGF0ZWRDbGljayhldnQsIGZhbHNlLCBmYWxzZSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzODc5MCkK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDA4LTExLTI2ICBHbGVubiBXaWxzb24gIDxnd2lsc29uQGdvb2dsZS5jb20+CisKKyAgICAg ICAgQWRkZWQgdGVzdHMgdG8gdmVyaWZ5IHRoYXQgcmFkaW8gYnV0dG9ucyBjYW4gYmUgY2hlY2tl ZAorICAgICAgICBldmVuIGlmIHRoZXkgZG9uJ3QgaGF2ZSB0aGUgbmFtZSBhdHRyaWJ1dGUgc2V0 LgorCisgICAgICAgIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE1MzQKKworICAgICAgICAqIGZhc3QvaHRtbC9zZWxlY3QtdW5uYW1lZC1yYWRpby1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvaHRtbC9zZWxlY3QtdW5uYW1lZC1yYWRpby5o dG1sOiBBZGRlZC4KKwogMjAwOC0xMS0yNiAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9A d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2h0bWwvc2VsZWN0LXVubmFtZWQtcmFkaW8tZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaHRtbC9zZWxlY3QtdW5uYW1lZC1yYWRp by1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2h0bWwvc2Vs ZWN0LXVubmFtZWQtcmFkaW8tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMg QEAKKyAKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGNsaWNraW5nIGEgcmFkaW8gYnV0dG9uIHdp dGhvdXQgYSBuYW1lIHdpbGwgbWFyayB0aGUgcmFkaW8gYnV0dG9uIGFzICdjaGVja2VkJy4gSW4g dGhlIGF1dG9tYXRlZCB0ZXN0cywgWW91IHNob3VsZCBzZWUgJ1BBU1MnIGJlbG93LiAKK1BBU1MK SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaHRtbC9zZWxlY3QtdW5uYW1lZC1yYWRpby5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaHRtbC9zZWxlY3QtdW5uYW1lZC1yYWRpby5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9odG1sL3NlbGVjdC11bm5hbWVk LXJhZGlvLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzIgQEAKKzxodG1sPgorPGhlYWQ+ CisgIDxzdHlsZT4KKyAgICBib2R5IHsgbWFyZ2luOiAwOyBwYWRkaW5nOiAwOyB9CisgIDwvc3R5 bGU+CisgIDxzY3JpcHQ+CisgICAgaWYod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICA8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPGlucHV0IHR5cGU9InJhZGlvIiBpZD0icmFkaW8iIHZhbHVlPSJ0ZXN0Ij4K Kzxicj4KK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGNsaWNraW5nIGEgcmFkaW8gYnV0dG9uIHdp dGhvdXQgYSBuYW1lIHdpbGwgbWFyawordGhlIHJhZGlvIGJ1dHRvbiBhcyAnY2hlY2tlZCcuICBJ biB0aGUgYXV0b21hdGVkIHRlc3RzLCBZb3Ugc2hvdWxkIHNlZSAnUEFTUycgCitiZWxvdy4KKzxi cj4KKzxzY3JpcHQ+CisgICBpZih3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAg ZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMTAsMTApOworICAgICBldmVudFNlbmRlci5tb3VzZURv d24oKTsKKyAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworCisgICAgIGlmKGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJyYWRpbyIpLmNoZWNrZWQpCisgICAgICAgZG9jdW1lbnQud3JpdGUoIlBB U1MiKTsKKyAgICAgZWxzZQorICAgICAgIGRvY3VtZW50LndyaXRlKCJGQUlMIik7CisgICB9IGVs c2UKKyAgICAgZG9jdW1lbnQud3JpdGUoIlRoaXMgdGVzdCB3aWxsIG9ubHkgcGFzcyBpbiBhdXRv bWF0ZWQgbW9kZS4gIFlvdSBzaG91bGQgYmUgYWJsZSB0byBjbGljayB0aGUgcmFkaW8gYnV0dG9u IGludG8gdGhlICdvbicgc3RhdGUgYWJvdmUuIik7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRt bD4K 25804 2008-12-05 17:50:46 -0800 2008-12-05 17:52:26 -0800 Possible patch for issue 21534 patch21534-3.txt text/plain 8431 gwilson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODc5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEtMjYgIEdsZW5uIFdpbHNvbiAgPGd3aWxzb25AZ29vZ2xl LmNvbT4KKworICAgICAgICBDaGFuZ2VzIHJhZGlvIGJ1dHRvbnMgc28gdGhleSBjYW4gYmUgJ2No ZWNrZWQnIGV2ZW4gaWYgdGhleQorICAgICAgICBkb24ndCBoYXZlIHRoZSBuYW1lIGF0dHJpYnV0 ZSBzZXQuCisKKyAgICAgICAgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTUzNAorCisgICAgICAgIFRlc3Q6IGZhc3QvaHRtbC9zZWxlY3QtdW5uYW1lZC1yYWRp by5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6cHJlRGlzcGF0Y2hFdmVudEhhbmRsZXIpOgorCiAy MDA4LTExLTI2ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuaWtvbGFzLnppbW1lcm1hbm5AdG9yY2ht b2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJD b3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCShyZXZpc2lvbiAzODk0OSkKKysrIFdlYkNvcmUvaHRtbC9I VE1MSW5wdXRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgzLDkgKzE4Myw2IEBAIGJv b2wgSFRNTElucHV0RWxlbWVudDo6aXNLZXlib2FyZEZvY3VzYWIKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCiAgICAgaWYgKGlucHV0VHlwZSgpID09IFJBRElPKSB7Ci0gICAgICAgIC8vIFVubmFt ZWQgcmFkaW8gYnV0dG9ucyBhcmUgbmV2ZXIgZm9jdXNhYmxlIChtYXRjaGVzIFdpbklFKS4KLSAg ICAgICAgaWYgKG5hbWUoKS5pc0VtcHR5KCkpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICAgICAgLy8gTmV2ZXIgYWxsb3cga2V5Ym9hcmQgdGFiYmluZyB0byBsZWF2ZSB5b3UgaW4g dGhlIHNhbWUgcmFkaW8gZ3JvdXAuICBBbHdheXMKICAgICAgICAgLy8gc2tpcCBhbnkgb3RoZXIg ZWxlbWVudHMgaW4gdGhlIGdyb3VwLgpAQCAtMTExMCwxMSArMTEwNyw2IEBAIHZvaWQqIEhUTUxJ bnB1dEVsZW1lbnQ6OnByZURpc3BhdGNoRXZlbnQKICAgICAgICAgICAgIH0KICAgICAgICAgfSBl bHNlIHsKICAgICAgICAgICAgIC8vIEZvciByYWRpbyBidXR0b25zLCBzdG9yZSB0aGUgY3VycmVu dCBzZWxlY3RlZCByYWRpbyBvYmplY3QuCi0gICAgICAgICAgICBpZiAobmFtZSgpLmlzRW1wdHko KSB8fCBjaGVja2VkKCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIDA7IC8vIE1hdGNoIFdpbklF IGFuZCBkb24ndCBhbGxvdyB1bm5hbWVkIHJhZGlvIGJ1dHRvbnMgdG8gYmUgY2hlY2tlZC4KLSAg ICAgICAgICAgICAgICAgICAgICAgICAgLy8gQ2hlY2tlZCBidXR0b25zIGp1c3Qgc3RheSBjaGVj a2VkLgotICAgICAgICAgICAgICAgICAgICAgICAgICAvLyBGSVhNRTogTmVlZCB0byBsZWFybiB0 byB3b3JrIHdpdGhvdXQgYSBmb3JtLgotCiAgICAgICAgICAgICAvLyBXZSByZWFsbHkgd2FudCBy YWRpbyBncm91cHMgdG8gZW5kIHVwIGluIHNhbmUgc3RhdGVzLCBpLmUuLCB0byBoYXZlIHNvbWV0 aGluZyBjaGVja2VkLgogICAgICAgICAgICAgLy8gVGhlcmVmb3JlIGlmIG5vdGhpbmcgaXMgY3Vy cmVudGx5IHNlbGVjdGVkLCB3ZSB3b24ndCBhbGxvdyB0aGlzIGFjdGlvbiB0byBiZSAidW5kb25l Iiwgc2luY2UKICAgICAgICAgICAgIC8vIHdlIHdhbnQgc29tZSBvYmplY3QgaW4gdGhlIHJhZGlv IGdyb3VwIHRvIGFjdHVhbGx5IGdldCBzZWxlY3RlZC4KQEAgLTExNTAsOCArMTE0Miw3IEBAIHZv aWQgSFRNTElucHV0RWxlbWVudDo6cG9zdERpc3BhdGNoRXZlbnQKICAgICAgICAgICAgICAgICAv LyBNYWtlIHN1cmUgaXQgaXMgc3RpbGwgYSByYWRpbyBidXR0b24gYW5kIG9ubHkgZG8gdGhlIHJl c3RvcmF0aW9uIGlmIGl0IHN0aWxsCiAgICAgICAgICAgICAgICAgLy8gYmVsb25ncyB0byBvdXIg Z3JvdXAuCiAKLSAgICAgICAgICAgICAgICAvLyBNYXRjaCBXaW5JRSBhbmQgZG9uJ3QgYWxsb3cg dW5uYW1lZCByYWRpbyBidXR0b25zIHRvIGJlIGNoZWNrZWQuCi0gICAgICAgICAgICAgICAgaWYg KGlucHV0LT5mb3JtKCkgPT0gZm9ybSgpICYmIGlucHV0LT5pbnB1dFR5cGUoKSA9PSBSQURJTyAm JiAhbmFtZSgpLmlzRW1wdHkoKSAmJiBpbnB1dC0+bmFtZSgpID09IG5hbWUoKSkgeworICAgICAg ICAgICAgICAgIGlmIChpbnB1dC0+Zm9ybSgpID09IGZvcm0oKSAmJiBpbnB1dC0+aW5wdXRUeXBl KCkgPT0gUkFESU8gJiYgaW5wdXQtPm5hbWUoKSA9PSBuYW1lKCkpIHsKICAgICAgICAgICAgICAg ICAgICAgLy8gT2ssIHRoZSBvbGQgcmFkaW8gYnV0dG9uIGlzIHN0aWxsIGluIG91ciBmb3JtIGFu ZCBpbiBvdXIgZ3JvdXAgYW5kIGlzIHN0aWxsIGEgCiAgICAgICAgICAgICAgICAgICAgIC8vIHJh ZGlvIGJ1dHRvbiwgc28gaXQncyBzYWZlIHRvIHJlc3RvcmUgc2VsZWN0aW9uIHRvIGl0LgogICAg ICAgICAgICAgICAgICAgICBpbnB1dC0+c2V0Q2hlY2tlZCh0cnVlKTsKQEAgLTEzMjgsOSArMTMx OSw4IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGwKICAgICAgICAg ICAgICAgICAgICAgaWYgKGVsdC0+Zm9ybSgpICE9IGZvcm0oKSkKICAgICAgICAgICAgICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBpZiAobi0+aGFzVGFnTmFtZShpbnB1 dFRhZykpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIC8vIE1hdGNoIFdpbklFIGFuZCBkb24n dCBhbGxvdyB1bm5hbWVkIHJhZGlvIGJ1dHRvbnMgdG8gYmUgY2hlY2tlZC4KICAgICAgICAgICAg ICAgICAgICAgICAgIEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0RWx0ID0gc3RhdGljX2Nhc3Q8SFRN TElucHV0RWxlbWVudCo+KG4pOwotICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGlucHV0RWx0 LT5pbnB1dFR5cGUoKSA9PSBSQURJTyAmJiAhbmFtZSgpLmlzRW1wdHkoKSAmJiBpbnB1dEVsdC0+ bmFtZSgpID09IG5hbWUoKSAmJiBpbnB1dEVsdC0+aXNGb2N1c2FibGUoKSkgeworICAgICAgICAg ICAgICAgICAgICAgICAgaWYgKGlucHV0RWx0LT5pbnB1dFR5cGUoKSA9PSBSQURJTyAmJiBpbnB1 dEVsdC0+bmFtZSgpID09IG5hbWUoKSAmJiBpbnB1dEVsdC0+aXNGb2N1c2FibGUoKSkgewogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGlucHV0RWx0LT5zZXRDaGVja2VkKHRydWUpOwogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGRvY3VtZW50KCktPnNldEZvY3VzZWROb2RlKGlucHV0 RWx0KTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnB1dEVsdC0+ZGlzcGF0Y2hTaW11 bGF0ZWRDbGljayhldnQsIGZhbHNlLCBmYWxzZSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzODk2OCkK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDA4LTEyLTAzICBHbGVubiBXaWxzb24gIDxnd2lsc29uQGdvb2dsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZWQvcmV3 b3JkZWQgdGVzdHMgdGhhdCByZWxpZWQgb24gV2luSUUncyBwYXN0IHF1aXJrIG9mIAorICAgICAg ICBub3QgYWxsb3dpbmcgc2VsZWN0aW9uIG9mIHVubmFtZWQgcmFkaW8gYnV0dG9ucy4KKworICAg ICAgICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTM0CisK KyAgICAgICAgKiBmYXN0L2Zvcm1zL2ZvY3VzMi1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFz dC9mb3Jtcy9mb2N1czIuaHRtbDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3JhZGlvX2NoZWNrZWRf bmFtZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9mb3Jtcy9yYWRpb19jaGVja2VkX25h bWUuaHRtbDoKKwogMjAwOC0xMi0wMyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2ZvY3VzMi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9mb2N1czItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAzNzQwMykKKysrIExh eW91dFRlc3RzL2Zhc3QvZm9ybXMvZm9jdXMyLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpA QCAtMjIsNiArMjIsOSBAQCBibHVyIGV2ZW50OiBbdG9dIElTSU5ERVgKIGZvY3VzIGV2ZW50OiBb dG9dIFBBU1NXT1JECiBrZXlkb3duIGV2ZW50OiBbdG9dIFBBU1NXT1JECiBibHVyIGV2ZW50OiBb dG9dIFBBU1NXT1JECitmb2N1cyBldmVudDogW3RvXSBSQURJTwora2V5ZG93biBldmVudDogW3Rv XSBSQURJTworYmx1ciBldmVudDogW3RvXSBSQURJTwogZm9jdXMgZXZlbnQ6IFt0b10gUkFOR0UK IGtleWRvd24gZXZlbnQ6IFt0b10gUkFOR0UKIGJsdXIgZXZlbnQ6IFt0b10gUkFOR0UKQEAgLTY1 LDYgKzY4LDkgQEAgYmx1ciBldmVudDogW3RvXSBJU0lOREVYCiBmb2N1cyBldmVudDogW3RvXSBQ QVNTV09SRAoga2V5ZG93biBldmVudDogW3RvXSBQQVNTV09SRAogYmx1ciBldmVudDogW3RvXSBQ QVNTV09SRAorZm9jdXMgZXZlbnQ6IFt0b10gUkFESU8KK2tleWRvd24gZXZlbnQ6IFt0b10gUkFE SU8KK2JsdXIgZXZlbnQ6IFt0b10gUkFESU8KIGZvY3VzIGV2ZW50OiBbdG9dIFJBTkdFCiBrZXlk b3duIGV2ZW50OiBbdG9dIFJBTkdFCiBibHVyIGV2ZW50OiBbdG9dIFJBTkdFCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2ZvY3VzMi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZm9ybXMvZm9jdXMyLmh0bWwJKHJldmlzaW9uIDM3NDAzKQorKysgTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9mb2N1czIuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTI3LDEzICsxMjcsMTMg QEAgc2V0dXAoKTsKIAogbG9nKCdQQVJFTlQgRE9DVU1FTlQ6XG4nKTsKIGRvY3VtZW50LmdldEVs ZW1lbnRzQnlUYWdOYW1lKCdpbnB1dCcpWzBdLmZvY3VzKCk7Ci1mb3IgKHZhciBpID0gMDsgaSA8 IDEzOyArK2kpIC8vPgorZm9yICh2YXIgaSA9IDA7IGkgPCAxNDsgKytpKSAvLz4KICAgICBkaXNw YXRjaE9wdGlvblRhYihsYXN0Rm9jdXNlZEVsZW1lbnQsIGZhbHNlKTsKIAogbGFzdEZvY3VzZWRF bGVtZW50LmJsdXIoKTsKIAogbG9nKCdcbklGUkFNRSBET0NVTUVOVDpcbicpOwogZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3Rlc3RJZnJhbWUnKS5jb250ZW50RG9jdW1lbnQuZ2V0RWxlbWVudHNC eVRhZ05hbWUoJ2lucHV0JylbMF0uZm9jdXMoKTsKLWZvciAodmFyIGkgPSAwOyBpIDwgMTM7ICsr aSkgLy8+Citmb3IgKHZhciBpID0gMDsgaSA8IDE0OyArK2kpIC8vPgogICAgIGRpc3BhdGNoT3B0 aW9uVGFiKGxhc3RGb2N1c2VkRWxlbWVudCwgZmFsc2UpOwogPC9zY3JpcHQ+CkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlvX2NoZWNrZWRfbmFtZS1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYWRpb19jaGVja2VkX25hbWUtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAzNzQwMykKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW9f Y2hlY2tlZF9uYW1lLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAK LVRoZXJlIGlzIGEgV2luSUUgcXVpcmsgdGhhdCBkb2VzIG5vdCBhbGxvdyBhIHVzZXIgdG8gc2Vs ZWN0IHJhZGlvIGJ1dHRvbnMgdGhhdCBkb24ndCBoYXZlIG5hbWVzLiBUaGlzIHRlc3RzIHRoYXQg d2Ugb25seSBob25vciB0aGF0IHF1aXJrCi1pbiByZXNwb25zZSB0byBtb3VzZSBhbmQga2V5Ym9h cmQgZXZlbnRzLiBJZiB0aGUgY2hlY2tlZCBhdHRyaWJ1dGUgaXMgc2V0IG9uIHRoZSBlbGVtZW50 IGluIHRoZSBtYXJrdXAsIG9yIGluIGphdmFzY3JpcHQsIHdlIHNob3VsZCBpZ25vcmUgdGhlIHF1 aXJrLgorVGhlcmUgd2FzIG9uY2UgYSBXaW5JRSBxdWlyayB0aGF0IGRpZCBub3QgYWxsb3cgYSB1 c2VyIHRvIHNlbGVjdCByYWRpbyBidXR0b25zIHRoYXQgZGlkJ3QgaGF2ZSBuYW1lcy4gSG93ZXZl ciwgdGhpcyB3YXMgY2hhbmdlZCBpbiBhIGxhdGVyIHZlcnNpb24sIGFuZCBXaW5JRSBub3cgYWxs b3dzIHVzZXJzIHRvIHNlbGVjdCBuYW1lbGVzcyByYWRpbyBidXR0b25zLiBUaGlzIHRlc3RzIHRo YXQgd2UgYWxsb3cgdW5uYW1lZCByYWRpbyBidXR0b25zIHRvIGJlIHNlbGVjdGVkLgorCiAgICAg CiBQYXNzCiBQYXNzCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlvX2NoZWNrZWRf bmFtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW9fY2hl Y2tlZF9uYW1lLmh0bWwJKHJldmlzaW9uIDM3NDAzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9yYWRpb19jaGVja2VkX25hbWUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjMsNyArMjMsNyBA QAogICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgICAg ICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oJyAnKTsKICAgICAgICAgICAgIH0KLSAgICAg ICAgICAgIHZlcmlmeUNoZWNrZWRTdGF0ZShyMiwgZmFsc2UpOworICAgICAgICAgICAgdmVyaWZ5 Q2hlY2tlZFN0YXRlKHIyLCB0cnVlKTsKICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAg IHZhciByMyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyMycpOwogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIApAQCAtMzMsNyArMzMsNyBAQAogICAgICAgICAgICAgICAg IGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwogICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1v dXNlVXAoKTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHZlcmlmeUNoZWNrZWRTdGF0ZShy MywgZmFsc2UpOworICAgICAgICAgICAgdmVyaWZ5Q2hlY2tlZFN0YXRlKHIzLCB0cnVlKTsKIAog ICAgICAgICB9CiAgICAgICAgIApAQCAtNTAsOCArNTAsMTAgQEAKICAgICAgICAgPC9zY3JpcHQ+ CiAgICAgPC9oZWFkPgogICAgIDxib2R5IG9ubG9hZD0idGVzdCgpIj4KLSAgICAgICAgVGhlcmUg aXMgYSBXaW5JRSBxdWlyayB0aGF0IGRvZXMgbm90IGFsbG93IGEgdXNlciB0byBzZWxlY3QgcmFk aW8gYnV0dG9ucyB0aGF0IGRvbid0IGhhdmUgbmFtZXMuICBUaGlzIHRlc3RzIHRoYXQgd2Ugb25s eSBob25vciB0aGF0IHF1aXJrPGJyPgotICAgICAgICBpbiByZXNwb25zZSB0byBtb3VzZSBhbmQg a2V5Ym9hcmQgZXZlbnRzLiAgSWYgdGhlIGNoZWNrZWQgYXR0cmlidXRlIGlzIHNldCBvbiB0aGUg ZWxlbWVudCBpbiB0aGUgbWFya3VwLCBvciBpbiBqYXZhc2NyaXB0LCB3ZSBzaG91bGQgaWdub3Jl IHRoZSBxdWlyay48YnI+CisgICAgICAgIFRoZXJlIHdhcyBvbmNlIGEgV2luSUUgcXVpcmsgdGhh dCBkaWQgbm90IGFsbG93IGEgdXNlciB0byBzZWxlY3QgcmFkaW8gYnV0dG9ucyB0aGF0IGRpZCd0 IGhhdmUgbmFtZXMuICAKKyAgICAgICAgSG93ZXZlciwgdGhpcyB3YXMgY2hhbmdlZCBpbiBhIGxh dGVyIHZlcnNpb24sIGFuZCBXaW5JRSBub3cgYWxsb3dzIHVzZXJzIHRvIHNlbGVjdCBuYW1lbGVz cyByYWRpbyBidXR0b25zLgorICAgICAgICBUaGlzIHRlc3RzIHRoYXQgd2UgYWxsb3cgdW5uYW1l ZCByYWRpbyBidXR0b25zIHRvIGJlIHNlbGVjdGVkLjxicj4KKyAgICAgICAgPGJyPgogICAgICAg ICA8Zm9ybSBpZD0iZnIiPgogICAgICAgICAgICAgPGlucHV0IHR5cGU9InJhZGlvIiBpZD0icjEi IGNoZWNrZWQ+CiAgICAgICAgICAgICA8aW5wdXQgdHlwZT0icmFkaW8iIGlkPSJyMiI+Cg==