215320 2020-08-10 05:12:40 -0700 Return values of FontDatabase::collectionForFamily are not thread safe 2020-08-10 09:41:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned andersca bfulgham ews-watchlist mmaxfield simon.fraser zalan oldest_to_newest 1679040 0 koivisto 2020-08-10 05:12:40 -0700 This results in a crash under findClosestFont: 50 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest) <== 50 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest) 50 WebCore: WebCore::FontCache::createFontPlatformData(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities) 50 WebCore: WebCore::FontCache::getCachedFontPlatformData(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities, bool) 50 WebCore: WebCore::FontCache::fontForFamily(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities, bool) 50 WebCore: WebCore::CSSFontSelector::fontRangesForFamily(WebCore::FontDescription const&, WTF::AtomString const&) 50 WebCore: WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*) 50 WebCore: WebCore::FontCascadeFonts::realizeFallbackRangesAt(WebCore::FontCascadeDescription const&, unsigned int) 50 WebCore: WebCore::FontCascadeFonts::primaryFont(WebCore::FontCascadeDescription const&) 1679041 1 koivisto 2020-08-10 05:13:55 -0700 <rdar://problem/66502539> 1679043 2 406293 koivisto 2020-08-10 05:26:20 -0700 Created attachment 406293 patch 1679077 3 ews-feeder 2020-08-10 09:41:52 -0700 Committed r265432: <https://trac.webkit.org/changeset/265432> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406293. 406293 2020-08-10 05:26:20 -0700 2020-08-10 09:41:52 -0700 patch font-cache-thread-crash.patch text/plain 3332 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZjY2NDkwYmJmMmMuLjEyZTRmYmJiNDAxYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIyIEBACisyMDIwLTA4LTEwICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KKworICAgICAgICBSZXR1cm4gdmFsdWVzIG9mIEZvbnREYXRhYmFzZTo6Y29sbGVjdGlvbkZv ckZhbWlseSBhcmUgbm90IHRocmVhZCBzYWZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUzMjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2NTAy NTM5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZv bnQgcHJld2FybWluZyBjYW4gYWRkIG5ldyBlbnRyaWVzIHRvIG1fZmFtaWx5TmFtZVRvRm9udERl c2NyaXB0b3JzIHdoaWxlIGxvb2t1cHMgYXJlIGJlaW5nIG1hZGUuCisgICAgICAgIEFjY2VzcyB0 byBpdCBpcyBwcm90ZWN0ZWQgYnkgYSBsb2NrLgorCisgICAgICAgIEhvd2V2ZXIgaWYgdGhlIGhh c2htYXAgZW5kcyB1cCByZWhhc2hpbmcsIHRoZSBwb2ludGVyIHJldHVybmVkIGZyb20gY29sbGVj dGlvbkZvckZhbWlseSBtYXkgZW5kIHVwIGJlY29taW5nIGludmFsaWQuCisgICAgICAgIFRoaXMg Y2FuIHJlc3VsdCBpbiBhIGNyYXNoIGxhdGVyIHVuZGVyIGZpbmRDbG9zZXN0Rm9udC4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRDYWNoZUNvcmVUZXh0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZvbnREYXRhYmFzZTo6Y29sbGVjdGlvbkZvckZhbWlseSk6CisKKyAg ICAgICAgSGVhcCBhbGxvY2F0ZSB0aGUgaGFzaG1hcCB2YWx1ZXMgc28gdGhleSBzdGF5IHZhbGlk IG92ZXIgaGFzaHRhYmxlIG11dGF0aW9ucy4KKwogMjAyMC0wOC0wNCAgRGV2aW4gUm91c3NvICA8 ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgIkRvdWJsZURvd24gQ2FzaW5vIiByZXNwaW4g YnV0dG9uIHN0b3BzIHdvcmtpbmcgd2l0aCB0cmFja3BhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQuY3Bw CmluZGV4IDRhMjZlMDdjYWQ5Yy4uMzY0MGJmMzE2YjdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q2FjaGVDb3JlVGV4dC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENhY2hlQ29yZVRleHQu Y3BwCkBAIC04ODksNiArODg5LDggQEAgcHVibGljOgogICAgIH07CiAKICAgICBzdHJ1Y3QgSW5z dGFsbGVkRm9udEZhbWlseSB7CisgICAgICAgIFdURl9NQUtFX1NUUlVDVF9GQVNUX0FMTE9DQVRF RDsKKwogICAgICAgICBJbnN0YWxsZWRGb250RmFtaWx5KCkgPSBkZWZhdWx0OwogCiAgICAgICAg IGV4cGxpY2l0IEluc3RhbGxlZEZvbnRGYW1pbHkoVmVjdG9yPEluc3RhbGxlZEZvbnQ+JiYgaW5z dGFsbGVkRm9udHMpCkBAIC05MjQsNyArOTI2LDcgQEAgcHVibGljOgogICAgICAgICAgICAgYXV0 byBsb2NrZXIgPSBob2xkTG9jayhtX2ZhbWlseU5hbWVUb0ZvbnREZXNjcmlwdG9yc0xvY2spOwog ICAgICAgICAgICAgYXV0byBpdCA9IG1fZmFtaWx5TmFtZVRvRm9udERlc2NyaXB0b3JzLmZpbmQo Zm9sZGVkKTsKICAgICAgICAgICAgIGlmIChpdCAhPSBtX2ZhbWlseU5hbWVUb0ZvbnREZXNjcmlw dG9ycy5lbmQoKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gaXQtPnZhbHVlOworICAgICAgICAg ICAgICAgIHJldHVybiAqaXQtPnZhbHVlOwogICAgICAgICB9CiAKICAgICAgICAgYXV0byBpbnN0 YWxsZWRGb250RmFtaWx5ID0gWyZdIHsKQEAgLTk0MiwxMyArOTQ0LDEzIEBAIHB1YmxpYzoKICAg ICAgICAgICAgICAgICAgICAgSW5zdGFsbGVkRm9udCBpbnN0YWxsZWRGb250KHN0YXRpY19jYXN0 PENURm9udERlc2NyaXB0b3JSZWY+KENGQXJyYXlHZXRWYWx1ZUF0SW5kZXgobWF0Y2hlcy5nZXQo KSwgaSkpLCBtX2FsbG93VXNlckluc3RhbGxlZEZvbnRzKTsKICAgICAgICAgICAgICAgICAgICAg cmVzdWx0LnVuY2hlY2tlZEFwcGVuZChXVEZNb3ZlKGluc3RhbGxlZEZvbnQpKTsKICAgICAgICAg ICAgICAgICB9Ci0gICAgICAgICAgICAgICAgcmV0dXJuIEluc3RhbGxlZEZvbnRGYW1pbHkoV1RG TW92ZShyZXN1bHQpKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gbWFrZVVuaXF1ZTxJbnN0YWxs ZWRGb250RmFtaWx5PihXVEZNb3ZlKHJlc3VsdCkpOwogICAgICAgICAgICAgfQotICAgICAgICAg ICAgcmV0dXJuIEluc3RhbGxlZEZvbnRGYW1pbHkoKTsKKyAgICAgICAgICAgIHJldHVybiBtYWtl VW5pcXVlPEluc3RhbGxlZEZvbnRGYW1pbHk+KCk7CiAgICAgICAgIH0oKTsKIAogICAgICAgICBh dXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fZmFtaWx5TmFtZVRvRm9udERlc2NyaXB0b3JzTG9jayk7 Ci0gICAgICAgIHJldHVybiBtX2ZhbWlseU5hbWVUb0ZvbnREZXNjcmlwdG9ycy5hZGQoZm9sZGVk Lmlzb2xhdGVkQ29weSgpLCBXVEZNb3ZlKGluc3RhbGxlZEZvbnRGYW1pbHkpKS5pdGVyYXRvci0+ dmFsdWU7CisgICAgICAgIHJldHVybiAqbV9mYW1pbHlOYW1lVG9Gb250RGVzY3JpcHRvcnMuYWRk KGZvbGRlZC5pc29sYXRlZENvcHkoKSwgV1RGTW92ZShpbnN0YWxsZWRGb250RmFtaWx5KSkuaXRl cmF0b3ItPnZhbHVlOwogICAgIH0KIAogICAgIGNvbnN0IEluc3RhbGxlZEZvbnQmIGZvbnRGb3JQ b3N0U2NyaXB0TmFtZShjb25zdCBBdG9tU3RyaW5nJiBwb3N0U2NyaXB0TmFtZSkKQEAgLTk4Niw3 ICs5ODgsNyBAQCBwcml2YXRlOgogICAgIH0KIAogICAgIExvY2sgbV9mYW1pbHlOYW1lVG9Gb250 RGVzY3JpcHRvcnNMb2NrOwotICAgIEhhc2hNYXA8U3RyaW5nLCBJbnN0YWxsZWRGb250RmFtaWx5 PiBtX2ZhbWlseU5hbWVUb0ZvbnREZXNjcmlwdG9yczsKKyAgICBIYXNoTWFwPFN0cmluZywgc3Rk Ojp1bmlxdWVfcHRyPEluc3RhbGxlZEZvbnRGYW1pbHk+PiBtX2ZhbWlseU5hbWVUb0ZvbnREZXNj cmlwdG9yczsKICAgICBIYXNoTWFwPFN0cmluZywgSW5zdGFsbGVkRm9udD4gbV9wb3N0U2NyaXB0 TmFtZVRvRm9udERlc2NyaXB0b3JzOwogICAgIEFsbG93VXNlckluc3RhbGxlZEZvbnRzIG1fYWxs b3dVc2VySW5zdGFsbGVkRm9udHM7CiB9Owo=