215319 2020-08-10 00:36:32 -0700 REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy 2020-08-10 10:59:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton bdakin darin hi megan_gardner sam webkit-bug-importer wenson_hsieh oldest_to_newest 1679024 0 thorton 2020-08-10 00:36:32 -0700 REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy 1679025 1 406286 thorton 2020-08-10 00:37:01 -0700 Created attachment 406286 Patch 1679026 2 thorton 2020-08-10 00:37:04 -0700 <rdar://problem/66688560> 1679028 3 406286 hi 2020-08-10 00:38:37 -0700 Comment on attachment 406286 Patch r=mews 1679031 4 ews-feeder 2020-08-10 01:18:07 -0700 Committed r265424: <https://trac.webkit.org/changeset/265424> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406286. 1679121 5 406286 darin 2020-08-10 10:59:38 -0700 Comment on attachment 406286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406286&action=review > Source/WebKitLegacy/ios/ChangeLog:12 > + * WebCoreSupport/WebVisiblePosition.mm: > + (+[DOMRange rangeForFirstPosition:second:]): > + We want to ensure that firstPosition is *before* secondPosition, so > + the change in r265176 got the condition backwards. Swap it. So sorry! I should make a regression test. 406286 2020-08-10 00:37:01 -0700 2020-08-10 01:18:08 -0700 Patch bug-215319-20200810003701.patch text/plain 1685 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L2lvcy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lvcy9DaGFuZ2VMb2cKaW5k ZXggMDA3ODE4NTY2OTk4YWI2ZjFhZTU4NWQ2ZDg0NjEwNmUzMDI4MmRjNy4uMDY4YTc2OWYyYzRh ZmNmNWQ0ODZjNTk4NDA5NDFjOWI3ODRlNzcyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9pb3MvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvaW9zL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA4LTEwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNjUxNzYpOiBDYW5ub3QgbWFr ZSBvciBleHRlbmQgc2VsZWN0aW9ucyBpbiBpT1MgV2ViS2l0TGVnYWN5IAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1MzE5CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS82NjY4ODU2MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYlZpc2libGVQb3NpdGlvbi5tbToKKyAg ICAgICAgKCtbRE9NUmFuZ2UgcmFuZ2VGb3JGaXJzdFBvc2l0aW9uOnNlY29uZDpdKToKKyAgICAg ICAgV2Ugd2FudCB0byBlbnN1cmUgdGhhdCBmaXJzdFBvc2l0aW9uIGlzICpiZWZvcmUqIHNlY29u ZFBvc2l0aW9uLCBzbworICAgICAgICB0aGUgY2hhbmdlIGluIHIyNjUxNzYgZ290IHRoZSBjb25k aXRpb24gYmFja3dhcmRzLiBTd2FwIGl0LgorCiAyMDIwLTA4LTA0ICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IENhdGFseXN0IGJ1aWxkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lvcy9XZWJDb3JlU3VwcG9ydC9XZWJWaXNpYmxl UG9zaXRpb24ubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L2lvcy9XZWJDb3JlU3VwcG9ydC9XZWJW aXNpYmxlUG9zaXRpb24ubW0KaW5kZXggNmRmNTkyN2FhZmQ4MGYzN2U5NzA3MjE0Zjc0MWNmZjVh YTA5NmQ3Yi4uZjIwYmM0YmIxY2M5MzdjOTBjZjRlODMzOGU5NDk3NDdhNzA4OGZlOSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9pb3MvV2ViQ29yZVN1cHBvcnQvV2ViVmlzaWJsZVBv c2l0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvaW9zL1dlYkNvcmVTdXBwb3J0L1dl YlZpc2libGVQb3NpdGlvbi5tbQpAQCAtNDc4LDcgKzQ3OCw3IEBAICsgKERPTVJhbmdlICopcmFu Z2VGb3JGaXJzdFBvc2l0aW9uOihXZWJWaXNpYmxlUG9zaXRpb24gKilmaXJzdCBzZWNvbmQ6KFdl YlZpc2liCiB7CiAgICAgYXV0byBmaXJzdFBvc2l0aW9uID0gW2ZpcnN0IF92aXNpYmxlUG9zaXRp b25dOwogICAgIGF1dG8gc2Vjb25kUG9zaXRpb24gPSBbc2Vjb25kIF92aXNpYmxlUG9zaXRpb25d OwotICAgIGlmIChmaXJzdFBvc2l0aW9uIDwgc2Vjb25kUG9zaXRpb24pCisgICAgaWYgKHNlY29u ZFBvc2l0aW9uIDwgZmlyc3RQb3NpdGlvbikKICAgICAgICAgc3RkOjpzd2FwKGZpcnN0UG9zaXRp b24sIHNlY29uZFBvc2l0aW9uKTsKICAgICByZXR1cm4ga2l0KG1ha2VTaW1wbGVSYW5nZShmaXJz dFBvc2l0aW9uLCBzZWNvbmRQb3NpdGlvbikpOwogfQo=