215298 2020-08-07 16:04:06 -0700 Off by one error in transform feedback buffer binding 2020-08-07 17:39:11 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 126404 1 jdarpinian jdarpinian cdumez changseok dino esprehn+autocc ews-watchlist graouts gyuyoung.kim kbr kondapallykalyan webkit-bug-importer oldest_to_newest 1678789 0 jdarpinian 2020-08-07 16:04:06 -0700 Off by one error in transform feedback buffer binding 1678791 1 406224 jdarpinian 2020-08-07 16:05:17 -0700 Created attachment 406224 Patch 1678798 2 406224 kbr 2020-08-07 16:07:09 -0700 Comment on attachment 406224 Patch Looks good to me. I'd r+ but my reviewer status hasn't been reinstated. 1678799 3 406224 cdumez 2020-08-07 16:08:00 -0700 Comment on attachment 406224 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review > Source/WebCore/ChangeLog:8 > + Caught by conformance test deqp/functional/gles3/negativebufferapi.html This change is missing a test. 1678802 4 406224 jdarpinian 2020-08-07 16:19:27 -0700 Comment on attachment 406224 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review >> Source/WebCore/ChangeLog:8 >> + Caught by conformance test deqp/functional/gles3/negativebufferapi.html > > This change is missing a test. The test is present. The suite it's in (deqp) is currently skipped in the test expectations because it takes a long time to run. I'm looking into whether we can make it faster. 1678812 5 406224 dino 2020-08-07 16:31:48 -0700 Comment on attachment 406224 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406224&action=review >>> Source/WebCore/ChangeLog:8 >>> + Caught by conformance test deqp/functional/gles3/negativebufferapi.html >> >> This change is missing a test. > > The test is present. The suite it's in (deqp) is currently skipped in the test expectations because it takes a long time to run. I'm looking into whether we can make it faster. We have a separate bot that runs the deqp tests. 1678827 6 ews-feeder 2020-08-07 16:56:34 -0700 Committed r265399: <https://trac.webkit.org/changeset/265399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406224. 1678828 7 webkit-bug-importer 2020-08-07 16:57:18 -0700 <rdar://problem/66706728> 406224 2020-08-07 16:05:17 -0700 2020-08-07 16:56:34 -0700 Patch bug-215298-20200807160516.patch text/plain 1615 jdarpinian U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRlZGUzM2JiNTVmYjQ4 YzgxZDE3ZjU4YmUzNDBmYmZhOTU5N2JhMi4uNjc4ZTExOThlYTYxYmUyZDgzNDM5NzMyNzExZWU2 YzNkOWNkYjY4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA4LTA3ICBKYW1l cyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBPZmYgYnkg b25lIGVycm9yIGluIHRyYW5zZm9ybSBmZWVkYmFjayBidWZmZXIgYmluZGluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1Mjk4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2F1Z2h0IGJ5IGNvbmZvcm1h bmNlIHRlc3QgZGVxcC9mdW5jdGlvbmFsL2dsZXMzL25lZ2F0aXZlYnVmZmVyYXBpLmh0bWwKKwor ICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMMlJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6V2ViR0wyUmVuZGVyaW5nQ29udGV4dDo6c2V0SW5kZXhlZEJ1ZmZlckJpbmRp bmcpOgorCiAyMDIwLTA4LTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAg ICAgICAgRHJvcCBub24tc3RhbmRhcmQgY3JlYXRlQnVmZmVyKEFycmF5QnVmZmVyLCBib29sZWFu KSBvdmVybG9hZCBmcm9tIEF1ZGlvQ29udGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0wyUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCBhZWYxMzI4MDBhNGYx MTBjYTg3OTc4ZDc1YTY3MDk5ZWFjM2FmY2ZhLi4xOTgzNGNlNWMwYzhkMmNmNzMwMjNkYzNkYTI0 ZDIzMDNiNGQyNjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TDJSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHTDJSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtMjM0MCw3ICsyMzQwLDcgQEAgYm9vbCBXZWJH TDJSZW5kZXJpbmdDb250ZXh0OjpzZXRJbmRleGVkQnVmZmVyQmluZGluZyhjb25zdCBjaGFyICpm dW5jdGlvbk5hbWUsIEcKIAogICAgIHN3aXRjaCAodGFyZ2V0KSB7CiAgICAgY2FzZSBHcmFwaGlj c0NvbnRleHRHTDo6VFJBTlNGT1JNX0ZFRURCQUNLX0JVRkZFUjoKLSAgICAgICAgaWYgKGluZGV4 ID4gbV9tYXhUcmFuc2Zvcm1GZWVkYmFja1NlcGFyYXRlQXR0cmlicykgeworICAgICAgICBpZiAo aW5kZXggPj0gbV9tYXhUcmFuc2Zvcm1GZWVkYmFja1NlcGFyYXRlQXR0cmlicykgewogICAgICAg ICAgICAgc3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3NDb250ZXh0R0w6OklOVkFMSURfVkFMVUUs IGZ1bmN0aW9uTmFtZSwgImluZGV4IG91dCBvZiByYW5nZSIpOwogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgICAgICB9Cg==