215292 2020-08-07 13:42:50 -0700 [webkitpy] Pick a reasonable auto-install location on NFS mounts 2020-08-08 13:31:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard dean_johnson dewei_zhu ews-watchlist fujii glenn slewis webkit-bug-importer oldest_to_newest 1678723 0 jbedard 2020-08-07 13:42:50 -0700 On occasion, webkitpy is hosted on an NFS mount. It would be wrong for clients which do not own the checkout to write auto-installed libraries to the NFS mount, since they do not own the mount. 1678724 1 webkit-bug-importer 2020-08-07 13:43:12 -0700 <rdar://problem/66698141> 1678727 2 406208 jbedard 2020-08-07 13:51:44 -0700 Created attachment 406208 Patch 1678730 3 406209 jbedard 2020-08-07 14:03:59 -0700 Created attachment 406209 Patch 1678732 4 406209 dean_johnson 2020-08-07 14:09:12 -0700 Comment on attachment 406209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406209&action=review LGTM /w comments. Unofficial r+. > Tools/Scripts/webkitpy/__init__.py:22 > +if sys.platform == 'darwin' and (not os.getuid() or os.stat(libraries).st_uid != os.getuid()): This is a bit difficult to read; can we split some of the logic into variables to make it clearer? e.g. is_root_user = os.getuid() == 0 user_owns_local_libraries = os.stat(libraries).st_uid == os.getuid() if sys.platform == 'darwin' and (is_root_user or not user_owns_local_libraries): libraries = os.path.expanduser('~/Library/webkitpy') 1678740 5 406214 jbedard 2020-08-07 14:28:06 -0700 Created attachment 406214 Patch 1678861 6 406214 ap 2020-08-07 20:21:25 -0700 Comment on attachment 406214 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406214&action=review > Tools/Scripts/webkitpy/__init__.py:23 > +if sys.platform == 'darwin' and (is_root or not does_own_libraries): Is it right to autoinstall onto a share even for someone who owns the directory? 1678900 7 jbedard 2020-08-08 06:20:13 -0700 (In reply to Alexey Proskuryakov from comment #6) > Comment on attachment 406214 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406214&action=review > > > Tools/Scripts/webkitpy/__init__.py:23 > > +if sys.platform == 'darwin' and (is_root or not does_own_libraries): > > Is it right to autoinstall onto a share even for someone who owns the > directory? Probably not, although I'm not sure a reliable way to determine if a given directory is a share. In practice, in all of the cases I'm aware of a share being used, it would be a configuration error if an individual user owned a directory anyways. 1678901 8 ews-feeder 2020-08-08 06:43:58 -0700 Committed r265408: <https://trac.webkit.org/changeset/265408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406214. 1678919 9 fujii 2020-08-08 12:57:40 -0700 WinCairo buildbot is failing since this change. https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Tests%29/builds/3130 Traceback (most recent call last): File "./Tools/Scripts/run-webkit-tests", line 36, in <module> from webkitpy.common import multiprocessing_bootstrap File "C:\WebKit-BuildWorker\wincairo-wkl-debug-tests\build\Tools\Scripts\webkitpy\__init__.py", line 21, in <module> is_root = not os.getuid() AttributeError: 'module' object has no attribute 'getuid' 1678922 10 fujii 2020-08-08 13:31:29 -0700 Committed r265409: <https://trac.webkit.org/changeset/265409> 406208 2020-08-07 13:51:44 -0700 2020-08-07 14:03:57 -0700 Patch bug-215292-20200807135143.patch text/plain 1496 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTM4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA4LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFBpY2sgYSBzYW5lIGF1dG8taW5zdGFsbCBsb2NhdGlv biBvbiBORlMgbW91bnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTUyOTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2Njk4MTQxPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9fX2luaXRfXy5weTogT24gTWFjT1MsIHdoZW4gcm9vdCwgd3JpdGUgYWxsIGF1dG8taW5z dGFsbGVkIGxpYnJhcmllcyB0byAvTGlicmFyaWVzL3dlYmtpdHB5LiBJZiB0aGUKKyAgICAgICAg Y3VycmVudCB1c2VyIGRvZXMgbm90IG93biB0aGUgY2hlY2tvdXQsIHVzZSB+L0xpYnJhcmllcy93 ZWJraXRweS4KKwogMjAyMC0wOC0wNyAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNv bT4KIAogICAgICAgICBFeHBlcmltZW50YWw6IENhcCB0aGUgZXhwaXJ5IG9mIHBlcnNpc3RlbnQg Y29va2llcyBzZXQgaW4gM3JkLXBhcnR5IENOQU1FIGNsb2FrZWQgSFRUUCByZXNwb25zZXMKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvX19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weQkocmV2aXNpb24gMjY1Mzg4KQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weQkod29ya2luZyBjb3B5KQpAQCAtMTksNCAr MTksOSBAQCBsaWJyYXJpZXMgPSBvcy5wYXRoLmpvaW4ob3MucGF0aC5hYnNwYXRoCiBzeXMucGF0 aC5pbnNlcnQoMCwgb3MucGF0aC5qb2luKGxpYnJhcmllcywgJ3dlYmtpdGNvcmVweScpKQogCiBm cm9tIHdlYmtpdGNvcmVweSBpbXBvcnQgQXV0b0luc3RhbGwKK2lmIHN5cy5wbGF0Zm9ybSA9PSAn ZGFyd2luJzoKKyAgICBpZiBub3Qgb3MuZ2V0dWlkKCk6CisgICAgICAgIGxpYnJhcmllcyA9ICcv TGlicmFyeS93ZWJraXRweScKKyAgICBlbGlmIG9zLnN0YXQobGlicmFyaWVzKS5zdF91aWQgIT0g b3MuZ2V0dWlkKCk6CisgICAgICAgIGxpYnJhcmllcyA9IG9zLnBhdGguZXhwYW5kdXNlcignfi9M aWJyYXJ5L3dlYmtpdHB5JykKIEF1dG9JbnN0YWxsLnNldF9kaXJlY3Rvcnkob3MucGF0aC5qb2lu KGxpYnJhcmllcywgJ2F1dG9pbnN0YWxsZWQnLCAncHl0aG9uLXt9Jy5mb3JtYXQoc3lzLnZlcnNp b25faW5mb1swXSkpKQo= 406209 2020-08-07 14:03:59 -0700 2020-08-07 14:28:03 -0700 Patch bug-215292-20200807140358.patch text/plain 1369 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTM4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA4LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFBpY2sgYSByZWFzb25hYmxlIGF1dG8taW5zdGFsbCBs b2NhdGlvbiBvbiBORlMgbW91bnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTUyOTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2Njk4MTQxPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9fX2luaXRfXy5weTogT24gTWFjT1MsIHdoZW4gdGhlIGN1cnJlbnQgdXNlciBk b2VzIG5vdCBvd24gdGhlIGNoZWNrb3V0LCB1c2Ugfi9MaWJyYXJpZXMvd2Via2l0cHkuCisKIDIw MjAtMDgtMDcgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAg RXhwZXJpbWVudGFsOiBDYXAgdGhlIGV4cGlyeSBvZiBwZXJzaXN0ZW50IGNvb2tpZXMgc2V0IGlu IDNyZC1wYXJ0eSBDTkFNRSBjbG9ha2VkIEhUVFAgcmVzcG9uc2VzCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI2NTM4OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvX19pbml0X18ucHkJKHdvcmtpbmcgY29weSkKQEAgLTE5LDQgKzE5LDYgQEAgbGlicmFy aWVzID0gb3MucGF0aC5qb2luKG9zLnBhdGguYWJzcGF0aAogc3lzLnBhdGguaW5zZXJ0KDAsIG9z LnBhdGguam9pbihsaWJyYXJpZXMsICd3ZWJraXRjb3JlcHknKSkKIAogZnJvbSB3ZWJraXRjb3Jl cHkgaW1wb3J0IEF1dG9JbnN0YWxsCitpZiBzeXMucGxhdGZvcm0gPT0gJ2RhcndpbicgYW5kIChu b3Qgb3MuZ2V0dWlkKCkgb3Igb3Muc3RhdChsaWJyYXJpZXMpLnN0X3VpZCAhPSBvcy5nZXR1aWQo KSk6CisgICAgbGlicmFyaWVzID0gb3MucGF0aC5leHBhbmR1c2VyKCd+L0xpYnJhcnkvd2Via2l0 cHknKQogQXV0b0luc3RhbGwuc2V0X2RpcmVjdG9yeShvcy5wYXRoLmpvaW4obGlicmFyaWVzLCAn YXV0b2luc3RhbGxlZCcsICdweXRob24te30nLmZvcm1hdChzeXMudmVyc2lvbl9pbmZvWzBdKSkp Cg== 406214 2020-08-07 14:28:06 -0700 2020-08-08 06:43:58 -0700 Patch bug-215292-20200807142805.patch text/plain 1506 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTM4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA4LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFBpY2sgYSByZWFzb25hYmxlIGF1dG8taW5zdGFsbCBs b2NhdGlvbiBvbiBORlMgbW91bnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTUyOTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2Njk4MTQxPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9fX2luaXRfXy5weTogT24gTWFjT1MsIHdoZW4gdGhlIGN1cnJlbnQgdXNlciBk b2VzIG5vdCBvd24gdGhlIGNoZWNrb3V0LCB1c2Ugfi9MaWJyYXJpZXMvd2Via2l0cHkuCisKIDIw MjAtMDgtMDcgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAg RXhwZXJpbWVudGFsOiBDYXAgdGhlIGV4cGlyeSBvZiBwZXJzaXN0ZW50IGNvb2tpZXMgc2V0IGlu IDNyZC1wYXJ0eSBDTkFNRSBjbG9ha2VkIEhUVFAgcmVzcG9uc2VzCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI2NTM4OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvX19pbml0X18ucHkJKHdvcmtpbmcgY29weSkKQEAgLTE4LDUgKzE4LDEwIEBAIGltcG9y dCBzeXMKIGxpYnJhcmllcyA9IG9zLnBhdGguam9pbihvcy5wYXRoLmFic3BhdGgob3MucGF0aC5k aXJuYW1lKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXykpKSwgJ2xpYnJhcmllcycpCiBzeXMucGF0 aC5pbnNlcnQoMCwgb3MucGF0aC5qb2luKGxpYnJhcmllcywgJ3dlYmtpdGNvcmVweScpKQogCitp c19yb290ID0gbm90IG9zLmdldHVpZCgpCitkb2VzX293bl9saWJyYXJpZXMgPSBvcy5zdGF0KGxp YnJhcmllcykuc3RfdWlkID09IG9zLmdldHVpZCgpCitpZiBzeXMucGxhdGZvcm0gPT0gJ2Rhcndp bicgYW5kIChpc19yb290IG9yIG5vdCBkb2VzX293bl9saWJyYXJpZXMpOgorICAgIGxpYnJhcmll cyA9IG9zLnBhdGguZXhwYW5kdXNlcignfi9MaWJyYXJ5L3dlYmtpdHB5JykKKwogZnJvbSB3ZWJr aXRjb3JlcHkgaW1wb3J0IEF1dG9JbnN0YWxsCiBBdXRvSW5zdGFsbC5zZXRfZGlyZWN0b3J5KG9z LnBhdGguam9pbihsaWJyYXJpZXMsICdhdXRvaW5zdGFsbGVkJywgJ3B5dGhvbi17fScuZm9ybWF0 KHN5cy52ZXJzaW9uX2luZm9bMF0pKSkK