215272 2020-08-07 08:55:15 -0700 Fix inequality in newly added assertion 2020-08-07 09:41:57 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215100 InRadar P2 Normal --- 215100 1 rmorisset rmorisset benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1678598 0 rmorisset 2020-08-07 08:55:15 -0700 In IndexSparseSet::validate() (that I just added), there is an assertion that m_values.size() < m_map.size(). It should be <= instead. 1678601 1 406177 rmorisset 2020-08-07 08:57:10 -0700 Created attachment 406177 Patch 1678618 2 ews-feeder 2020-08-07 09:39:35 -0700 Committed r265378: <https://trac.webkit.org/changeset/265378> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406177. 1678619 3 webkit-bug-importer 2020-08-07 09:40:22 -0700 <rdar://problem/66685769> 1678620 4 406177 ap 2020-08-07 09:41:57 -0700 Comment on attachment 406177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406177&action=review > Source/WTF/ChangeLog:8 > + No new tests, as it was caught by our testing infrastructure (not sure why it only got caught after landing). As determined in a Slack discussion, the explanation is that the landed patch was different from what went through EWS. 406177 2020-08-07 08:57:10 -0700 2020-08-07 09:39:35 -0700 Patch patch215272 text/plain 1335 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYThiOTlhMjg3ZmYuLmVjNWFkNzI3NzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIw LTA4LTA3ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAg Rml4IGluZXF1YWxpdHkgaW4gbmV3bHkgYWRkZWQgYXNzZXJ0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUyNzIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFzIGl0IHdhcyBj YXVnaHQgYnkgb3VyIHRlc3RpbmcgaW5mcmFzdHJ1Y3R1cmUgKG5vdCBzdXJlIHdoeSBpdCBvbmx5 IGdvdCBjYXVnaHQgYWZ0ZXIgbGFuZGluZykuCisKKyAgICAgICAgKiB3dGYvSW5kZXhTcGFyc2VT ZXQuaDoKKyAgICAgICAgKFdURjo6T3ZlcmZsb3dIYW5kbGVyPjo6dmFsaWRhdGUpOgorCiAyMDIw LTA4LTA3ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAg SW5kZXhTcGFyc2VTZXQ6OnNvcnQoKSBzaG91bGQgdXBkYXRlIG1fbWFwCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9JbmRleFNwYXJzZVNldC5oIGIvU291cmNlL1dURi93dGYvSW5kZXhTcGFy c2VTZXQuaAppbmRleCBlOGJlNzQyMTE1Mi4uMWZlZDI5MWRlYTUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL0luZGV4U3BhcnNlU2V0LmgKKysrIGIvU291cmNlL1dURi93dGYvSW5kZXhTcGFy c2VTZXQuaApAQCAtMjMyLDcgKzIzMiw3IEBAIHZvaWQgSW5kZXhTcGFyc2VTZXQ8RW50cnlUeXBl LCBFbnRyeVR5cGVUcmFpdHMsIE92ZXJmbG93SGFuZGxlcj46OnNvcnQoKQogdGVtcGxhdGU8dHlw ZW5hbWUgRW50cnlUeXBlLCB0eXBlbmFtZSBFbnRyeVR5cGVUcmFpdHMsIHR5cGVuYW1lIE92ZXJm bG93SGFuZGxlcj4KIHZvaWQgSW5kZXhTcGFyc2VTZXQ8RW50cnlUeXBlLCBFbnRyeVR5cGVUcmFp dHMsIE92ZXJmbG93SGFuZGxlcj46OnZhbGlkYXRlKCkKIHsKLSAgICBSRUxFQVNFX0FTU0VSVCht X3ZhbHVlcy5zaXplKCkgPCBtX21hcC5zaXplKCkpOworICAgIFJFTEVBU0VfQVNTRVJUKG1fdmFs dWVzLnNpemUoKSA8PSBtX21hcC5zaXplKCkpOwogICAgIGZvciAoY29uc3QgRW50cnlUeXBlJiBl bnRyeSA6ICp0aGlzKQogICAgICAgICBSRUxFQVNFX0FTU0VSVChjb250YWlucyhFbnRyeVR5cGVU cmFpdHM6OmtleShlbnRyeSkpKTsKIH0K