215269 2020-08-07 07:45:40 -0700 [WTF] Remove the build warning since r265344. 2020-08-08 03:55:18 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jh718.park jh718.park benjamin cdumez cmarcelo ddkilzer ews-watchlist sam webkit-bug-importer oldest_to_newest 1678584 0 jh718.park 2020-08-07 07:45:40 -0700 In file included from DerivedSources/ForwardingHeaders/wtf/text/AtomString.h:26, from DerivedSources/ForwardingHeaders/wtf/text/StringBuilder.h:30, from ../../Tools/TestWebKitAPI/WTFStringUtilities.h:39, from ../../Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:28: DerivedSources/ForwardingHeaders/wtf/text/IntegerToStringConversion.h: In instantiation of ‘unsigned int WTF::lengthOfIntegerAsString(IntegerType) [with IntegerType = bool]’: DerivedSources/ForwardingHeaders/wtf/text/StringConcatenateNumbers.h:60:61: required from ‘unsigned int WTF::StringTypeAdapter<Enum, typename std::enable_if<is_enum_v<Enum>, void>::type>::length() const [with Enum = TestWebKitAPI::BoolEnum; typename std::enable_if<is_enum_v<Enum>, void>::type = void]’ DerivedSources/ForwardingHeaders/wtf/text/StringConcatenate.h:390:35: required from ‘WTF::String WTF::tryMakeStringFromAdapters(StringTypeAdapter, StringTypeAdapters ...) [with StringTypeAdapter = WTF::StringTypeAdapter<TestWebKitAPI::BoolEnum, void>; StringTypeAdapters = {}]’ DerivedSources/ForwardingHeaders/wtf/text/StringConcatenate.h:420:37: required from ‘WTF::String WTF::tryMakeString(StringTypes ...) [with StringTypes = {TestWebKitAPI::BoolEnum}]’ DerivedSources/ForwardingHeaders/wtf/text/StringConcatenate.h:426:34: required from ‘WTF::String WTF::makeString(StringTypes ...) [with StringTypes = {TestWebKitAPI::BoolEnum}]’ ../../Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:111:5: required from here DerivedSources/ForwardingHeaders/wtf/text/IntegerToStringConversion.h:115:53: warning: parameter ‘integer’ set but not used [-Wunused-but-set-parameter] 115 | inline unsigned lengthOfIntegerAsString(IntegerType integer) | ~~~~~~~~~~~~^~~~~~~ 1678585 1 406174 jh718.park 2020-08-07 07:47:47 -0700 Created attachment 406174 Patch 1678786 2 406174 ddkilzer 2020-08-07 16:00:52 -0700 Comment on attachment 406174 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406174&action=review Both lengthOfIntegerAsString() and another method were refactored to handle all types in a single method, so I'd prefer to keep them that way. > Source/WTF/wtf/text/IntegerToStringConversion.h:-119 > - if constexpr (std::is_same_v<IntegerType, bool>) > - return 1; I think we should add UNUSED_PARAM(integer) here instead. 1678845 3 jh718.park 2020-08-07 17:42:37 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Comment on attachment 406174 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406174&action=review > > Both lengthOfIntegerAsString() and another method were refactored to handle > all types in a single method, so I'd prefer to keep them that way. > > > Source/WTF/wtf/text/IntegerToStringConversion.h:-119 > > - if constexpr (std::is_same_v<IntegerType, bool>) > > - return 1; > > I think we should add UNUSED_PARAM(integer) here instead. Thank you for your review. I will add UNUSED_PARAM in the next patchset. 1678852 4 406237 jh718.park 2020-08-07 18:21:53 -0700 Created attachment 406237 Patch 1678855 5 406239 jh718.park 2020-08-07 18:24:43 -0700 Created attachment 406239 Patch 1678898 6 jh718.park 2020-08-08 03:54:06 -0700 Committed r265407: <https://trac.webkit.org/changeset/265407> 1678899 7 webkit-bug-importer 2020-08-08 03:55:18 -0700 <rdar://problem/66721962> 406174 2020-08-07 07:47:47 -0700 2020-08-07 18:21:50 -0700 Patch bug-215269-20200807234746.patch text/plain 1934 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGEzMzZmOTMxNTA1YWEyZTYwMGZhNGE0 NWE0MTU5YTkyY2VlMDI4NDkuLjZmYjIzMmZmMjA5ZTFhMWU2ZTU1NTM0NzJjN2U0YmQzYmJhOWNi OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDgtMDcgIEpvb25naHVuIFBhcmsgIDxqaDcx OC5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXVEZdIFJlbW92ZSB0aGUgYnVpbGQgd2Fy bmluZyBzaW5jZSByMjY1MzQ0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE1MjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgd2FybmluZzogcGFyYW1ldGVyIOKAmGludGVnZXLigJkgc2V0IGJ1dCBub3Qg dXNlZCBbLVd1bnVzZWQtYnV0LXNldC1wYXJhbWV0ZXJdCisKKyAgICAgICAgKiB3dGYvdGV4dC9J bnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmg6CisgICAgICAgIChXVEY6Omxlbmd0aE9mSW50ZWdl ckFzU3RyaW5nKToKKwogMjAyMC0wOC0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgSW50cm9kdWNlIGEgVmVjdG9yOjppc29sYXRlZENvcHkoKSAmJgpkaWZm IC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgg Yi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaAppbmRleCBk ZDI4M2Q5ZGE3NzAxMjc0MTk5MDU1MWJmNDAxYTU1OTYxY2I5ODJiLi5iNDVkNzBkNjM5MjQyYTdh ODEwMTgzZjhlZGQzNTE5ZGZiOWE1ZjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0lu dGVnZXJUb1N0cmluZ0NvbnZlcnNpb24uaApAQCAtMTE1LDkgKzExNSw3IEBAIHRlbXBsYXRlPHR5 cGVuYW1lIEludGVnZXJUeXBlPgogaW5saW5lIHVuc2lnbmVkIGxlbmd0aE9mSW50ZWdlckFzU3Ry aW5nKEludGVnZXJUeXBlIGludGVnZXIpCiB7CiAgICAgc3RhdGljX2Fzc2VydChzdGQ6OmlzX2lu dGVncmFsX3Y8SW50ZWdlclR5cGU+KTsKLSAgICBpZiBjb25zdGV4cHIgKHN0ZDo6aXNfc2FtZV92 PEludGVnZXJUeXBlLCBib29sPikKLSAgICAgICAgcmV0dXJuIDE7Ci0gICAgZWxzZSBpZiBjb25z dGV4cHIgKHN0ZDo6aXNfc2lnbmVkX3Y8SW50ZWdlclR5cGU+KSB7CisgICAgaWYgY29uc3RleHBy IChzdGQ6OmlzX3NpZ25lZF92PEludGVnZXJUeXBlPikgewogICAgICAgICBpZiAoaW50ZWdlciA8 IDApCiAgICAgICAgICAgICByZXR1cm4gbGVuZ3RoT2ZJbnRlZ2VyQXNTdHJpbmdJbXBsPHR5cGVu YW1lIHN0ZDo6bWFrZV91bnNpZ25lZF90PEludGVnZXJUeXBlPiwgTmVnYXRpdmVOdW1iZXI+KC1p bnRlZ2VyKTsKICAgICAgICAgcmV0dXJuIGxlbmd0aE9mSW50ZWdlckFzU3RyaW5nSW1wbDx0eXBl bmFtZSBzdGQ6Om1ha2VfdW5zaWduZWRfdDxJbnRlZ2VyVHlwZT4sIFBvc2l0aXZlTnVtYmVyPihp bnRlZ2VyKTsKQEAgLTEyNSw0ICsxMjMsMTAgQEAgaW5saW5lIHVuc2lnbmVkIGxlbmd0aE9mSW50 ZWdlckFzU3RyaW5nKEludGVnZXJUeXBlIGludGVnZXIpCiAgICAgICAgIHJldHVybiBsZW5ndGhP ZkludGVnZXJBc1N0cmluZ0ltcGw8SW50ZWdlclR5cGUsIFBvc2l0aXZlTnVtYmVyPihpbnRlZ2Vy KTsKIH0KIAordGVtcGxhdGU8PgoraW5saW5lIHVuc2lnbmVkIGxlbmd0aE9mSW50ZWdlckFzU3Ry aW5nKGJvb2wpCit7CisgICAgcmV0dXJuIDE7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdURgo= 406237 2020-08-07 18:21:53 -0700 2020-08-07 18:24:39 -0700 Patch bug-215269-20200808102152.patch text/plain 1651 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE3OTBkMTVmZDVkNjFmZmU1NWE5M2U2 YzQzMWFiZDNlMjM0MjIyMjAuLjEwNzg2Y2ZiYzZkMWMwOTcwYWI4NWYzYjQ3ODFmYTBkYjUzMGIx OTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDgtMDcgIEpvb25naHVuIFBhcmsgIDxqaDcx OC5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXVEZdIFJlbW92ZSB0aGUgYnVpbGQgd2Fy bmluZyBzaW5jZSByMjY1MzQ0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE1MjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgd2FybmluZzogcGFyYW1ldGVyIMOiaW50ZWdlcsOiIHNldCBidXQgbm90IHVz ZWQgWy1XdW51c2VkLWJ1dC1zZXQtcGFyYW1ldGVyXQorCisgICAgICAgICogd3RmL3RleHQvSW50 ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oOgorICAgICAgICAoV1RGOjpsZW5ndGhPZkludGVnZXJB c1N0cmluZyk6CisKIDIwMjAtMDgtMDcgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5j b20+CiAKICAgICAgICAgRXhwZXJpbWVudGFsOiBDYXAgdGhlIGV4cGlyeSBvZiBwZXJzaXN0ZW50 IGNvb2tpZXMgc2V0IGluIDNyZC1wYXJ0eSBDTkFNRSBjbG9ha2VkIEhUVFAgcmVzcG9uc2VzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L0ludGVnZXJUb1N0cmluZ0NvbnZlcnNpb24u aCBiL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oCmluZGV4 IGRkMjgzZDlkYTc3MDEyNzQxOTkwNTUxYmY0MDFhNTU5NjFjYjk4MmIuLmM3NTQ2Njc1MjU0MDFh ZGFmMDU0Nzc2NTI4ZGUzNzE2NTAxZjEzZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3Rl eHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQv SW50ZWdlclRvU3RyaW5nQ29udmVyc2lvbi5oCkBAIC0xMTUsOCArMTE1LDEwIEBAIHRlbXBsYXRl PHR5cGVuYW1lIEludGVnZXJUeXBlPgogaW5saW5lIHVuc2lnbmVkIGxlbmd0aE9mSW50ZWdlckFz U3RyaW5nKEludGVnZXJUeXBlIGludGVnZXIpCiB7CiAgICAgc3RhdGljX2Fzc2VydChzdGQ6Omlz X2ludGVncmFsX3Y8SW50ZWdlclR5cGU+KTsKLSAgICBpZiBjb25zdGV4cHIgKHN0ZDo6aXNfc2Ft ZV92PEludGVnZXJUeXBlLCBib29sPikKKyAgICBpZiBjb25zdGV4cHIgKHN0ZDo6aXNfc2FtZV92 PEludGVnZXJUeXBlLCBib29sPikgeworICAgICAgICBVTlVTRURfUEFSQU0oaW50ZWdlcik7CiAg ICAgICAgIHJldHVybiAxOworICAgIH0KICAgICBlbHNlIGlmIGNvbnN0ZXhwciAoc3RkOjppc19z aWduZWRfdjxJbnRlZ2VyVHlwZT4pIHsKICAgICAgICAgaWYgKGludGVnZXIgPCAwKQogICAgICAg ICAgICAgcmV0dXJuIGxlbmd0aE9mSW50ZWdlckFzU3RyaW5nSW1wbDx0eXBlbmFtZSBzdGQ6Om1h a2VfdW5zaWduZWRfdDxJbnRlZ2VyVHlwZT4sIE5lZ2F0aXZlTnVtYmVyPigtaW50ZWdlcik7Cg== 406239 2020-08-07 18:24:43 -0700 2020-08-07 23:33:59 -0700 Patch bug-215269-20200808102441.patch text/plain 1653 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE3OTBkMTVmZDVkNjFmZmU1NWE5M2U2 YzQzMWFiZDNlMjM0MjIyMjAuLmVmOWE1N2NiMjNiZjkyMzM1MDU5MTk4MzQ0ZTMxM2Q0MzZlMjli N2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDgtMDcgIEpvb25naHVuIFBhcmsgIDxqaDcx OC5wYXJrQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtXVEZdIFJlbW92ZSB0aGUgYnVpbGQgd2Fy bmluZyBzaW5jZSByMjY1MzQ0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE1MjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgd2FybmluZzogcGFyYW1ldGVyIOKAmGludGVnZXLigJkgc2V0IGJ1dCBub3Qg dXNlZCBbLVd1bnVzZWQtYnV0LXNldC1wYXJhbWV0ZXJdCisKKyAgICAgICAgKiB3dGYvdGV4dC9J bnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmg6CisgICAgICAgIChXVEY6Omxlbmd0aE9mSW50ZWdl ckFzU3RyaW5nKToKKwogMjAyMC0wOC0wNyAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxl LmNvbT4KIAogICAgICAgICBFeHBlcmltZW50YWw6IENhcCB0aGUgZXhwaXJ5IG9mIHBlcnNpc3Rl bnQgY29va2llcyBzZXQgaW4gM3JkLXBhcnR5IENOQU1FIGNsb2FrZWQgSFRUUCByZXNwb25zZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvSW50ZWdlclRvU3RyaW5nQ29udmVyc2lv bi5oIGIvU291cmNlL1dURi93dGYvdGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKaW5k ZXggZGQyODNkOWRhNzcwMTI3NDE5OTA1NTFiZjQwMWE1NTk2MWNiOTgyYi4uYzc1NDY2NzUyNTQw MWFkYWYwNTQ3NzY1MjhkZTM3MTY1MDFmMTNmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv dGV4dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4 dC9JbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKQEAgLTExNSw4ICsxMTUsMTAgQEAgdGVtcGxh dGU8dHlwZW5hbWUgSW50ZWdlclR5cGU+CiBpbmxpbmUgdW5zaWduZWQgbGVuZ3RoT2ZJbnRlZ2Vy QXNTdHJpbmcoSW50ZWdlclR5cGUgaW50ZWdlcikKIHsKICAgICBzdGF0aWNfYXNzZXJ0KHN0ZDo6 aXNfaW50ZWdyYWxfdjxJbnRlZ2VyVHlwZT4pOwotICAgIGlmIGNvbnN0ZXhwciAoc3RkOjppc19z YW1lX3Y8SW50ZWdlclR5cGUsIGJvb2w+KQorICAgIGlmIGNvbnN0ZXhwciAoc3RkOjppc19zYW1l X3Y8SW50ZWdlclR5cGUsIGJvb2w+KSB7CisgICAgICAgIFVOVVNFRF9QQVJBTShpbnRlZ2VyKTsK ICAgICAgICAgcmV0dXJuIDE7CisgICAgfQogICAgIGVsc2UgaWYgY29uc3RleHByIChzdGQ6Omlz X3NpZ25lZF92PEludGVnZXJUeXBlPikgewogICAgICAgICBpZiAoaW50ZWdlciA8IDApCiAgICAg ICAgICAgICByZXR1cm4gbGVuZ3RoT2ZJbnRlZ2VyQXNTdHJpbmdJbXBsPHR5cGVuYW1lIHN0ZDo6 bWFrZV91bnNpZ25lZF90PEludGVnZXJUeXBlPiwgTmVnYXRpdmVOdW1iZXI+KC1pbnRlZ2VyKTsK