215241 2020-08-06 14:16:05 -0700 Avoid triggering redundant compositing updates when trying ot run a steps() animation on transform 2020-08-24 03:37:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215229 https://bugs.webkit.org/show_bug.cgi?id=215454 InRadar P2 Normal --- 1 simon.fraser simon.fraser graouts simon.fraser webkit-bug-importer zalan oldest_to_newest 1678401 0 simon.fraser 2020-08-06 14:16:05 -0700 Avoid triggering redundant compositing updates when trying ot run a steps() animation on transform 1678406 1 406114 simon.fraser 2020-08-06 14:22:01 -0700 Created attachment 406114 Patch 1678407 2 simon.fraser 2020-08-06 14:22:04 -0700 <rdar://problem/62737868> 1678486 3 simon.fraser 2020-08-06 17:58:57 -0700 http://trac.webkit.org/changeset/265358/webkit 1682293 4 406114 graouts 2020-08-24 03:37:48 -0700 Comment on attachment 406114 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406114&action=review > LayoutTests/animations/steps-transform-rendering-updates-expected.txt:2 > -PASS count < 6 is true > +FAIL count < 6 should be true. Was false. We shouldn't have a FAIL in one of the test outputs. 406114 2020-08-06 14:22:01 -0700 2020-08-06 14:32:17 -0700 Patch bug-215241-20200806142200.patch text/plain 7341 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIzN2M4NzY3MDljNmNh ZTJiM2Q1NzFiZjEyYjc0MGUyNzk2NmUyMy4uOGY1MmRlMzZkNDBhNGQyOGQxZmI2MmYzNDRlNmE4 NThjZGU4NTY2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA4LTA2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIHRyaWdn ZXJpbmcgcmVkdW5kYW50IGNvbXBvc2l0aW5nIHVwZGF0ZXMgd2hlbiB0cnlpbmcgb3QgcnVuIGEg c3RlcHMoKSBhbmltYXRpb24gb24gdHJhbnNmb3JtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUyNDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYy NzM3ODY4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdpdGggYSBzdGVwcygpIHRpbWluZyBmdW5jdGlvbiBhbmQga2V5ZnJhbWVzIGFuaW1hdGluZyB0 aGUgdHJhbnNmb3JtIHByb3BlcnR5LCBLZXlmcmFtZUVmZmVjdDo6YXBwbHlQZW5kaW5nQWNjZWxl cmF0ZWRBY3Rpb25zKCkKKyAgICAgICAgdHJpZXMgdG8gcmVzdGFydCB0aGUgYW5pbWF0aW9uIGV2 ZXJ5IHRpbWUgYmVjYXVzZSB0aGUgR3JhcGhpY3NMYXllciByZXBvcnRzIHRoYXQgaXQgZGlkbid0 IHN0YXJ0IGFuIGFjY2VsZXJhdGVkIGFuaW1hdGlvbi4KKyAgICAgICAgcjI2NDg1NiBwYXRjaGVk IHNvbWUgb2YgdGhpcywgYnV0IHdlIHN0aWxsIGNhbGwgYW5pbWF0aW9uRmluaXNoZWQoKSBldmVy eSB0aW1lLCBhbmQgdGhpcyB0cmlnZ2VycyBhIGNvbXBvc2l0aW5nIHVwZGF0ZSB2aWEKKyAgICAg ICAgdGhlIG1fb3duaW5nTGF5ZXIuc2V0TmVlZHMqIGNhbGxzIGluIFJlbmRlckxheWVyQmFja2lu Zzo6YW5pbWF0aW9uRmluaXNoZWQoKS4KKworICAgICAgICBTbyBkb24ndCB0cnkgdG8gcmVtb3Zl IHRoZSBhbmltYXRpb24gaWYgd2Fzbid0IHJ1bm5pbmcuIFRoaXMgbWFrZXMgdGhvc2UgY29tcG9z aXRpbmcgdXBkYXRlcyBhIG5vLW9wLCB3aGljaCBpcyBpbXBvcnRhbnQKKyAgICAgICAgYmVjYXVz ZSB0aGVzZSBhbmltYXRpb25zIHN0aWxsIGludmFsaWRhdGUgc3R5bGUgb24gZXZlcnkgZnJhbWUg KHdlYmtpdC5vcmcvYi8yMTUyMjkpLgorCisgICAgICAgIFRlc3Q6IGFuaW1hdGlvbnMvc3RlcHMt dHJhbnNmb3JtLWNvbXBvc2l0aW5nLXVwZGF0ZXMuaHRtbAorCisgICAgICAgICogYW5pbWF0aW9u L0tleWZyYW1lRWZmZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktleWZyYW1lRWZmZWN0Ojph cHBseVBlbmRpbmdBY2NlbGVyYXRlZEFjdGlvbnMpOgorCiAyMDIwLTA4LTA1ICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIG1vcmUgQW5p bWF0aW9ucyBsb2dnaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vS2V5 ZnJhbWVFZmZlY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0 LmNwcAppbmRleCA2YmVhZDI0YjA5NWJjMjgwODZjOTQxNDQ3MmUxOWJmYjhkODRhOWYwLi4wM2U0 YWJmNDgwYmIzMGQ2Nzg1YjgwZmExZDBmNjQyMzc4NmQ4MGJkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdC5jcHAKQEAgLTE2MTIsNyArMTYxMiw4IEBAIHZvaWQg S2V5ZnJhbWVFZmZlY3Q6OmFwcGx5UGVuZGluZ0FjY2VsZXJhdGVkQWN0aW9ucygpCiAgICAgYXV0 byB0aW1lT2Zmc2V0ID0gYW5pbWF0aW9uKCktPmN1cnJlbnRUaW1lKCkudmFsdWVPcigwX3MpLnNl Y29uZHMoKSAtIGRlbGF5KCkuc2Vjb25kcygpOwogCiAgICAgYXV0byBzdGFydEFuaW1hdGlvbiA9 IFsmXSgpIC0+IFJ1bm5pbmdBY2NlbGVyYXRlZCB7Ci0gICAgICAgIHJlbmRlcmVyLT5hbmltYXRp b25GaW5pc2hlZChtX2JsZW5kaW5nS2V5ZnJhbWVzLmFuaW1hdGlvbk5hbWUoKSk7CisgICAgICAg IGlmIChtX3J1bm5pbmdBY2NlbGVyYXRlZCA9PSBSdW5uaW5nQWNjZWxlcmF0ZWQ6OlllcykKKyAg ICAgICAgICAgIHJlbmRlcmVyLT5hbmltYXRpb25GaW5pc2hlZChtX2JsZW5kaW5nS2V5ZnJhbWVz LmFuaW1hdGlvbk5hbWUoKSk7CiAKICAgICAgICAgaWYgKCFtX2JsZW5kaW5nS2V5ZnJhbWVzLmhh c0ltcGxpY2l0S2V5ZnJhbWVzKCkpCiAgICAgICAgICAgICByZXR1cm4gcmVuZGVyZXItPnN0YXJ0 QW5pbWF0aW9uKHRpbWVPZmZzZXQsIGJhY2tpbmdBbmltYXRpb25Gb3JDb21wb3NpdGVkUmVuZGVy ZXIoKSwgbV9ibGVuZGluZ0tleWZyYW1lcykgPyBSdW5uaW5nQWNjZWxlcmF0ZWQ6OlllcyA6IFJ1 bm5pbmdBY2NlbGVyYXRlZDo6Tm87CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjEyMDAwMTNmYzgxYjlkY2Y0NWUzYjgwZWVh NjhlMmFiNDdhZTZiNy4uMDA0Y2JhMzQ3OTY2NWNjMzBkOWEyN2I3MGQ1ZDA4ZDE0OWIyMGIzZSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIHRyaWdnZXJpbmcgcmVkdW5kYW50IGNv bXBvc2l0aW5nIHVwZGF0ZXMgd2hlbiB0cnlpbmcgb3QgcnVuIGEgc3RlcHMoKSBhbmltYXRpb24g b24gdHJhbnNmb3JtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTUyNDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYyNzM3ODY4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFuaW1hdGlvbnMvc3RlcHMt dHJhbnNmb3JtLXJlbmRlcmluZy11cGRhdGVzLmh0bWwgd2FzIGxhbmRlZCB3aXRoIGEgYnVnOyBp dCBhbGlhc2VkCisgICAgICAgIHRoZSBnbG9iYWwgJ2NvdW50JyB2YXJpYWJsZSwgYW5kIHdhcyB0 aHVzIHRlc3RpbmcgdGhlIHdyb25nIHRoaW5nLiBTbyBsYW5kIGEgZmFpbGluZworICAgICAgICBy ZXN1bHQgZm9yIHRoZSB0ZXN0IGZvciBub3cgKHdlYmtpdC5vcmcvYi8yMTUyMjkgYWRkcmVzc2Vz IHRoZSBmaXgpLgorCisgICAgICAgICogYW5pbWF0aW9ucy9zdGVwcy10cmFuc2Zvcm0tY29tcG9z aXRpbmctdXBkYXRlcy1leHBlY3RlZC50eHQ6IENvcGllZCBmcm9tIExheW91dFRlc3RzL2FuaW1h dGlvbnMvc3RlcHMtdHJhbnNmb3JtLXJlbmRlcmluZy11cGRhdGVzLWV4cGVjdGVkLnR4dC4KKyAg ICAgICAgKiBhbmltYXRpb25zL3N0ZXBzLXRyYW5zZm9ybS1jb21wb3NpdGluZy11cGRhdGVzLmh0 bWw6IENvcGllZCBmcm9tIExheW91dFRlc3RzL2FuaW1hdGlvbnMvc3RlcHMtdHJhbnNmb3JtLXJl bmRlcmluZy11cGRhdGVzLmh0bWwuCisgICAgICAgICogYW5pbWF0aW9ucy9zdGVwcy10cmFuc2Zv cm0tcmVuZGVyaW5nLXVwZGF0ZXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGFuaW1hdGlvbnMv c3RlcHMtdHJhbnNmb3JtLXJlbmRlcmluZy11cGRhdGVzLmh0bWw6CisKIDIwMjAtMDgtMDYgIFRy dWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy ZXZlcnRpbmcgcjI2NTMyOC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvc3Rl cHMtdHJhbnNmb3JtLWNvbXBvc2l0aW5nLXVwZGF0ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvYW5pbWF0aW9ucy9zdGVwcy10cmFuc2Zvcm0tY29tcG9zaXRpbmctdXBkYXRlcy1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uODViMmEzOGNhMjczYzZkNzAwNjg3ODZlMzM5ZGY3NDFlNjRjYTRl OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvc3RlcHMtdHJhbnNm b3JtLWNvbXBvc2l0aW5nLXVwZGF0ZXMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNiBAQAorUEFT UyBjb3VudCBpcyAwCitQQVNTIGNvdW50IDwgNiBpcyB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv YW5pbWF0aW9ucy9zdGVwcy10cmFuc2Zvcm0tY29tcG9zaXRpbmctdXBkYXRlcy5odG1sIGIvTGF5 b3V0VGVzdHMvYW5pbWF0aW9ucy9zdGVwcy10cmFuc2Zvcm0tY29tcG9zaXRpbmctdXBkYXRlcy5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLmYwZmY1MTRlOTNkNDRlOGQzODgzMDk5NDM3MzM4MjE3MTRlYjA3NmMK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3N0ZXBzLXRyYW5zZm9y bS1jb21wb3NpdGluZy11cGRhdGVzLmh0bWwKQEAgLTAsMCArMSw0OCBAQAorPCFET0NUWVBFIEhU TUw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVz dC1wcmUuanMiPjwvc2NyaXB0PgorICAgIDxzdHlsZT4KKyAgICAgICAgI2JveCB7CisgICAgICAg ICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAg ICAgYmFja2dyb3VuZC1jb2xvcjogc2lsdmVyOworICAgICAgICB9CisgICAgICAgIAorICAgICAg ICAjYm94LmFuaW1hdGluZyB7CisgICAgICAgICAgICBhbmltYXRpb246IHNwaW5uZXIgMC4yNXMg c3RlcHMoMikgMTsKKyAgICAgICAgfQorCisgICAgICAgIEBrZXlmcmFtZXMgc3Bpbm5lciB7Cisg ICAgICAgICAgICBmcm9tIHsgdHJhbnNmb3JtOiByb3RhdGUoMGRlZyk7IH0KKyAgICAgICAgICAg IHRvICAgeyB0cmFuc2Zvcm06IHJvdGF0ZSgzNjBkZWcpOyB9CisgICAgICAgIH0KKyAgICA8L3N0 eWxlPgorICAgIDxzY3JpcHQ+CisgICAgICAgIHdpbmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsK KworICAgICAgICBsZXQgY291bnQgPSAwOworICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5l cignbG9hZCcsICgpID0+IHsKKyAgICAgICAgICAgIGxldCBib3ggPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgnYm94Jyk7CisgICAgICAgICAgICBib3guYWRkRXZlbnRMaXN0ZW5lcignYW5pbWF0 aW9uc3RhcnQnLCAoKSA9PiB7CisgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMp CisgICAgICAgICAgICAgICAgICAgIGludGVybmFscy5zdGFydFRyYWNraW5nQ29tcG9zaXRpbmdV cGRhdGVzKCk7CisgICAgICAgICAgICAgICAgc2hvdWxkQmUoJ2NvdW50JywgJzAnKTsKKyAgICAg ICAgICAgIH0sIGZhbHNlKTsKKyAgICAgICAgICAgIGJveC5hZGRFdmVudExpc3RlbmVyKCdhbmlt YXRpb25lbmQnLCAoKSA9PiB7CisgICAgICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMp CisgICAgICAgICAgICAgICAgICAgIGNvdW50ID0gaW50ZXJuYWxzLmNvbXBvc2l0aW5nVXBkYXRl Q291bnQoKTsKKyAgICAgICAgICAgICAgICBzaG91bGRCZVRydWUoJ2NvdW50IDwgNicpOworICAg ICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAgICAgICAgfSwgZmFsc2UpOworICAg ICAgICAgICAgCisgICAgICAgICAgICBib3guY2xhc3NMaXN0LmFkZCgnYW5pbWF0aW5nJyk7Cisg ICAgICAgIH0sIGZhbHNlKTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxk aXYgaWQ9ImJveCI+PC9kaXY+CisgICAgPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisgICAgPHNj cmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9zdGVwcy10cmFu c2Zvcm0tcmVuZGVyaW5nLXVwZGF0ZXMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYW5pbWF0 aW9ucy9zdGVwcy10cmFuc2Zvcm0tcmVuZGVyaW5nLXVwZGF0ZXMtZXhwZWN0ZWQudHh0CmluZGV4 IDg1YjJhMzhjYTI3M2M2ZDcwMDY4Nzg2ZTMzOWRmNzQxZTY0Y2E0ZTkuLmRiOWJmZDZlYmYyMTI3 NmE1OWFmMTI0ZWQ3ZTNlYmIzNjZmNDk2YTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2FuaW1h dGlvbnMvc3RlcHMtdHJhbnNmb3JtLXJlbmRlcmluZy11cGRhdGVzLWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3N0ZXBzLXRyYW5zZm9ybS1yZW5kZXJpbmctdXBkYXRl cy1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw1IEBACiBQQVNTIGNvdW50IGlzIDAKLVBBU1MgY291 bnQgPCA2IGlzIHRydWUKK0ZBSUwgY291bnQgPCA2IHNob3VsZCBiZSB0cnVlLiBXYXMgZmFsc2Uu CiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvc3RlcHMtdHJhbnNmb3JtLXJlbmRlcmluZy11 cGRhdGVzLmh0bWwgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3N0ZXBzLXRyYW5zZm9ybS1yZW5k ZXJpbmctdXBkYXRlcy5odG1sCmluZGV4IDIyOWVjMWFhYWUyM2FhNzU0ZGQ5ZDUxMWI2ODdiMmJk ZGZkYTZlMjEuLmRmMGFhNGQwNmRjZDIwMjA2YmU4N2M2N2RmMzFlNjAzYjQ2Nzg1MTIgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvc3RlcHMtdHJhbnNmb3JtLXJlbmRlcmluZy11 cGRhdGVzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9zdGVwcy10cmFuc2Zvcm0t cmVuZGVyaW5nLXVwZGF0ZXMuaHRtbApAQCAtMzQsNyArMzQsNyBAQAogICAgICAgICAgICAgICAg IHNob3VsZEJlKCdjb3VudCcsICcwJyk7CiAgICAgICAgICAgICB9LCBmYWxzZSk7CiAgICAgICAg ICAgICBib3guYWRkRXZlbnRMaXN0ZW5lcignYW5pbWF0aW9uZW5kJywgKCkgPT4gewotICAgICAg ICAgICAgICAgIGxldCBjb3VudCA9IGludGVybmFscy5yZW5kZXJpbmdVcGRhdGVDb3VudCgpOwor ICAgICAgICAgICAgICAgIGNvdW50ID0gaW50ZXJuYWxzLnJlbmRlcmluZ1VwZGF0ZUNvdW50KCk7 CiAgICAgICAgICAgICAgICAgc2hvdWxkQmVUcnVlKCdjb3VudCA8IDYnKTsKICAgICAgICAgICAg ICAgICBmaW5pc2hKU1Rlc3QoKTsKICAgICAgICAgICAgIH0sIGZhbHNlKTsK