215223 2020-08-06 10:06:06 -0700 Fix warnings related to unsigned >=0 ASSERTs 2020-08-07 00:56:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis ews-watchlist mifenton svillar webkit-bug-importer oldest_to_newest 1678283 0 rbuis 2020-08-06 10:06:06 -0700 Fix warnings related to unsigned >=0 ASSERTs by removing the expressions. Example warning: Source/WebCore/editing/TextCheckingHelper.cpp:425:39: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 1678284 1 406089 rbuis 2020-08-06 10:07:59 -0700 Created attachment 406089 Patch 1678534 2 ews-feeder 2020-08-07 00:55:15 -0700 Committed r265364: <https://trac.webkit.org/changeset/265364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406089. 1678535 3 webkit-bug-importer 2020-08-07 00:56:19 -0700 <rdar://problem/66668030> 406089 2020-08-06 10:07:59 -0700 2020-08-07 00:55:15 -0700 Patch bug-215223-20200806190758.patch text/plain 7496 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzliZTJlYzI5ZDQ2YjM4 Mjc3NDEyOTM0ZWQ1ZWMzYzA2NzUwMDBlMy4uYzczMWVhMTFiM2FhMTM3NjkwODE2MDgwY2E3ZWRk OWVkZjJkMGJlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTA2ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHdhcm5pbmdzIHJlbGF0ZWQg dG8gdW5zaWduZWQgPj0wIEFTU0VSVHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNTIyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZpeCB3YXJuaW5ncyByZWxhdGVkIHRvIHVuc2lnbmVkID49MCBBU1NF UlRzIGJ5IHJlbW92aW5nIHRoZSBleHByZXNzaW9ucy4gRXhhbXBsZSB3YXJuaW5nOgorICAgICAg ICBUZXh0Q2hlY2tpbmdIZWxwZXIuY3BwOjQyNTozOTogd2FybmluZzogY29tcGFyaXNvbiBvZiB1 bnNpZ25lZCBleHByZXNzaW9uID49IDAgaXMgYWx3YXlzIHRydWUgWy1XdHlwZS1saW1pdHNdCisK KyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6 Om1hcmtBbmRSZXBsYWNlRm9yKToKKyAgICAgICAgKiBlZGl0aW5nL1RleHRDaGVja2luZ0hlbHBl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdE1p c3NwZWxsZWRXb3JkT3JVbmdyYW1tYXRpY2FsUGhyYXNlIGNvbnN0KToKKyAgICAgICAgKFdlYkNv cmU6OlRleHRDaGVja2luZ0hlbHBlcjo6ZmluZFVuZ3JhbW1hdGljYWxQaHJhc2VzIGNvbnN0KToK KyAgICAgICAgKFdlYkNvcmU6OlRleHRDaGVja2luZ0hlbHBlcjo6Z3Vlc3Nlc0Zvck1pc3NwZWxs ZWRXb3JkT3JVbmdyYW1tYXRpY2FsUGhyYXNlIGNvbnN0KToKKwogMjAyMC0wOC0wNiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhRWxlbWVudEF1ZGlvU291 cmNlTm9kZSBpbnRlcmZhY2Ugc2hvdWxkIGhhdmUgYSBjb25zdHJ1Y3RvcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9FZGl0b3IuY3BwCmluZGV4IDg1OTI3Yzk0YTRkODFlYjdiNGM4MDQ2YzY3YzNkNzM5ZTBhMDQ2 YWUuLjcyMTZhNzFjMDQxNDM2MGNmYjRhNDgxYjVlNDAxODI3MTNiYjJkMjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL0VkaXRvci5jcHAKQEAgLTI3OTksMTUgKzI3OTksMTUgQEAgdm9pZCBFZGl0b3I6Om1h cmtBbmRSZXBsYWNlRm9yKGNvbnN0IFNwZWxsQ2hlY2tSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBW ZWN0b3I8VGUKICAgICAgICAgLy8gICAgIndvdWxkbiciIGFzIG1pc3NwZWxsZWQgcmlnaHQgYWZ0 ZXIgYXBvc3Ryb3BoZSBpcyB0eXBlZC4KICAgICAgICAgaWYgKHNob3VsZE1hcmtTcGVsbGluZyAm JiAhc2hvdWxkU2hvd0NvcnJlY3Rpb25QYW5lbCAmJiByZXN1bHRUeXBlID09IFRleHRDaGVja2lu Z1R5cGU6OlNwZWxsaW5nCiAgICAgICAgICAgICAmJiByZXN1bHRMb2NhdGlvbiA+PSBwYXJhZ3Jh cGguY2hlY2tpbmdTdGFydCgpICYmIHJlc3VsdEVuZExvY2F0aW9uIDw9IHNwZWxsaW5nUmFuZ2VF bmRPZmZzZXQgJiYgIXJlc3VsdEVuZHNBdEFtYmlndW91c0JvdW5kYXJ5KSB7Ci0gICAgICAgICAg ICBBU1NFUlQocmVzdWx0TGVuZ3RoID4gMCAmJiByZXN1bHRMb2NhdGlvbiA+PSAwKTsKKyAgICAg ICAgICAgIEFTU0VSVChyZXN1bHRMZW5ndGggPiAwKTsKICAgICAgICAgICAgIGF1dG8gbWlzc3Bl bGxpbmdSYW5nZSA9IHBhcmFncmFwaC5zdWJyYW5nZSh7IHJlc3VsdExvY2F0aW9uLCByZXN1bHRM ZW5ndGggfSk7CiAgICAgICAgICAgICBpZiAoIW1fYWx0ZXJuYXRpdmVUZXh0Q29udHJvbGxlci0+ aXNTcGVsbGluZ01hcmtlckFsbG93ZWQobWlzc3BlbGxpbmdSYW5nZSkpCiAgICAgICAgICAgICAg ICAgY29udGludWU7CiAgICAgICAgICAgICBhZGRNYXJrZXIobWlzc3BlbGxpbmdSYW5nZSwgRG9j dW1lbnRNYXJrZXI6OlNwZWxsaW5nLCByZXBsYWNlbWVudCk7CiAgICAgICAgIH0gZWxzZSBpZiAo c2hvdWxkTWFya0dyYW1tYXIgJiYgcmVzdWx0VHlwZSA9PSBUZXh0Q2hlY2tpbmdUeXBlOjpHcmFt bWFyICYmIHBhcmFncmFwaC5jaGVja2luZ1JhbmdlQ292ZXJzKHsgcmVzdWx0TG9jYXRpb24sIHJl c3VsdExlbmd0aCB9KSkgewotICAgICAgICAgICAgQVNTRVJUKHJlc3VsdExlbmd0aCA+IDAgJiYg cmVzdWx0TG9jYXRpb24gPj0gMCk7CisgICAgICAgICAgICBBU1NFUlQocmVzdWx0TGVuZ3RoID4g MCk7CiAgICAgICAgICAgICBmb3IgKGF1dG8mIGRldGFpbCA6IHJlc3VsdHNbaV0uZGV0YWlscykg ewotICAgICAgICAgICAgICAgIEFTU0VSVChkZXRhaWwucmFuZ2UubGVuZ3RoID4gMCAmJiBkZXRh aWwucmFuZ2UubG9jYXRpb24gPj0gMCk7CisgICAgICAgICAgICAgICAgQVNTRVJUKGRldGFpbC5y YW5nZS5sZW5ndGggPiAwKTsKICAgICAgICAgICAgICAgICBpZiAocGFyYWdyYXBoLmNoZWNraW5n UmFuZ2VDb3ZlcnMoeyByZXN1bHRMb2NhdGlvbiArIGRldGFpbC5yYW5nZS5sb2NhdGlvbiwgZGV0 YWlsLnJhbmdlLmxlbmd0aCB9KSkgewogICAgICAgICAgICAgICAgICAgICBhdXRvIGJhZEdyYW1t YXJSYW5nZSA9IHBhcmFncmFwaC5zdWJyYW5nZSh7IHJlc3VsdExvY2F0aW9uICsgZGV0YWlsLnJh bmdlLmxvY2F0aW9uLCBkZXRhaWwucmFuZ2UubGVuZ3RoIH0pOwogICAgICAgICAgICAgICAgICAg ICBhZGRNYXJrZXIoYmFkR3JhbW1hclJhbmdlLCBEb2N1bWVudE1hcmtlcjo6R3JhbW1hciwgZGV0 YWlsLnVzZXJEZXNjcmlwdGlvbik7CkBAIC0yODE2LDcgKzI4MTYsNyBAQCB2b2lkIEVkaXRvcjo6 bWFya0FuZFJlcGxhY2VGb3IoY29uc3QgU3BlbGxDaGVja1JlcXVlc3QmIHJlcXVlc3QsIGNvbnN0 IFZlY3RvcjxUZQogICAgICAgICB9IGVsc2UgaWYgKHJlc3VsdEVuZExvY2F0aW9uIDw9IGF1dG9t YXRpY1JlcGxhY2VtZW50RW5kTG9jYXRpb24gJiYgcmVzdWx0RW5kTG9jYXRpb24gPj0gcGFyYWdy YXBoLmF1dG9tYXRpY1JlcGxhY2VtZW50U3RhcnQoKQogICAgICAgICAgICAgJiYgaXNBdXRvbWF0 aWNUZXh0UmVwbGFjZW1lbnRUeXBlKHJlc3VsdFR5cGUpKSB7CiAgICAgICAgICAgICAvLyBJbiB0 aGlzIGNhc2UgdGhlIHJlc3VsdCByYW5nZSBqdXN0IGhhcyB0byB0b3VjaCB0aGUgYXV0b21hdGlj IHJlcGxhY2VtZW50IHJhbmdlLCBzbyB3ZSBjYW4gaGFuZGxlIHJlcGxhY2luZyBub24td29yZCB0 ZXh0IHN1Y2ggYXMgcHVuY3R1YXRpb24uCi0gICAgICAgICAgICBBU1NFUlQocmVzdWx0TGVuZ3Ro ID4gMCAmJiByZXN1bHRMb2NhdGlvbiA+PSAwKTsKKyAgICAgICAgICAgIEFTU0VSVChyZXN1bHRM ZW5ndGggPiAwKTsKIAogICAgICAgICAgICAgaWYgKHNob3VsZFNob3dDb3JyZWN0aW9uUGFuZWwg JiYgKHJlc3VsdEVuZExvY2F0aW9uIDwgYXV0b21hdGljUmVwbGFjZW1lbnRFbmRMb2NhdGlvbgog ICAgICAgICAgICAgICAgIHx8IChyZXN1bHRUeXBlICE9IFRleHRDaGVja2luZ1R5cGU6OlJlcGxh Y2VtZW50ICYmIHJlc3VsdFR5cGUgIT0gVGV4dENoZWNraW5nVHlwZTo6Q29ycmVjdGlvbikpKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0Q2hlY2tpbmdIZWxwZXIuY3BwCmluZGV4IDZj ZTZhYjc4ZDZiMDhlZTI3NzVhNDgwMTY3YTlhYjZlZTlhNzgzZWIuLmUyMzgyYmViMDE3OTg1NGMy YTUyMzhiM2QzNzBiOTRhNWU1MDU3ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvVGV4dENoZWNraW5nSGVscGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Rl eHRDaGVja2luZ0hlbHBlci5jcHAKQEAgLTM0Myw3ICszNDMsNiBAQCBhdXRvIFRleHRDaGVja2lu Z0hlbHBlcjo6ZmluZEZpcnN0TWlzc3BlbGxlZFdvcmRPclVuZ3JhbW1hdGljYWxQaHJhc2UoYm9v bCBjaGVjawogICAgICAgICAgICAgICAgIGZvciAoYXV0byYgcmVzdWx0IDogcmVzdWx0cykgewog ICAgICAgICAgICAgICAgICAgICBpZiAocmVzdWx0LnR5cGUgPT0gVGV4dENoZWNraW5nVHlwZTo6 U3BlbGxpbmcgJiYgcmVzdWx0LnJhbmdlLmxvY2F0aW9uID49IGN1cnJlbnRTdGFydE9mZnNldCAm JiByZXN1bHQucmFuZ2UubG9jYXRpb24gKyByZXN1bHQucmFuZ2UubGVuZ3RoIDw9IGN1cnJlbnRF bmRPZmZzZXQpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VSVChyZXN1bHQucmFuZ2Uu bGVuZ3RoID4gMCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBBU1NFUlQocmVzdWx0LnJhbmdl LmxvY2F0aW9uID49IDApOwogICAgICAgICAgICAgICAgICAgICAgICAgc3BlbGxpbmdMb2NhdGlv biA9IHJlc3VsdC5yYW5nZS5sb2NhdGlvbjsKICAgICAgICAgICAgICAgICAgICAgICAgIG1pc3Nw ZWxsZWRXb3JkID0gcGFyYWdyYXBoU3RyaW5nLnN1YnN0cmluZyhyZXN1bHQucmFuZ2UubG9jYXRp b24sIHJlc3VsdC5yYW5nZS5sZW5ndGgpOwogICAgICAgICAgICAgICAgICAgICAgICAgQVNTRVJU KG1pc3NwZWxsZWRXb3JkLmxlbmd0aCgpKTsKQEAgLTM1MSw3ICszNTAsNiBAQCBhdXRvIFRleHRD aGVja2luZ0hlbHBlcjo6ZmluZEZpcnN0TWlzc3BlbGxlZFdvcmRPclVuZ3JhbW1hdGljYWxQaHJh c2UoYm9vbCBjaGVjawogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgICAg IGlmIChjaGVja0dyYW1tYXIgJiYgcmVzdWx0LnR5cGUgPT0gVGV4dENoZWNraW5nVHlwZTo6R3Jh bW1hciAmJiByZXN1bHQucmFuZ2UubG9jYXRpb24gPCBjdXJyZW50RW5kT2Zmc2V0ICYmIHJlc3Vs dC5yYW5nZS5sb2NhdGlvbiArIHJlc3VsdC5yYW5nZS5sZW5ndGggPiBjdXJyZW50U3RhcnRPZmZz ZXQpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIEFTU0VSVChyZXN1bHQucmFuZ2UubGVuZ3Ro ID4gMCk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBBU1NFUlQocmVzdWx0LnJhbmdlLmxvY2F0 aW9uID49IDApOwogICAgICAgICAgICAgICAgICAgICAgICAgLy8gV2UgY2FuJ3Qgc3RvcCBhZnRl ciB0aGUgZmlyc3QgZ3JhbW1hciByZXN1bHQsIHNpbmNlIHRoZXJlIG1pZ2h0IHN0aWxsIGJlIGEg c3BlbGxpbmcgcmVzdWx0IGFmdGVyCiAgICAgICAgICAgICAgICAgICAgICAgICAvLyBpdCBiZWdp bnMgYnV0IGJlZm9yZSB0aGUgZmlyc3QgZGV0YWlsIGluIGl0LCBidXQgd2UgY2FuIHN0b3AgaWYg d2UgZmluZCBhIHNlY29uZCBncmFtbWFyIHJlc3VsdC4KICAgICAgICAgICAgICAgICAgICAgICAg IGlmIChmb3VuZEdyYW1tYXIpCkBAIC0zNTksNyArMzU3LDYgQEAgYXV0byBUZXh0Q2hlY2tpbmdI ZWxwZXI6OmZpbmRGaXJzdE1pc3NwZWxsZWRXb3JkT3JVbmdyYW1tYXRpY2FsUGhyYXNlKGJvb2wg Y2hlY2sKICAgICAgICAgICAgICAgICAgICAgICAgIGZvciAodW5zaWduZWQgaiA9IDA7IGogPCBy ZXN1bHQuZGV0YWlscy5zaXplKCk7IGorKykgewogICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IEdyYW1tYXJEZXRhaWwqIGRldGFpbCA9ICZyZXN1bHQuZGV0YWlsc1tqXTsKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBBU1NFUlQoZGV0YWlsLT5yYW5nZS5sZW5ndGggPiAwKTsK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICBBU1NFUlQoZGV0YWlsLT5yYW5nZS5sb2NhdGlv biA+PSAwKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAocmVzdWx0LnJhbmdlLmxv Y2F0aW9uICsgZGV0YWlsLT5yYW5nZS5sb2NhdGlvbiA+PSBjdXJyZW50U3RhcnRPZmZzZXQgJiYg cmVzdWx0LnJhbmdlLmxvY2F0aW9uICsgZGV0YWlsLT5yYW5nZS5sb2NhdGlvbiArIGRldGFpbC0+ cmFuZ2UubGVuZ3RoIDw9IGN1cnJlbnRFbmRPZmZzZXQgJiYgKCFmb3VuZEdyYW1tYXIgfHwgcmVz dWx0LnJhbmdlLmxvY2F0aW9uICsgZGV0YWlsLT5yYW5nZS5sb2NhdGlvbiA8IGdyYW1tYXJEZXRh aWxMb2NhdGlvbikpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3JhbW1hckRl dGFpbEluZGV4ID0gajsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ3JhbW1hckRl dGFpbExvY2F0aW9uID0gcmVzdWx0LnJhbmdlLmxvY2F0aW9uICsgZGV0YWlsLT5yYW5nZS5sb2Nh dGlvbjsKQEAgLTQyMiw3ICs0MTksNiBAQCBpbnQgVGV4dENoZWNraW5nSGVscGVyOjpmaW5kVW5n cmFtbWF0aWNhbFBocmFzZXMoT3BlcmF0aW9uIG9wZXJhdGlvbiwgY29uc3QgVmVjdAogICAgIGZv ciAodW5zaWduZWQgaSA9IDA7IGkgPCBncmFtbWFyRGV0YWlscy5zaXplKCk7IGkrKykgewogICAg ICAgICBjb25zdCBHcmFtbWFyRGV0YWlsKiBkZXRhaWwgPSAmZ3JhbW1hckRldGFpbHNbaV07CiAg ICAgICAgIEFTU0VSVChkZXRhaWwtPnJhbmdlLmxlbmd0aCA+IDApOwotICAgICAgICBBU1NFUlQo ZGV0YWlsLT5yYW5nZS5sb2NhdGlvbiA+PSAwKTsKICAgICAgICAgCiAgICAgICAgIHVpbnQ2NF90 IGRldGFpbFN0YXJ0T2Zmc2V0SW5QYXJhZ3JhcGggPSBiYWRHcmFtbWFyUGhyYXNlTG9jYXRpb24g KyBkZXRhaWwtPnJhbmdlLmxvY2F0aW9uOwogICAgICAgICAKQEAgLTU0MSw3ICs1MzcsNiBAQCBU ZXh0Q2hlY2tpbmdHdWVzc2VzIFRleHRDaGVja2luZ0hlbHBlcjo6Z3Vlc3Nlc0Zvck1pc3NwZWxs ZWRXb3JkT3JVbmdyYW1tYXRpY2FsUAogICAgICAgICBpZiAocmVzdWx0LnR5cGUgPT0gVGV4dENo ZWNraW5nVHlwZTo6R3JhbW1hciAmJiBwYXJhZ3JhcGguaXNDaGVja2luZ1JhbmdlQ292ZXJlZEJ5 KHJlc3VsdC5yYW5nZSkpIHsKICAgICAgICAgICAgIGZvciAoYXV0byYgZGV0YWlsIDogcmVzdWx0 LmRldGFpbHMpIHsKICAgICAgICAgICAgICAgICBBU1NFUlQoZGV0YWlsLnJhbmdlLmxlbmd0aCA+ IDApOwotICAgICAgICAgICAgICAgIEFTU0VSVChkZXRhaWwucmFuZ2UubG9jYXRpb24gPj0gMCk7 CiAgICAgICAgICAgICAgICAgaWYgKHBhcmFncmFwaC5jaGVja2luZ1JhbmdlTWF0Y2hlcyh7IHJl c3VsdC5yYW5nZS5sb2NhdGlvbiArIGRldGFpbC5yYW5nZS5sb2NhdGlvbiwgZGV0YWlsLnJhbmdl Lmxlbmd0aCB9KSkgewogICAgICAgICAgICAgICAgICAgICBTdHJpbmcgYmFkR3JhbW1hclBocmFz ZSA9IHBhcmFncmFwaC50ZXh0KCkuc3Vic3RyaW5nKHJlc3VsdC5yYW5nZS5sb2NhdGlvbiwgcmVz dWx0LnJhbmdlLmxlbmd0aCkudG9TdHJpbmcoKTsKICAgICAgICAgICAgICAgICAgICAgQVNTRVJU KGJhZEdyYW1tYXJQaHJhc2UubGVuZ3RoKCkpOwo=