215221 2020-08-06 10:01:42 -0700 WeakPtr threading assertion on editing/undo-manager/undo-manager-delete-stale-undo-items.html 2020-08-06 17:00:34 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hector_i_lopez wenson_hsieh cdumez ddkilzer hi megan_gardner saam thorton webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh ysuzuki oldest_to_newest 1678276 0 hector_i_lopez 2020-08-06 10:01:42 -0700 editing/undo-manager/undo-manager-delete-stale-undo-items.html This test is a flaky crash on macOS Debug/gpuprocess and iOS wk2 Debug according to history. First occurrence of a crash on iOS is at r262052. The first occurrence of a crash on macOS is at r259705. History: https://results.webkit.org/?suite=layout-tests&test=editing%2Fundo-manager%2Fundo-manager-delete-stale-undo-items.html&limit=50000&platform=ios&platform=mac&style=debug Crash Log: https://build.webkit.org/results/Apple%20iPadOS%2013%20Simulator%20Debug%20WK2%20(Tests)/r265322%20(3046)/editing/undo-manager/undo-manager-delete-stale-undo-items-crash-log.txt Application Specific Information: CoreSimulator 704.12 - Device: Managed 4 (425092F4-AB17-487D-8C79-D022DCAE0881) - Runtime: iOS 13.4 (17E255) - DeviceType: iPad (5th generation) CRASHING TEST: editing/undo-manager/undo-manager-delete-stale-undo-items.html Thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00000002468ff882 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x0000000246961425 _pthread_cond_wait + 698 2 com.apple.JavaScriptCore 0x000000024dc2cd00 WTF::ThreadCondition::wait(WTF::Mutex&) + 48 (ThreadingPOSIX.cpp:518) 3 com.apple.JavaScriptCore 0x000000024dc2cdf5 WTF::ThreadCondition::timedWait(WTF::Mutex&, WTF::WallTime) + 133 (ThreadingPOSIX.cpp:529) 4 com.apple.JavaScriptCore 0x000000024dbc95fb WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 427 (ParkingLot.cpp:602) 5 com.apple.JavaScriptCore 0x000000024db51900 WTF::ParkingLot::ParkResult WTF::ParkingLot::parkConditionally<bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&)::'lambda'(), bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&)::'lambda0'()>(void const*, WTF::Lock const&, bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&)::'lambda0'() const&, WTF::TimeWithDynamicClockType const&) + 96 (ParkingLot.h:82) 6 com.apple.JavaScriptCore 0x000000024db5180c bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 140 (Condition.h:76) 1678277 1 webkit-bug-importer 2020-08-06 10:02:05 -0700 <rdar://problem/66632111> 1678291 2 ap 2020-08-06 10:33:45 -0700 It's a different thread crashing: Thread 11 Crashed:: Heap Helper Thread 0 com.apple.JavaScriptCore 0x000000024db3cb8e WTFCrash + 14 (Assertions.cpp:295) 1 com.apple.WebCore 0x000000025532237b WTFCrashWithInfo(int, char const*, char const*, int) + 27 2 com.apple.WebCore 0x0000000258be6939 WTF::WeakPtr<WebCore::UndoManager, WTF::EmptyCounter>::operator->() const + 153 (WeakPtr.h:107) 3 com.apple.WebCore 0x0000000258be6883 WebCore::UndoItem::document() const + 67 (UndoItem.cpp:64) 4 com.apple.WebCore 0x000000025769ddaf WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void*, JSC::SlotVisitor&, char const**) + 111 (JSUndoItemCustom.cpp:43) 5 com.apple.JavaScriptCore 0x000000024edeb238 void JSC::WeakBlock::specializedVisit<JSC::PreciseAllocation>(JSC::PreciseAllocation&, JSC::SlotVisitor&) + 360 (WeakBlock.cpp:125) 6 com.apple.JavaScriptCore 0x000000024edeb072 JSC::WeakBlock::visit(JSC::SlotVisitor&) + 194 (WeakBlock.cpp:147) 7 com.apple.JavaScriptCore 0x000000024edd306e JSC::WeakSet::visit(JSC::SlotVisitor&) + 62 (WeakSet.h:117) 8 com.apple.JavaScriptCore 0x000000024edd3020 JSC::MarkedSpace::visitWeakSets(JSC::SlotVisitor&)::$_10::operator()(JSC::WeakSet*) const + 32 (MarkedSpace.cpp:279) 9 com.apple.JavaScriptCore 0x000000024edc340f void WTF::SentinelLinkedList<JSC::WeakSet, WTF::BasicRawSentinelNode<JSC::WeakSet, WTF::DumbPtrTraits<JSC::WeakSet> > >::forEach<JSC::MarkedSpace::visitWeakSets(JSC::SlotVisitor&)::$_10>(JSC::MarkedSpace::visitWeakSets(JSC::SlotVisitor&)::$_10 const&) + 95 (SentinelLinkedList.h:108) 10 com.apple.JavaScriptCore 0x000000024edc3356 JSC::MarkedSpace::visitWeakSets(JSC::SlotVisitor&) + 54 (MarkedSpace.cpp:281) 11 com.apple.JavaScriptCore 0x000000024ed7b643 JSC::Heap::addCoreConstraints()::$_35::operator()(JSC::SlotVisitor&) const + 67 (Heap.cpp:2805) 12 com.apple.JavaScriptCore 0x000000024ed7b5d3 WTF::Detail::CallableWrapper<JSC::Heap::addCoreConstraints()::$_35, void, JSC::SlotVisitor&>::call(JSC::SlotVisitor&) + 51 (Function.h:52) 13 com.apple.JavaScriptCore 0x000000024eddcb0a WTF::Function<void (JSC::SlotVisitor&)>::operator()(JSC::SlotVisitor&) const + 154 (Function.h:83) 1678432 3 406122 wenson_hsieh 2020-08-06 15:27:03 -0700 Created attachment 406122 Patch 1678437 4 406122 hi 2020-08-06 15:37:44 -0700 Comment on attachment 406122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406122&action=review r=me > Source/WebCore/page/UndoItem.cpp:44 > + if (undoManager) NIT: perhaps use a ternary `m_document = undoManager ? makeWeakPtr(undoManager->document()) : { };`? > Source/WebCore/page/UndoItem.cpp:55 > + m_undoManager = nullptr; > + m_document = nullptr; I wonder if there's any significant difference/preference between ` = nullptr` or `.clear()` 🤔 1678440 5 wenson_hsieh 2020-08-06 15:42:07 -0700 Thanks for the review! (In reply to Devin Rousso from comment #4) > Comment on attachment 406122 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406122&action=review > > r=me > > > Source/WebCore/page/UndoItem.cpp:44 > > + if (undoManager) > > NIT: perhaps use a ternary `m_document = undoManager ? > makeWeakPtr(undoManager->document()) : { };`? I wanted to do that originally, but it leads to: ./page/UndoItem.cpp:44:69: error: initializer list cannot be used on the right hand side of operator ':' m_document = undoManager ? makeWeakPtr(undoManager->document()) : { }; I suppose I could make it something like this instead: m_document = undoManager ? makeWeakPtr(undoManager->document()) : WeakPtr<Document> { }; > > > Source/WebCore/page/UndoItem.cpp:55 > > + m_undoManager = nullptr; > > + m_document = nullptr; > > I wonder if there's any significant difference/preference between ` = > nullptr` or `.clear()` 🤔 Now that I think about it, *maybe* ::clear() is a tiny bit more performant? (since it just destroys the inner m_impl instead of having to create a new WeakPtr). I’ll change this to clear(). 1678448 6 406127 wenson_hsieh 2020-08-06 16:10:41 -0700 Created attachment 406127 Patch for landing 1678468 7 ews-feeder 2020-08-06 17:00:34 -0700 Committed r265354: <https://trac.webkit.org/changeset/265354> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406127. 406122 2020-08-06 15:27:03 -0700 2020-08-06 15:37:44 -0700 Patch bug-215221-20200806152702.patch text/plain 2794 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNmYTIzM2UzODE1M2Uw ZjI4ZWJmZDBlMTBhMDFkOTg3ZmFjY2M4NS4uNzJlY2I4YTdlNWMzYzVjOTRmZjI2MWU2YjVlMGNk NzJkNGQ4YzA5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA4LTA2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFdlYWtQdHIgdGhy ZWFkaW5nIGFzc2VydGlvbiBvbiBlZGl0aW5nL3VuZG8tbWFuYWdlci91bmRvLW1hbmFnZXItZGVs ZXRlLXN0YWxlLXVuZG8taXRlbXMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE1MjIxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NjYzMjEx MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWZh Y3RvcnMgYFVuZG9JdGVtYCB0byBhdm9pZCBkZXJlZmVyZW5jaW5nIGl0cyBgbV91bmRvTWFuYWdl cmAgdW5kZXJuZWF0aCBgVW5kb0l0ZW06OmRvY3VtZW50YCwgd2hpY2ggaXMKKyAgICAgICAgY29u c3VsdGVkIHdoZW4gY29tcHV0aW5nIGl0cyBKUyB3cmFwcGVyJ3Mgb3BhcXVlIHJvb3RzLiBJbnN0 ZWFkIG9mIGdvaW5nIHRocm91Z2ggYG1fdW5kb01hbmFnZXJgIHRvIGdyYWIgdGhlCisgICAgICAg IGRvY3VtZW50LCBzdG9yZSBhIGBXZWFrUHRyYCB0byB0aGUgYERvY3VtZW50YCB1cG9uIHNldHRp bmcgdGhlIGBVbmRvTWFuYWdlcmAgYW5kIHJldHVybiBpdHMgcG9pbnRlciB2YWx1ZQorICAgICAg ICBkaXJlY3RseSBpbiBgZG9jdW1lbnQoKWAuCisKKyAgICAgICAgKiBwYWdlL1VuZG9JdGVtLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlVuZG9JdGVtOjpzZXRVbmRvTWFuYWdlcik6CisgICAgICAg IChXZWJDb3JlOjpVbmRvSXRlbTo6aW52YWxpZGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpVbmRv SXRlbTo6ZG9jdW1lbnQgY29uc3QpOgorICAgICAgICAqIHBhZ2UvVW5kb0l0ZW0uaDoKKwogMjAy MC0wOC0wNiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdU Rjo6bWFrZVN0cmluZygpIHNob3VsZCBoYW5kbGUgZW51bSB2YWx1ZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvVW5kb0l0ZW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9VbmRv SXRlbS5jcHAKaW5kZXggZTAzZjFmMGU2MGRjNjY3OTIwMWRjZDJmMjA3MWVlZjhmMGQ1MjVkNC4u NWNhMGU4MDJlYzJhZGUxZjQ5Y2YzYmU5YjBlZmRjMzJhMjYyNTBhZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9VbmRvSXRlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9V bmRvSXRlbS5jcHAKQEAgLTQxLDE0ICs0MSwxOCBAQCBVbmRvTWFuYWdlciogVW5kb0l0ZW06OnVu ZG9NYW5hZ2VyKCkgY29uc3QKIHZvaWQgVW5kb0l0ZW06OnNldFVuZG9NYW5hZ2VyKFVuZG9NYW5h Z2VyKiB1bmRvTWFuYWdlcikKIHsKICAgICBtX3VuZG9NYW5hZ2VyID0gbWFrZVdlYWtQdHIodW5k b01hbmFnZXIpOworICAgIGlmICh1bmRvTWFuYWdlcikKKyAgICAgICAgbV9kb2N1bWVudCA9IG1h a2VXZWFrUHRyKHVuZG9NYW5hZ2VyLT5kb2N1bWVudCgpKTsKKyAgICBlbHNlCisgICAgICAgIG1f ZG9jdW1lbnQgPSB7IH07CiB9CiAKIHZvaWQgVW5kb0l0ZW06OmludmFsaWRhdGUoKQogewotICAg IGlmIChhdXRvKiB1bmRvTWFuYWdlciA9IG1fdW5kb01hbmFnZXIuZ2V0KCkpIHsKKyAgICBpZiAo YXV0byogdW5kb01hbmFnZXIgPSBtX3VuZG9NYW5hZ2VyLmdldCgpKQogICAgICAgICB1bmRvTWFu YWdlci0+cmVtb3ZlSXRlbSgqdGhpcyk7Ci0gICAgICAgIG1fdW5kb01hbmFnZXIgPSBudWxscHRy OwotICAgIH0KKyAgICBtX3VuZG9NYW5hZ2VyID0gbnVsbHB0cjsKKyAgICBtX2RvY3VtZW50ID0g bnVsbHB0cjsKIH0KIAogYm9vbCBVbmRvSXRlbTo6aXNWYWxpZCgpIGNvbnN0CkBAIC01OCwxMCAr NjIsNyBAQCBib29sIFVuZG9JdGVtOjppc1ZhbGlkKCkgY29uc3QKIAogRG9jdW1lbnQqIFVuZG9J dGVtOjpkb2N1bWVudCgpIGNvbnN0CiB7Ci0gICAgaWYgKCFpc1ZhbGlkKCkpCi0gICAgICAgIHJl dHVybiBudWxscHRyOwotCi0gICAgcmV0dXJuICZtX3VuZG9NYW5hZ2VyLT5kb2N1bWVudCgpOwor ICAgIHJldHVybiBtX2RvY3VtZW50LmdldCgpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1VuZG9JdGVtLmggYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1VuZG9JdGVtLmgKaW5kZXggMzg2ZDQ3NmExZGRkMTM1ODQ4NjQzZmFkM2I4N2Ex NDA4MTE4Yjc4NC4uYjM1MTg4NTRkNzY1ZmNkODgxYWU2ODgwZTc5YzY5OTNmMWY5MjZkMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9VbmRvSXRlbS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvVW5kb0l0ZW0uaApAQCAtNzQsNiArNzQsNyBAQCBwcml2YXRlOgogICAgIFJlZjxW b2lkQ2FsbGJhY2s+IG1fdW5kb0hhbmRsZXI7CiAgICAgUmVmPFZvaWRDYWxsYmFjaz4gbV9yZWRv SGFuZGxlcjsKICAgICBXZWFrUHRyPFVuZG9NYW5hZ2VyPiBtX3VuZG9NYW5hZ2VyOworICAgIFdl YWtQdHI8RG9jdW1lbnQ+IG1fZG9jdW1lbnQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl Cg== 406127 2020-08-06 16:10:41 -0700 2020-08-06 17:00:34 -0700 Patch for landing bug-215221-20200806161040.patch text/plain 2767 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNmYTIzM2UzODE1M2Uw ZjI4ZWJmZDBlMTBhMDFkOTg3ZmFjY2M4NS4uZTNiOTlkODUyYWYwNGYxMGJmMGNkNjk3Y2UwM2E1 ZDEyZTc3MDQ5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA4LTA2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFdlYWtQdHIgdGhy ZWFkaW5nIGFzc2VydGlvbiBvbiBlZGl0aW5nL3VuZG8tbWFuYWdlci91bmRvLW1hbmFnZXItZGVs ZXRlLXN0YWxlLXVuZG8taXRlbXMuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE1MjIxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NjYzMjEx MT4KKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBSb3Vzc28uCisKKyAgICAgICAgUmVmYWN0 b3JzIGBVbmRvSXRlbWAgdG8gYXZvaWQgZGVyZWZlcmVuY2luZyBpdHMgYG1fdW5kb01hbmFnZXJg IHVuZGVybmVhdGggYFVuZG9JdGVtOjpkb2N1bWVudGAsIHdoaWNoIGlzCisgICAgICAgIGNvbnN1 bHRlZCB3aGVuIGNvbXB1dGluZyBpdHMgSlMgd3JhcHBlcidzIG9wYXF1ZSByb290cy4gSW5zdGVh ZCBvZiBnb2luZyB0aHJvdWdoIGBtX3VuZG9NYW5hZ2VyYCB0byBncmFiIHRoZQorICAgICAgICBk b2N1bWVudCwgc3RvcmUgYSBgV2Vha1B0cmAgdG8gdGhlIGBEb2N1bWVudGAgdXBvbiBzZXR0aW5n IHRoZSBgVW5kb01hbmFnZXJgIGFuZCByZXR1cm4gaXRzIHBvaW50ZXIgdmFsdWUKKyAgICAgICAg ZGlyZWN0bHkgaW4gYGRvY3VtZW50KClgLgorCisgICAgICAgICogcGFnZS9VbmRvSXRlbS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpVbmRvSXRlbTo6c2V0VW5kb01hbmFnZXIpOgorICAgICAgICAo V2ViQ29yZTo6VW5kb0l0ZW06OmludmFsaWRhdGUpOgorICAgICAgICAoV2ViQ29yZTo6VW5kb0l0 ZW06OmRvY3VtZW50IGNvbnN0KToKKyAgICAgICAgKiBwYWdlL1VuZG9JdGVtLmg6CisKIDIwMjAt MDgtMDYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBXVEY6 Om1ha2VTdHJpbmcoKSBzaG91bGQgaGFuZGxlIGVudW0gdmFsdWVzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1VuZG9JdGVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVW5kb0l0 ZW0uY3BwCmluZGV4IGUwM2YxZjBlNjBkYzY2NzkyMDFkY2QyZjIwNzFlZWY4ZjBkNTI1ZDQuLjVl ZmRlODcxMDA1NTBkYTRkMGQzZTNjMDdiZmQ1MGJlMDJjMTNiY2QgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvVW5kb0l0ZW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVW5k b0l0ZW0uY3BwCkBAIC00MSwxNCArNDEsMTUgQEAgVW5kb01hbmFnZXIqIFVuZG9JdGVtOjp1bmRv TWFuYWdlcigpIGNvbnN0CiB2b2lkIFVuZG9JdGVtOjpzZXRVbmRvTWFuYWdlcihVbmRvTWFuYWdl ciogdW5kb01hbmFnZXIpCiB7CiAgICAgbV91bmRvTWFuYWdlciA9IG1ha2VXZWFrUHRyKHVuZG9N YW5hZ2VyKTsKKyAgICBtX2RvY3VtZW50ID0gbWFrZVdlYWtQdHIodW5kb01hbmFnZXIgPyAmdW5k b01hbmFnZXItPmRvY3VtZW50KCkgOiBudWxscHRyKTsKIH0KIAogdm9pZCBVbmRvSXRlbTo6aW52 YWxpZGF0ZSgpCiB7Ci0gICAgaWYgKGF1dG8qIHVuZG9NYW5hZ2VyID0gbV91bmRvTWFuYWdlci5n ZXQoKSkgewotICAgICAgICB1bmRvTWFuYWdlci0+cmVtb3ZlSXRlbSgqdGhpcyk7Ci0gICAgICAg IG1fdW5kb01hbmFnZXIgPSBudWxscHRyOwotICAgIH0KKyAgICBpZiAobV91bmRvTWFuYWdlcikK KyAgICAgICAgbV91bmRvTWFuYWdlci0+cmVtb3ZlSXRlbSgqdGhpcyk7CisgICAgbV91bmRvTWFu YWdlci5jbGVhcigpOworICAgIG1fZG9jdW1lbnQuY2xlYXIoKTsKIH0KIAogYm9vbCBVbmRvSXRl bTo6aXNWYWxpZCgpIGNvbnN0CkBAIC01OCwxMCArNTksNyBAQCBib29sIFVuZG9JdGVtOjppc1Zh bGlkKCkgY29uc3QKIAogRG9jdW1lbnQqIFVuZG9JdGVtOjpkb2N1bWVudCgpIGNvbnN0CiB7Ci0g ICAgaWYgKCFpc1ZhbGlkKCkpCi0gICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgcmV0dXJu ICZtX3VuZG9NYW5hZ2VyLT5kb2N1bWVudCgpOworICAgIHJldHVybiBtX2RvY3VtZW50LmdldCgp OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1VuZG9JdGVtLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1VuZG9JdGVtLmgKaW5kZXgg Mzg2ZDQ3NmExZGRkMTM1ODQ4NjQzZmFkM2I4N2ExNDA4MTE4Yjc4NC4uYjM1MTg4NTRkNzY1ZmNk ODgxYWU2ODgwZTc5YzY5OTNmMWY5MjZkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9VbmRvSXRlbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVW5kb0l0ZW0uaApAQCAtNzQs NiArNzQsNyBAQCBwcml2YXRlOgogICAgIFJlZjxWb2lkQ2FsbGJhY2s+IG1fdW5kb0hhbmRsZXI7 CiAgICAgUmVmPFZvaWRDYWxsYmFjaz4gbV9yZWRvSGFuZGxlcjsKICAgICBXZWFrUHRyPFVuZG9N YW5hZ2VyPiBtX3VuZG9NYW5hZ2VyOworICAgIFdlYWtQdHI8RG9jdW1lbnQ+IG1fZG9jdW1lbnQ7 CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==