215212 2020-08-06 04:37:08 -0700 [WPE][GTK] Wrong argument order for clone syscall seccomp filter on s390x 2020-08-06 07:48:14 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto aperez aperez bugs-noreply cgarcia mcatanzaro pgriffis oldest_to_newest 1678230 0 berto 2020-08-06 04:37:08 -0700 It seems that the order of the arguments in the clone() syscall depends on the architecture (you can see that in the clone(2) manpage). We use that in WebKit's seccomp filter (glib/BubblewrapLauncher.cpp), and this is broken in s390x at least. Flatpak is also affected, and we are using the same code. Here's the fix for Flatpak: https://github.com/flatpak/flatpak/pull/3777/commits/6d70aabc03f0389e548911b14446d702a07b016c 1678231 1 berto 2020-08-06 04:47:10 -0700 (note: this **seems to be broken** in WebKit based on the fact that it is broken in Flatpak and we took that code, but it should be double checked) 1678232 2 aperez 2020-08-06 04:51:30 -0700 (In reply to Alberto Garcia from comment #0) > It seems that the order of the arguments in the clone() syscall depends on > the architecture (you can see that in the clone(2) manpage). > > We use that in WebKit's seccomp filter (glib/BubblewrapLauncher.cpp), and > this is broken in s390x at least. > > Flatpak is also affected, and we are using the same code. Here's the fix for > Flatpak: > https://github.com/flatpak/flatpak/pull/3777/commits/ > 6d70aabc03f0389e548911b14446d702a07b016c (CC'ing Patrick, as he's our resident sandboxing expert.) Yes, we also need a similar fix in the WebKit sandboxing code. One would imagine that libseccomp takes care of this kind of busy-work… but it turns out that it's a pretty dumb wrapper around the kernel interface 🤷️ 1678233 3 406081 aperez 2020-08-06 04:59:21 -0700 Created attachment 406081 Patch 1678238 4 406081 mcatanzaro 2020-08-06 06:39:35 -0700 Comment on attachment 406081 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406081&action=review > Source/WebKit/ChangeLog:3 > + [GLIB] Wrong argument order for clone syscall seccomp filter on s390x [WPE][GTK] 1678242 5 406083 aperez 2020-08-06 07:03:17 -0700 Created attachment 406083 Patch for landing 1678248 6 ews-feeder 2020-08-06 07:48:13 -0700 Committed r265326: <https://trac.webkit.org/changeset/265326> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406083. 406081 2020-08-06 04:59:21 -0700 2020-08-06 07:03:13 -0700 Patch bug-215212-20200806145920.patch text/plain 2097 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM5MGUwNTFmYWE5OTU0NzVj YTU0ZjEwYzAzYTkzMTk1ZjMyZDFjZTMuLmM5ZjVmZDYyYjA0MGY1MWMwMmVmNTU1ZWVmMGM2OTdj Zjc0NmY2YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDgtMDYgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gV3Jv bmcgYXJndW1lbnQgb3JkZXIgZm9yIGNsb25lIHN5c2NhbGwgc2VjY29tcCBmaWx0ZXIgb24gczM5 MHgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTIx MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBhdGNo IGJhc2VkIG9uIHRoaXMgRmxhdHBhayBjb21taXQ6CisgICAgICAgIGh0dHBzOi8vZ2l0aHViLmNv bS9mbGF0cGFrL2ZsYXRwYWsvcHVsbC8zNzc3L2NvbW1pdHMvNmQ3MGFhYmMwM2YwMzg5ZTU0ODkx MWIxNDQ0NmQ3MDJhMDdiMDE2YworCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOgor ICAgICAgICAoV2ViS2l0OjpzZXR1cFNlY2NvbXApOiBBZGQgcHJlcHJvY2Vzc29yIGd1YXJkIHRv IGNob29zZSB0aGUgY29ycmVjdAorICAgICAgICBjbG9uZSgpIHN5c3RlbSBjYWxsIGFyZ3VtZW50 IG9uIFMzOTAuCisKIDIwMjAtMDgtMDYgIEphbWVzIFNhdmFnZSAgPGphbWVzLnNhdmFnZUBhcHBs ZS5jb20+CiAKICAgICAgICAgQ291bGQgbm90IGZpbmQgbW9kdWxlICdXZWJLaXQnIGZvciB0YXJn ZXQgJ2FybXY3LWFwcGxlLWlvcycKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcAppbmRleCBhYjNhMTBk ZWNhMjc4M2ZmMjRhY2JiN2NlZGJmODdiZDcwMDQ3YzFiLi4yMTNhOWMxYTExNGIxN2FkNGViNmJi NzNjN2NmMzFiNjY4MzMzOTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9M YXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwCkBAIC01OTgsNyAr NTk4LDE2IEBAIHN0YXRpYyBpbnQgc2V0dXBTZWNjb21wKCkKICAgICAvLyAgICBpbiBjb21tb24v ZmxhdHBhay1ydW4uYwogICAgIC8vICBodHRwczovL2dpdC5nbm9tZS5vcmcvYnJvd3NlL2xpbnV4 LXVzZXItY2hyb290CiAgICAgLy8gICAgaW4gc3JjL3NldHVwLXNlY2NvbXAuYworCisjaWYgZGVm aW5lZChfX3MzOTBfXykgfHwgZGVmaW5lZChfX3MzOTB4X18pIHx8IGRlZmluZWQoX19DUklTX18p CisgICAgLy8gQXJjaGl0ZWN0dXJlcyB3aXRoIENPTkZJR19DTE9ORV9CQUNLV0FSRFMyOiB0aGUg Y2hpbGQgc3RhY2sKKyAgICAvLyBhbmQgZmxhZ3MgYXJndW1lbnRzIGFyZSByZXZlcnNlZCBzbyB0 aGUgZmxhZ3MgY29tZSBzZWNvbmQuCisgICAgc3RydWN0IHNjbXBfYXJnX2NtcCBjbG9uZUFyZyA9 IFNDTVBfQTEoU0NNUF9DTVBfTUFTS0VEX0VRLCBDTE9ORV9ORVdVU0VSLCBDTE9ORV9ORVdVU0VS KTsKKyNlbHNlCisgICAgLy8gTm9ybWFsbHkgdGhlIGZsYWdzIGNvbWUgZmlyc3QuCiAgICAgc3Ry dWN0IHNjbXBfYXJnX2NtcCBjbG9uZUFyZyA9IFNDTVBfQTAoU0NNUF9DTVBfTUFTS0VEX0VRLCBD TE9ORV9ORVdVU0VSLCBDTE9ORV9ORVdVU0VSKTsKKyNlbmRpZgorCiAgICAgc3RydWN0IHNjbXBf YXJnX2NtcCB0dHlBcmcgPSBTQ01QX0ExKFNDTVBfQ01QX01BU0tFRF9FUSwgMHhGRkZGRkZGRnUs IFRJT0NTVEkpOwogICAgIHN0cnVjdCB7CiAgICAgICAgIGludCBzY2FsbDsK 406083 2020-08-06 07:03:17 -0700 2020-08-06 07:48:14 -0700 Patch for landing bug-215212-20200806170316.patch text/plain 2061 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM5MGUwNTFmYWE5OTU0NzVj YTU0ZjEwYzAzYTkzMTk1ZjMyZDFjZTMuLmEyZWNjNTFiNTY3YzM4OTZjMDNlZDgxYmIzMjk3OTU2 YjJiMTU3MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDgtMDYgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtd IFdyb25nIGFyZ3VtZW50IG9yZGVyIGZvciBjbG9uZSBzeXNjYWxsIHNlY2NvbXAgZmlsdGVyIG9u IHMzOTB4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTUyMTIKKworICAgICAgICBSZXZpZXdlZCBieSBNaWNoYWVsIENhdGFuemFyby4KKworICAgICAg ICBQYXRjaCBiYXNlZCBvbiB0aGlzIEZsYXRwYWsgcHVsbCByZXF1ZXN0OgorICAgICAgICBodHRw czovL2dpdGh1Yi5jb20vZmxhdHBhay9mbGF0cGFrL3B1bGwvMzc3NworCisgICAgICAgIE5vIG5l dyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJi bGV3cmFwTGF1bmNoZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpzZXR1cFNlY2NvbXApOiBBZGQg cHJlcHJvY2Vzc29yIGd1YXJkIHRvIGNob29zZSB0aGUgY29ycmVjdAorICAgICAgICBjbG9uZSgp IHN5c3RlbSBjYWxsIGFyZ3VtZW50IG9uIFMzOTAuCisKIDIwMjAtMDgtMDYgIEphbWVzIFNhdmFn ZSAgPGphbWVzLnNhdmFnZUBhcHBsZS5jb20+CiAKICAgICAgICAgQ291bGQgbm90IGZpbmQgbW9k dWxlICdXZWJLaXQnIGZvciB0YXJnZXQgJ2FybXY3LWFwcGxlLWlvcycKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5j aGVyLmNwcAppbmRleCBhYjNhMTBkZWNhMjc4M2ZmMjRhY2JiN2NlZGJmODdiZDcwMDQ3YzFiLi4y MTNhOWMxYTExNGIxN2FkNGViNmJiNzNjN2NmMzFiNjY4MzMzOTY5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1 bmNoZXIuY3BwCkBAIC01OTgsNyArNTk4LDE2IEBAIHN0YXRpYyBpbnQgc2V0dXBTZWNjb21wKCkK ICAgICAvLyAgICBpbiBjb21tb24vZmxhdHBhay1ydW4uYwogICAgIC8vICBodHRwczovL2dpdC5n bm9tZS5vcmcvYnJvd3NlL2xpbnV4LXVzZXItY2hyb290CiAgICAgLy8gICAgaW4gc3JjL3NldHVw LXNlY2NvbXAuYworCisjaWYgZGVmaW5lZChfX3MzOTBfXykgfHwgZGVmaW5lZChfX3MzOTB4X18p IHx8IGRlZmluZWQoX19DUklTX18pCisgICAgLy8gQXJjaGl0ZWN0dXJlcyB3aXRoIENPTkZJR19D TE9ORV9CQUNLV0FSRFMyOiB0aGUgY2hpbGQgc3RhY2sKKyAgICAvLyBhbmQgZmxhZ3MgYXJndW1l bnRzIGFyZSByZXZlcnNlZCBzbyB0aGUgZmxhZ3MgY29tZSBzZWNvbmQuCisgICAgc3RydWN0IHNj bXBfYXJnX2NtcCBjbG9uZUFyZyA9IFNDTVBfQTEoU0NNUF9DTVBfTUFTS0VEX0VRLCBDTE9ORV9O RVdVU0VSLCBDTE9ORV9ORVdVU0VSKTsKKyNlbHNlCisgICAgLy8gTm9ybWFsbHkgdGhlIGZsYWdz IGNvbWUgZmlyc3QuCiAgICAgc3RydWN0IHNjbXBfYXJnX2NtcCBjbG9uZUFyZyA9IFNDTVBfQTAo U0NNUF9DTVBfTUFTS0VEX0VRLCBDTE9ORV9ORVdVU0VSLCBDTE9ORV9ORVdVU0VSKTsKKyNlbmRp ZgorCiAgICAgc3RydWN0IHNjbXBfYXJnX2NtcCB0dHlBcmcgPSBTQ01QX0ExKFNDTVBfQ01QX01B U0tFRF9FUSwgMHhGRkZGRkZGRnUsIFRJT0NTVEkpOwogICAgIHN0cnVjdCB7CiAgICAgICAgIGlu dCBzY2FsbDsK