215191 2020-08-05 14:10:21 -0700 Document versions of C++ and Python 2020-08-18 15:54:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 darin darin ap fujii jbedard mcatanzaro mjs simon.fraser webkit-bug-importer oldest_to_newest 1678075 0 darin 2020-08-05 14:10:21 -0700 Document versions of C++ and Python 1678077 1 406037 darin 2020-08-05 14:10:46 -0700 Created attachment 406037 Patch 1678078 2 darin 2020-08-05 14:12:26 -0700 Very rough draft. Currently does not require that "webkit-patch" be compatible with Python 2. Does not clarify that all new scripts need to be compatible with Python 3. Does not include information about writing python3 on the shebang line to make sure we get it on Apple systems. May be incorrect in other major ways. Looking for comment or refinements. 1678118 3 406037 jbedard 2020-08-05 15:38:32 -0700 Comment on attachment 406037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review > Websites/webkit.org/languages.md:32 > +This includes scripts like `webkit-patch`. webkit-patch is an example of something that needs to be Python 2 compatible, otherwise we can't apply patches on machines without Python 3. `configure-xcode-for-embedded-development` and `lint-test-expectations` would be better examples 1678119 4 406037 darin 2020-08-05 15:42:00 -0700 Comment on attachment 406037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review >> Websites/webkit.org/languages.md:32 >> +This includes scripts like `webkit-patch`. > > webkit-patch is an example of something that needs to be Python 2 compatible, otherwise we can't apply patches on machines without Python 3. > > `configure-xcode-for-embedded-development` and `lint-test-expectations` would be better examples So humans can do that, or so computers can do it? If it’s for humans, can they install Python 3? 1678121 5 406037 jbedard 2020-08-05 15:52:46 -0700 Comment on attachment 406037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review >>> Websites/webkit.org/languages.md:32 >>> +This includes scripts like `webkit-patch`. >> >> webkit-patch is an example of something that needs to be Python 2 compatible, otherwise we can't apply patches on machines without Python 3. >> >> `configure-xcode-for-embedded-development` and `lint-test-expectations` would be better examples > > So humans can do that, or so computers can do it? > > If it’s for humans, can they install Python 3? I'm not aware of anywhere we have bots calling this script, since Aakash moved us to Buildbot for EWS. If we're going to let ourselves break webkit-patch for Mojave, then we need to document installing Python 3 for Mojave. I would say that if we're officially documenting things, webkit-patch should either be in the 'needs to support Python 2' list or not mentioned, because this is the one script involved in developing WebKit that I've actually used on a machine without Python 3 in the last 6 months. 1678197 6 ap 2020-08-05 22:03:13 -0700 webkit-patch is a weird beast, as it doesn’t have anything required by engineers for WebKit development, but many engineers rely on it. Otherwise, svn-apply and svn-create-patch are sufficient. 1678200 7 406037 mjs 2020-08-05 22:28:46 -0700 Comment on attachment 406037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406037&action=review > Websites/webkit.org/languages.md:1 > +### C++ Does this file need to start with a level header, or will whatever pulls it into WordPress add that? > Websites/webkit.org/languages.md:5 > +It’s C++17. Guessing that this is a curly single quote/apostrophe but the double quotes just above are straight quotes. Better to be consistent. (There's other apparent curly quotes lower in the file. > Websites/webkit.org/languages.md:21 > +Scripts used for building and testing WebKit Was this meant to be a level 4 header starting with ####? Seems strange as a paragraph instead of a section header. > Websites/webkit.org/languages.md:30 > +Scripts used for developing WebKit Likewise, should this be a section header? 1678201 8 fujii 2020-08-05 22:34:20 -0700 (In reply to Darin Adler from comment #4) > If it’s for humans, can they install Python 3? We had a discussion before. https://lists.webkit.org/pipermail/webkit-dev/2019-July/030750.html > Having to download and install anything else would be a significant additional step. > > — Darin 1678202 9 fujii 2020-08-05 22:35:09 -0700 WebKit has another GCC version policy. WebKitGTK/GCCRequirement – WebKit https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement 1679818 10 webkit-bug-importer 2020-08-12 14:11:17 -0700 <rdar://problem/66933118> 1681141 11 406798 darin 2020-08-18 12:06:18 -0700 Created attachment 406798 Patch 1681142 12 darin 2020-08-18 12:06:30 -0700 Uploaded a new draft, responding to most of the comments above. 1681152 13 406798 jbedard 2020-08-18 12:58:39 -0700 Comment on attachment 406798 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406798&action=review > Websites/webkit.org/languages.md:37 > +This includes scripts like `configure-xcode-for-embedded-development` and `lint-test-expectations`. Nit: Double spaces after "like" and "and", seems like a typo 1681158 14 darin 2020-08-18 13:07:16 -0700 Committed r265827: <https://trac.webkit.org/changeset/265827> 1681228 15 406798 simon.fraser 2020-08-18 15:54:45 -0700 Comment on attachment 406798 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406798&action=review > Websites/webkit.org/languages.md:30 > +environment for older Apple OS versions such as macOS Movaje. "macOS Movaje" 406037 2020-08-05 14:10:46 -0700 2020-08-18 12:06:17 -0700 Patch bug-215191-20200805141046.patch text/plain 2150 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MzAzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGIyZjNk NmQ2YWJlZDc4ZTMxZmQ4ZWIxZmMyMjliNTgwYWVhZmY5N2MuLjI3NTM3MjhmYjg0ODQxNmFjYjdi NzlkZTNjN2UwNjliYjM4MDViNDcgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMjAtMDgtMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAg IERvY3VtZW50IHZlcnNpb25zIG9mIEMrKyBhbmQgUHl0aG9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUxOTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxhbmd1YWdlcy5tZDogQWRkZWQuCisKIDIw MjAtMDgtMDUgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAgICAgIEVuaGFuY2Ug ZmVhdHVyZSBzdGF0dXMgcGFnZSBvcmlnaW4gZm9yIGZsZXhpYmxlIHRlc3QgZW52aXJvbm1lbnRz CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL2xhbmd1YWdlcy5tZCBiL1dlYnNpdGVz L3dlYmtpdC5vcmcvbGFuZ3VhZ2VzLm1kCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjczNzYxOTUzMDZlNTBiYjIwNDIz MjFjMTJlZjJiODQ5OTkwYjdhNDgKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJzaXRlcy93ZWJraXQu b3JnL2xhbmd1YWdlcy5tZApAQCAtMCwwICsxLDM1IEBACisjIyMgQysrCisKK01vc3QgV2ViS2l0 IGNvZGUgaXMgd3JpdHRlbiBpbiBDKysuIEJ1dCBhIHJlYXNvbmFibGUgcXVlc3Rpb24gaXMsICJX aGljaCB2ZXJzaW9uIEMrKyI/CisKK0l04oCZcyBDKysxNy4KK1dlIGV2ZW50dWFsbHkgcGxhbiB0 byBtb3ZlIGZvcndhcmQgdG8gQysrMjAgYW5kIGJleW9uZC4KK0JlZm9yZSB3ZSBkbyB0aGF0IHdl IG1ha2Ugc3VyZSB0aGF0IGNvbXBpbGVycyBhbmQgbGlicmFyaWVzCitvbiB0aGUgcGxhdGZvcm1z IHRoYXQgV2ViS2l0IGNvbnRyaWJ1dG9ycyBhcmUgd29ya2luZyBvbiBhcmUgcmVhZHkuCisKK1Ro ZSByZWxldmFudCBjb21waWxlcnMgYXJlIHZlcnNpb25zIG9mIGNsYW5nLCBnY2MsIGFuZCBWaXN1 YWwgU3R1ZGlvLgorCisjIyMgU2NyaXB0cworCitUaGUgcHJlZmVycmVkIGxhbmd1YWdlIGZvciBX ZWJLaXQgcHJvamVjdCBzY3JpcHRzIGlzIFB5dGhvbi4KK1dlIGhhdmUgbGVnYWN5IHNjcmlwdHMg aW4gUGVybCBhbmQgUnVieSwgYnV0IHdlIGFzayB0aGF0IG5ldyBzY3JpcHRzIGJlIGRvbmUgaW4g UHl0aG9uLgorCisjIyMgUHl0aG9uCisKK1NvbWUgV2ViS2l0IHNjcmlwdHMgYXJlIGluIFB5dGhv biAzLCBvdGhlcnMgaW4gUHl0aG9uIDIuIFdoYXTigJlzIHRoZSBwb2xpY3kgb24gdGhhdD8KKwor U2NyaXB0cyB1c2VkIGZvciBidWlsZGluZyBhbmQgdGVzdGluZyBXZWJLaXQKKworVGhpcyBpbmNs dWRlcyBzY3JpcHRzIGxpa2UgYHJ1bi13ZWJraXQtdGVzdHNgIGFuZCB4eHh4eHh4eC4KKworQWxs IG9mIHRoZXNlIHNjcmlwdHMgbXVzdCBiZSB3cml0dGVuIHNvIHRoYXQgdGhleSBhcmUgY29tcGF0 aWJsZSB3aXRoIGJvdGggUHl0aG9uIDIgYW5kIFB5dGhvbiAzLgorU29tZSBwb3J0cyBidWlsZCBv biBlbnZpcm9ubWVudHMgdGhhdCBoYXZlIG9ubHkgUHl0aG9uIDIsIGluY2x1ZGluZyB0aGUgaW50 ZXJuYWwgQXBwbGUgYnVpbGQKK2Vudmlyb25tZW50IGZvciBvbGRlciBBcHBsZSBPUyB2ZXJzaW9u cyBzdWNoIGFzIG1hY09TIE1vdmFqb2UuCitPdGhlciBwb3J0cyBidWlsZCBvbiBlbnZpcm9ubWVu dHMgdGhhdCBoYXZlIG9ubHkgUHl0aG9uIDMuCisKK1NjcmlwdHMgdXNlZCBmb3IgZGV2ZWxvcGlu ZyBXZWJLaXQKKworVGhpcyBpbmNsdWRlcyBzY3JpcHRzIGxpa2UgYHdlYmtpdC1wYXRjaGAuCisK K1RoZXNlIHNjcmlwdHMgbXVzdCBiZSBjb21wYXRpYmxlIHdpdGggUHl0aG9uIDMsCithbmQgZG8g bm90IG5lZWQgdG8gYmUgY29tcGF0aWJsZSB3aXRoIFB5dGhvbiAyLgo= 406798 2020-08-18 12:06:18 -0700 2020-08-18 12:58:39 -0700 Patch bug-215191-20200818120618.patch text/plain 2878 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODI2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGFkMDli YTI5NzQ4MDVhMGI5YzdiZDdiZjY2YmZiODhlMjk0YWYzNjguLjUyMjNlNGIwNzE3ZTAwODA3ZDkx MjUyYmQzZTQ4Y2ZhMmNlMTNiYzcgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMjAtMDgtMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAg IERvY3VtZW50IHZlcnNpb25zIG9mIEMrKyBhbmQgUHl0aG9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUxOTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxhbmd1YWdlcy5tZDogQWRkZWQuCisKIDIw MjAtMDgtMTIgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB1 bnVzZWQgc2VsZWN0b3IgcGVyZm9ybWFuY2UgdGVzdApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Vi a2l0Lm9yZy9sYW5ndWFnZXMubWQgYi9XZWJzaXRlcy93ZWJraXQub3JnL2xhbmd1YWdlcy5tZApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi43Zjg0NWI0MzM5ZmQxODljMTAzZGQ0NGViZDBlM2IxYjVhNDZjYjc1Ci0tLSAv ZGV2L251bGwKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9sYW5ndWFnZXMubWQKQEAgLTAsMCAr MSw0OSBAQAorIyBXZWJLaXQgcHJvZ3JhbW1pbmcgbGFuZ3VhZ2VzCisKKyMjIEMrKworCitNb3N0 IFdlYktpdCBjb2RlIGlzIHdyaXR0ZW4gaW4gQysrLiBCdXQgYSByZWFzb25hYmxlIHF1ZXN0aW9u IGlzLCDigJxXaGljaCB2ZXJzaW9uIEMrKz/igJ0KKworSXTigJlzIEMrKzE3LgorV2UgZXZlbnR1 YWxseSBwbGFuIHRvIG1vdmUgZm9yd2FyZCB0byBDKysyMCBhbmQgYmV5b25kLgorQmVmb3JlIHdl IGRvIHRoYXQgd2UgbWFrZSBzdXJlIHRoYXQgY29tcGlsZXJzIGFuZCBsaWJyYXJpZXMKK29uIHRo ZSBwbGF0Zm9ybXMgdGhhdCBXZWJLaXQgY29udHJpYnV0b3JzIGFyZSB3b3JraW5nIG9uIGFyZSBy ZWFkeS4KKworVGhlIHJlbGV2YW50IGNvbXBpbGVycyBhcmUgdmVyc2lvbnMgb2YgY2xhbmcsIGdj YywgYW5kIFZpc3VhbCBTdHVkaW8uCitUaGUgV2ViS2l0IHByb2plY3QgaGFzIFthIGRvY3VtZW50 IGV4cGxhaW5pbmcgd2hpY2ggdmVyc2lvbiBvZiBnY2MgaXMgcmVxdWlyZWRdKGh0dHBzOi8vdHJh Yy53ZWJraXQub3JnL3dpa2kvV2ViS2l0R1RLL0dDQ1JlcXVpcmVtZW50KS4KKworIyMgU2NyaXB0 cworCitUaGUgcHJlZmVycmVkIGxhbmd1YWdlIGZvciBXZWJLaXQgcHJvamVjdCBzY3JpcHRzIGlz IFB5dGhvbi4KK1dlIGhhdmUgbGVnYWN5IHNjcmlwdHMgaW4gUGVybCBhbmQgUnVieSwgYnV0IHdl IGFzayB0aGF0IG5ldyBzY3JpcHRzIGJlIGRvbmUgaW4gUHl0aG9uLgorCisjIyMgUHl0aG9uCisK K1NvbWUgV2ViS2l0IHNjcmlwdHMgYXJlIGluIFB5dGhvbiAzLCBvdGhlcnMgaW4gUHl0aG9uIDIu IFdoYXTigJlzIHRoZSBwb2xpY3kgb24gdGhhdD8KKworIyMjIyBTY3JpcHRzIHVzZWQgZm9yIGJ1 aWxkaW5nIGFuZCB0ZXN0aW5nIFdlYktpdAorCitUaGlzIGluY2x1ZGVzIHNjcmlwdHMgbGlrZSBg cnVuLXdlYmtpdC10ZXN0c2AgYW5kIGBidWlsZC13ZWJraXRgLgorCitBbGwgb2YgdGhlc2Ugc2Ny aXB0cyBtdXN0IGJlIHdyaXR0ZW4gc28gdGhhdCB0aGV5IGFyZSBjb21wYXRpYmxlIHdpdGggYm90 aCBQeXRob24gMiBhbmQgUHl0aG9uIDMuCitTb21lIHBvcnRzIGJ1aWxkIG9uIGVudmlyb25tZW50 cyB0aGF0IGhhdmUgb25seSBQeXRob24gMiwgaW5jbHVkaW5nIHRoZSBpbnRlcm5hbCBBcHBsZSBi dWlsZAorZW52aXJvbm1lbnQgZm9yIG9sZGVyIEFwcGxlIE9TIHZlcnNpb25zIHN1Y2ggYXMgbWFj T1MgTW92YWplLgorT3RoZXIgcG9ydHMgYnVpbGQgb24gZW52aXJvbm1lbnRzIHRoYXQgaGF2ZSBv bmx5IFB5dGhvbiAzLgorCitBdCBzb21lIHBvaW50IGluIHRoZSBmdXR1cmUgdGhlIFB5dGhvbiAy IHJlcXVpcmVtZW50IHdpbGwgYmUgcmVsYXhlZC4KKworIyMjIyBTY3JpcHRzIHVzZWQgZm9yIGRl dmVsb3BpbmcgV2ViS2l0CisKK1RoaXMgaW5jbHVkZXMgc2NyaXB0cyBsaWtlICBgY29uZmlndXJl LXhjb2RlLWZvci1lbWJlZGRlZC1kZXZlbG9wbWVudGAgYW5kICBgbGludC10ZXN0LWV4cGVjdGF0 aW9uc2AuCisKK1RoZXNlIHNjcmlwdHMgbXVzdCBiZSBjb21wYXRpYmxlIHdpdGggUHl0aG9uIDMs CithbmQgZG8gbm90IG5lZWQgdG8gYmUgY29tcGF0aWJsZSB3aXRoIFB5dGhvbiAyLgorV2hpbGUg c29tZSBXZWJLaXQgZGV2ZWxvcG1lbnQgaXMgZG9uZSBvbiBzeXN0ZW1zCit0aGF0IGRvbuKAmXQg aGF2ZSBQeXRob24gMyBpbnN0YWxsZWQsIHRoZSB2YXN0IG1ham9yaXR5IGlzIG5vdAorYW5kIHNv IHdl4oCZcmUgbm90IHJlcXVpcmluZyBQeXRob24gMiBjb21wYXRpYmlsaXR5IGZvciBuZXcgc2Ny aXB0cwordGhhdCBhcmVu4oCZdCBwYXJ0IG9mIGJ1aWxkaW5nIGFuZCB0ZXN0aW5nLgorCisjIyMj IFdoaWNoIHZlcnNpb24gb2YgUHl0aG9uIDM/CisKK0F0IHRoZSBtb21lbnQsIHRoZSBwcmFjdGlj YWwgbWluaW11bSB2ZXJzaW9uIG9mIFB5dGhvbiAzIGlzIFB5dGhvbiAzLjcuMy4KK01vc3QgcGxh dGZvcm1zIGhhdmUgbmV3ZXIgdmVyc2lvbnMsIGFuZCB0aGF0IGlzIHRoZSB2ZXJzaW9uIGluIGlu Y2x1ZGVkIHdpdGggbWFjT1MgQ2F0YWxpbmEuCg==