215179 2020-08-05 11:49:11 -0700 r264813 breaks Make runner on remote devices 2020-08-05 16:55:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima saam webkit-bug-importer oldest_to_newest 1678004 0 ticaiolima 2020-08-05 11:49:11 -0700 The problem is that changes introduced by r264813 sets `LD_LIBRARY_PATH` wrongly. This can cause a variety of issues depending on configuration fo the remote runner. 1678012 1 406021 ticaiolima 2020-08-05 12:05:41 -0700 Created attachment 406021 Patch 1678141 2 406021 ticaiolima 2020-08-05 16:48:47 -0700 Comment on attachment 406021 Patch Win failure is very likely unrelated, since this change is Linux specific. Thank you for the review! 1678143 3 ews-feeder 2020-08-05 16:54:50 -0700 Committed r265312: <https://trac.webkit.org/changeset/265312> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406021. 1678144 4 webkit-bug-importer 2020-08-05 16:55:17 -0700 <rdar://problem/66600583> 406021 2020-08-05 12:05:41 -0700 2020-08-05 16:54:50 -0700 Patch bug-215179-20200805160539.patch text/plain 1445 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MjQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWYyZTg2M2Q0MzRmOTMzMWVjM2ZlYmE3NDY4NWVmZTgw ZjExYjYxZi4uN2Y5ZWY1YzQ4ODZkMjMwYmRmNWE2NmY4MGQxYjA0NDE1YTk0Nzg4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTA4LTA1ICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KKworICAg ICAgICByMjY0ODEzIGJyZWFrcyBNYWtlIHJ1bm5lciBvbiByZW1vdGUgZGV2aWNlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1MTc5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBpcyBz ZXR0aW5nIHVwIHRoZSBwcm9wZXIgYExEX0xJQlJBUllfUEFUSGAgdmFsdWUgdG8gcnVuIEpTQwor ICAgICAgICBzdHJlc3MgdGVzdHMgb24gcmVtb3RlIGRldmljZXMuCisKKyAgICAgICAgKiBTY3Jp cHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzOgorCiAyMDIwLTA4LTAzICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IC1hY2Nlc3NvcnlEb25lIHRv IGJsdXIgdGhlIGZvY3VzZWQgZWxlbWVudCBvbiBpUGFkIHdoZW4gQXV0b0ZpbGxpbmcgc3Ryb25n IHBhc3N3b3JkcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0 cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKaW5kZXggNGIzZmYyZjdiNzEw NDI5YjdhZTdhYWJjZTY2ZDA3Nzc4YjhiNGNhMi4uNjI4MzdhODVmOWE4MDZjMWEzYjIwNmQ1OTVm MTMxZTA3NmQ0YWY3OSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10 ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCkBAIC0yMTE1LDcg KzIxMTUsNyBAQCBlbmQKIAogZGVmIGV4cG9ydEJhc2VFbnZpcm9ubWVudFZhcmlhYmxlcwogICAg IGR5bGRGcmFtZXdvcmtQYXRoID0gIlxcJChjZCAjeyR0ZXN0aW5nRnJhbWV3b3JrUGF0aC5kaXJu YW1lfTsgcHdkKSIKLSAgICBsZExpYnJhcnlQYXRoID0gIlxcJChwd2QpLyN7JG91dHB1dERpci5i YXNlbmFtZX0vI3skanNjUGF0aC5kaXJuYW1lfSIKKyAgICBsZExpYnJhcnlQYXRoID0gIlxcJChj ZCAjeyR0ZXN0aW5nRnJhbWV3b3JrUGF0aC5kaXJuYW1lfS8uLjsgcHdkKS8jeyRqc2NQYXRoLmRp cm5hbWV9IgogICAgIFsKICAgICAgICAgImV4cG9ydCBEWUxEX0ZSQU1FV09SS19QQVRIPSN7ZHls ZEZyYW1ld29ya1BhdGh9ICYmICIsCiAgICAgICAgICJleHBvcnQgTERfTElCUkFSWV9QQVRIPSN7 bGRMaWJyYXJ5UGF0aH0gJiYiLAo=