215125 2020-08-04 06:36:44 -0700 Remove AudioSampleDataSource::setPaused 2020-08-04 09:02:22 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 215127 1 youennf youennf eric.carlson ews-watchlist ggaren glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1677611 0 youennf 2020-08-04 06:36:44 -0700 It is no longer used and can prevent m_transitioningFromPaused from being true 1677612 1 405916 youennf 2020-08-04 06:39:25 -0700 Created attachment 405916 Patch 1677632 2 405916 ggaren 2020-08-04 08:55:31 -0700 Comment on attachment 405916 Patch r=me Seems like m_transitioningFromPaused should be removed too? 1677635 3 youennf 2020-08-04 08:58:59 -0700 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 405916 [details] > Patch > > r=me > > Seems like m_transitioningFromPaused should be removed too? m_transitioningFromPaused is used to initialize the output sample timestamp offset. I'll rename it in https://bugs.webkit.org/show_bug.cgi?id=215127. 1677637 4 ews-feeder 2020-08-04 09:01:30 -0700 Committed r265244: <https://trac.webkit.org/changeset/265244> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405916. 1677638 5 webkit-bug-importer 2020-08-04 09:02:22 -0700 <rdar://problem/66525590> 405916 2020-08-04 06:39:25 -0700 2020-08-04 09:01:31 -0700 Patch bug-215125-20200804153923.patch text/plain 3543 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQwYWVmOWZiZDZkN2Yz MDhlODljZjYzZmVkNTYwNDcxNjZhZGY5ZS4uMjM4MmQ1YjIxNDljYzdkNDhkNDMwMGNjZDhlZDI4 NjhiMjNjOTUwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTA0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgQXVkaW9TYW1w bGVEYXRhU291cmNlOjpzZXRQYXVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNTEyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIG1fcGF1c2VkIGlzIHVudXNlZCBleGNlcHQgZm9yIHNldHRpbmcgbV90 cmFuc2l0aW9uaW5nRnJvbVBhdXNlZC4KKyAgICAgICAgc2V0UGF1c2VkIGlzIG9ubHkgdXNlZCBp biBBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJDb2NvYSBhdCBjcmVhdGlvbiBvZiB0aGUgc291 cmNlLgorICAgICAgICBXZSBjYW4gcmVtb3ZlIHRoZSBjYWxsIGZvciBzZXRQYXVzZWQodHJ1ZSkg YW5kIHJlbW92ZSBzZXRQYXVzZWQvbV9wYXVzZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRp by9tYWMvQXVkaW9TYW1wbGVEYXRhU291cmNlLmg6CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8v bWFjL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5tbToKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvU2Ft cGxlRGF0YVNvdXJjZTo6c2V0UGF1c2VkKTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9t ZWRpYXN0cmVhbS9tYWMvQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJDb2NvYS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckNvY29hOjpwdXNo U2FtcGxlcyk6CisKIDIwMjAtMDgtMDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBNZWRpYVJlY29yZGVyIGJpdHJhdGUgb3B0aW9u cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0F1ZGlvU2Ft cGxlRGF0YVNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0F1ZGlv U2FtcGxlRGF0YVNvdXJjZS5oCmluZGV4IGYyNTljNmEzZTY2YzhiNWI1ZjA2ZmNjMWQ0Mzc0NjIz YmM1ZDlhMDMuLmFmYzRiODNlYzljZTc4YTE2Y2Y1N2Q1ZTZmOGRiN2E4ZGFkZWE1ODkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb1NhbXBsZURhdGFT b3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvQXVkaW9TYW1w bGVEYXRhU291cmNlLmgKQEAgLTY1LDggKzY1LDYgQEAgcHVibGljOgogCiAgICAgYm9vbCBwdWxs QXZhbGFpYmxlU2FtcGxlc0FzQ2h1bmtzKEF1ZGlvQnVmZmVyTGlzdCYsIHNpemVfdCBmcmFtZUNv dW50LCB1aW50NjRfdCB0aW1lU3RhbXAsIEZ1bmN0aW9uPHZvaWQoKT4mJik7CiAKLSAgICB2b2lk IHNldFBhdXNlZChib29sKTsKLQogICAgIHZvaWQgc2V0Vm9sdW1lKGZsb2F0IHZvbHVtZSkgeyBt X3ZvbHVtZSA9IHZvbHVtZTsgfQogICAgIGZsb2F0IHZvbHVtZSgpIGNvbnN0IHsgcmV0dXJuIG1f dm9sdW1lOyB9CiAKQEAgLTExNSw3ICsxMTMsNiBAQCBwcml2YXRlOgogCiAgICAgZmxvYXQgbV92 b2x1bWUgeyAxLjAgfTsKICAgICBib29sIG1fbXV0ZWQgeyBmYWxzZSB9OwotICAgIGJvb2wgbV9w YXVzZWQgeyB0cnVlIH07CiAgICAgYm9vbCBtX3RyYW5zaXRpb25pbmdGcm9tUGF1c2VkIHsgdHJ1 ZSB9OwogCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvQXVkaW9TYW1wbGVEYXRhU291cmNlLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5tbQppbmRl eCBiYzg5NTIxNWMxNmIwMWU4MzkwN2RlZGFiZGFiMjUyYmY1NDYzODI1Li5mNmVkMjAxZDVmZWQ5 NDkyY2VmNzYzNmI2NDM5NzhmOGU5OWZkZjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hdWRpby9tYWMvQXVkaW9TYW1wbGVEYXRhU291cmNlLm1tCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb1NhbXBsZURhdGFTb3VyY2UubW0KQEAgLTc1 LDE1ICs3NSw2IEBAIEF1ZGlvU2FtcGxlRGF0YVNvdXJjZTo6fkF1ZGlvU2FtcGxlRGF0YVNvdXJj ZSgpCiAgICAgfQogfQogCi12b2lkIEF1ZGlvU2FtcGxlRGF0YVNvdXJjZTo6c2V0UGF1c2VkKGJv b2wgcGF1c2VkKQotewotICAgIGlmIChwYXVzZWQgPT0gbV9wYXVzZWQpCi0gICAgICAgIHJldHVy bjsKLQotICAgIG1fdHJhbnNpdGlvbmluZ0Zyb21QYXVzZWQgPSBtX3BhdXNlZDsKLSAgICBtX3Bh dXNlZCA9IHBhdXNlZDsKLX0KLQogT1NTdGF0dXMgQXVkaW9TYW1wbGVEYXRhU291cmNlOjpzZXR1 cENvbnZlcnRlcigpCiB7CiAgICAgQVNTRVJUKG1faW5wdXREZXNjcmlwdGlvbiAmJiBtX291dHB1 dERlc2NyaXB0aW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlh c3RyZWFtL21hYy9BdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckNvY29hLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BdWRpb01lZGlhU3RyZWFtVHJhY2tS ZW5kZXJlckNvY29hLmNwcAppbmRleCBiNGY0ZjE0MTQzMzc3MjFlNmIwN2ZhYWUzZTJiYmU2OGFm YjI1ZTdmLi43NjIzMmI3OWQ5ZDA3ZWIxYjg5YzQyZWI1MzQ0ZGRjMzA1NDJhZTA4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQXVkaW9NZWRpYVN0 cmVhbVRyYWNrUmVuZGVyZXJDb2NvYS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vbWFjL0F1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVyQ29jb2EuY3BwCkBA IC05MSw3ICs5MSw2IEBAIHZvaWQgQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJDb2NvYTo6 cHVzaFNhbXBsZXMoY29uc3QgTWVkaWFUaW1lJiBzYW1wbGVUaW1lCiAgICAgICAgICAgICBpZiAo b2xkU291cmNlKQogICAgICAgICAgICAgICAgIEF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVy VW5pdDo6c2luZ2xldG9uKCkucmVtb3ZlU291cmNlKCpvbGRTb3VyY2UpOwogCi0gICAgICAgICAg ICBuZXdTb3VyY2UtPnNldFBhdXNlZChmYWxzZSk7CiAgICAgICAgICAgICBuZXdTb3VyY2UtPnNl dFZvbHVtZSh2b2x1bWUoKSk7CiAgICAgICAgICAgICBBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5k ZXJlclVuaXQ6OnNpbmdsZXRvbigpLmFkZFNvdXJjZShXVEZNb3ZlKG5ld1NvdXJjZSkpOwogICAg ICAgICB9KTsK