215108 2020-08-03 15:41:47 -0700 [iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters 2020-08-05 12:55:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham katherine_cheney ryanhaddad webkit-bug-importer youennf oldest_to_newest 1677460 0 pvollan 2020-08-03 15:41:47 -0700 On iOS Simulator, the following code asserts in WebPage::platformDidReceiveLoadParameters: bool databaseUpdated = LaunchServicesDatabaseManager::singleton().waitForDatabaseUpdate(5_s); ASSERT_UNUSED(databaseUpdated, databaseUpdated); 1677462 1 405875 pvollan 2020-08-03 15:44:53 -0700 Created attachment 405875 Patch 1677478 2 webkit-bug-importer 2020-08-03 16:16:31 -0700 <rdar://problem/66496731> 1677607 3 405875 youennf 2020-08-04 05:08:54 -0700 Comment on attachment 405875 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405875&action=review > Source/WebKit/ChangeLog:9 > + com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Disable the entitlment check for simulator. r=me but before landing, could you try (or maybe you did already) to add this entitlement to iOS simulator? Looking at the code, I see XPCService-embedded-simulator.entitlements for instance where we could try adding that entitlement. 1677712 4 405939 pvollan 2020-08-04 13:37:48 -0700 Created attachment 405939 Patch 1677720 5 ews-feeder 2020-08-04 14:03:18 -0700 Committed r265260: <https://trac.webkit.org/changeset/265260> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405939. 1678043 6 pvollan 2020-08-05 12:55:15 -0700 (In reply to youenn fablet from comment #3) > Comment on attachment 405875 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405875&action=review > > > Source/WebKit/ChangeLog:9 > > + com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Disable the entitlment check for simulator. > > r=me but before landing, could you try (or maybe you did already) to add > this entitlement to iOS simulator? > Looking at the code, I see XPCService-embedded-simulator.entitlements for > instance where we could try adding that entitlement. Good point! That did the trick. Thanks for reviewing! 405875 2020-08-03 15:44:53 -0700 2020-08-04 05:08:54 -0700 Patch bug-215108-20200803154452.patch text/plain 2845 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjUyMjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTAzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TIFNpbXVsYXRvcl0gQXNz ZXJ0IHVuZGVyIFdlYlBhZ2U6OnBsYXRmb3JtRGlkUmVjZWl2ZUxvYWRQYXJhbWV0ZXJzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUxMDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFzc2VydHMg YmVjYXVzZSBpdCBhcHBlYXJzIHRoYXQgdGhlIFdlYkNvbnRlbnQgYW5kIE5ldHdvcmtpbmcgcHJv Y2VzcyBkbyBub3QgaGF2ZSB0aGUgcmVxdWlyZWQgZW50aXRsZW1lbnQKKyAgICAgICAgY29tLmFw cGxlLnByaXZhdGUud2Via2l0LnVzZS14cGMtZW5kcG9pbnQgb24gdGhlIGlPUyBTaW11bGF0b3Iu IERpc2FibGUgdGhlIGVudGl0bG1lbnQgY2hlY2sgZm9yIHNpbXVsYXRvci4KKworICAgICAgICBO byBuZXcgdGVzdHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBTaGFy ZWQvQ29jb2EvWFBDRW5kcG9pbnQubW06CisgICAgICAgIChXZWJLaXQ6OlhQQ0VuZHBvaW50OjpY UENFbmRwb2ludCk6CisgICAgICAgICogU2hhcmVkL0NvY29hL1hQQ0VuZHBvaW50Q2xpZW50Lm1t OgorICAgICAgICAoV2ViS2l0OjpYUENFbmRwb2ludENsaWVudDo6c2V0RW5kcG9pbnQpOgorCiAy MDIwLTA4LTAzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgbWFjQ2F0YWx5c3QgYnVpbGQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvU2hhcmVk L0NvY29hL1hQQ0VuZHBvaW50Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2hhcmVk L0NvY29hL1hQQ0VuZHBvaW50Lm1tCShyZXZpc2lvbiAyNjUyMjYpCisrKyBTb3VyY2UvV2ViS2l0 L1NoYXJlZC9Db2NvYS9YUENFbmRwb2ludC5tbQkod29ya2luZyBjb3B5KQpAQCAtNDEsMTIgKzQx LDE0IEBAIFhQQ0VuZHBvaW50OjpYUENFbmRwb2ludCgpCiAKICAgICAgICAgaWYgKHR5cGUgPT0g WFBDX1RZUEVfQ09OTkVDVElPTikgewogICAgICAgICAgICAgT1NPYmplY3RQdHI8eHBjX2Nvbm5l Y3Rpb25fdD4gY29ubmVjdGlvbiA9IG1lc3NhZ2U7CisjaWYgIVBMQVRGT1JNKElPU19GQU1JTFlf U0lNVUxBVE9SKQogICAgICAgICAgICAgYXV0byBwaWQgPSB4cGNfY29ubmVjdGlvbl9nZXRfcGlk KGNvbm5lY3Rpb24uZ2V0KCkpOwogCiAgICAgICAgICAgICBpZiAocGlkICE9IGdldHBpZCgpICYm ICFXVEY6Omhhc0VudGl0bGVtZW50KGNvbm5lY3Rpb24uZ2V0KCksICJjb20uYXBwbGUucHJpdmF0 ZS53ZWJraXQudXNlLXhwYy1lbmRwb2ludCIpKSB7CiAgICAgICAgICAgICAgICAgV1RGTG9nQWx3 YXlzKCJBdWRpdCB0b2tlbiBkb2VzIG5vdCBoYXZlIHJlcXVpcmVkIGVudGl0bGVtZW50IGNvbS5h cHBsZS5wcml2YXRlLndlYmtpdC51c2UteHBjLWVuZHBvaW50Iik7CiAgICAgICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICAgICAgfQorI2VuZGlmCiAgICAgICAgICAgICB4cGNfY29ubmVjdGlv bl9zZXRfdGFyZ2V0X3F1ZXVlKGNvbm5lY3Rpb24uZ2V0KCksIGRpc3BhdGNoX2dldF9tYWluX3F1 ZXVlKCkpOwogICAgICAgICAgICAgeHBjX2Nvbm5lY3Rpb25fc2V0X2V2ZW50X2hhbmRsZXIoY29u bmVjdGlvbi5nZXQoKSwgXih4cGNfb2JqZWN0X3QgZXZlbnQpIHsKICAgICAgICAgICAgICAgICBo YW5kbGVFdmVudChjb25uZWN0aW9uLmdldCgpLCBldmVudCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0 L1NoYXJlZC9Db2NvYS9YUENFbmRwb2ludENsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L1NoYXJlZC9Db2NvYS9YUENFbmRwb2ludENsaWVudC5tbQkocmV2aXNpb24gMjY1MjI2 KQorKysgU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvWFBDRW5kcG9pbnRDbGllbnQubW0JKHdv cmtpbmcgY29weSkKQEAgLTU3LDExICs1NywxMyBAQCB2b2lkIFhQQ0VuZHBvaW50Q2xpZW50Ojpz ZXRFbmRwb2ludCh4cGNfCiAgICAgICAgICAgICBpZiAoIWNvbm5lY3Rpb24pCiAgICAgICAgICAg ICAgICAgcmV0dXJuOwogCisjaWYgIVBMQVRGT1JNKElPU19GQU1JTFlfU0lNVUxBVE9SKQogICAg ICAgICAgICAgYXV0byBwaWQgPSB4cGNfY29ubmVjdGlvbl9nZXRfcGlkKGNvbm5lY3Rpb24pOwog ICAgICAgICAgICAgaWYgKHBpZCAhPSBnZXRwaWQoKSAmJiAhV1RGOjpoYXNFbnRpdGxlbWVudChj b25uZWN0aW9uLCAiY29tLmFwcGxlLnByaXZhdGUud2Via2l0LnVzZS14cGMtZW5kcG9pbnQiKSkg ewogICAgICAgICAgICAgICAgIFdURkxvZ0Fsd2F5cygiQXVkaXQgdG9rZW4gZG9lcyBub3QgaGF2 ZSByZXF1aXJlZCBlbnRpdGxlbWVudCBjb20uYXBwbGUucHJpdmF0ZS53ZWJraXQudXNlLXhwYy1l bmRwb2ludCIpOwogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KKyNlbmRp ZgogICAgICAgICAgICAgaGFuZGxlRXZlbnQobWVzc2FnZSk7CiAgICAgICAgIH0pOwogCg== 405939 2020-08-04 13:37:48 -0700 2020-08-04 14:03:19 -0700 Patch bug-215108-20200804133747.patch text/plain 1443 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjUyNTYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA4LTA0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TIFNpbXVsYXRvcl0gQXNz ZXJ0IHVuZGVyIFdlYlBhZ2U6OnBsYXRmb3JtRGlkUmVjZWl2ZUxvYWRQYXJhbWV0ZXJzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUxMDgKKworICAg ICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgIFRoaXMgYXNzZXJ0cyBi ZWNhdXNlIGl0IGFwcGVhcnMgdGhhdCB0aGUgV2ViQ29udGVudCBhbmQgTmV0d29ya2luZyBwcm9j ZXNzIGRvIG5vdCBoYXZlIHRoZSByZXF1aXJlZCBlbnRpdGxlbWVudAorICAgICAgICBjb20uYXBw bGUucHJpdmF0ZS53ZWJraXQudXNlLXhwYy1lbmRwb2ludCBvbiB0aGUgaU9TIFNpbXVsYXRvci4g QWRkIHRoZSBlbnRpdGxlbWVudCBmb3Igc2ltdWxhdG9yLgorIAorICAgICAgICBObyBuZXcgdGVz dHMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvaW9z L1hQQ1NlcnZpY2UtZW1iZWRkZWQtc2ltdWxhdG9yLmVudGl0bGVtZW50czoKKwogMjAyMC0wOC0w MyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxv dyAtYWNjZXNzb3J5RG9uZSB0byBibHVyIHRoZSBmb2N1c2VkIGVsZW1lbnQgb24gaVBhZCB3aGVu IEF1dG9GaWxsaW5nIHN0cm9uZyBwYXNzd29yZHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvUmVzb3Vy Y2VzL2lvcy9YUENTZXJ2aWNlLWVtYmVkZGVkLXNpbXVsYXRvci5lbnRpdGxlbWVudHMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9SZXNvdXJjZXMvaW9zL1hQQ1NlcnZpY2UtZW1iZWRkZWQt c2ltdWxhdG9yLmVudGl0bGVtZW50cwkocmV2aXNpb24gMjY1MjI2KQorKysgU291cmNlL1dlYktp dC9SZXNvdXJjZXMvaW9zL1hQQ1NlcnZpY2UtZW1iZWRkZWQtc2ltdWxhdG9yLmVudGl0bGVtZW50 cwkod29ya2luZyBjb3B5KQpAQCAtNCw1ICs0LDcgQEAKIDxkaWN0PgogCTxrZXk+Y29tLmFwcGxl LnJ1bm5pbmdib2FyZC5hc3NlcnRpb25zLndlYmtpdDwva2V5PgogCTx0cnVlLz4KKwk8a2V5PmNv bS5hcHBsZS5wcml2YXRlLndlYmtpdC51c2UteHBjLWVuZHBvaW50PC9rZXk+CisJPHRydWUvPgog PC9kaWN0PgogPC9wbGlzdD4K