21510 2008-10-09 15:07:23 -0700 REGRESSION: Patterns are recreated every time they paint 2012-12-30 17:06:01 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED NeedsReduction, Regression P1 Normal --- 21498 1 eric webkit-unassigned pdr oldest_to_newest 94783 0 eric 2008-10-09 15:07:23 -0700 Patterns are recreated every time they paint This is is a possible perf regression from the previous behavior where patterns were cached based on CTM over in the Canvas2dGraphicsContext object. Now that they're over on GraphicsContext we don't have a similar system for caching (yet). This bug is about building one so that we aren't recreating patterns every time we draw them. 94785 1 eric 2008-10-09 15:10:35 -0700 Btw, one way to solve this would be to simply roll out r35966, but given that we've had no complaints of poor canvas pattern drawing performance, and no performance tests to validate that we've actually regressed, I recommend we leave this code in for now. 94826 2 eric 2008-10-09 19:30:10 -0700 all functional regressions from r35966 (tracked by bug 21498) are now fixed. Only this possible perf regression remains. 94827 3 hyatt 2008-10-09 19:32:14 -0700 The way to typically observe pattern performance issues is with large JPEGs as the pattern tile. This is how we noticed perf issues with creation/throwing stuff away in background tiling patterns in HTML. 94829 4 hyatt 2008-10-09 19:33:41 -0700 Initial landing in r37462. 94830 5 hyatt 2008-10-09 19:33:55 -0700 Wrong bug. Sorry. 798270 6 eric 2012-12-30 17:06:01 -0800 I suspect this has long since been solved.