215077 2020-08-03 01:30:53 -0700 run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words 2020-08-27 08:33:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zhifei_fang zhifei_fang angelos ap keith_miller ticaiolima webkit-bug-importer zhifei_fang oldest_to_newest 1677261 0 zhifei_fang 2020-08-03 01:30:53 -0700 run-jsc-stress-test: Set DYLD_FRAMEWORK_PATH to "$(cd ../.vm; pwd)" because it escape shell words 1677262 1 405819 zhifei_fang 2020-08-03 01:31:18 -0700 Created attachment 405819 Patch 1677263 2 zhifei_fang 2020-08-03 01:31:51 -0700 rdar://66451802 1677265 3 zhifei_fang 2020-08-03 01:32:50 -0700 break by this change: https://bugs.webkit.org/show_bug.cgi?id=214356 1677266 4 zhifei_fang 2020-08-03 01:34:19 -0700 Hi, Angelos Any special reason to escape the DYLD_FRAMEWORK_PATH ? 1677345 5 ews-feeder 2020-08-03 10:30:58 -0700 Committed r265204: <https://trac.webkit.org/changeset/265204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405819. 1677404 6 webkit-bug-importer 2020-08-03 13:37:44 -0700 <rdar://problem/66489295> 1677912 7 ticaiolima 2020-08-05 04:15:43 -0700 (In reply to Zhifei Fang from comment #4) > Hi, Angelos > > Any special reason to escape the DYLD_FRAMEWORK_PATH ? Hi Zhifei. Angelos is on holidays now and he couldn't answer it on time. This change caused some issues to gnu-parallel-runner configuration (It is possible to see it on EWS ARMv7 and MIPS run): ``` /bin/bash: -c: line 0: syntax error near unexpected token `(' /bin/bash: -c: line 0: `cd jsc-stress-results/.runner && export DYLD_FRAMEWORK_PATH=\$(cd ../.vm; pwd) && export LD_LIBRARY_PATH=\$(pwd)/jsc-stress-results/.vm/JavaScriptCore.framework/Helpers &&export JSCTEST_timeout=1200 && export JSCTEST_hardTimeout=300 && export JSCTEST_memoryLimit=838860800 && export TZ=US/Pacific && sh ./test_script_25617' ``` IIUC, this change was necessary to allow Make runner work again for remote devices, right? I'm not very familiar with this part of the code and with pearl, so I don't want to make too much assumptions there. In the meantime, I changed configuration of those bots to use Make runner instead of gnu-parallel, so we can process EWS and post-commit bots queues. 1683378 8 angelos 2020-08-27 08:33:36 -0700 (In reply to Zhifei Fang from comment #4) > Hi, Angelos > > Any special reason to escape the DYLD_FRAMEWORK_PATH ? Hi Zhifei, the reason was I was using different kind of quoting when invoking GNU parallel. See https://bugs.webkit.org/show_bug.cgi?id=215887 for a suggested fix. 405819 2020-08-03 01:31:18 -0700 2020-08-03 10:30:58 -0700 Patch bug-215077-20200803013118.patch text/plain 1889 zhifei_fang U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWY1YWZmNWEyYmEwNTBhNTUwYzI1MjQwODE4ZjYxOWVl MTE2Mzc1Yi4uMzVlODdhYjc2YmYyMWIwNzVkYjlhNWU0OGEwM2MyMzBjN2Y5NmE4ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDIwLTA4LTAzICBaaGlmZWkgRmFuZyAgPHpoaWZlaV9mYW5nQGFwcGxlLmNvbT4KKwor ICAgICAgICBydW4tanNjLXN0cmVzcy10ZXN0OiBTZXQgRFlMRF9GUkFNRVdPUktfUEFUSCB0byAi JChjZCAuLi8udm07IHB3ZCkiIGJlY2F1c2UgaXQgZXNjYXBlIHNoZWxsIHdvcmRzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUwNzcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWpz Yy1zdHJlc3MtdGVzdHM6CisKIDIwMjAtMDgtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNl ckBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wcm92ZSB0aGUgY2hlY2stZm9yLWR1cGxpY2F0ZWQt cGxhdGZvcm0tdGVzdC1yZXN1bHRzIHNjcmlwdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9y dW4tanNjLXN0cmVzcy10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMK aW5kZXggNDYwYWFlMjE0MmJhZWQxMDRhY2JmNDU4OTI0ZDRiOTMwNzY1NWZjYS4uNGIzZmYyZjdi NzEwNDI5YjdhZTdhYWJjZTY2ZDA3Nzc4YjhiNGNhMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy9ydW4tanNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNz LXRlc3RzCkBAIC0yMTE0LDExICsyMTE0LDExIEBAIGRlZiBjb3B5QnVuZGxlVG9SZW1vdGUocmVt b3RlSG9zdCkKIGVuZAogCiBkZWYgZXhwb3J0QmFzZUVudmlyb25tZW50VmFyaWFibGVzCi0gICAg ZHlsZEZyYW1ld29ya1BhdGggPSAiJChjZCAjeyR0ZXN0aW5nRnJhbWV3b3JrUGF0aC5kaXJuYW1l fTsgcHdkKSIKLSAgICBsZExpYnJhcnlQYXRoID0gIiQocHdkKS8jeyRvdXRwdXREaXIuYmFzZW5h bWV9LyN7JGpzY1BhdGguZGlybmFtZX0iCisgICAgZHlsZEZyYW1ld29ya1BhdGggPSAiXFwkKGNk ICN7JHRlc3RpbmdGcmFtZXdvcmtQYXRoLmRpcm5hbWV9OyBwd2QpIgorICAgIGxkTGlicmFyeVBh dGggPSAiXFwkKHB3ZCkvI3skb3V0cHV0RGlyLmJhc2VuYW1lfS8jeyRqc2NQYXRoLmRpcm5hbWV9 IgogICAgIFsKLSAgICAgICAgImV4cG9ydCBEWUxEX0ZSQU1FV09SS19QQVRIPSN7U2hlbGx3b3Jk cy5zaGVsbGVzY2FwZShkeWxkRnJhbWV3b3JrUGF0aCl9ICYmICIsCi0gICAgICAgICJleHBvcnQg TERfTElCUkFSWV9QQVRIPSN7U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShsZExpYnJhcnlQYXRoKX0g JiYiLAorICAgICAgICAiZXhwb3J0IERZTERfRlJBTUVXT1JLX1BBVEg9I3tkeWxkRnJhbWV3b3Jr UGF0aH0gJiYgIiwKKyAgICAgICAgImV4cG9ydCBMRF9MSUJSQVJZX1BBVEg9I3tsZExpYnJhcnlQ YXRofSAmJiIsCiAgICAgICAgICJleHBvcnQgSlNDVEVTVF90aW1lb3V0PSN7U2hlbGx3b3Jkcy5z aGVsbGVzY2FwZShFTlZbJ0pTQ1RFU1RfdGltZW91dCddKX0gJiYgIiwKICAgICAgICAgImV4cG9y dCBKU0NURVNUX2hhcmRUaW1lb3V0PSN7U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShFTlZbJ0pTQ1RF U1RfaGFyZFRpbWVvdXQnXSl9ICYmICIsCiAgICAgICAgICJleHBvcnQgSlNDVEVTVF9tZW1vcnlM aW1pdD0je1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoRU5WWydKU0NURVNUX21lbW9yeUxpbWl0J10p fSAmJiAiLAo=