215038 2020-07-31 15:28:07 -0700 REGRESSION(r264766) webkitpy: newly added --suite flag conflicts with other --suite flags in safaripy 2020-08-03 09:59:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1677007 0 bburg 2020-07-31 15:28:07 -0700 . 1677008 1 webkit-bug-importer 2020-07-31 15:29:04 -0700 <rdar://problem/66401661> 1677013 2 405750 bburg 2020-07-31 15:41:08 -0700 Created attachment 405750 Patch 1677035 3 405750 jbedard 2020-07-31 16:32:25 -0700 Comment on attachment 405750 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405750&action=review > Tools/Scripts/webkitpy/results/options.py:34 > + optparse.make_option('--' + suite_name_flag, help='Optional flag for overriding reported suite name.', default=None), Note that since the caller of this will be the bit using the flag, we don't need to try anything fancy to change how we consume the flag, that's up to the code instantiation the options. 1677037 4 ews-feeder 2020-07-31 16:37:05 -0700 Invalid ChangeLog at /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog 1677309 5 405836 bburg 2020-08-03 09:18:21 -0700 Created attachment 405836 Patch 1677331 6 ews-feeder 2020-08-03 09:59:31 -0700 Committed r265201: <https://trac.webkit.org/changeset/265201> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405836. 405750 2020-07-31 15:41:08 -0700 2020-08-03 09:18:20 -0700 Patch bug-215038-20200731154108.patch text/plain 2056 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBmZjY5MjRkZjQ2NTkzNzMwNjJlMzUxNDJiMjgxNWEz ZjhhNWQ5ZS4uYTZiODJmNzMwZTEyNWY3NDQwZDE4ZWIzMGM5OWQ5NmJjN2JlNmJhYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACitoMjAyMC0wNy0zMSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OKHIyNjQ3NjYpIHdlYmtpdHB5OiBuZXdseSBhZGRlZCAtLXN1aXRlIGZsYWcg Y29uZmxpY3RzIHdpdGggb3RoZXIgLS1zdWl0ZSBmbGFncyBpbiBzYWZhcmlweQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1MDM4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3Jlc3VsdHMvb3B0aW9ucy5weToKKyAgICAgICAgKHVwbG9hZF9vcHRpb25zKToKKyAgICAgICAg Rm9yIGNvbXBhdGliaWxpdHksIG1ha2UgaXQgcG9zc2libGUgdG8gY3JlYXRlIHRoZSBvcHRpb24g d2l0aCBhIGRpZmZlcmVudGx5LW5hbWVkIGZsYWcuCisKIDIwMjAtMDctMzEgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNwZWNpYWwgSElEIG1hcHBpbmcgZm9y IHRoZSBEdWFsc2hvY2sgMyBjb250cm9sbGVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Jlc3VsdHMvb3B0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcmVzdWx0 cy9vcHRpb25zLnB5CmluZGV4IDBiMjU1NWU2ZjExZTUzYTQ2Nzc0MzM5NTJkMGJhZDU5NzJmYWYx ZWQuLjZkOGVhNjUyYWZiNGMwOGFhOTVkOWQxNTlhN2ZiNGQxM2M4NzM0Y2EgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcmVzdWx0cy9vcHRpb25zLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcmVzdWx0cy9vcHRpb25zLnB5CkBAIC0yMyw3ICsyMyw3IEBACiBpbXBv cnQgb3B0cGFyc2UKIAogCi1kZWYgdXBsb2FkX29wdGlvbnMoKToKK2RlZiB1cGxvYWRfb3B0aW9u cyhzdWl0ZV9uYW1lX2ZsYWc9J3N1aXRlJyk6CiAgICAgcmV0dXJuIFsKICAgICAgICAgb3B0cGFy c2UubWFrZV9vcHRpb24oJy0tcmVwb3J0JywgYWN0aW9uPSdhcHBlbmQnLCBkZXN0PSdyZXBvcnRf dXJscycsIGhlbHA9J1VSTCAob3IgVVJMcykgdG8gcmVwb3J0IHRlc3QgcmVzdWx0cyB0bycpLAog ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbignLS1idWlsZGJvdC1tYXN0ZXInLCBoZWxwPSdU aGUgdXJsIG9mIHRoZSBidWlsZGJvdCBtYXN0ZXIuJyksCkBAIC0zMSw1ICszMSw1IEBAIGRlZiB1 cGxvYWRfb3B0aW9ucygpOgogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbignLS1idWlsZC1u dW1iZXInLCBoZWxwPSdUaGUgYnVpbGRib3QgYnVpbGQgbnVtYmVyIHRlc3RzIGFyZSBhc3NvY2lh dGVkIHdpdGguJyksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLWJ1aWxkYm90LXdv cmtlcicsIGhlbHA9J1RoZSBidWlsZGJvdCB3b3JrZXIgdGVzdHMgd2VyZSBydW4gb24uJyksCiAg ICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLXJlc3VsdC1yZXBvcnQtZmxhdm9yJywgaGVs cD0nT3B0aW9uYWwgZmxhZyBmb3IgY2F0ZWdvcml6aW5nIHRlc3QgcnVucyB3aGljaCBkbyBub3Qg Zml0IGludG8gb3RoZXIgY29uZmlndXJhdGlvbiBvcHRpb25zLicpLAotICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbignLS1zdWl0ZScsIGhlbHA9J09wdGlvbmFsIGZsYWcgZm9yIG92ZXJyaWRp bmcgcmVwb3J0ZWQgc3VpdGUgbmFtZS4nLCBkZWZhdWx0PU5vbmUpLAorICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbignLS0nICsgc3VpdGVfbmFtZV9mbGFnLCBoZWxwPSdPcHRpb25hbCBmbGFn IGZvciBvdmVycmlkaW5nIHJlcG9ydGVkIHN1aXRlIG5hbWUuJywgZGVmYXVsdD1Ob25lKSwKICAg ICBdCg== 405836 2020-08-03 09:18:21 -0700 2020-08-03 09:59:31 -0700 Patch bug-215038-20200803091821.patch text/plain 2056 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBmZjY5MjRkZjQ2NTkzNzMwNjJlMzUxNDJiMjgxNWEz ZjhhNWQ5ZS4uNzNkNWM2MTExZGVhNzJmNjkzNzZjNDJmMmFlODM1MTcwNGVlMWFhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA3LTMxICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocjI2NDc2Nikgd2Via2l0cHk6IG5ld2x5IGFkZGVkIC0tc3VpdGUgZmxhZyBj b25mbGljdHMgd2l0aCBvdGhlciAtLXN1aXRlIGZsYWdzIGluIHNhZmFyaXB5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUwMzgKKworICAgICAgICBS ZXZpZXdlZCBieSBKb25hdGhhbiBCZWRhcmQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3Jlc3VsdHMvb3B0aW9ucy5weToKKyAgICAgICAgKHVwbG9hZF9vcHRpb25zKToKKyAgICAgICAg Rm9yIGNvbXBhdGliaWxpdHksIG1ha2UgaXQgcG9zc2libGUgdG8gY3JlYXRlIHRoZSBvcHRpb24g d2l0aCBhIGRpZmZlcmVudGx5LW5hbWVkIGZsYWcuCisKIDIwMjAtMDctMzEgIEJyYWR5IEVpZHNv biAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFNwZWNpYWwgSElEIG1hcHBpbmcgZm9y IHRoZSBEdWFsc2hvY2sgMyBjb250cm9sbGVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Jlc3VsdHMvb3B0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcmVzdWx0 cy9vcHRpb25zLnB5CmluZGV4IDBiMjU1NWU2ZjExZTUzYTQ2Nzc0MzM5NTJkMGJhZDU5NzJmYWYx ZWQuLjZkOGVhNjUyYWZiNGMwOGFhOTVkOWQxNTlhN2ZiNGQxM2M4NzM0Y2EgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcmVzdWx0cy9vcHRpb25zLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcmVzdWx0cy9vcHRpb25zLnB5CkBAIC0yMyw3ICsyMyw3IEBACiBpbXBv cnQgb3B0cGFyc2UKIAogCi1kZWYgdXBsb2FkX29wdGlvbnMoKToKK2RlZiB1cGxvYWRfb3B0aW9u cyhzdWl0ZV9uYW1lX2ZsYWc9J3N1aXRlJyk6CiAgICAgcmV0dXJuIFsKICAgICAgICAgb3B0cGFy c2UubWFrZV9vcHRpb24oJy0tcmVwb3J0JywgYWN0aW9uPSdhcHBlbmQnLCBkZXN0PSdyZXBvcnRf dXJscycsIGhlbHA9J1VSTCAob3IgVVJMcykgdG8gcmVwb3J0IHRlc3QgcmVzdWx0cyB0bycpLAog ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbignLS1idWlsZGJvdC1tYXN0ZXInLCBoZWxwPSdU aGUgdXJsIG9mIHRoZSBidWlsZGJvdCBtYXN0ZXIuJyksCkBAIC0zMSw1ICszMSw1IEBAIGRlZiB1 cGxvYWRfb3B0aW9ucygpOgogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbignLS1idWlsZC1u dW1iZXInLCBoZWxwPSdUaGUgYnVpbGRib3QgYnVpbGQgbnVtYmVyIHRlc3RzIGFyZSBhc3NvY2lh dGVkIHdpdGguJyksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLWJ1aWxkYm90LXdv cmtlcicsIGhlbHA9J1RoZSBidWlsZGJvdCB3b3JrZXIgdGVzdHMgd2VyZSBydW4gb24uJyksCiAg ICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLXJlc3VsdC1yZXBvcnQtZmxhdm9yJywgaGVs cD0nT3B0aW9uYWwgZmxhZyBmb3IgY2F0ZWdvcml6aW5nIHRlc3QgcnVucyB3aGljaCBkbyBub3Qg Zml0IGludG8gb3RoZXIgY29uZmlndXJhdGlvbiBvcHRpb25zLicpLAotICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbignLS1zdWl0ZScsIGhlbHA9J09wdGlvbmFsIGZsYWcgZm9yIG92ZXJyaWRp bmcgcmVwb3J0ZWQgc3VpdGUgbmFtZS4nLCBkZWZhdWx0PU5vbmUpLAorICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbignLS0nICsgc3VpdGVfbmFtZV9mbGFnLCBoZWxwPSdPcHRpb25hbCBmbGFn IGZvciBvdmVycmlkaW5nIHJlcG9ydGVkIHN1aXRlIG5hbWUuJywgZGVmYXVsdD1Ob25lKSwKICAg ICBdCg==