215009 2020-07-30 21:59:36 -0700 Fix build around broken internal SDK for iOS 13 2020-07-31 08:54:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller aestes ews-watchlist mark.lam mitz msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1676719 0 keith_miller 2020-07-30 21:59:36 -0700 Fix build around broken internal SDK for iOS 13 1676720 1 405666 keith_miller 2020-07-30 22:02:16 -0700 Created attachment 405666 Patch 1676721 2 keith_miller 2020-07-30 22:03:46 -0700 CCing people that know more about the build to make sure there's not a more reasonable fix. I don't really understand why we are able to locate the <machine/cpu_capabilities.h> header when building JSC but not when building TestWebKitAPI... 1676742 3 405666 saam 2020-07-30 23:08:28 -0700 Comment on attachment 405666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405666&action=review > Source/JavaScriptCore/assembler/FastJITPermissions.h:33 > +// FIXME: We only need this because the internal SDK is broken for an update of iOS 13... D: But since it shipped that way it's probably too late to fix. See: rdar://66350584 > +#define HAVE_THREAD_SELF_RESTRICT USE(APPLE_INTERNAL_SDK) && __has_include(<machine/cpu_capabilities.h>) this feels wrong. And could be indicative of other bugs. I'd prefer a better solution, but if this is all we have, better to unblock the build. Might be worth asking a few other folks who know the build system better. Also, please document what's going on in the radar 1676748 4 405674 keith_miller 2020-07-30 23:49:49 -0700 Created attachment 405674 Patch 1676749 5 405674 mark.lam 2020-07-30 23:53:10 -0700 Comment on attachment 405674 Patch r=me 1676750 6 keith_miller 2020-07-30 23:54:19 -0700 rdar://66350584 1676832 7 ews-feeder 2020-07-31 08:54:34 -0700 Committed r265141: <https://trac.webkit.org/changeset/265141> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405674. 405666 2020-07-30 22:02:16 -0700 2020-07-30 23:49:47 -0700 Patch bug-215009-20200730220215.patch text/plain 2818 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 ZTU2NTI2OTI1OWFkZWI5MGEzMTQ5NDdlZWE2NmU2Mzg1YWY0Yzc0Li5mZWYyY2JhZmYzM2FhM2M1 Y2Q3ODQwMTI5ZTNmNTQ4Y2MwZWZiYjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wNy0zMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBGaXggYnVpbGQgYXJvdW5kIGJyb2tlbiBpbnRlcm5hbCBTREsgZm9y IGlPUyAxMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE1MDA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SXQgbG9va3MgbGlrZSB0aGUgPG9zL3RocmVhZF9zZWxmX3Jlc3RyaWN0Lmg+IGhlYWRlciBpcyBi cm9rZW4gb24KKyAgICAgICAgYW4gdXBkYXRlIHRvIGlPUyAxMy4gVGhpcyBpcyBjcmF6eSBoYWNr IHRvIHdvcmsgYXJvdW5kIHRoZSBmYWN0CisgICAgICAgIHRoYXQgaXQgaW5jbHVkZXMgYSBmaWxl IHRoYXQncyBub3QgaW4gdGhlIFNESyB3aGVuIFRlc3RXZWJLaXRBUEkKKyAgICAgICAgc2VlcyBv dXIgaGVhZGVyLi4uCisKKyAgICAgICAgKiBhc3NlbWJsZXIvRmFzdEpJVFBlcm1pc3Npb25zLmg6 CisgICAgICAgICh1c2VGYXN0SklUUGVybWlzc2lvbnMpOgorICAgICAgICAodGhyZWFkU2VsZlJl c3RyaWN0UldYVG9SVyk6CisgICAgICAgICh0aHJlYWRTZWxmUmVzdHJpY3RSV1hUb1JYKToKKwog MjAyMC0wNy0zMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmUgVUIgZnJvbSBub25QQUNCaXRzTWFzayBjb21wdXRhdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9GYXN0SklUUGVybWlzc2lvbnMuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvRmFzdEpJVFBlcm1pc3Npb25zLmgKaW5k ZXggZGMwNzA3OWMxZjE5YzBjOGFmODc4M2Y3ZGE3NjQwNWIwMTM1YWMyYS4uMDNkOTg3M2E2ZTE3 ODhjM2EyOGU0MWI0NzY4MmQ3YjI4NmVjNTE2OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9GYXN0SklUUGVybWlzc2lvbnMuaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL0Zhc3RKSVRQZXJtaXNzaW9ucy5oCkBAIC0yOSw5ICsyOSwxMiBA QAogCiAjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAKKy8vIEZJWE1FOiBXZSBvbmx5IG5lZWQg dGhpcyBiZWNhdXNlIHRoZSBpbnRlcm5hbCBTREsgaXMgYnJva2VuIGZvciBhbiB1cGRhdGUgb2Yg aU9TIDEzLi4uIEQ6IEJ1dCBzaW5jZSBpdCBzaGlwcGVkIHRoYXQgd2F5IGl0J3MgcHJvYmFibHkg dG9vIGxhdGUgdG8gZml4LiBTZWU6IHJkYXI6Ly82NjM1MDU4NAorI2RlZmluZSBIQVZFX1RIUkVB RF9TRUxGX1JFU1RSSUNUIFVTRShBUFBMRV9JTlRFUk5BTF9TREspICYmIF9faGFzX2luY2x1ZGUo PG1hY2hpbmUvY3B1X2NhcGFiaWxpdGllcy5oPikKKwogI2lmIEhBVkUoUFRIUkVBRF9KSVRfUEVS TUlTU0lPTlNfQVBJKQogI2luY2x1ZGUgPHB0aHJlYWQuaD4KLSNlbGlmIFVTRShBUFBMRV9JTlRF Uk5BTF9TREspCisjZWxpZiBIQVZFKFRIUkVBRF9TRUxGX1JFU1RSSUNUKQogI2luY2x1ZGUgPG9z L3RocmVhZF9zZWxmX3Jlc3RyaWN0Lmg+IAogI2VuZGlmCiAKQEAgLTQxLDcgKzQ0LDcgQEAgc3Rh dGljIEFMV0FZU19JTkxJTkUgYm9vbCB1c2VGYXN0SklUUGVybWlzc2lvbnMoKQogICAgIHJldHVy biB0cnVlOwogI2VsaWYgSEFWRShQVEhSRUFEX0pJVF9QRVJNSVNTSU9OU19BUEkpIAogICAgIHJl dHVybiAhIXB0aHJlYWRfaml0X3dyaXRlX3Byb3RlY3Rfc3VwcG9ydGVkX25wKCk7Ci0jZWxpZiBV U0UoQVBQTEVfSU5URVJOQUxfU0RLKQorI2VsaWYgSEFWRShUSFJFQURfU0VMRl9SRVNUUklDVCkK ICAgICByZXR1cm4gISFvc190aHJlYWRfc2VsZl9yZXN0cmljdF9yd3hfaXNfc3VwcG9ydGVkKCk7 CiAjZWxzZQogICAgIHJldHVybiBmYWxzZTsKQEAgLTU0LDcgKzU3LDcgQEAgc3RhdGljIEFMV0FZ U19JTkxJTkUgdm9pZCB0aHJlYWRTZWxmUmVzdHJpY3RSV1hUb1JXKCkKIAogI2lmIEhBVkUoUFRI UkVBRF9KSVRfUEVSTUlTU0lPTlNfQVBJKSAKICAgICBwdGhyZWFkX2ppdF93cml0ZV9wcm90ZWN0 X25wKGZhbHNlKTsKLSNlbGlmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisjZWxpZiBIQVZFKFRI UkVBRF9TRUxGX1JFU1RSSUNUKQogICAgIG9zX3RocmVhZF9zZWxmX3Jlc3RyaWN0X3J3eF90b19y dygpOwogI2Vsc2UKICAgICBib29sIHRhdXRvbG9neVRvSWdub3JlV2FybmluZyA9IHRydWU7CkBA IC02OSw3ICs3Miw3IEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHZvaWQgdGhyZWFkU2VsZlJlc3Ry aWN0UldYVG9SWCgpCiAKICNpZiBIQVZFKFBUSFJFQURfSklUX1BFUk1JU1NJT05TX0FQSSkgCiAg ICAgcHRocmVhZF9qaXRfd3JpdGVfcHJvdGVjdF9ucCh0cnVlKTsKLSNlbGlmIFVTRShBUFBMRV9J TlRFUk5BTF9TREspCisjZWxpZiBIQVZFKFRIUkVBRF9TRUxGX1JFU1RSSUNUKQogICAgIG9zX3Ro cmVhZF9zZWxmX3Jlc3RyaWN0X3J3eF90b19yeCgpOwogI2Vsc2UKICAgICBib29sIHRhdXRvbG9n eVRvSWdub3JlV2FybmluZyA9IHRydWU7Cg== 405674 2020-07-30 23:49:49 -0700 2020-07-31 08:54:35 -0700 Patch bug-215009-20200730234949.patch text/plain 2440 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzI4YTRjNTVkMGE2OTcxZWQ4NTUyMDg1MGI2NDZlYjU2 ODJmZjIwYy4uZmU4MzllYzQxMTU5NWExOTE3YmFjYTNiYzJhM2VhNjBkZGRkNTRiNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTA3LTMwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIEZpeCBidWlsZCBhcm91bmQgYnJva2VuIGludGVybmFsIFNESyBmb3IgaU9TIDEz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUwMDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBuZWVk IHRvIG1hbnVhbGx5IGluY2x1ZGUgdGhlIHByaXZhdGUgaGVhZGVycyBiZWNhdXNlIHRoZSBzeXN0 ZW0gdHJpZXMgdG8gaGlkZSB0aGVtIGZyb20gdXMgZXZlbiBvbiBpbnRlcm5hbCBidWlsZHMuLi4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS54 Y2NvbmZpZzoKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJL aXRBUElMaWJyYXJ5LnhjY29uZmlnOgorCiAyMDIwLTA3LTMwICBEZWFuIEphY2tzb24gIDxkaW5v QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViR0xdIFNhZmFyaSBzbmFwc2hvdHMgb2YgV2ViR0wg Y29udGVudCBpbiB0aGUgdGFiIHBpY2tlciBkb24ndCB3b3JrCmRpZmYgLS1naXQgYS9Ub29scy9U ZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUEkueGNjb25maWcgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUEkueGNjb25maWcKaW5k ZXggYjJiMjRhMTI4ODMwNzhiOTgwNWU3YWIxZWI5ZmZlOTUwOWFjMTA5MC4uMDMxZWFlNmVjNTFh ZDY5ZDNmNzkwNTM3NDNhZjYwNzVmYzM4YjhiYyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp dEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V2ViS2l0QVBJLnhjY29uZmlnCisrKyBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS54Y2NvbmZpZwpAQCAtNjUs NiArNjUsOCBAQCBXS19ISURfTERGTEFHUyA9ICQoV0tfSElEX0xERkxBR1NfJChXS19QTEFURk9S TV9OQU1FKSk7CiBXS19ISURfTERGTEFHU19tYWNvc3ggPSAkKFdLX0hJRF9MREZMQUdTJChXS19N QUNPU18xMDE1KSk7CiBXS19ISURfTERGTEFHU19NQUNPU19TSU5DRV8xMDE1ID0gLWZyYW1ld29y ayBISUQ7CiAKK09USEVSX0NQTFVTUExVU0ZMQUdTID0gJChpbmhlcml0ZWQpIC1pc3lzdGVtICQo U0RLUk9PVCkvU3lzdGVtL0xpYnJhcnkvRnJhbWV3b3Jrcy9TeXN0ZW0uZnJhbWV3b3JrL1ByaXZh dGVIZWFkZXJzOworCiBPVEhFUl9MREZMQUdTID0gJChpbmhlcml0ZWQpICQoVU5FWFBPUlRFRF9T WU1CT0xfTERGTEFHUykgLWxndGVzdCAtZm9yY2VfbG9hZCAkKEJVSUxUX1BST0RVQ1RTX0RJUikv bGliVGVzdFdlYktpdEFQSS5hIC1mcmFtZXdvcmsgSmF2YVNjcmlwdENvcmUgLWZyYW1ld29yayBX ZWJLaXQgLWxXZWJDb3JlVGVzdFN1cHBvcnQgJChXS19BVVRIS0lUX0xERkxBR1MpICQoV0tfTkVU V09SS19MREZMQUdTKSAkKFdLX1BERktJVF9MREZMQUdTKSAkKFdLX0hJRF9MREZMQUdTKSAkKE9U SEVSX0xERkxBR1NfUExBVEZPUk1fJChXS19DT0NPQV9UT1VDSCkpOwogT1RIRVJfTERGTEFHU19Q TEFURk9STV8gPSAtZnJhbWV3b3JrIENvY29hIC1mcmFtZXdvcmsgQ2FyYm9uOwogCmRpZmYgLS1n aXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRBUElMaWJy YXJ5LnhjY29uZmlnIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V2Vi S2l0QVBJTGlicmFyeS54Y2NvbmZpZwppbmRleCBjMTUyYmMxYjgyN2Q5MWVkM2ZjMDcxNDgyZThm NjU4YjE4MjM2YTJiLi5iNjUxOGZjYjI4ZjE0MzRhYjg3MzBkZmU3NTQ2ZWRiOTUxNjE4MjUwIDEw MDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRpb25zL1Rlc3RXZWJLaXRB UElMaWJyYXJ5LnhjY29uZmlnCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlv bnMvVGVzdFdlYktpdEFQSUxpYnJhcnkueGNjb25maWcKQEAgLTIzLDYgKzIzLDggQEAKIC8vIFRI RSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIC8vCiAKKyNpbmNsdWRlICJUZXN0V2ViS2l0 QVBJLnhjY29uZmlnIgorCiBQUk9EVUNUX05BTUUgPSBUZXN0V2ViS2l0QVBJOwogU0tJUF9JTlNU QUxMID0gWUVTOwogR0NDX1NZTUJPTFNfUFJJVkFURV9FWFRFUk4gPSBZRVM7Cg==