21500 2008-10-09 02:58:18 -0700 Qt-port on Linux should be built with g++ -O3 switch 2009-04-16 18:22:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ossy webkit-unassigned hausmann laszlo.gombos oldest_to_newest 94731 0 ossy 2008-10-09 02:58:18 -0700 WebKit Qt-port on Linux is built with g++ -O2 switch because of Qt default config (Qt-4.4.1/mkspecs/common/g++.conf) Building with -O3 switch instead of -O2, JSC is faster. (I used gcc version 4.1.2, Qt version 4.4.1 and WebKit rev37424) runtime and code size of JSC: - 3.51% speedup on SunSpider (+/-0.8%) - 1.30% speedup on V8 (+/-0.65%) - 3.81% speedup on WindScorpion (+/-1.0%) - Code size of JSC .text section increased by 9.96% I'll send patch soon. 94732 1 ossy 2008-10-09 05:11:36 -0700 Layout tests result - the whole WebKit built with -O3: 489.63s total testing time 7272 test cases (89%) succeeded 836 test cases (10%) had incorrect layout 3 test cases (<1%) crashed Layout tests result - only JSC built with -O3: 513.98s total testing time 7277 test cases (89%) succeeded 831 test cases (10%) had incorrect layout 3 test cases (<1%) crashed Layout tests result - original 37424 revision (with default -O2): 531.12s total testing time 7272 test cases (89%) succeeded 836 test cases (10%) had incorrect layout 3 test cases (<1%) crashed 94733 2 24230 ossy 2008-10-09 05:44:13 -0700 Created attachment 24230 proposed patch 94744 3 alp 2008-10-09 09:25:30 -0700 (In reply to comment #2) > Created an attachment (id=24230) [edit] > proposed patch > It's incorrect to build WebCore with -O3 I believe (only JavaScriptCore should be -03). 94865 4 ossy 2008-10-10 00:50:06 -0700 (In reply to comment #3) > It's incorrect to build WebCore with -O3 I believe (only JavaScriptCore should > be -03). Why is it incorrect? Does building WebCore with -O3 cause any problem? It seems to work fine (and faster) here with -O3. Maybe on other platforms have a problem with -O3. A little code size growth can be bad for embedded systems, but not for PC's. 96078 5 hausmann 2008-10-21 05:52:47 -0700 I agree with Alp here, only JavaScriptCore should be build with O3. Can you patch JavaScriptCore/JavaScriptCore.pri instead? 96728 6 ossy 2008-10-27 02:23:31 -0700 (In reply to comment #5) I will create patch for ToT and measure its speedup soon. 96731 7 ossy 2008-10-27 03:32:57 -0700 I've created new patch for JavaScriptCore/JavaScriptCore.pri at r37894. runtime and code size of JSC: - 2.02% speedup on SunSpider (+/-0.8%) - 1.10% speedup on V8 (+/-0.7%) - 3.45% speedup on WindScorpion (+/-1.1%) - Code size of JSC .text section increased by 9.70% 96732 8 24686 ossy 2008-10-27 03:35:52 -0700 Created attachment 24686 proposed patch 98610 9 ossy 2008-11-13 05:52:47 -0800 new results for r38367: - 1.41% speedup on SunSpider (+/-0.5%) - 0.12% speedup on V8 (+/-0.3%) - not significant - 6.33% speedup on WindScorpion (+/-0.3%) - Code size of JSC .text section increased by 9.70% There isn't activity a long time. Is anybody interested in landing this patch? 98801 10 24686 hausmann 2008-11-14 10:50:31 -0800 Comment on attachment 24686 proposed patch Looks good. I'll also add -fstrict-aliasing when landing like we do in WebCore/WebCore.pro, so that we are on the safe side. 98802 11 hausmann 2008-11-14 10:53:18 -0800 Nevermind the comment about aliasing, that was nonsense :-) Landed your patch in r38398. Thanks! 24230 2008-10-09 05:44:13 -0700 2008-10-27 03:35:52 -0700 proposed patch O3.patch text/plain 949 ossy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3NDQ1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAt MDkgIENzYWJhIE9zenRyb2dvbmFjIDxvc3ppQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTUwMAorCQorICAgICAgICAzLjUxJSBzcGVlZHVwIG9uIFN1 blNwaWRlciAoUXQtcG9ydCBvbiBMaW51eCkKKyAgICAgICAgMS4zMCUgc3BlZWR1cCBvbiBWOCAo UXQtcG9ydCBvbiBMaW51eCkKKworICAgICAgICA3LjgxJSBzcGVlZHVwIG9uIGxheW91dCB0ZXN0 cworCisgICAgICAgICogV2ViS2l0LnByaTogYnVpbGRpbmcgd2l0aCAtTzMgaW5zdGVhZCBvZiAt TzIgKGdjYykKKwogMjAwOC0xMC0wNyAgQWxwIFRva2VyICA8YWxwQG51YW50aS5jb20+CiAKICAg ICAgICAgR1RLKyBidWlsZCBmaXggZm9yIG9sZGVyIGF1dG9tYWtlIHZlcnNpb25zICgxLjcpLiBE aXNjdXNzZWQgaW4gYnVnCkluZGV4OiBXZWJLaXQucHJpCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC5w cmkJKHJldmlzaW9uIDM3NDI0KQorKysgV2ViS2l0LnByaQkod29ya2luZyBjb3B5KQpAQCAtODcs MyArODcsNSBAQCBkZWZpbmVUZXN0KGFkZEV4dHJhQ29tcGlsZXJXaXRoSGVhZGVyKSB7CiAgICAg cmV0dXJuKHRydWUpCiB9CiAKKyotZysrKjpRTUFLRV9DWFhGTEFHU19SRUxFQVNFIC09IC1PMgor Ki1nKysqOlFNQUtFX0NYWEZMQUdTX1JFTEVBU0UgKz0gLU8zCg== 24686 2008-10-27 03:35:52 -0700 2008-11-14 10:50:31 -0800 proposed patch O3.patch text/plain 1133 ossy SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM3ODk2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAtMjcgIENzYWJhIE9z enRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTUwMD4KKwkKKwlKYXZhU2NyaXB0Q29yZSBidWlsZCB3aXRoIC1PMyBmbGFn IGluc3RlYWQgb2YgLU8yIChnY2MpLgorCTIuMDIlIHNwZWVkdXAgb24gU3VuU3BpZGVyIChRdC1w b3J0IG9uIExpbnV4KQorCTEuMTAlIHNwZWVkdXAgb24gVjggKFF0LXBvcnQgb24gTGludXgpCisJ My40NSUgc3BlZWR1cCBvbiBXaW5kU2NvcnBpb24gKFF0LXBvcnQgb24gTGludXgpCisKKyAgICAg ICAgKiBKYXZhU2NyaXB0Q29yZS5wcmk6CisKIDIwMDgtMTAtMjUgIEdlb2ZmcmV5IEdhcmVuICA8 Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv SmF2YVNjcmlwdENvcmUucHJpCShyZXZpc2lvbiAzNzg5NikKKysrIEphdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLnByaQkod29ya2luZyBjb3B5KQpAQCAtMTcyLDMgKzE3Miw2IEBAIGtqc2Jp c29uLnZhcmlhYmxlX291dCA9IEdFTkVSQVRFRF9TT1VSQ0UKIGtqc2Jpc29uLmRlcGVuZGVuY3lf dHlwZSA9IFRZUEVfQwoga2pzYmlzb24uQ09ORklHID0gdGFyZ2V0X3ByZWRlcHMKIGFkZEV4dHJh Q29tcGlsZXJXaXRoSGVhZGVyKGtqc2Jpc29uKQorCisqLWcrKyo6UU1BS0VfQ1hYRkxBR1NfUkVM RUFTRSAtPSAtTzIKKyotZysrKjpRTUFLRV9DWFhGTEFHU19SRUxFQVNFICs9IC1PMwo=