214998 2020-07-30 17:20:50 -0700 [webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS 2020-07-31 09:10:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214378 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ews-watchlist webkit-bug-importer oldest_to_newest 1676653 0 jbedard 2020-07-30 17:20:50 -0700 At the moment, changes to webkitcorepy do not trigger webkitpy EWS, and they should. 1676655 1 webkit-bug-importer 2020-07-30 17:21:41 -0700 <rdar://problem/66355658> 1676657 2 405641 jbedard 2020-07-30 17:24:46 -0700 Created attachment 405641 Patch 1676806 3 aakash_jain 2020-07-31 06:51:57 -0700 r+ with the unit-test fixed. 1676829 4 405695 jbedard 2020-07-31 08:40:45 -0700 Created attachment 405695 Patch 1676839 5 ews-feeder 2020-07-31 09:10:07 -0700 Committed r265143: <https://trac.webkit.org/changeset/265143> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405695. 405641 2020-07-30 17:24:46 -0700 2020-07-31 08:40:44 -0700 Patch bug-214998-20200730172446.patch text/plain 2760 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTEyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTA3LTMwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBDaGFuZ2VzIHRvIFRvb2xzL1NjcmlwdHMvbGli cmFyaWVzIHNob3VsZCB0cmlnZ2VyIEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE0OTk4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NjM1NTY1 OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENoZWNrUGF0Y2hS ZWxldmFuY2UpOiBBZGQgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMuCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OgorICAgICAgICAoVGVzdENo ZWNrUGF0Y2hSZWxldmFuY2UudGVzdF9yZWxldmFudF93ZWJraXRweV9wYXRjaCk6CisgICAgICAg IChUZXN0Q2hlY2tQYXRjaFJlbGV2YW5jZS50ZXN0X3JlbGV2YW50X2xpYnJhcmllc19wYXRjaCk6 CisKIDIwMjAtMDctMzAgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWJHTF0gU2FmYXJpIHNuYXBzaG90cyBvZiBXZWJHTCBjb250ZW50IGluIHRoZSB0YWIgcGlj a2VyIGRvbid0IHdvcmsKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHkJKHJldmlzaW9uIDI2NTExOSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMjk4LDYgKzI5OCw3IEBAIGNsYXNz IENoZWNrUGF0Y2hSZWxldmFuY2UoYnVpbGRzdGVwLkJ1aWwKIAogICAgIHdlYmtpdHB5X3BhdGhz ID0gWwogICAgICAgICAnVG9vbHMvU2NyaXB0cy93ZWJraXRweS8nLAorICAgICAgICAnVG9vbHMv U2NyaXB0cy9saWJyYXJpZXMvJywKICAgICBdCiAKICAgICBncm91cF90b19wYXRoc19tYXBwaW5n ID0gewpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0 ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjY1MTE5KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMzA0 LDYgKzIzMDQsMjAgQEAgY2xhc3MgVGVzdENoZWNrUGF0Y2hSZWxldmFuY2UoQnVpbGRTdGVwTQog ICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0n UGF0Y2ggY29udGFpbnMgcmVsZXZhbnQgY2hhbmdlcycpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1 blN0ZXAoKQogCisgICAgZGVmIHRlc3RfcmVsZXZhbnRfd2Via2l0cHlfcGF0Y2goc2VsZik6Cisg ICAgICAgIENoZWNrUGF0Y2hSZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2FtcGxl IHBhdGNoOyBmaWxlOiBUb29scy9TY3JpcHRzL3dlYmtpdHB5JworICAgICAgICBzZWxmLnNldHVw U3RlcChDaGVja1BhdGNoUmVsZXZhbmNlKCkpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1 aWxkZXJuYW1lJywgJ1dlYktpdFB5LVRlc3RzLUVXUycpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0 Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXRjaCBjb250YWlucyByZWxldmFu dCBjaGFuZ2VzJykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisKKyAgICBkZWYgdGVz dF9yZWxldmFudF9saWJyYXJpZXNfcGF0Y2goc2VsZik6CisgICAgICAgIENoZWNrUGF0Y2hSZWxl dmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2FtcGxlIHBhdGNoOyBmaWxlOiBUb29scy9T Y3JpcHRzL2xpYnJhcmllcycKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoQ2hlY2tQYXRjaFJlbGV2 YW5jZSgpKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdXZWJLaXRQ eS1UZXN0cy1FV1MnKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1Ms IHN0YXRlX3N0cmluZz0nUGF0Y2ggY29udGFpbnMgcmVsZXZhbnQgY2hhbmdlcycpCisgICAgICAg IHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCiAgICAgZGVmIHRlc3RfcXVldWVzX3dpdGhvdXRfcmVs ZXZhbmNlX2luZm8oc2VsZik6CiAgICAgICAgIENoZWNrUGF0Y2hSZWxldmFuY2UuX2dldF9wYXRj aCA9IGxhbWJkYSB4OiAnU2FtcGxlIHBhdGNoJwogICAgICAgICBxdWV1ZXMgPSBbJ0NvbW1pdC1R dWV1ZScsICdTdHlsZS1FV1MnLCAnQXBwbHktV2F0Y2hMaXN0LUVXUycsICdHVEstQnVpbGQtRVdT JywgJ0dUSy1XSzItVGVzdHMtRVdTJywK 405695 2020-07-31 08:40:45 -0700 2020-07-31 09:10:08 -0700 Patch bug-214998-20200731084045.patch text/plain 2800 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTEzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTA3LTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBDaGFuZ2VzIHRvIFRvb2xzL1NjcmlwdHMvbGli cmFyaWVzIHNob3VsZCB0cmlnZ2VyIEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE0OTk4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NjM1NTY1 OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAgICAgKENoZWNrUGF0Y2hS ZWxldmFuY2UpOiBBZGQgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMuCisgICAgICAgICogQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OgorICAgICAgICAoVGVzdENo ZWNrUGF0Y2hSZWxldmFuY2UudGVzdF9yZWxldmFudF93ZWJraXRweV9wYXRjaCk6CisgICAgICAg IChUZXN0Q2hlY2tQYXRjaFJlbGV2YW5jZS50ZXN0X3JlbGV2YW50X2xpYnJhcmllc19wYXRjaCk6 CisKIDIwMjAtMDctMzAgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAg ICAgICAgIFt3ZWJraXRjb3JlcHldIEFkZCBhbiBhdXRvLWluc3RhbGxlciAoVW5yZXZpZXdlZCBm b2xsb3ctdXAgZml4KQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0 ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwcy5weQkocmV2aXNpb24gMjY1MTM5KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOTcsNyArMjk3LDggQEAgY2xhc3Mg Q2hlY2tQYXRjaFJlbGV2YW5jZShidWlsZHN0ZXAuQnVpbAogICAgIF0KIAogICAgIHdlYmtpdHB5 X3BhdGhzID0gWwotICAgICAgICAnVG9vbHMvU2NyaXB0cy93ZWJraXRweS8nLAorICAgICAgICAn VG9vbHMvU2NyaXB0cy93ZWJraXRweScsCisgICAgICAgICdUb29scy9TY3JpcHRzL2xpYnJhcmll cycsCiAgICAgXQogCiAgICAgZ3JvdXBfdG9fcGF0aHNfbWFwcGluZyA9IHsKSW5kZXg6IFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJ KHJldmlzaW9uIDI2NTEzOSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjMwNCw2ICsyMzA0LDIwIEBAIGNs YXNzIFRlc3RDaGVja1BhdGNoUmVsZXZhbmNlKEJ1aWxkU3RlcE0KICAgICAgICAgc2VsZi5leHBl Y3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1BhdGNoIGNvbnRhaW5zIHJl bGV2YW50IGNoYW5nZXMnKQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAorICAgIGRl ZiB0ZXN0X3JlbGV2YW50X3dlYmtpdHB5X3BhdGNoKHNlbGYpOgorICAgICAgICBDaGVja1BhdGNo UmVsZXZhbmNlLl9nZXRfcGF0Y2ggPSBsYW1iZGEgeDogJ1NhbXBsZSBwYXRjaDsgZmlsZTogVG9v bHMvU2NyaXB0cy93ZWJraXRweScKKyAgICAgICAgc2VsZi5zZXR1cFN0ZXAoQ2hlY2tQYXRjaFJl bGV2YW5jZSgpKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdXZWJL aXRQeS1UZXN0cy1FV1MnKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NF U1MsIHN0YXRlX3N0cmluZz0nUGF0Y2ggY29udGFpbnMgcmVsZXZhbnQgY2hhbmdlcycpCisgICAg ICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCisgICAgZGVmIHRlc3RfcmVsZXZhbnRfbGlicmFy aWVzX3BhdGNoKHNlbGYpOgorICAgICAgICBDaGVja1BhdGNoUmVsZXZhbmNlLl9nZXRfcGF0Y2gg PSBsYW1iZGEgeDogJ1NhbXBsZSBwYXRjaDsgZmlsZTogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMn CisgICAgICAgIHNlbGYuc2V0dXBTdGVwKENoZWNrUGF0Y2hSZWxldmFuY2UoKSkKKyAgICAgICAg c2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnV2ViS2l0UHktVGVzdHMtRVdTJykKKyAg ICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1Bh dGNoIGNvbnRhaW5zIHJlbGV2YW50IGNoYW5nZXMnKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5T dGVwKCkKKwogICAgIGRlZiB0ZXN0X3F1ZXVlc193aXRob3V0X3JlbGV2YW5jZV9pbmZvKHNlbGYp OgogICAgICAgICBDaGVja1BhdGNoUmVsZXZhbmNlLl9nZXRfcGF0Y2ggPSBsYW1iZGEgeDogJ1Nh bXBsZSBwYXRjaCcKICAgICAgICAgcXVldWVzID0gWydDb21taXQtUXVldWUnLCAnU3R5bGUtRVdT JywgJ0FwcGx5LVdhdGNoTGlzdC1FV1MnLCAnR1RLLUJ1aWxkLUVXUycsICdHVEstV0syLVRlc3Rz LUVXUycsCg==