<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214995</bug_id>
          
          <creation_ts>2020-07-30 16:14:55 -0700</creation_ts>
          <short_desc>Log a warning to the dev console when gamepads are accessed from an insecure context</short_desc>
          <delta_ts>2020-08-03 13:35:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=215099</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brady Eidson">beidson</reporter>
          <assigned_to name="Brady Eidson">beidson</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>mkwst</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1676616</commentid>
    <comment_count>0</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2020-07-30 16:14:55 -0700</bug_when>
    <thetext>Log a warning to the dev console when gamepads are accessed from an insecure context

This is to prep for the eventual restriction to secure contexts

https://github.com/w3c/gamepad/pull/120</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676957</commentid>
    <comment_count>1</comment_count>
      <attachid>405735</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2020-07-31 14:00:09 -0700</bug_when>
    <thetext>Created attachment 405735
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676959</commentid>
    <comment_count>2</comment_count>
      <attachid>405735</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-07-31 14:02:10 -0700</bug_when>
    <thetext>Comment on attachment 405735
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405735&amp;action=review

&gt; Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:80
&gt; +    RELEASE_ASSERT(domWindow);
&gt; +    auto* document = domWindow-&gt;document();
&gt; +    RELEASE_ASSERT(document);

These seem ... aggressive? Why not just bail?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676962</commentid>
    <comment_count>3</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2020-07-31 14:03:43 -0700</bug_when>
    <thetext>(In reply to Tim Horton from comment #2)
&gt; Comment on attachment 405735 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=405735&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:80
&gt; &gt; +    RELEASE_ASSERT(domWindow);
&gt; &gt; +    auto* document = domWindow-&gt;document();
&gt; &gt; +    RELEASE_ASSERT(document);
&gt; 
&gt; These seem ... aggressive? Why not just bail?

Yah, because the signature to return an actual array is a bummer.
I&apos;ll deal with it now sub optimally.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676964</commentid>
    <comment_count>4</comment_count>
      <attachid>405736</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2020-07-31 14:07:09 -0700</bug_when>
    <thetext>Created attachment 405736
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676992</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-07-31 15:14:10 -0700</bug_when>
    <thetext>Committed r265160: &lt;https://trac.webkit.org/changeset/265160&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405736.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676994</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-07-31 15:15:23 -0700</bug_when>
    <thetext>&lt;rdar://problem/66401022&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1677227</commentid>
    <comment_count>7</comment_count>
      <attachid>405736</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-08-02 12:28:16 -0700</bug_when>
    <thetext>Comment on attachment 405736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405736&amp;action=review

&gt; Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:86
&gt; +        static std::once_flag onceFlag;
&gt; +        std::call_once(onceFlag, [document] {

I noticed that lots of people use the thread-safe std::call_once in code that otherwise is not thread safe. I often ask them to use a boolean instead. Am I the baddie?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1677399</commentid>
    <comment_count>8</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-08-03 13:35:41 -0700</bug_when>
    <thetext>(In reply to EWS from comment #5)
&gt; Committed r265160: &lt;https://trac.webkit.org/changeset/265160&gt;
This introduced a broken test for windows: http/tests/misc/gamepads-insecure.html 

EWS also warned about this failure, tracked in Bug 215099.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405735</attachid>
            <date>2020-07-31 14:00:09 -0700</date>
            <delta_ts>2020-07-31 14:07:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214995-20200731140009.patch</filename>
            <type>text/plain</type>
            <size>4035</size>
            <attacher name="Brady Eidson">beidson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzJmM2U0MmUyZWU5NzUw
ODE3OTUzN2NjMzE3NDlmMGUzYjJjMTdhZC4uZTcwNGMzMjMzNWZjMzgzYzE2Yzg1NDI1MjY4YWZk
ZDM4NGJjN2ZjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTMxICBCcmFk
eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBMb2cgYSB3YXJuaW5nIHRv
IHRoZSBkZXYgY29uc29sZSB3aGVuIGdhbWVwYWRzIGFyZSBhY2Nlc3NlZCBmcm9tIGFuIGluc2Vj
dXJlIGNvbnRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMTQ5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBUZXN0OiBodHRwL3Rlc3RzL21pc2MvZ2FtZXBhZHMtaW5zZWN1cmUuaHRtbAorCisgICAg
ICAgICogTW9kdWxlcy9nYW1lcGFkL05hdmlnYXRvckdhbWVwYWQuY3BwOgorICAgICAgICAoV2Vi
Q29yZTo6TmF2aWdhdG9yR2FtZXBhZDo6Z2V0R2FtZXBhZHMpOiBJbnNlY3VyZSBjb250ZXh0cyBz
aG91bGQgbG9nIHRoYXQgZ2V0R2FtZXBhZHMoKSB3aWxsCisgICAgICAgICAgYmUgZ29pbmcgYXdh
eSBpbiBhIGZ1dHVyZSByZWxlYXNlLiBKdXN0IGRvIGl0IG9uY2UsIGJlY2F1c2UgZ2V0R2FtZXBh
ZHMoKSBpcyBjYWxsZWQgZnJlcXVlbnRseS4KKwogMjAyMC0wNy0zMSAgQ2FybG9zIEdhcmNpYSBD
YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gTW91c2Ugd2hlZWwg
ZXZlbnRzIG9uIGhvcml6b250YWwgc2Nyb2xsYmFyIG5vdCBjb3JyZWN0bHkgaGFuZGxlZCB3aGVu
IEFDIG1vZGUgaXMgZm9yY2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dh
bWVwYWQvTmF2aWdhdG9yR2FtZXBhZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVw
YWQvTmF2aWdhdG9yR2FtZXBhZC5jcHAKaW5kZXggODUwZDIyZGUyODViYjMzNWQyMmU4YzJlMjUz
YjdhYjZlMGM2MDM0Ni4uOWEyZDZiZTg4OWU3MGEzYTBmZTg0Yjc5NmIxZWMwYTYyNWIyZTc0MCAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nYW1lcGFkL05hdmlnYXRvckdhbWVw
YWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2FtZXBhZC9OYXZpZ2F0b3JHYW1l
cGFkLmNwcApAQCAtMjgsNiArMjgsNyBAQAogCiAjaWYgRU5BQkxFKEdBTUVQQUQpCiAKKyNpbmNs
dWRlICJET01XaW5kb3cuaCIKICNpbmNsdWRlICJHYW1lcGFkLmgiCiAjaW5jbHVkZSAiR2FtZXBh
ZE1hbmFnZXIuaCIKICNpbmNsdWRlICJHYW1lcGFkUHJvdmlkZXIuaCIKQEAgLTczLDYgKzc0LDIw
IEBAIFJlZjxHYW1lcGFkPiBOYXZpZ2F0b3JHYW1lcGFkOjpnYW1lcGFkRnJvbVBsYXRmb3JtR2Ft
ZXBhZChQbGF0Zm9ybUdhbWVwYWQmIHBsYXRmCiAKIGNvbnN0IFZlY3RvcjxSZWZQdHI8R2FtZXBh
ZD4+JiBOYXZpZ2F0b3JHYW1lcGFkOjpnZXRHYW1lcGFkcyhOYXZpZ2F0b3ImIG5hdmlnYXRvcikK
IHsKKyAgICBhdXRvKiBkb21XaW5kb3cgPSBuYXZpZ2F0b3Iud2luZG93KCk7CisgICAgUkVMRUFT
RV9BU1NFUlQoZG9tV2luZG93KTsKKyAgICBhdXRvKiBkb2N1bWVudCA9IGRvbVdpbmRvdy0+ZG9j
dW1lbnQoKTsKKyAgICBSRUxFQVNFX0FTU0VSVChkb2N1bWVudCk7CisKKyAgICBpZiAoIWRvY3Vt
ZW50LT5pc1NlY3VyZUNvbnRleHQoKSkgeworICAgICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcg
b25jZUZsYWc7CisgICAgICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2VGbGFnLCBbZG9jdW1lbnRdIHsK
KyAgICAgICAgICAgIGRvY3VtZW50LT5hZGRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlOjpT
ZWN1cml0eSwgTWVzc2FnZUxldmVsOjpXYXJuaW5nLCAiTmF2aWdhdG9yLmdldEdhbWVwYWRzKCkg
d2lsbCBiZSByZW1vdmVkIGZyb20gaW5zZWN1cmUgY29udGV4dHMgaW4gYSBmdXR1cmUgcmVsZWFz
ZSJfcyk7CisgICAgICAgIH0pOworCisgICAgfQorCisKICAgICByZXR1cm4gTmF2aWdhdG9yR2Ft
ZXBhZDo6ZnJvbSgmbmF2aWdhdG9yKS0+Z2FtZXBhZHMoKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDIxM2NhNmUx
OWI3MWRjOWY3ZjVhMTA5NmIyMmQxMjQ4ZDY5YjRkYjQuLmVlZGY1YjRhYzExZmIyZjY4ZDBlMzQ3
YmU2MDUwYmMxZDVhNmI1NzcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg
Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNy0zMSAgQnJh
ZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTG9nIGEgd2FybmluZyB0
byB0aGUgZGV2IGNvbnNvbGUgd2hlbiBnYW1lcGFkcyBhcmUgYWNjZXNzZWQgZnJvbSBhbiBpbnNl
Y3VyZSBjb250ZXh0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0OTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgKiBodHRwL3Rlc3RzL21pc2MvZ2FtZXBhZHMtaW5zZWN1cmUtZXhwZWN0ZWQudHh0OiBB
ZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2MvZ2FtZXBhZHMtaW5zZWN1cmUuaHRtbDog
QWRkZWQuCisKIDIwMjAtMDctMzAgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAK
ICAgICAgICAgW0dUS11bV1BFXSBHYXJkZW4gdGhyZWUgcGVyc2lzdGVudCBmYWlsdXJlcyBmcm9t
IGd0ayByZWxlYXNlIGJvdC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlz
Yy9nYW1lcGFkcy1pbnNlY3VyZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3Rz
L21pc2MvZ2FtZXBhZHMtaW5zZWN1cmUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0
CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA5N2RmM2Ji
M2MwODhjZDI3MzQ5ZjVmYTEwNmU2MzY1YmJjMzVjZGQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv
dXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZ2FtZXBhZHMtaW5zZWN1cmUtZXhwZWN0ZWQudHh0CkBA
IC0wLDAgKzEsMiBAQAorQ09OU09MRSBNRVNTQUdFOiBOYXZpZ2F0b3IuZ2V0R2FtZXBhZHMoKSB3
aWxsIGJlIHJlbW92ZWQgZnJvbSBpbnNlY3VyZSBjb250ZXh0cyBpbiBhIGZ1dHVyZSByZWxlYXNl
CitUZXN0IHRoYXQgYWNjZXNzaW5nIG5hdmlnYXRvci5nZXRHYW1lcGFkcyBmcm9tIGFuIGluc2Vj
dXJlIGNvbnRleHQgbG9ncyBhIHdhcm5pbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAv
dGVzdHMvbWlzYy9nYW1lcGFkcy1pbnNlY3VyZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0
cy9taXNjL2dhbWVwYWRzLWluc2VjdXJlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMWQ0YWY0YzdjZWU3YzMz
ZWE2NDc1MjE4ZTY5OGQzMjBjZGIzMjkzNgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz
L2h0dHAvdGVzdHMvbWlzYy9nYW1lcGFkcy1pbnNlY3VyZS5odG1sCkBAIC0wLDAgKzEsMTEgQEAK
Kzxib2R5PgorPHA+VGVzdCB0aGF0IGFjY2Vzc2luZyBuYXZpZ2F0b3IuZ2V0R2FtZXBhZHMgZnJv
bSBhbiBpbnNlY3VyZSBjb250ZXh0IGxvZ3MgYSB3YXJuaW5nPC9wPgorPHNjcmlwdD4KK2lmICh3
aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKK2lmICh3aW5k
b3cuaW50ZXJuYWxzKQorICAgIGludGVybmFscy5tYXJrQ29udGV4dEFzSW5zZWN1cmUoKTsKKwor
bmF2aWdhdG9yLmdldEdhbWVwYWRzKCk7Cis8L3NjcmlwdD4KKzwvYm9keT4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405736</attachid>
            <date>2020-07-31 14:07:09 -0700</date>
            <delta_ts>2020-07-31 15:14:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214995-20200731140709.patch</filename>
            <type>text/plain</type>
            <size>4119</size>
            <attacher name="Brady Eidson">beidson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzJmM2U0MmUyZWU5NzUw
ODE3OTUzN2NjMzE3NDlmMGUzYjJjMTdhZC4uYmNhZjY0YjNkZWZlZGNhYWNlMjRmMTE1N2MxMzg5
ZmY5MGNhYmRkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTMxICBCcmFk
eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBMb2cgYSB3YXJuaW5nIHRv
IHRoZSBkZXYgY29uc29sZSB3aGVuIGdhbWVwYWRzIGFyZSBhY2Nlc3NlZCBmcm9tIGFuIGluc2Vj
dXJlIGNvbnRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMTQ5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAg
IFRlc3Q6IGh0dHAvdGVzdHMvbWlzYy9nYW1lcGFkcy1pbnNlY3VyZS5odG1sCisKKyAgICAgICAg
KiBNb2R1bGVzL2dhbWVwYWQvTmF2aWdhdG9yR2FtZXBhZC5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpOYXZpZ2F0b3JHYW1lcGFkOjpnZXRHYW1lcGFkcyk6IEluc2VjdXJlIGNvbnRleHRzIHNob3Vs
ZCBsb2cgdGhhdCBnZXRHYW1lcGFkcygpIHdpbGwKKyAgICAgICAgICBiZSBnb2luZyBhd2F5IGlu
IGEgZnV0dXJlIHJlbGVhc2UuIEp1c3QgZG8gaXQgb25jZSwgYmVjYXVzZSBnZXRHYW1lcGFkcygp
IGlzIGNhbGxlZCBmcmVxdWVudGx5LgorCiAyMDIwLTA3LTMxICBDYXJsb3MgR2FyY2lhIENhbXBv
cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBNb3VzZSB3aGVlbCBldmVu
dHMgb24gaG9yaXpvbnRhbCBzY3JvbGxiYXIgbm90IGNvcnJlY3RseSBoYW5kbGVkIHdoZW4gQUMg
bW9kZSBpcyBmb3JjZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2FtZXBh
ZC9OYXZpZ2F0b3JHYW1lcGFkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2FtZXBhZC9O
YXZpZ2F0b3JHYW1lcGFkLmNwcAppbmRleCA4NTBkMjJkZTI4NWJiMzM1ZDIyZThjMmUyNTNiN2Fi
NmUwYzYwMzQ2Li43ODFmMTZmNjgwMjYwZTMwMmVhOTY4MGE1OWNkM2FmZWQ5NDE4NTcwIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvTmF2aWdhdG9yR2FtZXBhZC5j
cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nYW1lcGFkL05hdmlnYXRvckdhbWVwYWQu
Y3BwCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpZiBFTkFCTEUoR0FNRVBBRCkKIAorI2luY2x1ZGUg
IkRPTVdpbmRvdy5oIgogI2luY2x1ZGUgIkdhbWVwYWQuaCIKICNpbmNsdWRlICJHYW1lcGFkTWFu
YWdlci5oIgogI2luY2x1ZGUgIkdhbWVwYWRQcm92aWRlci5oIgpAQCAtNzMsNiArNzQsMjEgQEAg
UmVmPEdhbWVwYWQ+IE5hdmlnYXRvckdhbWVwYWQ6OmdhbWVwYWRGcm9tUGxhdGZvcm1HYW1lcGFk
KFBsYXRmb3JtR2FtZXBhZCYgcGxhdGYKIAogY29uc3QgVmVjdG9yPFJlZlB0cjxHYW1lcGFkPj4m
IE5hdmlnYXRvckdhbWVwYWQ6OmdldEdhbWVwYWRzKE5hdmlnYXRvciYgbmF2aWdhdG9yKQogewor
ICAgIGF1dG8qIGRvbVdpbmRvdyA9IG5hdmlnYXRvci53aW5kb3coKTsKKyAgICBEb2N1bWVudCog
ZG9jdW1lbnQgPSBkb21XaW5kb3cgPyBkb21XaW5kb3ctPmRvY3VtZW50KCkgOiBudWxscHRyOwor
ICAgIGlmICghZG9jdW1lbnQpIHsKKyAgICAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFZlY3Rv
cjxSZWZQdHI8R2FtZXBhZD4+PiBlbXB0eUdhbWVwYWRzOworICAgICAgICByZXR1cm4gZW1wdHlH
YW1lcGFkczsKKyAgICB9CisKKyAgICBpZiAoIWRvY3VtZW50LT5pc1NlY3VyZUNvbnRleHQoKSkg
eworICAgICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZUZsYWc7CisgICAgICAgIHN0ZDo6
Y2FsbF9vbmNlKG9uY2VGbGFnLCBbZG9jdW1lbnRdIHsKKyAgICAgICAgICAgIGRvY3VtZW50LT5h
ZGRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlOjpTZWN1cml0eSwgTWVzc2FnZUxldmVsOjpX
YXJuaW5nLCAiTmF2aWdhdG9yLmdldEdhbWVwYWRzKCkgd2lsbCBiZSByZW1vdmVkIGZyb20gaW5z
ZWN1cmUgY29udGV4dHMgaW4gYSBmdXR1cmUgcmVsZWFzZSJfcyk7CisgICAgICAgIH0pOworCisg
ICAgfQorCiAgICAgcmV0dXJuIE5hdmlnYXRvckdhbWVwYWQ6OmZyb20oJm5hdmlnYXRvciktPmdh
bWVwYWRzKCk7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91
dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyMTNjYTZlMTliNzFkYzlmN2Y1YTEwOTZiMjJkMTI0OGQ2
OWI0ZGI0Li44NGRjMGMwOTIzZmEwODU0MDBiMmIyODdkZDczNWI5OTA4Nzg3Y2JhIDEwMDY0NAot
LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu
Y29tPgorCisgICAgICAgIExvZyBhIHdhcm5pbmcgdG8gdGhlIGRldiBjb25zb2xlIHdoZW4gZ2Ft
ZXBhZHMgYXJlIGFjY2Vzc2VkIGZyb20gYW4gaW5zZWN1cmUgY29udGV4dC4KKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDk5NQorCisgICAgICAgIFJl
dmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2MvZ2FtZXBh
ZHMtaW5zZWN1cmUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21p
c2MvZ2FtZXBhZHMtaW5zZWN1cmUuaHRtbDogQWRkZWQuCisKIDIwMjAtMDctMzAgIExhdXJvIE1v
dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBHYXJkZW4gdGhy
ZWUgcGVyc2lzdGVudCBmYWlsdXJlcyBmcm9tIGd0ayByZWxlYXNlIGJvdC4KZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9nYW1lcGFkcy1pbnNlY3VyZS1leHBlY3RlZC50
eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZ2FtZXBhZHMtaW5zZWN1cmUtZXhwZWN0
ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAuLjA5N2RmM2JiM2MwODhjZDI3MzQ5ZjVmYTEwNmU2MzY1YmJjMzVj
ZGQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZ2FtZXBh
ZHMtaW5zZWN1cmUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorQ09OU09MRSBNRVNTQUdF
OiBOYXZpZ2F0b3IuZ2V0R2FtZXBhZHMoKSB3aWxsIGJlIHJlbW92ZWQgZnJvbSBpbnNlY3VyZSBj
b250ZXh0cyBpbiBhIGZ1dHVyZSByZWxlYXNlCitUZXN0IHRoYXQgYWNjZXNzaW5nIG5hdmlnYXRv
ci5nZXRHYW1lcGFkcyBmcm9tIGFuIGluc2VjdXJlIGNvbnRleHQgbG9ncyBhIHdhcm5pbmcKZGlm
ZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9nYW1lcGFkcy1pbnNlY3VyZS5o
dG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2dhbWVwYWRzLWluc2VjdXJlLmh0bWwK
bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMC4uMWQ0YWY0YzdjZWU3YzMzZWE2NDc1MjE4ZTY5OGQzMjBjZGIzMjkzNgotLS0g
L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9nYW1lcGFkcy1pbnNl
Y3VyZS5odG1sCkBAIC0wLDAgKzEsMTEgQEAKKzxib2R5PgorPHA+VGVzdCB0aGF0IGFjY2Vzc2lu
ZyBuYXZpZ2F0b3IuZ2V0R2FtZXBhZHMgZnJvbSBhbiBpbnNlY3VyZSBjb250ZXh0IGxvZ3MgYSB3
YXJuaW5nPC9wPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVu
bmVyLmR1bXBBc1RleHQoKTsKK2lmICh3aW5kb3cuaW50ZXJuYWxzKQorICAgIGludGVybmFscy5t
YXJrQ29udGV4dEFzSW5zZWN1cmUoKTsKKworbmF2aWdhdG9yLmdldEdhbWVwYWRzKCk7Cis8L3Nj
cmlwdD4KKzwvYm9keT4K
</data>

          </attachment>
      

    </bug>

</bugzilla>