214983 2020-07-30 12:57:19 -0700 webkitpy: If LC_ALL is set to a empty string, svn doesn't use the password store 2023-07-30 23:27:53 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=259640 InRadar P2 Normal --- 1 fujii fujii darin ddkilzer ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1676502 0 fujii 2020-07-30 12:57:19 -0700 If LC_ALL is set to a empty string, svn doesn't use the password store in my environment. I'm using svn with gpg-agent on Ubuntu 20.04 svn version 1.13.0 (r1867053) gpg-agent (GnuPG) 2.2.19 r101274 (Bug 68691) has set LC_ALL to a empty string. If I invoke 'svn ci' on terminal, svn askes gpg-agent my password as expected, but if I invoke 'LC_ALL= svn ci', svn askes my password by itself. 1676505 1 405601 fujii 2020-07-30 13:08:17 -0700 Created attachment 405601 Patch 1676532 2 405601 darin 2020-07-30 13:50:40 -0700 Comment on attachment 405601 Patch Looks great to me, but I am not sure why we had it set to empty string before. 1676671 3 fujii 2020-07-30 18:14:29 -0700 Committed r265124: <https://trac.webkit.org/changeset/265124> 1676674 4 webkit-bug-importer 2020-07-30 18:15:29 -0700 <rdar://problem/66357693> 1676676 5 fujii 2020-07-30 18:19:16 -0700 Thank you for the review. I don't know the reason. ios-wk2 testing EWS bot is sick today. Apple devs are working on <rdar://problem/58089873>. 405601 2020-07-30 13:08:17 -0700 2020-07-30 13:50:40 -0700 Patch bug-214983-20200731050815.patch text/plain 1908 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MDkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2ZlMGNhOTgxZTA3YWE1OTQ3ODdlZDQ1OTQ2ZTkzNTNj YTYxMmIwNC4uMjI2NGRlMTdhZTgzM2ZiNGU4MWY5NzY4ZGMyOWVlNjA5NzA4MDM1ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTA3LTMwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHdlYmtpdHB5OiBJZiBMQ19BTEwgaXMgc2V0IHRvIGEgZW1wdHkgc3RyaW5n LCBzdm4gZG9lc24ndCB1c2UgdGhlIHBhc3N3b3JkIHN0b3JlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5ODMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBMQ19BTEwgaXMgc2V0IHRvIGEgZW1wdHkg c3RyaW5nLCBzdm4gZG9lc24ndCB1c2UgdGhlIHBhc3N3b3JkCisgICAgICAgIHN0b3JlIGluIG15 IGVudmlyb25tZW50LiBJJ20gdXNpbmcgc3ZuIHdpdGggZ3BnLWFnZW50IG9uIFVidW50dQorICAg ICAgICAyMC4wNCAoc3ZuIHZlcnNpb24gMS4xMy4wLCBncGctYWdlbnQgMi4yLjE5KS4KKworICAg ICAgICByMTAxMjc0IChCdWcgNjg2OTEpIGhhcyBzZXQgTENfQUxMIHRvIGEgZW1wdHkgc3RyaW5n LgorCisgICAgICAgIElmIEkgaW52b2tlICdzdm4gY2knIG9uIG15IHRlcm1pbmFsLCBzdm4gYXNr ZXMgZ3BnLWFnZW50IG15CisgICAgICAgIHBhc3N3b3JkIGFzIGV4cGVjdGVkLCBidXQgaWYgSSBp bnZva2UgJ0xDX0FMTD0gc3ZuIGNpJywgc3ZuIGFza2VzCisgICAgICAgIG15IHBhc3N3b3JkIGJ5 IGl0c2VsZi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHk6Cisg ICAgICAgIChIb3N0Ll9lbmdhZ2VfYXdlc29tZV9sb2NhbGVfaGFja3MpOiBTZXQgdGhlIGVudiB2 YXIgTENfQUxMIHRvICdlbl9VUy5VVEYtOCcuCisKIDIwMjAtMDctMzAgIFRpbSBIb3J0b24gIDx0 aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIGNvbnRlbnQgZ2V0cyBzdHVj ayBpbiBhbiBpbmFjdGl2ZSBzdGF0ZSAobm8gY3Vyc29yIHVwZGF0ZXMgb3IgdGV4dCBpbnNlcnRp b24gY2FyZXQpIHdoZW4gYWN0aXZhdGluZyBhIHRhYiB3aXRoIGEgdGh1bWJuYWlsIHZpc2libGUK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9ob3N0LnB5CmluZGV4IDZmNjhjZjIyYTNlYjc3YWUz OTZiYWExN2YxNmJjYmEzMDgyYmVkZDkuLjU2Y2QwODM0YjRmYmVmZmZlOWQ4YTRmMzllYTdjZTZh OTE0MTM1ZjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2hvc3Qu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdC5weQpAQCAtODUsNyAr ODUsNyBAQCBjbGFzcyBIb3N0KFN5c3RlbUhvc3QpOgogICAgICAgICBvcy5lbnZpcm9uWydMQU5H VUFHRSddID0gJ2VuJwogICAgICAgICBvcy5lbnZpcm9uWydMQU5HJ10gPSAnZW5fVVMuVVRGLTgn CiAgICAgICAgIG9zLmVudmlyb25bJ0xDX01FU1NBR0VTJ10gPSAnZW5fVVMuVVRGLTgnCi0gICAg ICAgIG9zLmVudmlyb25bJ0xDX0FMTCddID0gJycKKyAgICAgICAgb3MuZW52aXJvblsnTENfQUxM J10gPSAnZW5fVVMuVVRGLTgnCiAKICAgICBkZWYgaW5pdGlhbGl6ZV9zY20oc2VsZiwgcGF0Y2hf ZGlyZWN0b3JpZXM9Tm9uZSk6CiAgICAgICAgIGRldGVjdG9yID0gU0NNRGV0ZWN0b3Ioc2VsZi5m aWxlc3lzdGVtLCBzZWxmLmV4ZWN1dGl2ZSkK