21497 2008-10-08 22:19:01 -0700 REGRESSION (r37433): Bytecode JSC tests are severely broken 2008-10-09 00:12:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Regression P2 Normal --- 1 zwarich zwarich darin oldest_to_newest 94699 0 zwarich 2008-10-08 22:19:01 -0700 There is a typo in r37433 that leads to a significant number of JSC test failures when using the bytecode interpreter. I can't finish running the tests without quitting and continuing the driver after each one. I unfortunately figured this out while spending a few hours reducing and chasing down bug 21459 in bytecode. 94700 1 24222 zwarich 2008-10-08 22:25:47 -0700 Created attachment 24222 Proposed patch 94701 2 24222 mjs 2008-10-08 22:26:27 -0700 Comment on attachment 24222 Proposed patch r=me 94702 3 zwarich 2008-10-08 22:31:03 -0700 Landed in r37441. 94709 4 darin 2008-10-09 00:12:22 -0700 Oops. Sorry. Thanks! 24222 2008-10-08 22:25:47 -0700 2008-10-08 22:26:27 -0700 Proposed patch bytecode.diff text/plain 1284 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3NDM5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAt MDggIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMTQ5NzogUkVHUkVTU0lPTiAo cjM3NDMzKTogQnl0ZWNvZGUgSlNDIHRlc3RzIGFyZSBzZXZlcmVseSBicm9rZW4KKyAgICAgICAg PGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5Nz4KKworICAgICAg ICBGaXggYSB0eXBvIGluIHIzNzQzMyB0aGF0IGNhdXNlcyB0aGUgZmFpbHVyZSBvZiBhIGxhcmdl IG51bWJlciBvZiBKU0MKKyAgICAgICAgdGVzdHMgd2l0aCB0aGUgYnl0ZWNvZGUgaW50ZXJwcmV0 ZXIgZW5hYmxlZC4KKworICAgICAgICAqIFZNL01hY2hpbmUuY3BwOgorICAgICAgICAoSlNDOjpN YWNoaW5lOjpwcml2YXRlRXhlY3V0ZSk6CisKIDIwMDgtMTAtMDggIE1hcmsgUm93ZSAgPG1yb3dl QGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeC4KSW5kZXg6IFZNL01hY2hp bmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFZNL01hY2hpbmUuY3BwCShyZXZpc2lvbiAzNzQzOSkKKysr IFZNL01hY2hpbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMzI5LDcgKzMzMjksNyBAQCBKU1Zh bHVlKiBNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZShFeGVjdXRpCiAgICAgICAgICAgICBKU1ZhbHVl KiByZXR1cm5WYWx1ZSA9IGNhbGxEYXRhLm5hdGl2ZS5mdW5jdGlvbihuZXdDYWxsRnJhbWUsIHN0 YXRpY19jYXN0PEpTRnVuY3Rpb24qPih2KSwgdGhpc1ZhbHVlLCBhcmdzKTsKICAgICAgICAgICAg IFZNX0NIRUNLX0VYQ0VQVElPTigpOwogCi0gICAgICAgICAgICBuZXdDYWxsRnJhbWVbZHN0XSA9 IHJldHVyblZhbHVlOworICAgICAgICAgICAgY2FsbEZyYW1lW2RzdF0gPSByZXR1cm5WYWx1ZTsK IAogICAgICAgICAgICAgaWYgKCplbmFibGVkUHJvZmlsZXJSZWZlcmVuY2UpCiAgICAgICAgICAg ICAgICAgKCplbmFibGVkUHJvZmlsZXJSZWZlcmVuY2UpLT5kaWRFeGVjdXRlKGNhbGxGcmFtZSwg c3RhdGljX2Nhc3Q8SlNGdW5jdGlvbio+KHYpKTsK