214963 2020-07-30 06:46:24 -0700 [JSC][32-bits] iterator_next should check for EmptyValue instead of undefined to execute LLInt fast path 2020-07-30 15:18:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214737 InRadar P2 Normal --- 1 ticaiolima ticaiolima darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1676360 0 ticaiolima 2020-07-30 06:46:24 -0700 ... 1676421 1 405581 ticaiolima 2020-07-30 09:53:11 -0700 Created attachment 405581 Patch 1676465 2 405581 ysuzuki 2020-07-30 11:24:55 -0700 Comment on attachment 405581 Patch r=me 1676582 3 405581 ticaiolima 2020-07-30 15:11:34 -0700 Comment on attachment 405581 Patch Thank you very much for the review! 1676583 4 ews-feeder 2020-07-30 15:17:16 -0700 Committed r265112: <https://trac.webkit.org/changeset/265112> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405581. 1676586 5 webkit-bug-importer 2020-07-30 15:18:16 -0700 <rdar://problem/66350251> 405581 2020-07-30 09:53:11 -0700 2020-07-30 15:17:16 -0700 Patch bug-214963-20200730135308.patch text/plain 3063 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MmFmZGYyNTRmOTZiOGY3YjFjZGRmMmE3M2UzZWM3MzJlNDFiMWNlLi5kZGMzZmJkN2VjYTYwMjBm ODEzMzAxZjdhY2NkNDY3NmZhYzczZjAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wNy0zMCAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0pTQ11bMzItYml0c10gaW50ZXJhdG9yX25leHQgc2hvdWxkIGNoZWNrIGZv ciBFbXB0eVZhbHVlIGluc3RlYWQgb2YgdW5kZWZpbmVkIHRvIGV4ZWN1dGUgTExJbnQgZmFzdCBw YXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5 NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVy ZSB3YXMgYSBidWcgaW4gcHJldmlvdXMgaW1wbGVtZW50YXRpb24gdGhhdCBhbGxvd3MgZXhlY3V0 aW9uIG9mCisgICAgICAgIGBpbnRlcmF0b3JfbmV4dGAgZmFzdCBwYXRoIGlmIHdlIHNldCBBcnJh eUl0ZXJhdG9yLnByb3RvdHlwZS5uZXh0IHRvCisgICAgICAgIDAuIFRoaXMgaGFwcGVuZWQgYmVj YXVzZSB3ZSB3ZXJlIG5vdCBwcm9wZXJseSBjaGVja2luZyBgVmFsdWVFbXB0eWAKKyAgICAgICAg ZnJvbSBgbV9uZXh0YC4gVGhpcyBwYXRjaCBpcyBmaXhpbmcgc3VjaCBpc3N1ZSBhbmQgZG9pbmcg dGhlIHByb3BlcgorICAgICAgICB2ZXJpZmljYXRpb24uCisKKyAgICAgICAgKiBsbGludC9Mb3dM ZXZlbEludGVycHJldGVyMzJfNjQuYXNtOgorCiAyMDIwLTA3LTI5ICBZdXN1a2UgU3V6dWtpICA8 eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gQWRkIEIzOjpCb3R0b21UdXBsZVZh bHVlIG5vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl bEludGVycHJldGVyMzJfNjQuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KaW5kZXggMjc1MDY5MGEyZmY4MDljMjQ2NjNjMDhmNWI2 ZDMyYWJlMzhiODg0My4uNDhmZTBkZDM1ZjgxNTBmM2Q3YTE3NzdjZDY5MWFkNWMwOWQ5YjFmOCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0 ZXIzMl82NC5hc20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50 ZXJwcmV0ZXIzMl82NC5hc20KQEAgLTI3NjksOCArMjc2OSw3IEBAIGVuZCkKIGxsaW50T3BXaXRo TWV0YWRhdGEob3BfaXRlcmF0b3JfbmV4dCwgT3BJdGVyYXRvck5leHQsIG1hY3JvIChzaXplLCBn ZXQsIGRpc3BhdGNoLCBtZXRhZGF0YSwgcmV0dXJuKQogICAgICAgICAKICAgICBsb2FkVmFyaWFi bGUoZ2V0LCBtX25leHQsIHQwLCB0MSwgdDApCi0gICAgYmllcSB0MSwgVW5kZWZpbmVkVGFnLCAu aXRlcmF0b3JOZXh0R2VuZXJpYwotICAgIGJ0aW56IHQwLCAuaXRlcmF0b3JOZXh0R2VuZXJpYwor ICAgIGJpbmVxIHQxLCBFbXB0eVZhbHVlVGFnLCAuaXRlcmF0b3JOZXh0R2VuZXJpYwogCiAgICAg bWFjcm8gZmFzdE5hcnJvdygpCiAgICAgICAgIGNhbGxTbG93UGF0aChfaXRlcmF0b3JfbmV4dF90 cnlfZmFzdF9uYXJyb3cpCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMv Q2hhbmdlTG9nCmluZGV4IDcyN2I3NDVhYTdhNWEwNTZkNDkzYmJhOTJlOWRhNmIzOTI3YzM4NTQu LjIzY2U1ZmU2ODUwNzBhZDExYzA2NTM2ZDlmNmIxNjVkMDAxN2VjYWEgMTAwNjQ0Ci0tLSBhL0pT VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMjAtMDctMzAgIENhaW8gTGltYSAgPHRpY2Fpb2xpbWFAZ21haWwuY29tPgorCisgICAgICAg IFtKU0NdWzMyLWJpdHNdIGludGVyYXRvcl9uZXh0IHNob3VsZCBjaGVjayBmb3IgRW1wdHlWYWx1 ZSBpbnN0ZWFkIG9mIHVuZGVmaW5lZCB0byBleGVjdXRlIExMSW50IGZhc3QgcGF0aAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0OTYzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvaW52YWxp ZGF0ZS1hcnJheS1pdGVyYXRvci1wcm90b3R5cGUtbmV4dC5qczogQWRkZWQuCisKIDIwMjAtMDct MjkgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCB1c2UgcmVxdWlyZU9wdGlvbnMKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2ludmFs aWRhdGUtYXJyYXktaXRlcmF0b3ItcHJvdG90eXBlLW5leHQuanMgYi9KU1Rlc3RzL3N0cmVzcy9p bnZhbGlkYXRlLWFycmF5LWl0ZXJhdG9yLXByb3RvdHlwZS1uZXh0LmpzCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMy MzY1YjdkYTlhYjQzN2IzOWMyZGEzYjgwOTU2YjFhZmU5MzgxYWUKLS0tIC9kZXYvbnVsbAorKysg Yi9KU1Rlc3RzL3N0cmVzcy9pbnZhbGlkYXRlLWFycmF5LWl0ZXJhdG9yLXByb3RvdHlwZS1uZXh0 LmpzCkBAIC0wLDAgKzEsMTMgQEAKK0FycmF5LnByb3RvdHlwZVtTeW1ib2wuaXRlcmF0b3JdKCku X19wcm90b19fLm5leHQgPSAwOworCitsZXQgYXJyID0gWzEsIDIsIDNdOworCit0cnkgeworICAg IGZvciAobGV0IGVsZSBvZiBhcnIpIHsKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJJdCBzaG91 bGQgbmV2ZXIgZXhlY3V0ZSIpOworICAgIH0KK30gY2F0Y2goZSkgeworICAgIGlmICghZSBpbnN0 YW5jZW9mIFR5cGVFcnJvcikKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJJdCBzaG91bGQgdGhy b3cgYSBUeXBlRXJyb3IsIGJ1dCBpdCB0aHJldyAiICsgZSk7Cit9CisK