214962 2020-07-30 02:54:47 -0700 Web content gets stuck in an inactive state (no cursor updates or text insertion caret) when activating a tab with a thumbnail visible 2020-07-30 11:25:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton adachan bdakin cdumez simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1676343 0 thorton 2020-07-30 02:54:47 -0700 Web content gets stuck in an inactive state (no cursor updates or text insertion caret) when activating a tab with a thumbnail visible 1676344 1 405560 thorton 2020-07-30 02:55:05 -0700 Created attachment 405560 Patch 1676345 2 thorton 2020-07-30 02:55:07 -0700 <rdar://problem/65670984> 1676376 3 405560 wenson_hsieh 2020-07-30 08:02:48 -0700 Comment on attachment 405560 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405560&action=review > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3859 > + m_page->activityStateDidChange(WebCore::ActivityState::allFlags()); Nit - is there value in being more specific than `allFlags()` here? 1676461 4 thorton 2020-07-30 11:20:19 -0700 (In reply to Wenson Hsieh from comment #3) > Comment on attachment 405560 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405560&action=review > > > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3859 > > + m_page->activityStateDidChange(WebCore::ActivityState::allFlags()); > > Nit - is there value in being more specific than `allFlags()` here? I don't think so. It's a minor perf hit, but 1) use of WKThumbnailView's window trickles indirectly into *most* of the flags, and 2) I don't want people to have to keep track of #1 in the future when adding new flags. 3) You're already flinging views around, so the perf hit of asking the view and window a few questions is almost certainly negligible. 1676462 5 thorton 2020-07-30 11:20:35 -0700 (We do diffing before doing anything more expensive) 1676467 6 ews-feeder 2020-07-30 11:25:52 -0700 Committed r265091: <https://trac.webkit.org/changeset/265091> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405560. 405560 2020-07-30 02:55:05 -0700 2020-07-30 11:25:53 -0700 Patch bug-214962-20200730025504.patch text/plain 14190 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0ODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTMxZmZjNDdmZGE0Mzhl NjQ2ZDMyNTdjMTJhNzk0MjMzZjJlYzRiZi4uNzljNDE0MThkZGJkZDVmNGY1NDllZjRlMDY0MzI4 ZWY4ZWQwZjRkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA3LTMwICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBjb250ZW50 IGdldHMgc3R1Y2sgaW4gYW4gaW5hY3RpdmUgc3RhdGUgKG5vIGN1cnNvciB1cGRhdGVzIG9yIHRl eHQgaW5zZXJ0aW9uIGNhcmV0KSB3aGVuIGFjdGl2YXRpbmcgYSB0YWIgd2l0aCBhIHRodW1ibmFp bCB2aXNpYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTQ5NjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1NjcwOTg0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyBBUEkgdGVzdDogV2ViS2l0 LldLVGh1bWJuYWlsVmlld1Jlc2V0c1ZpZXdTdGF0ZVdoZW5VbnBhcmVudGVkCisKKyAgICAgICAg KiB0ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6Omlz UGFnZUFjdGl2ZSBjb25zdCk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuaDoKKyAgICAg ICAgKiB0ZXN0aW5nL0ludGVybmFscy5pZGw6CisgICAgICAgIEFkZCBhICJ2aWV3IHdpbmRvdyBp cyBhY3RpdmUiIGdldHRlci4KKwogMjAyMC0wNy0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBzdGVwcygpIHRpbWluZyBmdW5jdGlvbiBvbiBhIHRy YW5zZm9ybSBhbmltYXRpb24gdHJpZ2dlcnMgYSByZW5kZXIgZXZlcnkgZnJhbWUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5k ZXggZDdkNDQzOTQ1ZDQ3ZTQ3OThkZDg1ZGZhMDY5MjQxZWE4ZDgwNTdiNS4uMmE0YmVmOTg0YTQx ZTQ1NjIzZDEyZDY3NzI1ZmZhYmIxNzk1YmY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMyBAQAor MjAyMC0wNy0zMCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgY29udGVudCBnZXRzIHN0dWNrIGluIGFuIGluYWN0aXZlIHN0YXRlIChubyBjdXJz b3IgdXBkYXRlcyBvciB0ZXh0IGluc2VydGlvbiBjYXJldCkgd2hlbiBhY3RpdmF0aW5nIGEgdGFi IHdpdGggYSB0aHVtYm5haWwgdmlzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE0OTYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NTY3MDk4 ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0lt cGw6OnNldFRodW1ibmFpbFZpZXcpOgorICAgICAgICBXaGVuIFdLVGh1bWJuYWlsVmlldyBpcyB1 bnBhcmVudGVkLCBpbnZhbGlkYXRlIGFsbCBhY3Rpdml0eSBzdGF0ZSBiaXRzLgorICAgICAgICBX ZSBkbyB0aGlzIGJlY2F1c2UgbWFueSBvZiB0aGUgZnVuY3Rpb25zIHRoYXQgY29tcHV0ZSBhY3Rp dml0eSBzdGF0ZSBiaXRzCisgICAgICAgIHVzZSB0aGUgV0tUaHVtYm5haWxWaWV3J3Mgd2luZG93 IHdoaWxlIGl0IGlzIHBhcmVudGVkLiBXaGVuIGl0IGlzIHVucGFyZW50ZWQsCisgICAgICAgIGFu ZCB3ZSBzd2l0Y2ggYmFjayB0byB1c2luZyB0aGUgV0tXZWJWaWV3J3Mgd2luZG93LCB3ZSBtdXN0 bid0IGdldCBzdHVjaworICAgICAgICB3aXRoIGFjdGl2aXR5IHN0YXRlIGJpdHMgZnJvbSBXS1Ro dW1ibmFpbFZpZXcncyB3aW5kb3cuCisKKyAgICAgICAgVGhpcyB3YXMgcGFydGljdWxhcmx5IHBy b2JsZW1hdGljIGluIHRoZSBjYXNlIG9mIHRoZSBXS1RodW1ibmFpbFZpZXdzCisgICAgICAgIHVz ZWQgZm9yIHRhYiBob3ZlciBwcmV2aWV3cywgYmVjYXVzZSB0aGF0IHdpbmRvdyBpcyBub3Qga2V5 LCBzbyB3ZSdkIGdldAorICAgICAgICBzdHVjayB3aXRoIHRoZSBpbmFjdGl2ZS13aW5kb3cgc3Rh dGUsIHJlc3VsdGluZyBpbiBhIGxhY2sgb2YgY3Vyc29yIHVwZGF0ZXMsCisgICAgICAgIGEgaGlk ZGVuIHRleHQgY2FyZXQsIHRoZSB3cm9uZyBzZWxlY3Rpb24gY29sb3IsIGV0Yy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGxNYWMubW06CisgICAgICAgIChXZWJLaXQ6 OlBhZ2VDbGllbnRJbXBsOjppc1ZpZXdXaW5kb3dBY3RpdmUpOgorICAgICAgICBXaGlsZSB3cml0 aW5nIHRoZSBBUEkgdGVzdCBmb3IgdGhpcywgSSBub3RpY2VkIHRoYXQgaXNWaWV3V2luZG93QWN0 aXZlCisgICAgICAgIHJldHVybnMgWUVTIGlmIHRoZXJlIGlzIG5vIGtleSB3aW5kb3cgQU5EIFdL V2ViVmlldyBpcyB1bnBhcmVudGVkCisgICAgICAgIChbTlNBcHAga2V5V2luZG93XSA9PSBhY3Rp dmVXaW5kb3coKSA9PSBuaWwpLgorICAgICAgICBUaGlzIHNlZW1zIGNvbXBsZXRlbHkgaW5zYW5l IChob3cgY2FuIHRoZSB3aW5kb3cgYmUgYWN0aXZlIGlmIGl0IGRvZXNuJ3QKKyAgICAgICAgZXhp c3Q/KSwgYW5kIGJyZWFrcyB0aGUgdGVzdCwgc28gZW5zdXJlIHRoYXQgd2Ugb25seSBzYXkgWUVT IGlmIHdlIGFjdHVhbGx5CisgICAgICAgIGhhdmUgYSB3aW5kb3cuCisKIDIwMjAtMDctMjQgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB1bmRlciBQcmVj b25uZWN0VGFzazo6c3RhcnQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9J bnRlcm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4 IDRkMmNiYmRmOWFjNzc2OWFiYmZjZGIwOWY1Y2VlMzI0ODE1NzJmNDEuLjg0MWE5MTc4YWYzNDUx OWI5YTAxYWM2MGNlYjk5NjhmOGNhNmYxYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFs cy5jcHAKQEAgLTUxNzEsNiArNTE3MSwxNSBAQCB2b2lkIEludGVybmFsczo6c2V0UGFnZUlzRm9j dXNlZEFuZEFjdGl2ZShib29sIGlzRm9jdXNlZEFuZEFjdGl2ZSkKICAgICBwYWdlLnNldEFjdGl2 aXR5U3RhdGUoc3RhdGUpOwogfQogCitib29sIEludGVybmFsczo6aXNQYWdlQWN0aXZlKCkgY29u c3QKK3sKKyAgICBhdXRvKiBkb2N1bWVudCA9IGNvbnRleHREb2N1bWVudCgpOworICAgIGlmICgh ZG9jdW1lbnQgfHwgIWRvY3VtZW50LT5wYWdlKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICBhdXRvJiBwYWdlID0gKmRvY3VtZW50LT5wYWdlKCk7CisgICAgcmV0dXJuIHBhZ2UuYWN0aXZp dHlTdGF0ZSgpLmNvbnRhaW5zKEFjdGl2aXR5U3RhdGU6OldpbmRvd0lzQWN0aXZlKTsKK30KKwog I2lmIEVOQUJMRShXRUJfUlRDKQogdm9pZCBJbnRlcm5hbHM6OnNldEgyNjRIYXJkd2FyZUVuY29k ZXJBbGxvd2VkKGJvb2wgYWxsb3dlZCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCmlu ZGV4IDk1OTI3MGY3NThmOWY5YjhlOGY0YmY1NDRjYzZlZGQxYjRhNWI5YjAuLjcwNDZjYjc5M2M0 MDU2MjA4ZDRkYmMyZmZhNDlmNzQxYzhkMWQ2ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bHMuaApAQCAtNzcyLDcgKzc3Miw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2V0UGFnZVZpc2li aWxpdHkoYm9vbCBpc1Zpc2libGUpOwogICAgIHZvaWQgc2V0UGFnZUlzRm9jdXNlZEFuZEFjdGl2 ZShib29sKTsKLQorICAgIGJvb2wgaXNQYWdlQWN0aXZlKCkgY29uc3Q7CiAKICNpZiBFTkFCTEUo V0VCX1JUQykKICAgICB2b2lkIHNldEgyNjRIYXJkd2FyZUVuY29kZXJBbGxvd2VkKGJvb2wgYWxs b3dlZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwg Yi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwKaW5kZXggMWY5ODAwOGNmODA5 NzYyZTY0ZjFhN2E1MGUwYzQ5MzU5M2Q2Nzk5MS4uNzQzM2NiNmMyZTkzYTIxNzljMjhjYjM2ZTBl NDY4MDYwZjIwOTc2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bHMuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbApAQCAtNzk2 LDYgKzc5Niw3IEBAIGVudW0gQ29udGVudFNpemVDYXRlZ29yeSB7CiAKICAgICB2b2lkIHNldFBh Z2VWaXNpYmlsaXR5KGJvb2xlYW4gaXNWaXNpYmxlKTsKICAgICB2b2lkIHNldFBhZ2VJc0ZvY3Vz ZWRBbmRBY3RpdmUoYm9vbGVhbiBpc0ZvY3VzZWQpOworICAgIGJvb2xlYW4gaXNQYWdlQWN0aXZl KCk7CiAKICAgICBbQ29uZGl0aW9uYWw9V0VCX1JUQ10gdm9pZCBzZXRIMjY0SGFyZHdhcmVFbmNv ZGVyQWxsb3dlZChib29sZWFuIGFsbG93ZWQpOwogICAgIFtDb25kaXRpb25hbD1XRUJfUlRDXSB2 b2lkIGFwcGx5Um90YXRpb25Gb3JPdXRnb2luZ1ZpZGVvU291cmNlcyhSVENQZWVyQ29ubmVjdGlv biBjb25uZWN0aW9uKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29h L1dlYlZpZXdJbXBsLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0lt cGwubW0KaW5kZXggYTRhMDM4M2M3N2NmMGRkNWRkN2I2YWJmMmU0ZGNiMzU1OTViZTNiYy4uMGY5 ZThmY2RlNWU1MTM3YjY4NzQ2ODYyMWVkNmY1YzU0ZDcyMGE1ZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0KKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0KQEAgLTM4NTQsOCArMzg1NCwxMCBAQCB2 b2lkIFdlYlZpZXdJbXBsOjpzZXRUaHVtYm5haWxWaWV3KF9XS1RodW1ibmFpbFZpZXcgKnRodW1i bmFpbFZpZXcpCiAKICAgICBpZiAodGh1bWJuYWlsVmlldykKICAgICAgICAgdXBkYXRlVGh1bWJu YWlsVmlld0xheWVyKCk7Ci0gICAgZWxzZQorICAgIGVsc2UgewogICAgICAgICBzZXRBY2NlbGVy YXRlZENvbXBvc2l0aW5nUm9vdExheWVyKG1fcm9vdExheWVyLmdldCgpKTsKKyAgICAgICAgbV9w YWdlLT5hY3Rpdml0eVN0YXRlRGlkQ2hhbmdlKFdlYkNvcmU6OkFjdGl2aXR5U3RhdGU6OmFsbEZs YWdzKCkpOworICAgIH0KIH0KIAogdm9pZCBXZWJWaWV3SW1wbDo6cmVwYXJlbnRMYXllclRyZWVJ blRodW1ibmFpbFZpZXcoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFj L1BhZ2VDbGllbnRJbXBsTWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1BhZ2VD bGllbnRJbXBsTWFjLm1tCmluZGV4IDM3MGIyZmM1NTYzYmRhMGYxZTdmYWMzNTExMWVmN2IzNjUz OTAwMjAuLjRkMzY4NzcxMGM5MjEyYjQ3NjRkZWVhNWVmNWVhY2EwNzgzZDVkYTQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbE1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGxNYWMubW0KQEAgLTE2 MCw3ICsxNjAsNyBAQCBib29sIFBhZ2VDbGllbnRJbXBsOjppc1ZpZXdXaW5kb3dBY3RpdmUoKQog ewogICAgIEFTU0VSVChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNv bW11bmljYXRlV2l0aFdpbmRvd1NlcnZlcikpOwogICAgIE5TV2luZG93ICphY3RpdmVWaWV3V2lu ZG93ID0gYWN0aXZlV2luZG93KCk7Ci0gICAgcmV0dXJuIGFjdGl2ZVZpZXdXaW5kb3cuaXNLZXlX aW5kb3cgfHwgW05TQXBwIGtleVdpbmRvd10gPT0gYWN0aXZlVmlld1dpbmRvdzsKKyAgICByZXR1 cm4gYWN0aXZlVmlld1dpbmRvdy5pc0tleVdpbmRvdyB8fCAoYWN0aXZlVmlld1dpbmRvdyAmJiBb TlNBcHAga2V5V2luZG93XSA9PSBhY3RpdmVWaWV3V2luZG93KTsKIH0KIAogYm9vbCBQYWdlQ2xp ZW50SW1wbDo6aXNWaWV3Rm9jdXNlZCgpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggYjdmY2ZjOTQ0MTlmN2RlYWVkMzFhMjU2MzVlM2UyYzMwZmNm ODFjNS4uNDU4NmFhNGNjYjkxZjllZDc5MDU2MjMzYjdiYThhYjhhNzhmOTYxOCAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBA CisyMDIwLTA3LTMwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisg ICAgICAgIFdlYiBjb250ZW50IGdldHMgc3R1Y2sgaW4gYW4gaW5hY3RpdmUgc3RhdGUgKG5vIGN1 cnNvciB1cGRhdGVzIG9yIHRleHQgaW5zZXJ0aW9uIGNhcmV0KSB3aGVuIGFjdGl2YXRpbmcgYSB0 YWIgd2l0aCBhIHRodW1ibmFpbCB2aXNpYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5NjIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1Njcw OTg0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvV0tUaHVtYm5haWxWaWV3Lm1tOgorICAgICAgICAo VGVzdFdlYktpdEFQSTo6VEVTVCk6CisgICAgICAgIEFkZCBhIHRlc3QgZW5zdXJpbmcgdGhhdCB3 ZSBnbyBiYWNrIHRvIHRoZSBhY3RpdmUtd2luZG93IHN0YXRlIGFmdGVyCisgICAgICAgIHVucGFy ZW50aW5nIGEgV0tUaHVtYm5haWxWaWV3IHRoYXQgd2FzIGluc3RhbGxlZCBpbiBhbiBpbmFjdGl2 ZSB3aW5kb3cuCisKKyAgICAgICAgKC1bV0tUaHVtYm5haWxWaWV3RGVsZWdhdGUgd2ViVmlldzpk aWRGaW5pc2hOYXZpZ2F0aW9uOl0pOiBEZWxldGVkLgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkv bWFjL09mZnNjcmVlbldpbmRvdy5oOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvbWFjL09mZnNj cmVlbldpbmRvdy5tbToKKyAgICAgICAgKC1bT2Zmc2NyZWVuV2luZG93IGluaXRXaXRoU2l6ZTpd KToKKyAgICAgICAgKC1bT2Zmc2NyZWVuV2luZG93IGluaXRXaXRoU2l6ZTppc0tleVdpbmRvdzpd KToKKyAgICAgICAgKC1bT2Zmc2NyZWVuV2luZG93IGlzS2V5V2luZG93XSk6CisKIDIwMjAtMDct MjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21l IGxvZ2dpbmcgdG8gZGVidWcgV2ViS2l0LlF1b3RhRGVsZWdhdGUgdGVzdCB0aGF0IHRpbWVzIG91 dCBvbiBhIERlYnVnIGJvdApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXQvV0tUaHVtYm5haWxWaWV3Lm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQvV0tUaHVtYm5haWxWaWV3Lm1tCmluZGV4IGUzYjYzYzUzODkwMDQ3ZGI2ZDY1N2RlMDAxMzM4 N2Y0YzRiOGFiYmEuLjM3N2ZiZWFhYTBjMjIzNmI2ZGM0MjY4MjRlYjJhOTVlNjgwNGJkMzcgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L1dLVGh1bWJuYWlsVmll dy5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9XS1RodW1ibmFpbFZp ZXcubW0KQEAgLTI4LDkgKzI4LDExIEBACiAjaWYgUExBVEZPUk0oTUFDKQogCiAjaW1wb3J0ICJK YXZhU2NyaXB0VGVzdC5oIgorI2ltcG9ydCAiT2Zmc2NyZWVuV2luZG93LmgiCiAjaW1wb3J0ICJQ bGF0Zm9ybVV0aWxpdGllcy5oIgogI2ltcG9ydCAiUGxhdGZvcm1XZWJWaWV3LmgiCiAjaW1wb3J0 ICJUZXN0V0tXZWJWaWV3LmgiCisjaW1wb3J0ICJXS1dlYlZpZXdDb25maWd1cmF0aW9uRXh0cmFz LmgiCiAjaW1wb3J0IDxXZWJLaXQvV0tWaWV3UHJpdmF0ZS5oPgogI2ltcG9ydCA8V2ViS2l0L19X S1RodW1ibmFpbFZpZXcuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KQEAgLTYxLDE5ICs2 Myw2IEBAIC0gKHZvaWQpb2JzZXJ2ZVZhbHVlRm9yS2V5UGF0aDooTlNTdHJpbmcgKilrZXlQYXRo IG9mT2JqZWN0OihpZClvYmplY3QgY2hhbmdlOihOCiAKIEBlbmQKIAotCi1AaW50ZXJmYWNlIFdL VGh1bWJuYWlsVmlld0RlbGVnYXRlIDogTlNPYmplY3QgPFdLTmF2aWdhdGlvbkRlbGVnYXRlPgot QGVuZAotCi1AaW1wbGVtZW50YXRpb24gV0tUaHVtYm5haWxWaWV3RGVsZWdhdGUKLQotLSAodm9p ZCl3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRpZEZpbmlzaE5hdmlnYXRpb246KFdLTmF2 aWdhdGlvbiAqKW5hdmlnYXRpb24KLXsKLSAgICBkaWRGaW5pc2hMb2FkID0gdHJ1ZTsKLX0KLQot QGVuZAotCiBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAKICNpZiBXS19IQVZFX0NfU1BJCkBA IC0xOTksMTAgKzE4OCw3IEBAIFRFU1QoV2ViS2l0LCBXS1RodW1ibmFpbFZpZXdLZWVwU25hcHNo b3RXaGVuUmVtb3ZlZEZyb21TdXBlcnZpZXdXS1dlYlZpZXcpCiB7CiAgICAgYXV0byB3ZWJWaWV3 ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFr ZSgwLCAwLCA4MDAsIDYwMCldKTsKICAgICBXS1BhZ2VTZXRDdXN0b21CYWNraW5nU2NhbGVGYWN0 b3IoW3dlYlZpZXcgX3BhZ2VGb3JUZXN0aW5nXSwgMSk7Ci0gICAgYXV0byBkZWxlZ2F0ZSA9IGFk b3B0TlMoW1tXS1RodW1ibmFpbFZpZXdEZWxlZ2F0ZSBhbGxvY10gaW5pdF0pOwotICAgIFt3ZWJW aWV3IHNldE5hdmlnYXRpb25EZWxlZ2F0ZTpkZWxlZ2F0ZS5nZXQoKV07Ci0gICAgW3dlYlZpZXcg IGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6W1tOU0J1bmRsZSBtYWlu QnVuZGxlXSBVUkxGb3JSZXNvdXJjZTpAImxvdHMtb2YtdGV4dCIgd2l0aEV4dGVuc2lvbjpAImh0 bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEkucmVzb3VyY2VzIl1dXTsKLSAgICBVdGls OjpydW4oJmRpZEZpbmlzaExvYWQpOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVz dFBhZ2VOYW1lZDpAImxvdHMtb2YtdGV4dCJdOwogCiAgICAgUmV0YWluUHRyPF9XS1RodW1ibmFp bFZpZXc+IHRodW1ibmFpbFZpZXcgPSBhZG9wdE5TKFtbX1dLVGh1bWJuYWlsVmlldyBhbGxvY10g aW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDEwMCwgMTAwKSBmcm9tV0tXZWJWaWV3Ondl YlZpZXcuZ2V0KCldKTsKICAgICAKQEAgLTI0MSwxMCArMjI3LDcgQEAgVEVTVChXZWJLaXQsIFdL VGh1bWJuYWlsVmlld01heGltdW1TbmFwc2hvdFNpemVXS1dlYlZpZXcpCiB7CiAgICAgYXV0byB3 ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dS ZWN0TWFrZSgwLCAwLCA4MDAsIDYwMCldKTsKICAgICBXS1BhZ2VTZXRDdXN0b21CYWNraW5nU2Nh bGVGYWN0b3IoW3dlYlZpZXcgX3BhZ2VGb3JUZXN0aW5nXSwgMSk7Ci0gICAgYXV0byBkZWxlZ2F0 ZSA9IGFkb3B0TlMoW1tXS1RodW1ibmFpbFZpZXdEZWxlZ2F0ZSBhbGxvY10gaW5pdF0pOwotICAg IFt3ZWJWaWV3IHNldE5hdmlnYXRpb25EZWxlZ2F0ZTpkZWxlZ2F0ZS5nZXQoKV07Ci0gICAgW3dl YlZpZXcgIGxvYWRSZXF1ZXN0OltOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6W1tOU0J1bmRs ZSBtYWluQnVuZGxlXSBVUkxGb3JSZXNvdXJjZTpAImxvdHMtb2YtdGV4dCIgd2l0aEV4dGVuc2lv bjpAImh0bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEkucmVzb3VyY2VzIl1dXTsKLSAg ICBVdGlsOjpydW4oJmRpZEZpbmlzaExvYWQpOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlM b2FkVGVzdFBhZ2VOYW1lZDpAImxvdHMtb2YtdGV4dCJdOwogCiAgICAgYXV0byB0aHVtYm5haWxW aWV3ID0gYWRvcHROUyhbW19XS1RodW1ibmFpbFZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNN YWtlUmVjdCgwLCAwLCAxMDAsIDEwMCkgZnJvbVdLV2ViVmlldzp3ZWJWaWV3LmdldCgpXSk7CiAK QEAgLTI4NSw2ICsyNjgsNDEgQEAgVEVTVChXZWJLaXQsIFdLVGh1bWJuYWlsVmlld01heGltdW1T bmFwc2hvdFNpemVXS1dlYlZpZXcpCiAgICAgW3RodW1ibmFpbFZpZXcgcmVtb3ZlT2JzZXJ2ZXI6 b2JzZXJ2ZXIuZ2V0KCkgZm9yS2V5UGF0aDpAInNuYXBzaG90U2l6ZSIgY29udGV4dDpzbmFwc2hv dFNpemVDaGFuZ2VLVk9Db250ZXh0XTsKIH0KIAorVEVTVChXZWJLaXQsIFdLVGh1bWJuYWlsVmll d1Jlc2V0c1ZpZXdTdGF0ZVdoZW5VbnBhcmVudGVkKQoreworICAgIFdLV2ViVmlld0NvbmZpZ3Vy YXRpb24gKmNvbmZpZ3VyYXRpb24gPSBbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBfdGVzdF9jb25m aWd1cmF0aW9uV2l0aFRlc3RQbHVnSW5DbGFzc05hbWU6QCJXZWJQcm9jZXNzUGx1Z0luV2l0aElu dGVybmFscyIgY29uZmlndXJlSlNDRm9yVGVzdGluZzpZRVNdOworICAgIGF1dG8gd2ViVmlldyA9 IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2Uo MCwgMCwgODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbl0pOworICAgIFt3ZWJW aWV3IHJlbW92ZUZyb21TdXBlcnZpZXddOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2Fk VGVzdFBhZ2VOYW1lZDpAImxvdHMtb2YtdGV4dCJdOworCisgICAgYXV0byB0aHVtYm5haWxWaWV3 ID0gYWRvcHROUyhbW19XS1RodW1ibmFpbFZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtl UmVjdCgwLCAwLCAxMDAsIDEwMCkgZnJvbVdLV2ViVmlldzp3ZWJWaWV3LmdldCgpXSk7CisKKyAg ICBhdXRvIG9ic2VydmVyID0gYWRvcHROUyhbW1NuYXBzaG90U2l6ZU9ic2VydmVyIGFsbG9jXSBp bml0XSk7CisKKyAgICBbdGh1bWJuYWlsVmlldyBhZGRPYnNlcnZlcjpvYnNlcnZlci5nZXQoKSBm b3JLZXlQYXRoOkAic25hcHNob3RTaXplIiBvcHRpb25zOk5TS2V5VmFsdWVPYnNlcnZpbmdPcHRp b25OZXcgY29udGV4dDpzbmFwc2hvdFNpemVDaGFuZ2VLVk9Db250ZXh0XTsKKworICAgIFJldGFp blB0cjxOU1dpbmRvdz4gb3RoZXJXaW5kb3cgPSBhZG9wdE5TKFtbT2Zmc2NyZWVuV2luZG93IGFs bG9jXSBpbml0V2l0aFNpemU6Q0dTaXplTWFrZSgxMDAsIDEwMCkgaXNLZXlXaW5kb3c6Tk9dKTsK KyAgICBbW290aGVyV2luZG93IGNvbnRlbnRWaWV3XSBhZGRTdWJ2aWV3OnRodW1ibmFpbFZpZXcu Z2V0KCldOworICAgIFtvdGhlcldpbmRvdyBvcmRlckZyb250Om5pbF07CisgICAgW1t3ZWJWaWV3 IGhvc3RXaW5kb3ddIG1ha2VLZXlBbmRPcmRlckZyb250Om5pbF07CisgICAgVXRpbDo6cnVuKCZk aWRUYWtlU25hcHNob3QpOworICAgIGRpZFRha2VTbmFwc2hvdCA9IGZhbHNlOworICAgIEVYUEVD VF9GQUxTRShbdGh1bWJuYWlsVmlldyBsYXllcl0uY29udGVudHMgPT0gbmlsKTsKKyAgICBbd2Vi VmlldyB3YWl0Rm9yTmV4dFByZXNlbnRhdGlvblVwZGF0ZV07CisgICAgRVhQRUNUX0ZBTFNFKFtb d2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAid2luZG93LmludGVybmFscy5p c1BhZ2VBY3RpdmUoKSJdIGJvb2xWYWx1ZV0pOworCisgICAgW3dlYlZpZXcgYWRkVG9UZXN0V2lu ZG93XTsKKyAgICBbd2ViVmlldyB3YWl0Rm9yTmV4dFByZXNlbnRhdGlvblVwZGF0ZV07CisgICAg RVhQRUNUX0ZBTFNFKFtbd2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAid2lu ZG93LmludGVybmFscy5pc1BhZ2VBY3RpdmUoKSJdIGJvb2xWYWx1ZV0pOworCisgICAgW3RodW1i bmFpbFZpZXcgcmVtb3ZlRnJvbVN1cGVydmlld107CisgICAgW3dlYlZpZXcgd2FpdEZvck5leHRQ cmVzZW50YXRpb25VcGRhdGVdOworICAgIEVYUEVDVF9UUlVFKFtbd2ViVmlldyBvYmplY3RCeUV2 YWx1YXRpbmdKYXZhU2NyaXB0OkAid2luZG93LmludGVybmFscy5pc1BhZ2VBY3RpdmUoKSJdIGJv b2xWYWx1ZV0pOworCisgICAgW3RodW1ibmFpbFZpZXcgcmVtb3ZlT2JzZXJ2ZXI6b2JzZXJ2ZXIu Z2V0KCkgZm9yS2V5UGF0aDpAInNuYXBzaG90U2l6ZSIgY29udGV4dDpzbmFwc2hvdFNpemVDaGFu Z2VLVk9Db250ZXh0XTsKK30KKworCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCiAKLSNl bmRpZgorI2VuZGlmIC8vIFBMQVRGT1JNKE1BQykKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvbWFjL09mZnNjcmVlbldpbmRvdy5oIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9tYWMvT2Zm c2NyZWVuV2luZG93LmgKaW5kZXggMjQ4ZWIxMWNkNjcxYjNhOGY4ZTQ3M2MwYjUyMDYxODYyMTZk NTIxOS4uY2IzZDhjYzg1ZjhkY2FiMGRhZGEzNjVjMGRlZmFlNDk1NjZkNThmNyAxMDA2NDQKLS0t IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9tYWMvT2Zmc2NyZWVuV2luZG93LmgKKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9tYWMvT2Zmc2NyZWVuV2luZG93LmgKQEAgLTM0LDYgKzM0LDcgQEAgQGlu dGVyZmFjZSBPZmZzY3JlZW5XaW5kb3cgOiBOU1dpbmRvdwogLSAoaW5zdGFuY2V0eXBlKWluaXRX aXRoQ29udGVudFJlY3Q6KE5TUmVjdCljb250ZW50UmVjdCBzdHlsZU1hc2s6KE5TV2luZG93U3R5 bGVNYXNrKXN0eWxlIGJhY2tpbmc6KE5TQmFja2luZ1N0b3JlVHlwZSliYWNraW5nU3RvcmVUeXBl IGRlZmVyOihCT09MKWZsYWcgc2NyZWVuOihOU1NjcmVlbiAqKXNjcmVlbiBOU19VTkFWQUlMQUJM RTsKIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoU2l6ZTooQ0dTaXplKXNpemU7CistIChpbnN0 YW5jZXR5cGUpaW5pdFdpdGhTaXplOihDR1NpemUpc2l6ZSBpc0tleVdpbmRvdzooQk9PTClpc0tl eVdpbmRvdzsKIAogQGVuZAogCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL21hYy9P ZmZzY3JlZW5XaW5kb3cubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL21hYy9PZmZzY3JlZW5XaW5k b3cubW0KaW5kZXggN2ExMDBmNzVlMWVkZGIyODBlOWM2YzYwZWIwNDA5OWE1NWRmNjYwMi4uNTE3 N2FhNDM0ZTY4ZjM3MmJlNDE4YWUxMWRmZGZkM2Q0N2RiZjc1YiAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS9tYWMvT2Zmc2NyZWVuV2luZG93Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvbWFjL09mZnNjcmVlbldpbmRvdy5tbQpAQCAtMjYsMTAgKzI2LDE5IEBACiAjaW1wb3J0 ICJjb25maWcuaCIKICNpbXBvcnQgIk9mZnNjcmVlbldpbmRvdy5oIgogCi1AaW1wbGVtZW50YXRp b24gT2Zmc2NyZWVuV2luZG93CitAaW1wbGVtZW50YXRpb24gT2Zmc2NyZWVuV2luZG93IHsKKyAg ICBCT09MIF9pc0tleVdpbmRvdzsKK30KIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoU2l6ZToo Q0dTaXplKXNpemUKIHsKKyAgICByZXR1cm4gW3NlbGYgaW5pdFdpdGhTaXplOnNpemUgaXNLZXlX aW5kb3c6WUVTXTsKK30KKworLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoU2l6ZTooQ0dTaXplKXNp emUgaXNLZXlXaW5kb3c6KEJPT0wpaXNLZXlXaW5kb3cKK3sKKyAgICBfaXNLZXlXaW5kb3cgPSBp c0tleVdpbmRvdzsKKwogICAgIE5TUmVjdCByZWN0ID0gTlNNYWtlUmVjdCgwLCAwLCBzaXplLndp ZHRoLCBzaXplLmhlaWdodCk7CiAgICAgTlNSZWN0IHdpbmRvd1JlY3QgPSBOU09mZnNldFJlY3Qo cmVjdCwgLTEwMDAwLCBbKE5TU2NyZWVuICopW1tOU1NjcmVlbiBzY3JlZW5zXSBvYmplY3RBdElu ZGV4OjBdIGZyYW1lXS5zaXplLmhlaWdodCAtIHJlY3Quc2l6ZS5oZWlnaHQgKyAxMDAwMCk7CiAg ICAgc2VsZiA9IFtzdXBlciBpbml0V2l0aENvbnRlbnRSZWN0OndpbmRvd1JlY3Qgc3R5bGVNYXNr Ok5TV2luZG93U3R5bGVNYXNrQm9yZGVybGVzcyBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVy ZWQgZGVmZXI6WUVTXTsKQEAgLTQ2LDcgKzU1LDcgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRo U2l6ZTooQ0dTaXplKXNpemUKIAogLSAoQk9PTClpc0tleVdpbmRvdwogewotICAgIHJldHVybiBZ RVM7CisgICAgcmV0dXJuIF9pc0tleVdpbmRvdzsKIH0KIAogLSAoQk9PTClpc1Zpc2libGUK