214938 2020-07-29 14:49:27 -0700 Highlight color does not switch after being set it system preferences. 2020-07-29 18:07:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1676148 0 megan_gardner 2020-07-29 14:49:27 -0700 Highlight color does not switch after being set it system preferences. 1676154 1 405507 megan_gardner 2020-07-29 14:52:54 -0700 Created attachment 405507 Patch 1676157 2 405507 thorton 2020-07-29 14:57:23 -0700 Comment on attachment 405507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405507&action=review > Source/WebKit/ChangeLog:9 > + After the changes to the sandbox and how defaults are being transferred to the web process, This should probably reference a commit. > Source/WebKit/ChangeLog:11 > + after setting the defaults so that the value is retried after it is actually set and we do "value is retried" -> "cache is invalidated" You might even mention which cache (colorCache in RenderTheme)... > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:953 > + [notificationCenter postNotificationName:@"NSSystemColorsWillChangeNotification" object:nil]; > + [notificationCenter postNotificationName:NSSystemColorsDidChangeNotification object:nil]; While it looks weird that "WillChange" and "DidChange" are adjacent without the change sitting between them, this does match what happens in AppKit. 1676160 3 405508 megan_gardner 2020-07-29 15:04:37 -0700 Created attachment 405508 Patch 1676164 4 405508 thorton 2020-07-29 15:09:31 -0700 Comment on attachment 405508 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405508&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:933 > +static const WTF::String& userHighlightColorPreferenceKey() Space above here. > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:938 > + Not here. 1676182 5 405514 megan_gardner 2020-07-29 15:30:53 -0700 Created attachment 405514 Patch 1676268 6 ews-feeder 2020-07-29 18:00:27 -0700 Committed r265072: <https://trac.webkit.org/changeset/265072> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405514. 1676270 7 webkit-bug-importer 2020-07-29 18:01:17 -0700 <rdar://problem/66302507> 1676273 8 megan_gardner 2020-07-29 18:07:18 -0700 <rdar://problem/65270586> 405507 2020-07-29 14:52:54 -0700 2020-07-29 15:54:30 -0700 Patch bug-214938-20200729145253.patch text/plain 3518 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhiNDVkMzQxNmE0MWEwOWIw ZDVhMjgxYzEyOTFjNTZkOWJmNTM4NDUuLjdhMTg4NjQ3NjdmZWVhY2JmZDEyOGFiZWU0YWMwZWJj ODk1ZGM3MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDctMjkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBIaWdobGlnaHQgY29s b3IgZG9lcyBub3Qgc3dpdGNoIGFmdGVyIGJlaW5nIHNldCBpdCBzeXN0ZW0gcHJlZmVyZW5jZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5MzgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1MjcwNTg2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHRoZSBjaGFuZ2VzIHRvIHRoZSBzYW5k Ym94IGFuZCBob3cgZGVmYXVsdHMgYXJlIGJlaW5nIHRyYW5zZmVycmVkIHRvIHRoZSB3ZWIgcHJv Y2VzcywKKyAgICAgICAgdGhlIGhpZ2hsaWdodCBjb2xvciB3YXMgbm90IGJlaW5nIHVwZGF0ZWQg aW1tZWRpYXRlbHkuIFdlIG5lZWQgdG8gc2VuZCB0aGUgcHJvcGVyIG5vdGlmaWNhdGlvbgorICAg ICAgICBhZnRlciBzZXR0aW5nIHRoZSBkZWZhdWx0cyBzbyB0aGF0IHRoZSB2YWx1ZSBpcyByZXRy aWVkIGFmdGVyIGl0IGlzIGFjdHVhbGx5IHNldCBhbmQgd2UgZG8KKyAgICAgICAgbm90IGVuZCB1 cCB3aXRoIGEgc3RhbGUgdmFsdWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlBy b2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6dXNlckhpZ2hsaWdodENvbG9yUHJlZmVy ZW5jZUtleSk6CisgICAgICAgIChXZWJLaXQ6OmRpc3BhdGNoU2ltdWxhdGVkTm90aWZpY2F0aW9u c0ZvclByZWZlcmVuY2VDaGFuZ2UpOgorCiAyMDIwLTA3LTI3ICBNZWdhbiBHYXJkbmVyICA8bWVn YW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgVHJ5aW5nIHRvIGxvb2t1cCB3aGVuIFdl YlZpZXcgaXMgaW4gYSBwb3BvdmVyIGNhdXNlcyBwcm9jZXNzIHRvIGhhbmcuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCBiOWU2 OGY4OGRiZjI4NWFjZjgyYmExYTE3ZWQyNjI5MjliNjhkY2JhLi5hYjMzMTc1Y2JkZDVmY2JjMjU5 NTZiNjM5MWIxMTNiMjEwNTQwZGNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTkzMCw2ICs5MzAsMTMgQEAgc3RhdGljIGNv bnN0IFdURjo6U3RyaW5nJiB1c2VyQWNjZW50Q29sb3JQcmVmZXJlbmNlS2V5KCkKICAgICBzdGF0 aWMgTmV2ZXJEZXN0cm95ZWQ8V1RGOjpTdHJpbmc+IHVzZXJBY2NlbnRDb2xvclByZWZlcmVuY2VL ZXkoTUFLRV9TVEFUSUNfU1RSSU5HX0lNUEwoIkFwcGxlQWNjZW50Q29sb3IiKSk7CiAgICAgcmV0 dXJuIHVzZXJBY2NlbnRDb2xvclByZWZlcmVuY2VLZXk7CiB9CitzdGF0aWMgY29uc3QgV1RGOjpT dHJpbmcmIHVzZXJIaWdobGlnaHRDb2xvclByZWZlcmVuY2VLZXkoKQoreworICAgIHN0YXRpYyBO ZXZlckRlc3Ryb3llZDxXVEY6OlN0cmluZz4gdXNlckhpZ2hsaWdodENvbG9yUHJlZmVyZW5jZUtl eShNQUtFX1NUQVRJQ19TVFJJTkdfSU1QTCgiQXBwbGVIaWdobGlnaHRDb2xvciIpKTsKKyAgICBy ZXR1cm4gdXNlckhpZ2hsaWdodENvbG9yUHJlZmVyZW5jZUtleTsKK30KKworCiAjZW5kaWYKIAog c3RhdGljIHZvaWQgZGlzcGF0Y2hTaW11bGF0ZWROb3RpZmljYXRpb25zRm9yUHJlZmVyZW5jZUNo YW5nZShjb25zdCBTdHJpbmcmIGtleSkKQEAgLTkzOCw4ICs5NDUsMTggQEAgc3RhdGljIHZvaWQg ZGlzcGF0Y2hTaW11bGF0ZWROb3RpZmljYXRpb25zRm9yUHJlZmVyZW5jZUNoYW5nZShjb25zdCBT dHJpbmcmIGtleSkKICAgICAvLyBPcmRpbmFyaWx5LCBvdGhlciBwYXJ0cyBvZiB0aGUgc3lzdGVt IGVuc3VyZSB0aGF0IHRoaXMgbm90aWZpY2F0aW9uIGlzIHBvc3RlZCBhZnRlciB0aGlzIGRlZmF1 bHQgaXMgY2hhbmdlZC4KICAgICAvLyBIb3dldmVyLCBzaW5jZSB3ZSBzeW5jaHJvbml6ZSBkZWZh dWx0cyB0byB0aGUgV2ViIENvbnRlbnQgcHJvY2VzcyB1c2luZyBhIG1lY2hhbmlzbSBub3Qga25v d24gdG8gdGhlIHJlc3QKICAgICAvLyBvZiB0aGUgc3lzdGVtLCB3ZSBtdXN0IHJlLXBvc3QgdGhl IG5vdGlmaWNhdGlvbiBpbiB0aGUgV2ViIENvbnRlbnQgcHJvY2VzcyBhZnRlciB1cGRhdGluZyB0 aGUgZGVmYXVsdC4KLSAgICBpZiAoa2V5ID09IHVzZXJBY2NlbnRDb2xvclByZWZlcmVuY2VLZXko KSkKLSAgICAgICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBwb3N0Tm90 aWZpY2F0aW9uTmFtZTpAImtDVUlOb3RpZmljYXRpb25BcXVhQ29sb3JWYXJpYW50Q2hhbmdlZCIg b2JqZWN0Om5pbF07CisgICAgCisgICAgaWYgKGtleSA9PSB1c2VyQWNjZW50Q29sb3JQcmVmZXJl bmNlS2V5KCkpIHsKKyAgICAgICAgTlNOb3RpZmljYXRpb25DZW50ZXIgKm5vdGlmaWNhdGlvbkNl bnRlciA9IFtOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXTsKKyAgICAgICAgW25v dGlmaWNhdGlvbkNlbnRlciBwb3N0Tm90aWZpY2F0aW9uTmFtZTpAImtDVUlOb3RpZmljYXRpb25B cXVhQ29sb3JWYXJpYW50Q2hhbmdlZCIgb2JqZWN0Om5pbF07CisgICAgICAgIFtub3RpZmljYXRp b25DZW50ZXIgcG9zdE5vdGlmaWNhdGlvbk5hbWU6QCJOU1N5c3RlbUNvbG9yc1dpbGxDaGFuZ2VO b3RpZmljYXRpb24iIG9iamVjdDpuaWxdOworICAgICAgICBbbm90aWZpY2F0aW9uQ2VudGVyIHBv c3ROb3RpZmljYXRpb25OYW1lOk5TU3lzdGVtQ29sb3JzRGlkQ2hhbmdlTm90aWZpY2F0aW9uIG9i amVjdDpuaWxdOworICAgIH0KKyAgICBpZiAoa2V5ID09IHVzZXJIaWdobGlnaHRDb2xvclByZWZl cmVuY2VLZXkoKSkgeworICAgICAgICBOU05vdGlmaWNhdGlvbkNlbnRlciAqbm90aWZpY2F0aW9u Q2VudGVyID0gW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdOworICAgICAgICBb bm90aWZpY2F0aW9uQ2VudGVyIHBvc3ROb3RpZmljYXRpb25OYW1lOkAiTlNTeXN0ZW1Db2xvcnNX aWxsQ2hhbmdlTm90aWZpY2F0aW9uIiBvYmplY3Q6bmlsXTsKKyAgICAgICAgW25vdGlmaWNhdGlv bkNlbnRlciBwb3N0Tm90aWZpY2F0aW9uTmFtZTpOU1N5c3RlbUNvbG9yc0RpZENoYW5nZU5vdGlm aWNhdGlvbiBvYmplY3Q6bmlsXTsKKyAgICB9CiAjZW5kaWYKIH0KIAo= 405508 2020-07-29 15:04:37 -0700 2020-07-29 15:54:12 -0700 Patch bug-214938-20200729150436.patch text/plain 3580 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhiNDVkMzQxNmE0MWEwOWIw ZDVhMjgxYzEyOTFjNTZkOWJmNTM4NDUuLjRmYTYyMzE4NmY4Y2M5MWUxOWZkYjczNmM0MWUwN2U5 YjA1ODA1MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDctMjkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBIaWdobGlnaHQgY29s b3IgZG9lcyBub3Qgc3dpdGNoIGFmdGVyIGJlaW5nIHNldCBpdCBzeXN0ZW0gcHJlZmVyZW5jZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5MzgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1MjcwNTg2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHRoZSBjaGFuZ2VzIHRvIHRoZSBzYW5k Ym94IGFuZCBob3cgZGVmYXVsdHMgYXJlIGJlaW5nIHRyYW5zZmVycmVkIHRvIHRoZSB3ZWIgcHJv Y2VzcworICAgICAgICAoaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI1ODA2NC93 ZWJraXQpLCB0aGUgaGlnaGxpZ2h0IGNvbG9yIHdhcyBub3QgYmVpbmcgdXBkYXRlZCAKKyAgICAg ICAgaW1tZWRpYXRlbHkuIFdlIG5lZWQgdG8gc2VuZCB0aGUgcHJvcGVyIG5vdGlmaWNhdGlvbiBh ZnRlciBzZXR0aW5nIHRoZSBkZWZhdWx0cyBzbyB0aGF0IHRoZSAKKyAgICAgICAgY29sb3IgY2Fj aGUgaXMgaW52YWxpZGF0ZWQgYWZ0ZXIgaXQgaXMgYWN0dWFsbHkgc2V0IGFuZCB3ZSBkbyBub3Qg ZW5kIHVwIHdpdGggYSBzdGFsZSB2YWx1ZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2Ev V2ViUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0Ojp1c2VySGlnaGxpZ2h0Q29sb3JQ cmVmZXJlbmNlS2V5KToKKyAgICAgICAgKFdlYktpdDo6ZGlzcGF0Y2hTaW11bGF0ZWROb3RpZmlj YXRpb25zRm9yUHJlZmVyZW5jZUNoYW5nZSk6CisKIDIwMjAtMDctMjcgIE1lZ2FuIEdhcmRuZXIg IDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnlpbmcgdG8gbG9va3VwIHdo ZW4gV2ViVmlldyBpcyBpbiBhIHBvcG92ZXIgY2F1c2VzIHByb2Nlc3MgdG8gaGFuZy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0g Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4 IGI5ZTY4Zjg4ZGJmMjg1YWNmODJiYTFhMTdlZDI2MjkyOWI2OGRjYmEuLmFiMzMxNzVjYmRkNWZj YmMyNTk1NmI2MzkxYjExM2IyMTA1NDBkY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQpAQCAtOTMwLDYgKzkzMCwxMyBAQCBzdGF0 aWMgY29uc3QgV1RGOjpTdHJpbmcmIHVzZXJBY2NlbnRDb2xvclByZWZlcmVuY2VLZXkoKQogICAg IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxXVEY6OlN0cmluZz4gdXNlckFjY2VudENvbG9yUHJlZmVy ZW5jZUtleShNQUtFX1NUQVRJQ19TVFJJTkdfSU1QTCgiQXBwbGVBY2NlbnRDb2xvciIpKTsKICAg ICByZXR1cm4gdXNlckFjY2VudENvbG9yUHJlZmVyZW5jZUtleTsKIH0KK3N0YXRpYyBjb25zdCBX VEY6OlN0cmluZyYgdXNlckhpZ2hsaWdodENvbG9yUHJlZmVyZW5jZUtleSgpCit7CisgICAgc3Rh dGljIE5ldmVyRGVzdHJveWVkPFdURjo6U3RyaW5nPiB1c2VySGlnaGxpZ2h0Q29sb3JQcmVmZXJl bmNlS2V5KE1BS0VfU1RBVElDX1NUUklOR19JTVBMKCJBcHBsZUhpZ2hsaWdodENvbG9yIikpOwor ICAgIHJldHVybiB1c2VySGlnaGxpZ2h0Q29sb3JQcmVmZXJlbmNlS2V5OworfQorCisKICNlbmRp ZgogCiBzdGF0aWMgdm9pZCBkaXNwYXRjaFNpbXVsYXRlZE5vdGlmaWNhdGlvbnNGb3JQcmVmZXJl bmNlQ2hhbmdlKGNvbnN0IFN0cmluZyYga2V5KQpAQCAtOTM4LDggKzk0NSwxOCBAQCBzdGF0aWMg dm9pZCBkaXNwYXRjaFNpbXVsYXRlZE5vdGlmaWNhdGlvbnNGb3JQcmVmZXJlbmNlQ2hhbmdlKGNv bnN0IFN0cmluZyYga2V5KQogICAgIC8vIE9yZGluYXJpbHksIG90aGVyIHBhcnRzIG9mIHRoZSBz eXN0ZW0gZW5zdXJlIHRoYXQgdGhpcyBub3RpZmljYXRpb24gaXMgcG9zdGVkIGFmdGVyIHRoaXMg ZGVmYXVsdCBpcyBjaGFuZ2VkLgogICAgIC8vIEhvd2V2ZXIsIHNpbmNlIHdlIHN5bmNocm9uaXpl IGRlZmF1bHRzIHRvIHRoZSBXZWIgQ29udGVudCBwcm9jZXNzIHVzaW5nIGEgbWVjaGFuaXNtIG5v dCBrbm93biB0byB0aGUgcmVzdAogICAgIC8vIG9mIHRoZSBzeXN0ZW0sIHdlIG11c3QgcmUtcG9z dCB0aGUgbm90aWZpY2F0aW9uIGluIHRoZSBXZWIgQ29udGVudCBwcm9jZXNzIGFmdGVyIHVwZGF0 aW5nIHRoZSBkZWZhdWx0LgotICAgIGlmIChrZXkgPT0gdXNlckFjY2VudENvbG9yUHJlZmVyZW5j ZUtleSgpKQotICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHBv c3ROb3RpZmljYXRpb25OYW1lOkAia0NVSU5vdGlmaWNhdGlvbkFxdWFDb2xvclZhcmlhbnRDaGFu Z2VkIiBvYmplY3Q6bmlsXTsKKyAgICAKKyAgICBpZiAoa2V5ID09IHVzZXJBY2NlbnRDb2xvclBy ZWZlcmVuY2VLZXkoKSkgeworICAgICAgICBOU05vdGlmaWNhdGlvbkNlbnRlciAqbm90aWZpY2F0 aW9uQ2VudGVyID0gW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdOworICAgICAg ICBbbm90aWZpY2F0aW9uQ2VudGVyIHBvc3ROb3RpZmljYXRpb25OYW1lOkAia0NVSU5vdGlmaWNh dGlvbkFxdWFDb2xvclZhcmlhbnRDaGFuZ2VkIiBvYmplY3Q6bmlsXTsKKyAgICAgICAgW25vdGlm aWNhdGlvbkNlbnRlciBwb3N0Tm90aWZpY2F0aW9uTmFtZTpAIk5TU3lzdGVtQ29sb3JzV2lsbENo YW5nZU5vdGlmaWNhdGlvbiIgb2JqZWN0Om5pbF07CisgICAgICAgIFtub3RpZmljYXRpb25DZW50 ZXIgcG9zdE5vdGlmaWNhdGlvbk5hbWU6TlNTeXN0ZW1Db2xvcnNEaWRDaGFuZ2VOb3RpZmljYXRp b24gb2JqZWN0Om5pbF07CisgICAgfQorICAgIGlmIChrZXkgPT0gdXNlckhpZ2hsaWdodENvbG9y UHJlZmVyZW5jZUtleSgpKSB7CisgICAgICAgIE5TTm90aWZpY2F0aW9uQ2VudGVyICpub3RpZmlj YXRpb25DZW50ZXIgPSBbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl07CisgICAg ICAgIFtub3RpZmljYXRpb25DZW50ZXIgcG9zdE5vdGlmaWNhdGlvbk5hbWU6QCJOU1N5c3RlbUNv bG9yc1dpbGxDaGFuZ2VOb3RpZmljYXRpb24iIG9iamVjdDpuaWxdOworICAgICAgICBbbm90aWZp Y2F0aW9uQ2VudGVyIHBvc3ROb3RpZmljYXRpb25OYW1lOk5TU3lzdGVtQ29sb3JzRGlkQ2hhbmdl Tm90aWZpY2F0aW9uIG9iamVjdDpuaWxdOworICAgIH0KICNlbmRpZgogfQogCg== 405514 2020-07-29 15:30:53 -0700 2020-07-29 18:00:27 -0700 Patch bug-214938-20200729153053.patch text/plain 3578 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhiNDVkMzQxNmE0MWEwOWIw ZDVhMjgxYzEyOTFjNTZkOWJmNTM4NDUuLjRmYTYyMzE4NmY4Y2M5MWUxOWZkYjczNmM0MWUwN2U5 YjA1ODA1MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDctMjkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBIaWdobGlnaHQgY29s b3IgZG9lcyBub3Qgc3dpdGNoIGFmdGVyIGJlaW5nIHNldCBpdCBzeXN0ZW0gcHJlZmVyZW5jZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5MzgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1MjcwNTg2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIHRoZSBjaGFuZ2VzIHRvIHRoZSBzYW5k Ym94IGFuZCBob3cgZGVmYXVsdHMgYXJlIGJlaW5nIHRyYW5zZmVycmVkIHRvIHRoZSB3ZWIgcHJv Y2VzcworICAgICAgICAoaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzI1ODA2NC93 ZWJraXQpLCB0aGUgaGlnaGxpZ2h0IGNvbG9yIHdhcyBub3QgYmVpbmcgdXBkYXRlZCAKKyAgICAg ICAgaW1tZWRpYXRlbHkuIFdlIG5lZWQgdG8gc2VuZCB0aGUgcHJvcGVyIG5vdGlmaWNhdGlvbiBh ZnRlciBzZXR0aW5nIHRoZSBkZWZhdWx0cyBzbyB0aGF0IHRoZSAKKyAgICAgICAgY29sb3IgY2Fj aGUgaXMgaW52YWxpZGF0ZWQgYWZ0ZXIgaXQgaXMgYWN0dWFsbHkgc2V0IGFuZCB3ZSBkbyBub3Qg ZW5kIHVwIHdpdGggYSBzdGFsZSB2YWx1ZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2Ev V2ViUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0Ojp1c2VySGlnaGxpZ2h0Q29sb3JQ cmVmZXJlbmNlS2V5KToKKyAgICAgICAgKFdlYktpdDo6ZGlzcGF0Y2hTaW11bGF0ZWROb3RpZmlj YXRpb25zRm9yUHJlZmVyZW5jZUNoYW5nZSk6CisKIDIwMjAtMDctMjcgIE1lZ2FuIEdhcmRuZXIg IDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnlpbmcgdG8gbG9va3VwIHdo ZW4gV2ViVmlldyBpcyBpbiBhIHBvcG92ZXIgY2F1c2VzIHByb2Nlc3MgdG8gaGFuZy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0g Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4 IGI5ZTY4Zjg4ZGJmMjg1YWNmODJiYTFhMTdlZDI2MjkyOWI2OGRjYmEuLjA5NDYyYzE1ZTViNjJi ZTVkZTg5NjlkNmE1MzdmNzVhNjEzZmUyYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQpAQCAtOTMwLDYgKzkzMCwxMiBAQCBzdGF0 aWMgY29uc3QgV1RGOjpTdHJpbmcmIHVzZXJBY2NlbnRDb2xvclByZWZlcmVuY2VLZXkoKQogICAg IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxXVEY6OlN0cmluZz4gdXNlckFjY2VudENvbG9yUHJlZmVy ZW5jZUtleShNQUtFX1NUQVRJQ19TVFJJTkdfSU1QTCgiQXBwbGVBY2NlbnRDb2xvciIpKTsKICAg ICByZXR1cm4gdXNlckFjY2VudENvbG9yUHJlZmVyZW5jZUtleTsKIH0KKworc3RhdGljIGNvbnN0 IFdURjo6U3RyaW5nJiB1c2VySGlnaGxpZ2h0Q29sb3JQcmVmZXJlbmNlS2V5KCkKK3sKKyAgICBz dGF0aWMgTmV2ZXJEZXN0cm95ZWQ8V1RGOjpTdHJpbmc+IHVzZXJIaWdobGlnaHRDb2xvclByZWZl cmVuY2VLZXkoTUFLRV9TVEFUSUNfU1RSSU5HX0lNUEwoIkFwcGxlSGlnaGxpZ2h0Q29sb3IiKSk7 CisgICAgcmV0dXJuIHVzZXJIaWdobGlnaHRDb2xvclByZWZlcmVuY2VLZXk7Cit9CiAjZW5kaWYK IAogc3RhdGljIHZvaWQgZGlzcGF0Y2hTaW11bGF0ZWROb3RpZmljYXRpb25zRm9yUHJlZmVyZW5j ZUNoYW5nZShjb25zdCBTdHJpbmcmIGtleSkKQEAgLTkzOCw4ICs5NDQsMTggQEAgc3RhdGljIHZv aWQgZGlzcGF0Y2hTaW11bGF0ZWROb3RpZmljYXRpb25zRm9yUHJlZmVyZW5jZUNoYW5nZShjb25z dCBTdHJpbmcmIGtleSkKICAgICAvLyBPcmRpbmFyaWx5LCBvdGhlciBwYXJ0cyBvZiB0aGUgc3lz dGVtIGVuc3VyZSB0aGF0IHRoaXMgbm90aWZpY2F0aW9uIGlzIHBvc3RlZCBhZnRlciB0aGlzIGRl ZmF1bHQgaXMgY2hhbmdlZC4KICAgICAvLyBIb3dldmVyLCBzaW5jZSB3ZSBzeW5jaHJvbml6ZSBk ZWZhdWx0cyB0byB0aGUgV2ViIENvbnRlbnQgcHJvY2VzcyB1c2luZyBhIG1lY2hhbmlzbSBub3Qg a25vd24gdG8gdGhlIHJlc3QKICAgICAvLyBvZiB0aGUgc3lzdGVtLCB3ZSBtdXN0IHJlLXBvc3Qg dGhlIG5vdGlmaWNhdGlvbiBpbiB0aGUgV2ViIENvbnRlbnQgcHJvY2VzcyBhZnRlciB1cGRhdGlu ZyB0aGUgZGVmYXVsdC4KLSAgICBpZiAoa2V5ID09IHVzZXJBY2NlbnRDb2xvclByZWZlcmVuY2VL ZXkoKSkKLSAgICAgICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBwb3N0 Tm90aWZpY2F0aW9uTmFtZTpAImtDVUlOb3RpZmljYXRpb25BcXVhQ29sb3JWYXJpYW50Q2hhbmdl ZCIgb2JqZWN0Om5pbF07CisgICAgCisgICAgaWYgKGtleSA9PSB1c2VyQWNjZW50Q29sb3JQcmVm ZXJlbmNlS2V5KCkpIHsKKyAgICAgICAgTlNOb3RpZmljYXRpb25DZW50ZXIgKm5vdGlmaWNhdGlv bkNlbnRlciA9IFtOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXTsKKyAgICAgICAg W25vdGlmaWNhdGlvbkNlbnRlciBwb3N0Tm90aWZpY2F0aW9uTmFtZTpAImtDVUlOb3RpZmljYXRp b25BcXVhQ29sb3JWYXJpYW50Q2hhbmdlZCIgb2JqZWN0Om5pbF07CisgICAgICAgIFtub3RpZmlj YXRpb25DZW50ZXIgcG9zdE5vdGlmaWNhdGlvbk5hbWU6QCJOU1N5c3RlbUNvbG9yc1dpbGxDaGFu Z2VOb3RpZmljYXRpb24iIG9iamVjdDpuaWxdOworICAgICAgICBbbm90aWZpY2F0aW9uQ2VudGVy IHBvc3ROb3RpZmljYXRpb25OYW1lOk5TU3lzdGVtQ29sb3JzRGlkQ2hhbmdlTm90aWZpY2F0aW9u IG9iamVjdDpuaWxdOworICAgIH0KKyAgICBpZiAoa2V5ID09IHVzZXJIaWdobGlnaHRDb2xvclBy ZWZlcmVuY2VLZXkoKSkgeworICAgICAgICBOU05vdGlmaWNhdGlvbkNlbnRlciAqbm90aWZpY2F0 aW9uQ2VudGVyID0gW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdOworICAgICAg ICBbbm90aWZpY2F0aW9uQ2VudGVyIHBvc3ROb3RpZmljYXRpb25OYW1lOkAiTlNTeXN0ZW1Db2xv cnNXaWxsQ2hhbmdlTm90aWZpY2F0aW9uIiBvYmplY3Q6bmlsXTsKKyAgICAgICAgW25vdGlmaWNh dGlvbkNlbnRlciBwb3N0Tm90aWZpY2F0aW9uTmFtZTpOU1N5c3RlbUNvbG9yc0RpZENoYW5nZU5v dGlmaWNhdGlvbiBvYmplY3Q6bmlsXTsKKyAgICB9CiAjZW5kaWYKIH0KIAo=