<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214934</bug_id>
          
          <creation_ts>2020-07-29 14:23:59 -0700</creation_ts>
          <short_desc>[GTK] 2.29.4 fails to link on armv7hl</short_desc>
          <delta_ts>2020-07-29 16:57:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>annulen</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>clopez</cc>
    
    <cc>dino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>graouts</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1676131</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-07-29 14:23:59 -0700</bug_when>
    <thetext>I&apos;m not sure what changed, but 2.29.4 doesn&apos;t link on ARM:

/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::GetHelperExecutableDir[abi:cxx11]()&apos;:
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:64: undefined reference to `dladdr&apos;
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::getSymbol(char const*)&apos;:
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:98: undefined reference to `dlsym&apos;
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::~PosixLibrary()&apos;:
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:87: undefined reference to `dlclose&apos;
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::~PosixLibrary()&apos;:
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:87: undefined reference to `dlclose&apos;
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::PosixLibrary(std::__cxx11::basic_string&lt;char, std::char_traits&lt;char&gt;, std::allocator&lt;char&gt; &gt; const&amp;)&apos;:
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:75: undefined reference to `dlopen&apos;
/usr/bin/ld: lib/../Source/ThirdParty/ANGLE/CMakeFiles/ANGLE.dir/src/common/system_utils_posix.cpp.o: in function `angle::PosixLibrary::PosixLibrary(std::__cxx11::basic_string&lt;char, std::char_traits&lt;char&gt;, std::allocator&lt;char&gt; &gt; const&amp;)&apos;:
/builddir/build/BUILD/webkitgtk-2.29.4/armv7hl-redhat-linux-gnueabi/../Source/ThirdParty/ANGLE/src/common/system_utils_posix.cpp:79: undefined reference to `dlerror&apos;
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676133</commentid>
    <comment_count>1</comment_count>
      <attachid>405501</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-07-29 14:24:51 -0700</bug_when>
    <thetext>Created attachment 405501
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676134</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2020-07-29 14:25:50 -0700</bug_when>
    <thetext>Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1676242</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-07-29 16:57:07 -0700</bug_when>
    <thetext>Committed r265070: &lt;https://trac.webkit.org/changeset/265070&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405501.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405501</attachid>
            <date>2020-07-29 14:24:51 -0700</date>
            <delta_ts>2020-07-29 16:57:08 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214934-20200729162450.patch</filename>
            <type>text/plain</type>
            <size>1337</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k
ZXggZTNlYTE4NzYxZDJjODRkNjM2MmNjY2JhNDcyZWU4MmJmMDk3MWRjMC4uNmU4MmRlZjVmOGNj
Yzg3YjEzNWYwM2JlMTcyNmY3ODUyOTYwYjRkOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy
dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTI5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh
bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIDIuMjkuNCBmYWlscyB0byBsaW5rIG9u
IGFybXY3aGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIxNDkzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IExpbmsgQU5HTEUgdG8gd2l0aCAtbGRsCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwog
MjAyMC0wNy0yOCAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGNocm9taXVtLm9yZz4KIAogICAgICAg
ICBQYXVzZSBkdXJpbmcgQU5HTEUgcm9sbCBzY3JpcHQgYWZ0ZXIgcmViYXNpbmcgYW5kIGJlZm9y
ZSBkZWxldGluZyB0ZW1wb3JhcnkgR2l0IHJlcG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBh
cnR5L0FOR0xFL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VM
aXN0cy50eHQKaW5kZXggM2JhZjUwZWRjYTlkYWRjNzVkOGZjNGVhMDhlZDVkZTFiNTUyOTdkNi4u
ZDM4NDg3ZDE5NGRkNzMyZTczNjM0ZGQ1ZGMxMmVjM2Y3YzZkMTJmZSAxMDA2NDQKLS0tIGEvU291
cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1RoaXJkUGFy
dHkvQU5HTEUvQ01ha2VMaXN0cy50eHQKQEAgLTEyOSw2ICsxMjksNyBAQCBpZiAoVVNFX0FOR0xF
X0VHTCkKIGVsc2UgKCkKICAgICBhZGRfbGlicmFyeShBTkdMRSBTVEFUSUMgJHtBTkdMRV9TT1VS
Q0VTfSkKICAgICB0YXJnZXRfaW5jbHVkZV9kaXJlY3RvcmllcyhBTkdMRSBQUklWQVRFICR7QU5H
TEVfUFJJVkFURV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKKyAgICB0YXJnZXRfbGlua19saWJyYXJp
ZXMoQU5HTEUgUFJJVkFURSAke0NNQUtFX0RMX0xJQlN9KQogICAgIHRhcmdldF9jb21waWxlX2Rl
ZmluaXRpb25zKEFOR0xFIFBSSVZBVEUKICAgICAgICAgJHtBTkdMRV9ERUZJTklUSU9OU30KICAg
ICAgICAgJHtub19nbF9wcm90b3R5cGVzfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>