21490 2008-10-08 17:16:23 -0700 Optimize keyframe style sheet changes by avoiding styleSheetChanged() 2008-10-14 14:31:55 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin abarth dino simon.fraser oldest_to_newest 94647 0 cmarrin 2008-10-08 17:16:23 -0700 Back before I changed the way keyframe style was resolved (https://bugs.webkit.org/show_bug.cgi?id=20995), I needed to call styleSheetChanged() after deleting or inserting keyframe rules so the keyframe style could be recomputed. But this caused ALL style to be recomputed, which was really expensive and also required a complete redraw of the page. After the change it is no longer necessary to do the styleSheetChanged() call because RenderStyles are created as needed when the animation is started. removing this call will significantly improve performance of adding or removing keyframes. 94649 1 24209 cmarrin 2008-10-08 17:19:00 -0700 Created attachment 24209 Patch, including LayoutTest file 94986 2 24209 darin 2008-10-11 13:22:27 -0700 Comment on attachment 24209 Patch, including LayoutTest file r=me 95265 3 abarth 2008-10-14 01:42:24 -0700 Will land. 95275 4 abarth 2008-10-14 03:01:31 -0700 My Mac Mini died in the middle of testing this patch. I'm going to take it into the store tomorrow. 95313 5 simon.fraser 2008-10-14 11:21:57 -0700 We'll land this 95356 6 cmarrin 2008-10-14 14:31:55 -0700 Sending LayoutTests/ChangeLog Adding LayoutTests/css3/change-keyframes-expected.txt Adding LayoutTests/css3/change-keyframes.html Sending WebCore/ChangeLog Sending WebCore/css/WebKitCSSKeyframesRule.cpp Transmitting file data ..... Committed revision 37592. 24209 2008-10-08 17:19:00 -0700 2008-10-11 13:22:27 -0700 Patch, including LayoutTest file 21490.patch text/plain 6706 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzQzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAtMDggIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eGVkIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ5MAorICAgICAg ICBPcHRpbWl6ZSBrZXlmcmFtZSBzdHlsZSBzaGVldCBjaGFuZ2VzIGJ5IGF2b2lkaW5nIHN0eWxl U2hlZXRDaGFuZ2VkKCkKKworICAgICAgICBUZXN0OiBjc3MzL2NoYW5nZS1rZXlmcmFtZXMuaHRt bAorCisgICAgICAgICogY3NzL1dlYktpdENTU0tleWZyYW1lc1J1bGUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6V2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZTo6YXBwZW5kKToKKyAgICAgICAgKFdlYkNv cmU6OldlYktpdENTU0tleWZyYW1lc1J1bGU6OmRlbGV0ZVJ1bGUpOgorCiAyMDA4LTEwLTA4ICBF cmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlciwgTmlrb2xhcyBaaW1tZXJtYW5uIGFuZCBEYXZlIEh5YXR0LgpJbmRleDogV2ViQ29y ZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9j c3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5jcHAJKHJldmlzaW9uIDM3NDI5KQorKysgV2ViQ29y ZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg0LDcg Kzg0LDYgQEAgY29uc3QgV2ViS2l0Q1NTS2V5ZnJhbWVSdWxlKiBXZWJLaXRDU1NLZQogdm9pZCBX ZWJLaXRDU1NLZXlmcmFtZXNSdWxlOjphcHBlbmQoV2ViS2l0Q1NTS2V5ZnJhbWVSdWxlKiBydWxl KQogewogICAgIG1fbHN0Q1NTUnVsZXMuZ2V0KCktPmFwcGVuZChydWxlKTsKLSAgICBzdHlsZXNo ZWV0KCktPnN0eWxlU2hlZXRDaGFuZ2VkKCk7CiB9CiAKIHZvaWQgV2ViS2l0Q1NTS2V5ZnJhbWVz UnVsZTo6aW5zZXJ0UnVsZShjb25zdCBTdHJpbmcmIHJ1bGUpCkBAIC05OCwxMCArOTcsOCBAQCB2 b2lkIFdlYktpdENTU0tleWZyYW1lc1J1bGU6Omluc2VydFJ1bGUoCiB2b2lkIFdlYktpdENTU0tl eWZyYW1lc1J1bGU6OmRlbGV0ZVJ1bGUoY29uc3QgU3RyaW5nJiBzKQogewogICAgIGludCBpID0g ZmluZFJ1bGVJbmRleChzKTsKLSAgICBpZiAoaSA+PSAwKSB7CisgICAgaWYgKGkgPj0gMCkKICAg ICAgICAgbV9sc3RDU1NSdWxlcy5nZXQoKS0+ZGVsZXRlUnVsZShpKTsKLSAgICAgICAgc3R5bGVz aGVldCgpLT5zdHlsZVNoZWV0Q2hhbmdlZCgpOwotICAgIH0KIH0KIAogV2ViS2l0Q1NTS2V5ZnJh bWVSdWxlKiBXZWJLaXRDU1NLZXlmcmFtZXNSdWxlOjpmaW5kUnVsZShjb25zdCBTdHJpbmcmIHMp CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAzNzQzMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA4LTEwLTA4ICBDaHJpcyBNYXJyaW4gIDxj bWFycmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0Y2FzZSBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxNDkwCisgICAgICAgIE9wdGltaXplIGtleWZyYW1lIHN0eWxlIHNoZWV0IGNoYW5n ZXMgYnkgYXZvaWRpbmcgc3R5bGVTaGVldENoYW5nZWQoKQorCisgICAgICAgICogY3NzMy9jaGFu Z2Uta2V5ZnJhbWVzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogY3NzMy9jaGFuZ2Ut a2V5ZnJhbWVzLmh0bWw6IEFkZGVkLgorCiAyMDA4LTEwLTA4ICBFcmljIFNlaWRlbCAgPGVyaWNA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlciwgTmlrb2xhcyBa aW1tZXJtYW5uIGFuZCBEYXZlIEh5YXR0LgpJbmRleDogTGF5b3V0VGVzdHMvY3NzMy9jaGFuZ2Ut a2V5ZnJhbWVzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9jc3MzL2No YW5nZS1rZXlmcmFtZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv Y3NzMy9jaGFuZ2Uta2V5ZnJhbWVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwyIEBACitUaGlzIHRlc3QgcGVyZm9ybXMgYW4gYW5pbWF0aW9uIG9mIHRoZSBsZWZ0IHByb3Bl cnR5IGFuZCBtYWtlcyBzdXJlIGl0IGlzIGFuaW1hdGluZy4gVGhlbiBpdCBzdG9wcyB0aGUgYW5p bWF0aW9uLCBjaGFuZ2VzIHRoZSBrZXlmcmFtZXMgdG8gYW4gYW5pbWF0aW9uIG9mIHRoZSB0b3Ag cHJvcGVydHksIHJlc3RhcnRzIHRoZSBhbmltYXRpb24gYW5kIG1ha2VzIHN1cmUgdG9wIGlzIGFu aW1hdGluZy4KK1BBU1MKSW5kZXg6IExheW91dFRlc3RzL2NzczMvY2hhbmdlLWtleWZyYW1lcy5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2NzczMvY2hhbmdlLWtleWZyYW1lcy5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvY3NzMy9jaGFuZ2Uta2V5ZnJhbWVzLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTE2IEBACis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0v L1czQy8vRFREIEhUTUwgNC4wMSBUcmFuc2l0aW9uYWwvL0VOIgorICAgImh0dHA6Ly93d3cudzMu b3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+CisKKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorICA8 bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNl dD11dGYtOCI+CisgIDx0aXRsZT5UZXN0IENoYW5naW5nIEtleWZyYW1lcyBVc2luZyBDU1NPTTwv dGl0bGU+CisgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CisgICAgI2Jv eCB7CisgICAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKKyAgICAgICAgbGVmdDogMDsKKyAgICAg ICAgdG9wOiAwOworICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICB3aWR0aDogMTAwcHg7 CisgICAgICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7CisgICAgICAgIC13ZWJraXQtYW5pbWF0 aW9uLWR1cmF0aW9uOiAxczsKKyAgICAgICAgLXdlYmtpdC1hbmltYXRpb24tdGltaW5nLWZ1bmN0 aW9uOiBsaW5lYXI7CisgICAgICAgIC13ZWJraXQtYW5pbWF0aW9uLW5hbWU6ICJhbmltIjsKKyAg ICB9CisgICAgQC13ZWJraXQta2V5ZnJhbWVzICJhbmltIiB7CisgICAgICAgIGZyb20geyBsZWZ0 OiAxMDBweDsgfQorICAgICAgICA0MCUgIHsgbGVmdDogMjAwcHg7IH0KKyAgICAgICAgNjAlICB7 IGxlZnQ6IDIwMHB4OyB9CisgICAgICAgIHRvICAgeyBsZWZ0OiAzMDBweDsgfQorICAgIH0KKyAg ICA8L3N0eWxlPgorICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1 dGYtOCI+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisgICAgCisgICAgcmVzdWx0ID0gIlBBU1Mi OworICAgIGNvbnN0IGRlZmF1bHRUb2xlcmFuY2UgPSAxMDsKKyAgICAKKyAgICBmdW5jdGlvbiBp c0VxdWFsKGFjdHVhbCwgZGVzaXJlZCwgdG9sZXJhbmNlKQorICAgIHsKKyAgICAgICAgaWYgKHRv bGVyYW5jZSA9PSB1bmRlZmluZWQgfHwgdG9sZXJhbmNlID09IDApCisgICAgICAgICAgICB0b2xl cmFuY2UgPSBkZWZhdWx0VG9sZXJhbmNlOworICAgICAgICB2YXIgZGlmZiA9IE1hdGguYWJzKGFj dHVhbCAtIGRlc2lyZWQpOworICAgICAgICByZXR1cm4gZGlmZiA8IHRvbGVyYW5jZTsKKyAgICB9 CisgICAgCisgICAgZnVuY3Rpb24gc25hcHNob3QocHJvcGVydHksIGV4cGVjdGVkKQorICAgIHsK KyAgICAgICAgaWYgKHJlc3VsdCAhPSAiUEFTUyIpCisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIAorICAgICAgICB2YXIgcHJvcCA9IHBhcnNlSW50KHdpbmRvdy5nZXRDb21wdXRlZFN0eWxl KGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdib3gnKSlbcHJvcGVydHldKTsKKyAgICAgICAgaWYg KCFpc0VxdWFsKHByb3AsIGV4cGVjdGVkKSkKKyAgICAgICAgICAgIHJlc3VsdCA9ICJGQUlMKCci K3Byb3BlcnR5KyInIHByb3BlcnR5IHdhczoiK3Byb3ArIiwgZXhwZWN0ZWQ6IitleHBlY3RlZCsi KSI7CisgICAgfQorICAgIAorICAgIGZ1bmN0aW9uIGZpbmRLZXlmcmFtZXNSdWxlKHJ1bGUpCisg ICAgeworICAgICAgICB2YXIgc3MgPSBkb2N1bWVudC5zdHlsZVNoZWV0czsKKyAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCBzcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAgZm9yICh2YXIg aiA9IDA7IGogPCBzc1tpXS5jc3NSdWxlcy5sZW5ndGg7ICsraikgeworICAgICAgICAgICAgICAg IGlmIChzc1tpXS5jc3NSdWxlc1tqXS50eXBlID09IHdpbmRvdy5DU1NSdWxlLldFQktJVF9LRVlG UkFNRVNfUlVMRSAmJiBzc1tpXS5jc3NSdWxlc1tqXS5uYW1lID09IHJ1bGUpCisgICAgICAgICAg ICAgICAgICAgIHJldHVybiBzc1tpXS5jc3NSdWxlc1tqXTsKKyAgICAgICAgICAgIH0KKyAgICAg ICAgfQorICAgICAgICAKKyAgICAgICAgcmV0dXJuIG51bGw7CisgICAgfQorICAgICAgICAKKyAg ICBmdW5jdGlvbiBjaGFuZ2UoKQorICAgIHsKKyAgICAgICAgLy8gY2hhbmdlIGtleWZyYW1lcwor ICAgICAgICB2YXIga2V5ZnJhbWVzID0gZmluZEtleWZyYW1lc1J1bGUoImFuaW0iKTsKKyAgICAg ICAga2V5ZnJhbWVzLmRlbGV0ZVJ1bGUoIjAlIik7CisgICAgICAgIGtleWZyYW1lcy5kZWxldGVS dWxlKCI0MCUiKTsKKyAgICAgICAga2V5ZnJhbWVzLmRlbGV0ZVJ1bGUoIjYwJSIpOworICAgICAg ICBrZXlmcmFtZXMuZGVsZXRlUnVsZSgiMTAwJSIpOworICAgICAgICBrZXlmcmFtZXMuaW5zZXJ0 UnVsZSgiMCUgeyB0b3A6IDUwcHg7IH0iKTsKKyAgICAgICAga2V5ZnJhbWVzLmluc2VydFJ1bGUo IjQwJSB7IHRvcDogMTAwcHg7IH0iKTsKKyAgICAgICAga2V5ZnJhbWVzLmluc2VydFJ1bGUoIjYw JSB7IHRvcDogMTAwcHg7IH0iKTsKKyAgICAgICAga2V5ZnJhbWVzLmluc2VydFJ1bGUoIjEwMCUg eyB0b3A6IDE1MHB4OyB9Iik7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdib3gn KS5zdHlsZS53ZWJraXRBbmltYXRpb25OYW1lID0gImFuaW0iOworICAgICAgICAKKyAgICAgICAg c2V0VGltZW91dCgic25hcHNob3QoJ3RvcCcsIDEwMCkiLCA1MDApOworICAgICAgICAKKyAgICAg ICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gcmVzdWx0OworICAgICAgICAgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgICAgIH0sIDYwMCk7CisgICAgfQorICAg IAorICAgIGZ1bmN0aW9uIHN0YXJ0Q2hhbmdlKCkKKyAgICB7CisgICAgICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdib3gnKS5zdHlsZS53ZWJraXRBbmltYXRpb25OYW1lID0gIm5vbmUiOwor ICAgICAgICBzZXRUaW1lb3V0KCJjaGFuZ2UoKSIsIDApOworICAgIH0KKworICAgIGZ1bmN0aW9u IHN0YXJ0KCkKKyAgICB7CisgICAgICAgIGRvY3VtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoJ3dl YmtpdEFuaW1hdGlvblN0YXJ0Jywgc3RhcnQsIGZhbHNlKTsKKyAgICAgICAgc2V0VGltZW91dCgi c25hcHNob3QoJ2xlZnQnLCAyMDApIiwgNTAwKTsKKyAgICAgICAgc2V0VGltZW91dCgic3RhcnRD aGFuZ2UoKSIsIDYwMCk7CisgICAgfQorICAgIAorICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVu ZXIoJ3dlYmtpdEFuaW1hdGlvblN0YXJ0Jywgc3RhcnQsIGZhbHNlKTsKKyAgICAKKyAgPC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keT4KK1RoaXMgdGVzdCBwZXJmb3JtcyBhbiBhbmltYXRpb24gb2Yg dGhlIGxlZnQgcHJvcGVydHkgYW5kIG1ha2VzIHN1cmUgaXQgaXMgYW5pbWF0aW5nLiBUaGVuIGl0 IHN0b3BzCit0aGUgYW5pbWF0aW9uLCBjaGFuZ2VzIHRoZSBrZXlmcmFtZXMgdG8gYW4gYW5pbWF0 aW9uIG9mIHRoZSB0b3AgcHJvcGVydHksIHJlc3RhcnRzIHRoZSBhbmltYXRpb24KK2FuZCBtYWtl cyBzdXJlIHRvcCBpcyBhbmltYXRpbmcuCis8ZGl2IGlkPSJib3giPgorPC9kaXY+Cis8ZGl2IGlk PSJyZXN1bHQiPgorPC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==