214898 2020-07-28 14:42:11 -0700 Web Inspector: REGRESSION(r255396): Audit: button to exit edit mode in main content area is missing border 2022-03-01 02:26:11 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi bburg bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1675809 0 hi 2020-07-28 14:42:11 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. go to the Audit Tab 3. enter Edit mode from the navigation sidebar => the Done button in the main content area is missing a border 1675810 1 webkit-bug-importer 2020-07-28 14:42:26 -0700 <rdar://problem/66238391> 1675830 2 hi 2020-07-28 15:10:37 -0700 I'm pretty sure this was caused by the following change from r255396 <https://webkit.org/b/205434>: ``` -.message-text-view .navigation-item-help .navigation-bar > .item { +.navigation-item-help > .navigation-bar > .item { ``` 1675845 3 405425 bburg 2020-07-28 16:00:53 -0700 Created attachment 405425 Patch 1675848 4 405425 hi 2020-07-28 16:12:38 -0700 Comment on attachment 405425 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405425&action=review r=me > Source/WebInspectorUI/UserInterface/Views/Main.css:239 > .navigation-item-help > .navigation-bar > .item { we could also adjust `WI.createNavigationItemHelp` to always expect `console.assert(navigationItem instanceof WI.ButtonNavigationItem);` so that we could add `.button` to the CSS since `.text-only` only exists for `WI.ButtonNavigationItem` > Source/WebInspectorUI/UserInterface/Views/Main.css:246 > +.navigation-item-help > .navigation-bar > .item:not(.text-only) { ditto (:239) > Source/WebInspectorUI/UserInterface/Views/Main.css:250 > +.navigation-item-help > .navigation-bar > .item.text-only { ditto (:239) > Source/WebInspectorUI/UserInterface/Views/Main.css:251 > + border: solid 1px var(--border-color); It's a bit odd that we have the same CSS property repeated twice exactly as is for two rules that should both match the same thing. Perhaps you could add a comment above it explaining that this is necessary due to the specificity of `.navigation-bar .item.button.text-only`? 1675899 5 bburg 2020-07-28 21:31:35 -0700 Committed r265027: <https://trac.webkit.org/changeset/265027> 405425 2020-07-28 16:00:53 -0700 2022-03-01 02:26:11 -0800 Patch bug-214898-20200728160053.patch text/plain 2035 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm MDAyZGQzOWRlYzA0YTQwNzA1ODczNGIyNGUyYjUzODY2ZWRjZjlhLi4zMWE2MzgzMWJlNTQwNmIz M2I1NWFjMzI1OTUyNmEwOTA3YmM0MWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMC0wNy0yOCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OKHIyNTUzOTYpOiBBdWRpdDogYnV0dG9u IHRvIGV4aXQgZWRpdCBtb2RlIGluIG1haW4gY29udGVudCBhcmVhIGlzIG1pc3NpbmcgYm9yZGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ4OTgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2MjM4MzkxPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwbGl0IG91dCB0aGUgcnVsZXMgZm9yIHRleHQt b25seSBidXR0b25zLiBUaGUgcmVncmVzc2luZyBjaGFuZ2UgYWRkZWQgbW9yZSBzcGVjaWZpY2l0 eQorICAgICAgICBmb3IgdGhlIHRleHQgKyBpbWFnZSBjYXNlIHdoaWNoIG1hZGUgdGhlIGJvcmRl ciB0cmFuc3BhcmVudCBhbmQgcmVtb3ZlZCBleHRyYSBwYWRkaW5nLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9NYWluLmNzczoKKyAgICAgICAgKC5uYXZpZ2F0aW9uLWl0ZW0taGVs cCA+IC5uYXZpZ2F0aW9uLWJhciA+IC5pdGVtKToKKyAgICAgICAgKC5uYXZpZ2F0aW9uLWl0ZW0t aGVscCA+IC5uYXZpZ2F0aW9uLWJhciA+IC5pdGVtOm5vdCgudGV4dC1vbmx5KSk6CisgICAgICAg ICgubmF2aWdhdGlvbi1pdGVtLWhlbHAgPiAubmF2aWdhdGlvbi1iYXIgPiAuaXRlbS50ZXh0LW9u bHkpOgorCiAyMDIwLTA3LTIyICBDb25yYWQgU2h1bHR6ICA8Y29ucmFkX3NodWx0ekBhcHBsZS5j b20+CiAKICAgICAgICAgVXBkYXRlIG1hY09TIFZlcnNpb24gbWFjcm9zCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9NYWluLmNzcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL01haW4uY3NzCmluZGV4IDExMzIy YTczZjMyNTQ0YTcwMDEwZTdkNDU1YmY0YzY2NGY0NjY5NzguLmE4YTJkMDIyNjQzOGEwNTdkNWZj YWRlODhjNTY1NDUxYzEwYzg1ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL01haW4uY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL01haW4uY3NzCkBAIC0yMzgsMTIgKzIzOCwxOSBAQCBib2R5LmRv Y2tlZDptYXRjaGVzKC5yaWdodCwgLmxlZnQpICNuYXZpZ2F0aW9uLXNpZGViYXIuY29sbGFwc2Vk ID4gLnJlc2l6ZXIgewogCiAubmF2aWdhdGlvbi1pdGVtLWhlbHAgPiAubmF2aWdhdGlvbi1iYXIg PiAuaXRlbSB7CiAgICAgaGVpZ2h0OiAxMDAlOwotICAgIHBhZGRpbmc6IDAgNHB4ICFpbXBvcnRh bnQ7CiAgICAgZm9udC1zaXplOiAxMXB4OwogICAgIGJvcmRlci1yYWRpdXM6IDRweDsKICAgICBi b3JkZXI6IHNvbGlkIDFweCB2YXIoLS1ib3JkZXItY29sb3IpOwogfQogCisubmF2aWdhdGlvbi1p dGVtLWhlbHAgPiAubmF2aWdhdGlvbi1iYXIgPiAuaXRlbTpub3QoLnRleHQtb25seSkgeworICAg IHBhZGRpbmc6IDAgNHB4ICFpbXBvcnRhbnQ7Cit9CisKKy5uYXZpZ2F0aW9uLWl0ZW0taGVscCA+ IC5uYXZpZ2F0aW9uLWJhciA+IC5pdGVtLnRleHQtb25seSB7CisgICAgYm9yZGVyOiBzb2xpZCAx cHggdmFyKC0tYm9yZGVyLWNvbG9yKTsKK30KKwogLm1lc3NhZ2UtdGV4dC12aWV3LmVycm9yIHsK ICAgICBjb2xvcjogdmFyKC0tZXJyb3ItdGV4dC1jb2xvcik7CiB9Cg==