214886 2020-07-28 11:15:50 -0700 Web Inspector: Don't allow docking to a hidden web view 2020-07-28 12:22:19 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1675691 0 timothy 2020-07-28 11:15:50 -0700 When the Inspected Web View is hidden, don't try to attach. 1675693 1 405380 timothy 2020-07-28 11:17:48 -0700 Created attachment 405380 Patch 1675701 2 405380 hi 2020-07-28 11:40:55 -0700 Comment on attachment 405380 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405380&action=review r=me > Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:282 > + if (!m_inspectedPage || !m_inspectorPage || !platformCanAttach(m_canAttach)) NIT: can you use `platformCanAttach(canAttach())` instead? This is what other callers do, and it covers the future case where `canAttach` becomes more complex :) > Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:314 > + if (!m_inspectedPage || !m_inspectorPage || (!m_isAttached && m_isVisible)) Is `m_isVisible` necessary? 1675706 3 405386 timothy 2020-07-28 11:53:37 -0700 Created attachment 405386 Patch 1675709 4 405380 timothy 2020-07-28 11:57:32 -0700 Comment on attachment 405380 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405380&action=review >> Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:282 >> + if (!m_inspectedPage || !m_inspectorPage || !platformCanAttach(m_canAttach)) > > NIT: can you use `platformCanAttach(canAttach())` instead? This is what other callers do, and it covers the future case where `canAttach` becomes more complex :) Okay. >> Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp:314 >> + if (!m_inspectedPage || !m_inspectorPage || (!m_isAttached && m_isVisible)) > > Is `m_isVisible` necessary? Yes, since m_isAttached could be stale after close. 1675726 5 ews-feeder 2020-07-28 12:21:40 -0700 Committed r264999: <https://trac.webkit.org/changeset/264999> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405386. 1675727 6 webkit-bug-importer 2020-07-28 12:22:19 -0700 <rdar://problem/66231117> 405380 2020-07-28 11:17:48 -0700 2020-07-28 11:57:39 -0700 Patch bug-214886-20200728111748.patch text/plain 2792 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhiNDVkMzQxNmE0MWEwOWIw ZDVhMjgxYzEyOTFjNTZkOWJmNTM4NDUuLmE3Yzk0Mjg2YTA4NWM2NzMyNTE5NWFmYzQ0MmY0YjEx MDlkZTkzNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMjggIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IERv bid0IGFsbG93IGRvY2tpbmcgdG8gYSBoaWRkZW4gd2ViIHZpZXcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDg4NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJ bnNwZWN0b3JQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5Ojph dHRhY2gpOiBDYWxsIHBsYXRmb3JtQ2FuQXR0YWNoKCkgc2luY2UgaXQgY2FuIGRvIGEgbGl2ZSBj aGVjay4KKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OmRldGFjaCk6IFJldHVy biBlYXJseSBpZiBhbHJlYWR5IGF0dGFjaGVkLCBvdGhlcndpc2UgYXNzZXJ0cyBsYXRlci4KKyAg ICAgICAgKiBVSVByb2Nlc3MvSW5zcGVjdG9yL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbToK KyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ2FuQXR0YWNoKTog UmV0dXJuIGZsYXNlIHdoZW4gdGhlIHdlYiB2aWV3IGlzIGhpZGRlbi4KKwogMjAyMC0wNy0yNyAg TWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFRyeWlu ZyB0byBsb29rdXAgd2hlbiBXZWJWaWV3IGlzIGluIGEgcG9wb3ZlciBjYXVzZXMgcHJvY2VzcyB0 byBoYW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dl Ykluc3BlY3RvclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9X ZWJJbnNwZWN0b3JQcm94eS5jcHAKaW5kZXggMDExYTY2OWU0M2VjZWJmY2Q0MTkyMGI3ZGU2MWM2 ZmEyYmE2NDdkMS4uYzZlYTlhM2ZlN2IzZDI2YmJhNTM5MGExNmY4NTMxYzVjMmYxYjY3ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3RvclBy b3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5zcGVj dG9yUHJveHkuY3BwCkBAIC0yNzksNyArMjc5LDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6 YXR0YWNoTGVmdCgpCiB2b2lkIFdlYkluc3BlY3RvclByb3h5OjphdHRhY2goQXR0YWNobWVudFNp ZGUgc2lkZSkKIHsKICAgICBBU1NFUlQobV9pbnNwZWN0b3JQYWdlKTsKLSAgICBpZiAoIW1faW5z cGVjdGVkUGFnZSB8fCAhbV9pbnNwZWN0b3JQYWdlIHx8ICFjYW5BdHRhY2goKSkKKyAgICBpZiAo IW1faW5zcGVjdGVkUGFnZSB8fCAhbV9pbnNwZWN0b3JQYWdlIHx8ICFwbGF0Zm9ybUNhbkF0dGFj aChtX2NhbkF0dGFjaCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIG1faXNBdHRhY2hlZCA9IHRy dWU7CkBAIC0zMTEsNyArMzExLDcgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6YXR0YWNoKEF0 dGFjaG1lbnRTaWRlIHNpZGUpCiAKIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OmRldGFjaCgpCiB7 Ci0gICAgaWYgKCFtX2luc3BlY3RlZFBhZ2UgfHwgIW1faW5zcGVjdG9yUGFnZSkKKyAgICBpZiAo IW1faW5zcGVjdGVkUGFnZSB8fCAhbV9pbnNwZWN0b3JQYWdlIHx8ICghbV9pc0F0dGFjaGVkICYm IG1faXNWaXNpYmxlKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9pc0F0dGFjaGVkID0gZmFs c2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dl Ykluc3BlY3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9y L21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQppbmRleCBlMjA3YjU3MTA3OGEwODEzZDc1Zjgw NTIzZTIxYWVkYzA0NjZhM2MxLi5hNTU3YzgzYTRiMjhiZTU0ZTliZjllY2I1OGJkMjUyZDNlOTc1 OGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvbWFjL1dl Ykluc3BlY3RvclByb3h5TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3Bl Y3Rvci9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KQEAgLTQxMSw2ICs0MTEsOSBAQCBib29s IFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNhbkF0dGFjaChib29sIHdlYlByb2Nlc3NDYW5B dHRhY2gpCiAgICAgaWYgKFtXS0luc3BlY3RvclZpZXdDb250cm9sbGVyIHZpZXdJc0luc3BlY3Rv cldlYlZpZXc6aW5zcGVjdGVkVmlld10pCiAgICAgICAgIHJldHVybiB3ZWJQcm9jZXNzQ2FuQXR0 YWNoOwogCisgICAgaWYgKGluc3BlY3RlZFZpZXcuaGlkZGVuKQorICAgICAgICByZXR1cm4gZmFs c2U7CisKICAgICBzdGF0aWMgY29uc3QgZmxvYXQgbWluaW11bUF0dGFjaGVkSGVpZ2h0ID0gMjUw OwogICAgIHN0YXRpYyBjb25zdCBmbG9hdCBtYXhpbXVtQXR0YWNoZWRIZWlnaHRSYXRpbyA9IDAu NzU7CiAgICAgc3RhdGljIGNvbnN0IGZsb2F0IG1pbmltdW1BdHRhY2hlZFdpZHRoID0gNTAwOwo= 405386 2020-07-28 11:53:37 -0700 2020-07-28 12:21:41 -0700 Patch bug-214886-20200728115336.patch text/plain 2790 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhiNDVkMzQxNmE0MWEwOWIw ZDVhMjgxYzEyOTFjNTZkOWJmNTM4NDUuLmM0MDhjYjI2MTMxMjczN2JlZjBkOWExNWUwMjc5MTk0 YTgzZTk1ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMjggIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IERv bid0IGFsbG93IGRvY2tpbmcgdG8gYSBoaWRkZW4gd2ViIHZpZXcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDg4NgorCisgICAgICAgIFJldmlld2Vk IGJ5IERldmluIFJvdXNzby4KKworICAgICAgICAqIFVJUHJvY2Vzcy9JbnNwZWN0b3IvV2ViSW5z cGVjdG9yUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6YXR0 YWNoKTogQ2FsbCBwbGF0Zm9ybUNhbkF0dGFjaCgpIHNpbmNlIGl0IGNhbiBkbyBhIGxpdmUgY2hl Y2suCisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpkZXRhY2gpOiBSZXR1cm4g ZWFybHkgaWYgYWxyZWFkeSBhdHRhY2hlZCwgb3RoZXJ3aXNlIGFzc2VydHMgbGF0ZXIuCisgICAg ICAgICogVUlQcm9jZXNzL0luc3BlY3Rvci9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW06Cisg ICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNhbkF0dGFjaCk6IFJl dHVybiBmbGFzZSB3aGVuIHRoZSB3ZWIgdmlldyBpcyBoaWRkZW4uCisKIDIwMjAtMDctMjcgIE1l Z2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnlpbmcg dG8gbG9va3VwIHdoZW4gV2ViVmlldyBpcyBpbiBhIHBvcG92ZXIgY2F1c2VzIHByb2Nlc3MgdG8g aGFuZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJ bnNwZWN0b3JQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0b3IvV2Vi SW5zcGVjdG9yUHJveHkuY3BwCmluZGV4IDAxMWE2NjllNDNlY2ViZmNkNDE5MjBiN2RlNjFjNmZh MmJhNjQ3ZDEuLmM5M2M4MWY5ZmU4OTVlOWMzYmQ5OTAwNjJhOTFkYThkZGZmNTBhNzIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9XZWJJbnNwZWN0b3JQcm94 eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL1dlYkluc3BlY3Rv clByb3h5LmNwcApAQCAtMjc5LDcgKzI3OSw3IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OmF0 dGFjaExlZnQoKQogdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6YXR0YWNoKEF0dGFjaG1lbnRTaWRl IHNpZGUpCiB7CiAgICAgQVNTRVJUKG1faW5zcGVjdG9yUGFnZSk7Ci0gICAgaWYgKCFtX2luc3Bl Y3RlZFBhZ2UgfHwgIW1faW5zcGVjdG9yUGFnZSB8fCAhY2FuQXR0YWNoKCkpCisgICAgaWYgKCFt X2luc3BlY3RlZFBhZ2UgfHwgIW1faW5zcGVjdG9yUGFnZSB8fCAhcGxhdGZvcm1DYW5BdHRhY2go Y2FuQXR0YWNoKCkpKQogICAgICAgICByZXR1cm47CiAKICAgICBtX2lzQXR0YWNoZWQgPSB0cnVl OwpAQCAtMzExLDcgKzMxMSw3IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6OmF0dGFjaChBdHRh Y2htZW50U2lkZSBzaWRlKQogCiB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpkZXRhY2goKQogewot ICAgIGlmICghbV9pbnNwZWN0ZWRQYWdlIHx8ICFtX2luc3BlY3RvclBhZ2UpCisgICAgaWYgKCFt X2luc3BlY3RlZFBhZ2UgfHwgIW1faW5zcGVjdG9yUGFnZSB8fCAoIW1faXNBdHRhY2hlZCAmJiBt X2lzVmlzaWJsZSkpCiAgICAgICAgIHJldHVybjsKIAogICAgIG1faXNBdHRhY2hlZCA9IGZhbHNl OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL21hYy9XZWJJ bnNwZWN0b3JQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0luc3BlY3Rvci9t YWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KaW5kZXggZTIwN2I1NzEwNzhhMDgxM2Q3NWY4MDUy M2UyMWFlZGMwNDY2YTNjMS4uYTU1N2M4M2E0YjI4YmU1NGU5YmY5ZWNiNThiZDI1MmQzZTk3NThk MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvSW5zcGVjdG9yL21hYy9XZWJJ bnNwZWN0b3JQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9JbnNwZWN0 b3IvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCkBAIC00MTEsNiArNDExLDkgQEAgYm9vbCBX ZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DYW5BdHRhY2goYm9vbCB3ZWJQcm9jZXNzQ2FuQXR0 YWNoKQogICAgIGlmIChbV0tJbnNwZWN0b3JWaWV3Q29udHJvbGxlciB2aWV3SXNJbnNwZWN0b3JX ZWJWaWV3Omluc3BlY3RlZFZpZXddKQogICAgICAgICByZXR1cm4gd2ViUHJvY2Vzc0NhbkF0dGFj aDsKIAorICAgIGlmIChpbnNwZWN0ZWRWaWV3LmhpZGRlbikKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCiAgICAgc3RhdGljIGNvbnN0IGZsb2F0IG1pbmltdW1BdHRhY2hlZEhlaWdodCA9IDI1MDsK ICAgICBzdGF0aWMgY29uc3QgZmxvYXQgbWF4aW11bUF0dGFjaGVkSGVpZ2h0UmF0aW8gPSAwLjc1 OwogICAgIHN0YXRpYyBjb25zdCBmbG9hdCBtaW5pbXVtQXR0YWNoZWRXaWR0aCA9IDUwMDsK