214865 2020-07-28 01:45:49 -0700 [WPE] Make Touchpoint ID unique 2024-03-27 02:01:20 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=270516 P2 Normal --- 1 m.felsch webkit-unassigned bst bugs-noreply m.felsch zan oldest_to_newest 1675549 0 m.felsch 2020-07-28 01:45:49 -0700 [WPE] Make Touchpoint ID unique 1675556 1 405347 m.felsch 2020-07-28 02:29:00 -0700 Created attachment 405347 Patch 1686505 2 405347 zan 2020-09-08 01:05:39 -0700 Comment on attachment 405347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405347&action=review > Source/WebKit/ChangeLog:13 > + The web uses a unique touch point id. A few touch controllers reporting > + a unique ID by ABS_MT_TRACKING_ID [1] but libinput and the wayland-protocol > + don't take this information into account. Fix this within webkit to be > + independent of libinput, the wayland-protocol and a wayland-compositor. Can you please elaborate in more detail what failures in the libinput/wayland infrastructure this change tries to work around? 1693653 3 405347 m.felsch 2020-09-30 23:03:01 -0700 Comment on attachment 405347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405347&action=review >> Source/WebKit/ChangeLog:13 >> + independent of libinput, the wayland-protocol and a wayland-compositor. > > Can you please elaborate in more detail what failures in the libinput/wayland infrastructure this change tries to work around? As I wrote a few input event devices delivering a unique ID but this gets ignored by libinput and isn't covered by the wayland-protocol at all. Currently we are using the non unique touchpoint number to fill the web.touchpointID event. This is forbidden by the Spec if I got it correctly. You can see the different behavior if you call your test page: https://people.igalia.com/clopez/wkbug/pointer-events/test.html on an iOS-Port Safari browser or on an WPE-Port cog (embedded device with touch is required). 1745062 4 m.felsch 2021-03-30 01:49:35 -0700 Ping 1930832 5 bst 2023-02-03 05:41:55 -0800 Updated version of the patch: https://github.com/WebKit/WebKit/pull/9599 1950343 6 ews-feeder 2023-04-21 06:28:35 -0700 Committed 263237@main (057b735cbf91): <https://commits.webkit.org/263237@main> Reviewed commits have been landed. Closing PR #9599 and removing active labels. 405347 2020-07-28 02:29:00 -0700 2020-07-28 02:29:00 -0700 Patch bug-214865-20200728112859.patch text/plain 3234 m.felsch U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYwMGNkYTczYTZhZWI2ZWZl NDBhNTYyOTdjN2FlMmQ2YmQ5ZDA1YzQuLjBiOGIxOGNhOWNhZGU0NWUxN2Q4YzMyYThiNWFmZTI3 MTJjYzRkMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDctMjggIE1hcmNvIEZl bHNjaCAgPG0uZmVsc2NoQHBlbmd1dHJvbml4LmRlPgorCisgICAgICAgIFtXUEVdIE1ha2UgVG91 Y2hwb2ludCBJRCB1bmlxdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNDg2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgVGhlIHdlYiB1c2VzIGEg dW5pcXVlIHRvdWNoIHBvaW50IGlkLiBBIGZldyB0b3VjaCBjb250cm9sbGVycyByZXBvcnRpbmcK KyAgICAgICAgYSB1bmlxdWUgSUQgYnkgQUJTX01UX1RSQUNLSU5HX0lEIFsxXSBidXQgbGliaW5w dXQgYW5kIHRoZSB3YXlsYW5kLXByb3RvY29sCisgICAgICAgIGRvbid0IHRha2UgdGhpcyBpbmZv cm1hdGlvbiBpbnRvIGFjY291bnQuIEZpeCB0aGlzIHdpdGhpbiB3ZWJraXQgdG8gYmUKKyAgICAg ICAgaW5kZXBlbmRlbnQgb2YgbGliaW5wdXQsIHRoZSB3YXlsYW5kLXByb3RvY29sIGFuZCBhIHdh eWxhbmQtY29tcG9zaXRvci4KKworICAgICAgICBbMV0gaHR0cHM6Ly93d3cua2VybmVsLm9yZy9k b2MvaHRtbC9sYXRlc3QvaW5wdXQvbXVsdGktdG91Y2gtcHJvdG9jb2wuaHRtbD9oaWdobGlnaHQ9 YWJzX210X3RyYWNraW5nX2lkI2V2ZW50LXNlbWFudGljcworCisgICAgICAgICogU2hhcmVkL2xp YndwZS9XZWJFdmVudEZhY3RvcnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJFdmVudEZhY3Rv cnk6OmNyZWF0ZVdlYlRvdWNoRXZlbnQpOgorCiAyMDIwLTA3LTI3ICBNYXJjbyBGZWxzY2ggIDxt LmZlbHNjaEBwZW5ndXRyb25peC5kZT4KIAogICAgICAgICBbV1BFXSBnYXJkZW5pbmcgc2Nyb2xs IGdlc3R1cmUgY29udHJvbGxlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvbGli d3BlL1dlYkV2ZW50RmFjdG9yeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9saWJ3cGUvV2Vi RXZlbnRGYWN0b3J5LmNwcAppbmRleCA2MTU1NjI1OTdlZGUyZGU1OGU3Y2M3MzVjZGUzODQxMDMw OTcyNzI4Li43MzJlNThjODJhMjgxMDE0MTZjODcxMzQ0ZmI2YzU0Y2I4MDViMzY0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9saWJ3cGUvV2ViRXZlbnRGYWN0b3J5LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9saWJ3cGUvV2ViRXZlbnRGYWN0b3J5LmNwcApAQCAtMzEs NiArMzEsMTAgQEAKICNpbmNsdWRlIDxjbWF0aD4KICNpbmNsdWRlIDx3cGUvd3BlLmg+CiAKKyNp ZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQorI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CisjZW5kaWYK KwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIHN0YXRpYyBpbmxpbmUgYm9vbCBpc1dQRUtleUNvZGVG cm9tS2V5UGFkKHVuc2lnbmVkIGtleUNvZGUpCkBAIC0yMzAsMTUgKzIzNCwyNCBAQCBzdGF0aWMg V2ViS2l0OjpXZWJQbGF0Zm9ybVRvdWNoUG9pbnQ6OlRvdWNoUG9pbnRTdGF0ZSBzdGF0ZUZvclRv dWNoUG9pbnQoaW50IG1haQogV2ViVG91Y2hFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdl YlRvdWNoRXZlbnQoc3RydWN0IHdwZV9pbnB1dF90b3VjaF9ldmVudCogZXZlbnQsIGZsb2F0IGRl dmljZVNjYWxlRmFjdG9yKQogewogICAgIFdlYkV2ZW50OjpUeXBlIHR5cGUgPSBXZWJFdmVudDo6 Tm9UeXBlOworICAgIHN0YXRpYyBIYXNoTWFwPGludDMyX3QsIGludDMyX3Q+IGFjdGl2ZVRyYWNr aW5nVG91Y2hQb2ludHM7CisgICAgc3RhdGljIGludDMyX3QgdW5pcXVlVG91Y2hQb2ludElkOwor ICAgIGludDMyX3QgcG9pbnRJZDsKKwogICAgIHN3aXRjaCAoZXZlbnQtPnR5cGUpIHsKICAgICBj YXNlIHdwZV9pbnB1dF90b3VjaF9ldmVudF90eXBlX2Rvd246CiAgICAgICAgIHR5cGUgPSBXZWJF dmVudDo6VG91Y2hTdGFydDsKKyAgICAgICAgYWN0aXZlVHJhY2tpbmdUb3VjaFBvaW50cy5hZGQo ZXZlbnQtPmlkLCB1bmlxdWVUb3VjaFBvaW50SWQpOworICAgICAgICBwb2ludElkID0gdW5pcXVl VG91Y2hQb2ludElkOworICAgICAgICB1bmlxdWVUb3VjaFBvaW50SWQrKzsKICAgICAgICAgYnJl YWs7CiAgICAgY2FzZSB3cGVfaW5wdXRfdG91Y2hfZXZlbnRfdHlwZV9tb3Rpb246CiAgICAgICAg IHR5cGUgPSBXZWJFdmVudDo6VG91Y2hNb3ZlOworICAgICAgICBwb2ludElkID0gYWN0aXZlVHJh Y2tpbmdUb3VjaFBvaW50cy5nZXQoZXZlbnQtPmlkKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSB3cGVfaW5wdXRfdG91Y2hfZXZlbnRfdHlwZV91cDoKICAgICAgICAgdHlwZSA9IFdlYkV2ZW50 OjpUb3VjaEVuZDsKKyAgICAgICAgcG9pbnRJZCA9IGFjdGl2ZVRyYWNraW5nVG91Y2hQb2ludHMu dGFrZShldmVudC0+aWQpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIHdwZV9pbnB1dF90b3Vj aF9ldmVudF90eXBlX251bGw6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpAQCAtMjU1 LDcgKzI2OCw3IEBAIFdlYlRvdWNoRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJUb3Vj aEV2ZW50KHN0cnVjdCB3cGVfaW5wdXRfdG91Y2hfZXZlbnQqCiAgICAgICAgIFdlYkNvcmU6Oklu dFBvaW50IHBvaW50Q29vcmRpbmF0ZXMocG9pbnQueCwgcG9pbnQueSk7CiAgICAgICAgIHBvaW50 Q29vcmRpbmF0ZXMuc2NhbGUoMSAvIGRldmljZVNjYWxlRmFjdG9yKTsKICAgICAgICAgdG91Y2hQ b2ludHMudW5jaGVja2VkQXBwZW5kKAotICAgICAgICAgICAgV2ViS2l0OjpXZWJQbGF0Zm9ybVRv dWNoUG9pbnQocG9pbnQuaWQsIHN0YXRlRm9yVG91Y2hQb2ludChldmVudC0+aWQsICZwb2ludCks CisgICAgICAgICAgICBXZWJLaXQ6OldlYlBsYXRmb3JtVG91Y2hQb2ludChwb2ludElkLCBzdGF0 ZUZvclRvdWNoUG9pbnQoZXZlbnQtPmlkLCAmcG9pbnQpLAogICAgICAgICAgICAgICAgIHBvaW50 Q29vcmRpbmF0ZXMsIHBvaW50Q29vcmRpbmF0ZXMpKTsKICAgICB9CiAK