214844 2020-07-27 13:05:08 -0700 [Big Sur] Wrap SPI in feature guards 2020-07-28 14:43:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214707 InRadar P2 Normal --- 1 jbedard jbedard ap darin saagar thorton webkit-bug-importer oldest_to_newest 1675364 0 jbedard 2020-07-27 13:05:08 -0700 There is some Big Sur SPI declarations that should arguably be behind a feature flag. 1675373 1 webkit-bug-importer 2020-07-27 13:14:37 -0700 <rdar://problem/66178527> 1675374 2 405306 jbedard 2020-07-27 13:20:18 -0700 Created attachment 405306 Patch 1675375 3 405306 ap 2020-07-27 13:25:02 -0700 Comment on attachment 405306 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405306&action=review > Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:39 > extern const NSImageHintKey NSImageHintSymbolFont; Pre-existing issue, but this shouldn't be in #else, correct? We want the compiler to tell us if the type is incorrect. 1675380 4 405307 jbedard 2020-07-27 13:40:36 -0700 Created attachment 405307 Patch 1675401 5 ews-feeder 2020-07-27 15:00:01 -0700 Committed r264946: <https://trac.webkit.org/changeset/264946> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405307. 1675704 6 saagar 2020-07-28 11:47:19 -0700 Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes build errors :( I'll put up a new patch to move it back into. 1675794 7 jbedard 2020-07-28 14:17:34 -0700 Reopening to attach new patch. 1675795 8 405413 jbedard 2020-07-28 14:17:35 -0700 Created attachment 405413 Patch for landing 1675799 9 jbedard 2020-07-28 14:23:25 -0700 (In reply to Saagar Jha from comment #6) > Sadly, this moves the code out of the NS_ASSUME_NONNULL region and causes > build errors :( I'll put up a new patch to move it back into. Oops! Build fix incoming. Bots will be up for Seed 3 shortly, so we'll be more formally defending this build. 1675812 10 ews-feeder 2020-07-28 14:43:47 -0700 Committed r265010: <https://trac.webkit.org/changeset/265010> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405413. 405306 2020-07-27 13:20:18 -0700 2020-07-27 13:40:34 -0700 Patch bug-214844-20200727132017.patch text/plain 1228 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjY0OTQwKQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3 LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbQmln IFN1cl0gV3JhcCBTUEkgaW4gZmVhdHVyZSBndWFyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDg0NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjYxNzg1Mjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwYWwvc3BpL21hYy9OU0ltYWdlU1BJLmg6CisKIDIwMjAtMDctMjcgIFNhYWdhciBKaGEg IDxzYWFnYXJAc2FhZ2FyamhhLmNvbT4KIAogICAgICAgICBSZW1vdmUgZGVmaW5pdGlvbiBvZiBO U0ltYWdlU3ltYm9sU2NhbGUsIHdoaWNoIGlzIHBhcnQgb2YgdGhlIGJldGEgMyBTREsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0ltYWdlU1BJLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAkocmV2aXNpb24g MjY0OTM5KQorKysgU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAko d29ya2luZyBjb3B5KQpAQCAtMzUsOCArMzUsMTAgQEAKIAogTlNfQVNTVU1FX05PTk5VTExfQkVH SU4KIAorI2lmIEhBVkUoQUxURVJOQVRFX0lDT05TKQogZXh0ZXJuIGNvbnN0IE5TSW1hZ2VIaW50 S2V5IE5TSW1hZ2VIaW50U3ltYm9sRm9udDsKIGV4dGVybiBjb25zdCBOU0ltYWdlSGludEtleSBO U0ltYWdlSGludFN5bWJvbFNjYWxlOworI2VuZGlmCiAKIEBpbnRlcmZhY2UgTlNJbWFnZSAoKQog LSAodm9pZClsb2NrRm9jdXNXaXRoUmVjdDooTlNSZWN0KXJlY3QgY29udGV4dDoobnVsbGFibGUg TlNHcmFwaGljc0NvbnRleHQgKiljb250ZXh0IGhpbnRzOihudWxsYWJsZSBOU0RpY3Rpb25hcnkg KiloaW50cyBmbGlwcGVkOihCT09MKWZsaXBwZWQ7Cg== 405307 2020-07-27 13:40:36 -0700 2020-07-28 14:17:32 -0700 Patch bug-214844-20200727134035.patch text/plain 1400 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjY0OTQwKQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3 LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbQmln IFN1cl0gV3JhcCBTUEkgaW4gZmVhdHVyZSBndWFyZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDg0NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjYxNzg1Mjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwYWwvc3BpL21hYy9OU0ltYWdlU1BJLmg6CisKIDIwMjAtMDctMjcgIFNhYWdhciBKaGEg IDxzYWFnYXJAc2FhZ2FyamhhLmNvbT4KIAogICAgICAgICBSZW1vdmUgZGVmaW5pdGlvbiBvZiBO U0ltYWdlU3ltYm9sU2NhbGUsIHdoaWNoIGlzIHBhcnQgb2YgdGhlIGJldGEgMyBTREsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0ltYWdlU1BJLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAkocmV2aXNpb24g MjY0OTM5KQorKysgU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAko d29ya2luZyBjb3B5KQpAQCAtMzUsOSArMzUsNiBAQAogCiBOU19BU1NVTUVfTk9OTlVMTF9CRUdJ TgogCi1leHRlcm4gY29uc3QgTlNJbWFnZUhpbnRLZXkgTlNJbWFnZUhpbnRTeW1ib2xGb250Owot ZXh0ZXJuIGNvbnN0IE5TSW1hZ2VIaW50S2V5IE5TSW1hZ2VIaW50U3ltYm9sU2NhbGU7Ci0KIEBp bnRlcmZhY2UgTlNJbWFnZSAoKQogLSAodm9pZClsb2NrRm9jdXNXaXRoUmVjdDooTlNSZWN0KXJl Y3QgY29udGV4dDoobnVsbGFibGUgTlNHcmFwaGljc0NvbnRleHQgKiljb250ZXh0IGhpbnRzOihu dWxsYWJsZSBOU0RpY3Rpb25hcnkgKiloaW50cyBmbGlwcGVkOihCT09MKWZsaXBwZWQ7CiBAZW5k CkBAIC01MCw0ICs0Nyw5IEBAIE5TX0FTU1VNRV9OT05OVUxMX0VORAogCiAjZW5kaWYKIAorI2lm IEhBVkUoQUxURVJOQVRFX0lDT05TKQorZXh0ZXJuIGNvbnN0IE5TSW1hZ2VIaW50S2V5IE5TSW1h Z2VIaW50U3ltYm9sRm9udDsKK2V4dGVybiBjb25zdCBOU0ltYWdlSGludEtleSBOU0ltYWdlSGlu dFN5bWJvbFNjYWxlOworI2VuZGlmCisKICNlbmRpZgo= 405413 2020-07-28 14:17:35 -0700 2020-07-28 14:43:48 -0700 Patch for landing bug-214844-20200728141734.patch text/plain 1136 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjY1MDA2KQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3 LTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbQmln IFN1cl0gV3JhcCBTUEkgaW4gZmVhdHVyZSBndWFyZHMgKEZvbGxvdy11cCBmaXgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ4NDQKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzY2MTc4NTI3PgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4 LgorCisgICAgICAgICogcGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oOiBHdWFyZCBTUEkgd2l0aCBO U19BU1NVTUVfTk9OTlVMTC4KKwogMjAyMC0wNy0yNyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFy ZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0JpZyBTdXJdIFdyYXAgU1BJIGluIGZlYXR1cmUgZ3Vh cmRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0ltYWdlU1BJLmgJ KHJldmlzaW9uIDI2NTAwNSkKKysrIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0lt YWdlU1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDggKzQ4LDE0IEBAIE5TX0FTU1VNRV9OT05O VUxMX0VORAogI2VuZGlmCiAKICNpZiBIQVZFKEFMVEVSTkFURV9JQ09OUykKKworTlNfQVNTVU1F X05PTk5VTExfQkVHSU4KKwogZXh0ZXJuIGNvbnN0IE5TSW1hZ2VIaW50S2V5IE5TSW1hZ2VIaW50 U3ltYm9sRm9udDsKIGV4dGVybiBjb25zdCBOU0ltYWdlSGludEtleSBOU0ltYWdlSGludFN5bWJv bFNjYWxlOworCitOU19BU1NVTUVfTk9OTlVMTF9FTkQKKwogI2VuZGlmCiAKICNlbmRpZgo=