214837 2020-07-27 11:07:03 -0700 ASSERTION FAILED: isSymbol() in Source/JavaScriptCore/runtime/JSCell.cpp(188) 2020-07-28 09:38:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Linux RESOLVED FIXED InRadar P2 Critical --- 1 wmrabb mark.lam bfulgham darin ews-watchlist keith_miller mark.lam msaboff product-security saam tzagallo webkit-bug-importer oldest_to_newest 1675314 0 405296 wmrabb 2020-07-27 11:07:03 -0700 Created attachment 405296 The JS file that causes a crash in the built JSC binary I've attached the JS file that causes a crash on an asan-enabled JavaScriptCore binary. Here is how I built the binary (note: the commit hash for the version of WebKit I used is 3215a5ce92987ec8184b9133114e9f8213ae43ab): ===================== git clone git://git.webkit.org/WebKit.git cd WebKit Tools/Scripts/set-webkit-configuration --asan --debug Tools/Scripts/build-webkit --debug --jsc-only ===================== Here is the output of JSC: ===================== ASSERTION FAILED: isSymbol() ../../Source/JavaScriptCore/runtime/JSCell.cpp(188) : JSC::JSObject* JSC::JSCell::toObjectSlow(JSC::JSGlobalObject*) const Aborted ===================== This is the function where it crashes (the arrow denotes the exact line): ===================== JSObject* JSCell::toObjectSlow(JSGlobalObject* globalObject) const { Integrity::auditStructureID(globalObject->vm(), structureID()); ASSERT(!isObject()); if (isString()) return static_cast<const JSString*>(this)->toObject(globalObject); if (isHeapBigInt()) return static_cast<const JSBigInt*>(this)->toObject(globalObject); =====> ASSERT(isSymbol()); return static_cast<const Symbol*>(this)->toObject(globalObject); } ===================== 1675315 1 webkit-bug-importer 2020-07-27 11:07:19 -0700 <rdar://problem/66171782> 1675497 2 mark.lam 2020-07-27 19:04:19 -0700 This is not a real bug. The test was iterating over special properties in the jsc shell that are only for testing use. This scenario cannot manifest in any productized version of JSC because these special test properties will not be present. I'll put together a patch to make all the special test properties non-enumerable so that they will stop tripping up people who doing blind enumeration on the jsc shell's test global object. 1675508 3 mark.lam 2020-07-27 20:44:10 -0700 Thanks for this report. I will upload a patch to mitigate this issue shortly. 1675509 4 405339 mark.lam 2020-07-27 20:44:52 -0700 Created attachment 405339 proposed patch. 1675628 5 405339 darin 2020-07-28 09:13:03 -0700 Comment on attachment 405339 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=405339&action=review > Source/JavaScriptCore/jsc.cpp:477 > + static constexpr unsigned DontEnum = 0 | PropertyAttribute::DontEnum; What is the purpose of the "0 |" here? Is it a way to convert an enumeration value to an integer? Why is it better than static_cast? 1675638 6 405339 mark.lam 2020-07-28 09:21:08 -0700 Comment on attachment 405339 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=405339&action=review Thanks for the review. >> Source/JavaScriptCore/jsc.cpp:477 >> + static constexpr unsigned DontEnum = 0 | PropertyAttribute::DontEnum; > > What is the purpose of the "0 |" here? Is it a way to convert an enumeration value to an integer? Why is it better than static_cast? Yes, it's for converting the enumeration into an integer. I chose it because it's less verbose than a static_cast<unsigned> cast. It's better in my eyes because it concisely expresses the idea, but "better" here is subjective. 1675642 7 405339 darin 2020-07-28 09:29:37 -0700 Comment on attachment 405339 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=405339&action=review >>> Source/JavaScriptCore/jsc.cpp:477 >>> + static constexpr unsigned DontEnum = 0 | PropertyAttribute::DontEnum; >> >> What is the purpose of the "0 |" here? Is it a way to convert an enumeration value to an integer? Why is it better than static_cast? > > Yes, it's for converting the enumeration into an integer. I chose it because it's less verbose than a static_cast<unsigned> cast. It's better in my eyes because it concisely expresses the idea, but "better" here is subjective. It’s oblique. Prettier and more elegant if you understand it, but no connotation of "converting type" unless you happen to know the idiom. 1675647 8 405339 mark.lam 2020-07-28 09:35:42 -0700 Comment on attachment 405339 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=405339&action=review >>>> Source/JavaScriptCore/jsc.cpp:477 >>>> + static constexpr unsigned DontEnum = 0 | PropertyAttribute::DontEnum; >>> >>> What is the purpose of the "0 |" here? Is it a way to convert an enumeration value to an integer? Why is it better than static_cast? >> >> Yes, it's for converting the enumeration into an integer. I chose it because it's less verbose than a static_cast<unsigned> cast. It's better in my eyes because it concisely expresses the idea, but "better" here is subjective. > > It’s oblique. Prettier and more elegant if you understand it, but no connotation of "converting type" unless you happen to know the idiom. There are places where we set more than one attribute value using enums (e.g. PropertyAttribute::DontEnum | PropertyAttribute::DontDelete). In those places, we also don't do the static_cast, and arguably, one would also have to understand the same idiom to understand why it works. I think we should adopt this idiom. Also, it's a very common idiom for "converting to integer" in JS code. Given that this is JSC, the idiom should not be that foreign. 1675650 9 ews-feeder 2020-07-28 09:38:40 -0700 Committed r264991: <https://trac.webkit.org/changeset/264991> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405339. 405296 2020-07-27 11:07:03 -0700 2020-07-27 11:07:03 -0700 The JS file that causes a crash in the built JSC binary testcase.js text/javascript 230 wmrabb ZnVuY3Rpb24gdjAodjEpew0KICAgICAgICBmb3IodmFyIHYyIGluIHYxKXsNCiAgICAgICAgICAg ICAgICBmb3IodmFyIHYzIGluIHYxW3YyXSl7DQogICAgICAgICAgICAgICAgfQ0KICAgICAgICB9 DQp9DQp2YXIgdjQgPSAoZnVuY3Rpb24gKCl7DQogICAgICAgIGZvcih2YXIgdjEgaW4gdGhpcyl7 DQogICAgICAgICAgICAgICAgdjAodGhpc1t2MV0pOw0KICAgICAgICB9DQp9KTsNCnY0KCdsY2wn KTs= 405339 2020-07-27 20:44:52 -0700 2020-07-28 09:38:41 -0700 proposed patch. bug-214837.patch text/plain 7568 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjQ5NjIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIwLTA3LTI3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBpc1N5bWJvbCgpIGluIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTQ2VsbC5jcHAoMTg4KQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0ODM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvanNjLXNoZWxsLXRlc3QtcHJvcGVy dGllcy1zaG91bGQtbm90LWJlLWVudW1lcmFibGUuanM6IEFkZGVkLgorCiAyMDIwLTA3LTI1ICBZ dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHRlc3Qy NjIKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2pzYy1zaGVsbC10ZXN0LXByb3BlcnRpZXMtc2hvdWxk LW5vdC1iZS1lbnVtZXJhYmxlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2pzYy1z aGVsbC10ZXN0LXByb3BlcnRpZXMtc2hvdWxkLW5vdC1iZS1lbnVtZXJhYmxlLmpzCShub25leGlz dGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2pzYy1zaGVsbC10ZXN0LXByb3BlcnRpZXMtc2hvdWxk LW5vdC1iZS1lbnVtZXJhYmxlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTUgQEAKKy8v QCBydW5EZWZhdWx0CisKK2Z1bmN0aW9uIGJhcihvKSB7CisgICAgZm9yICh2YXIgeCBpbiBvKSB7 CisgICAgICAgIGZvcih2YXIgeSBpbiBvW3hdKSB7IH0KKyAgICB9Cit9CisKK3ZhciBmb28gPSAo ZnVuY3Rpb24gKCkgeworICAgIGZvciAodmFyIHByb3AgaW4gdGhpcykgeworICAgICAgICBiYXIo dGhpc1twcm9wXSk7CisgICAgfQorfSk7CisKK2ZvbygpOwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjQ5MjYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDctMjcgIE1hcmsgTGFt ICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IGlzU3lt Ym9sKCkgaW4gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmNwcCgxODgpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ4MzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgaXNzdWUg Zm91bmQgYnkgdGhpcyBidWcgd2FzIHRoYXQganNjIHNoZWxsIHRlc3QgcHJvcGVydGllcyB3ZXJl IGVudW1lcmFibGUuCisgICAgICAgIFRoZXNlIHByb3BlcnRpZXMgYXJlIG9ubHkgbWVhbnQgZm9y IHRlc3QgZGV2ZWxvcG1lbnQgdXNlLiAgVGhleSB3aWxsIG5ldmVyIGJlCisgICAgICAgIHByZXNl bnQgaW4gYSBwcm9kdWN0aXplZCBKYXZhU2NyaXB0IGVudmlyb25tZW50LgorCisgICAgICAgIFRo aXMgcGF0Y2ggaGVscHMgcmVkdWNlIHRoZSBjaGFuZ2Ugb2YgdXNlcnMgb2YgdGhlIGpzYyBzaGVs bCB0cmlwcGluZyB1cCBvbiB0aGVzZQorICAgICAgICB0ZXN0IHByb3BlcnRpZXMgd2hlbiBlbnVt ZXJhdGluZyB0aGUgZ2xvYmFsIG9iamVjdC4KKworICAgICAgICAqIGpzYy5jcHA6CisKIDIwMjAt MDctMjQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIHBsdWdpbkVs ZW1lbnRDdXN0b21HZXRPd25Qcm9wZXJ0eVNsb3QoKSBzaG91bGQgc3VwcG9ydCBWTUlucXVpcnkg cmVxdWVzdHMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gMjY0OTI2KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ3NCw2ICs0 NzQsOCBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIEdsb2JhbE9iamVjdChWTSYsIFN0cnVjdHVy ZSopOwogCisgICAgc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBEb250RW51bSA9IDAgfCBQcm9w ZXJ0eUF0dHJpYnV0ZTo6RG9udEVudW07CisKICAgICB2b2lkIGZpbmlzaENyZWF0aW9uKFZNJiB2 bSwgY29uc3QgVmVjdG9yPFN0cmluZz4mIGFyZ3VtZW50cykKICAgICB7CiAgICAgICAgIEJhc2U6 OmZpbmlzaENyZWF0aW9uKHZtKTsKQEAgLTUyMSwxMiArNTIzLDEyIEBAIHByaXZhdGU6CiAgICAg ICAgIGFkZEZ1bmN0aW9uKHZtLCAiY2xlYXJTYW1wbGluZ0ZsYWdzIiwgZnVuY3Rpb25DbGVhclNh bXBsaW5nRmxhZ3MsIDEpOwogI2VuZGlmCiAKLSAgICAgICAgcHV0RGlyZWN0TmF0aXZlRnVuY3Rp b24odm0sIHRoaXMsIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJPU1JFeGl0IiksIDAsIGZ1 bmN0aW9uVW5kZWZpbmVkMSwgT1NSRXhpdEludHJpbnNpYywgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KFByb3BlcnR5QXR0cmlidXRlOjpEb250RW51bSkpOwotICAgICAgICBwdXREaXJlY3ROYXRpdmVG dW5jdGlvbih2bSwgdGhpcywgSWRlbnRpZmllcjo6ZnJvbVN0cmluZyh2bSwgImlzRmluYWxUaWVy IiksIDAsIGZ1bmN0aW9uRmFsc2UsIElzRmluYWxUaWVySW50cmluc2ljLCBzdGF0aWNfY2FzdDx1 bnNpZ25lZD4oUHJvcGVydHlBdHRyaWJ1dGU6OkRvbnRFbnVtKSk7Ci0gICAgICAgIHB1dERpcmVj dE5hdGl2ZUZ1bmN0aW9uKHZtLCB0aGlzLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKHZtLCAicHJl ZGljdEludDMyIiksIDAsIGZ1bmN0aW9uVW5kZWZpbmVkMiwgU2V0SW50MzJIZWFwUHJlZGljdGlv bkludHJpbnNpYywgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KFByb3BlcnR5QXR0cmlidXRlOjpEb250 RW51bSkpOwotICAgICAgICBwdXREaXJlY3ROYXRpdmVGdW5jdGlvbih2bSwgdGhpcywgSWRlbnRp Zmllcjo6ZnJvbVN0cmluZyh2bSwgImlzSW50MzIiKSwgMCwgZnVuY3Rpb25Jc0ludDMyLCBDaGVj a0ludDMySW50cmluc2ljLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oUHJvcGVydHlBdHRyaWJ1dGU6 OkRvbnRFbnVtKSk7Ci0gICAgICAgIHB1dERpcmVjdE5hdGl2ZUZ1bmN0aW9uKHZtLCB0aGlzLCBJ ZGVudGlmaWVyOjpmcm9tU3RyaW5nKHZtLCAiaXNQdXJlTmFOIiksIDAsIGZ1bmN0aW9uSXNQdXJl TmFOLCBDaGVja0ludDMySW50cmluc2ljLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oUHJvcGVydHlB dHRyaWJ1dGU6OkRvbnRFbnVtKSk7Ci0gICAgICAgIHB1dERpcmVjdE5hdGl2ZUZ1bmN0aW9uKHZt LCB0aGlzLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKHZtLCAiZmlhdEludDUyIiksIDAsIGZ1bmN0 aW9uSWRlbnRpdHksIEZpYXRJbnQ1MkludHJpbnNpYywgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KFBy b3BlcnR5QXR0cmlidXRlOjpEb250RW51bSkpOworICAgICAgICBwdXREaXJlY3ROYXRpdmVGdW5j dGlvbih2bSwgdGhpcywgSWRlbnRpZmllcjo6ZnJvbVN0cmluZyh2bSwgIk9TUkV4aXQiKSwgMCwg ZnVuY3Rpb25VbmRlZmluZWQxLCBPU1JFeGl0SW50cmluc2ljLCBEb250RW51bSk7CisgICAgICAg IHB1dERpcmVjdE5hdGl2ZUZ1bmN0aW9uKHZtLCB0aGlzLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5n KHZtLCAiaXNGaW5hbFRpZXIiKSwgMCwgZnVuY3Rpb25GYWxzZSwgSXNGaW5hbFRpZXJJbnRyaW5z aWMsIERvbnRFbnVtKTsKKyAgICAgICAgcHV0RGlyZWN0TmF0aXZlRnVuY3Rpb24odm0sIHRoaXMs IElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJwcmVkaWN0SW50MzIiKSwgMCwgZnVuY3Rpb25V bmRlZmluZWQyLCBTZXRJbnQzMkhlYXBQcmVkaWN0aW9uSW50cmluc2ljLCBEb250RW51bSk7Cisg ICAgICAgIHB1dERpcmVjdE5hdGl2ZUZ1bmN0aW9uKHZtLCB0aGlzLCBJZGVudGlmaWVyOjpmcm9t U3RyaW5nKHZtLCAiaXNJbnQzMiIpLCAwLCBmdW5jdGlvbklzSW50MzIsIENoZWNrSW50MzJJbnRy aW5zaWMsIERvbnRFbnVtKTsKKyAgICAgICAgcHV0RGlyZWN0TmF0aXZlRnVuY3Rpb24odm0sIHRo aXMsIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJpc1B1cmVOYU4iKSwgMCwgZnVuY3Rpb25J c1B1cmVOYU4sIENoZWNrSW50MzJJbnRyaW5zaWMsIERvbnRFbnVtKTsKKyAgICAgICAgcHV0RGly ZWN0TmF0aXZlRnVuY3Rpb24odm0sIHRoaXMsIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJm aWF0SW50NTIiKSwgMCwgZnVuY3Rpb25JZGVudGl0eSwgRmlhdEludDUySW50cmluc2ljLCBEb250 RW51bSk7CiAgICAgICAgIAogICAgICAgICBhZGRGdW5jdGlvbih2bSwgImVmZmVjdGZ1bDQyIiwg ZnVuY3Rpb25FZmZlY3RmdWw0MiwgMCk7CiAgICAgICAgIGFkZEZ1bmN0aW9uKHZtLCAibWFrZU1h c3F1ZXJhZGVyIiwgZnVuY3Rpb25NYWtlTWFzcXVlcmFkZXIsIDApOwpAQCAtNTgyLDIyICs1ODQs MjIgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIEpTQXJyYXkqIGFycmF5ID0gY29uc3RydWN0RW1w dHlBcnJheSh0aGlzLCBudWxscHRyKTsKICAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBp IDwgYXJndW1lbnRzLnNpemUoKTsgKytpKQogICAgICAgICAgICAgICAgIGFycmF5LT5wdXREaXJl Y3RJbmRleCh0aGlzLCBpLCBqc1N0cmluZyh2bSwgYXJndW1lbnRzW2ldKSk7Ci0gICAgICAgICAg ICBwdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJhcmd1bWVudHMiKSwg YXJyYXkpOworICAgICAgICAgICAgcHV0RGlyZWN0KHZtLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5n KHZtLCAiYXJndW1lbnRzIiksIGFycmF5LCBEb250RW51bSk7CiAgICAgICAgIH0KIAotICAgICAg ICBwdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJjb25zb2xlIiksIGpz VW5kZWZpbmVkKCkpOworICAgICAgICBwdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21TdHJp bmcodm0sICJjb25zb2xlIiksIGpzVW5kZWZpbmVkKCksIERvbnRFbnVtKTsKICAgICAgICAgCiAg ICAgICAgIFN0cnVjdHVyZSogcGxhaW5PYmplY3RTdHJ1Y3R1cmUgPSBKU0ZpbmFsT2JqZWN0Ojpj cmVhdGVTdHJ1Y3R1cmUodm0sIHRoaXMsIG9iamVjdFByb3RvdHlwZSgpLCAwKTsKICAgICAgICAg CiAgICAgICAgIEpTT2JqZWN0KiBkb2xsYXIgPSBKU0ZpbmFsT2JqZWN0OjpjcmVhdGUodm0sIHBs YWluT2JqZWN0U3RydWN0dXJlKTsKLSAgICAgICAgcHV0RGlyZWN0KHZtLCBJZGVudGlmaWVyOjpm cm9tU3RyaW5nKHZtLCAiJCIpLCBkb2xsYXIpOwotICAgICAgICBwdXREaXJlY3Qodm0sIElkZW50 aWZpZXI6OmZyb21TdHJpbmcodm0sICIkMjYyIiksIGRvbGxhcik7CisgICAgICAgIHB1dERpcmVj dCh2bSwgSWRlbnRpZmllcjo6ZnJvbVN0cmluZyh2bSwgIiQiKSwgZG9sbGFyLCBEb250RW51bSk7 CisgICAgICAgIHB1dERpcmVjdCh2bSwgSWRlbnRpZmllcjo6ZnJvbVN0cmluZyh2bSwgIiQyNjIi KSwgZG9sbGFyLCBEb250RW51bSk7CiAgICAgICAgIAogICAgICAgICBhZGRGdW5jdGlvbih2bSwg ZG9sbGFyLCAiY3JlYXRlUmVhbG0iLCBmdW5jdGlvbkRvbGxhckNyZWF0ZVJlYWxtLCAwKTsKICAg ICAgICAgYWRkRnVuY3Rpb24odm0sIGRvbGxhciwgImRldGFjaEFycmF5QnVmZmVyIiwgZnVuY3Rp b25UcmFuc2ZlckFycmF5QnVmZmVyLCAxKTsKICAgICAgICAgYWRkRnVuY3Rpb24odm0sIGRvbGxh ciwgImV2YWxTY3JpcHQiLCBmdW5jdGlvbkRvbGxhckV2YWxTY3JpcHQsIDEpOwogICAgICAgICAK LSAgICAgICAgZG9sbGFyLT5wdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0s ICJnbG9iYWwiKSwgdGhpcyk7CisgICAgICAgIGRvbGxhci0+cHV0RGlyZWN0KHZtLCBJZGVudGlm aWVyOjpmcm9tU3RyaW5nKHZtLCAiZ2xvYmFsIiksIHRoaXMsIERvbnRFbnVtKTsKICAgICAgICAg ZG9sbGFyLT5wdXREaXJlY3RDdXN0b21BY2Nlc3Nvcih2bSwgSWRlbnRpZmllcjo6ZnJvbVN0cmlu Zyh2bSwgIklzSFRNTEREQSIpLAogICAgICAgICAgICAgQ3VzdG9tR2V0dGVyU2V0dGVyOjpjcmVh dGUodm0sIFtdKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEVuY29kZWRKU1ZhbHVlLCBQ cm9wZXJ0eU5hbWUpIHsKICAgICAgICAgICAgICAgICByZXR1cm4gZnVuY3Rpb25NYWtlTWFzcXVl cmFkZXIoZ2xvYmFsT2JqZWN0LCBudWxscHRyKTsKQEAgLTYwNiw3ICs2MDgsNyBAQCBwcml2YXRl OgogICAgICAgICApOwogCiAgICAgICAgIEpTT2JqZWN0KiBhZ2VudCA9IEpTRmluYWxPYmplY3Q6 OmNyZWF0ZSh2bSwgcGxhaW5PYmplY3RTdHJ1Y3R1cmUpOwotICAgICAgICBkb2xsYXItPnB1dERp cmVjdCh2bSwgSWRlbnRpZmllcjo6ZnJvbVN0cmluZyh2bSwgImFnZW50IiksIGFnZW50KTsKKyAg ICAgICAgZG9sbGFyLT5wdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJh Z2VudCIpLCBhZ2VudCwgRG9udEVudW0pOwogICAgICAgICAKICAgICAgICAgLy8gVGhlIHRlc3Qy NjIgSU5URVJQUkVUSU5HLm1kIGRvY3VtZW50IHNheXMgdGhhdCBzb21lIG9mIHRoZXNlIGZ1bmN0 aW9ucyBhcmUganVzdCBpbiB0aGUgbWFpbgogICAgICAgICAvLyB0aHJlYWQgYW5kIHNvbWUgYXJl IGluIHRoZSBvdGhlciB0aHJlYWRzLiBXZSBqdXN0IHB1dCB0aGVtIGluIGFsbCB0aHJlYWRzLgpA QCAtNjM2LDcgKzYzOCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBhZGRGdW5jdGlvbihWTSYgdm0s IEpTT2JqZWN0KiBvYmplY3QsIGNvbnN0IGNoYXIqIG5hbWUsIE5hdGl2ZUZ1bmN0aW9uIGZ1bmN0 aW9uLCB1bnNpZ25lZCBhcmd1bWVudHMpCiAgICAgewogICAgICAgICBJZGVudGlmaWVyIGlkZW50 aWZpZXIgPSBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKHZtLCBuYW1lKTsKLSAgICAgICAgb2JqZWN0 LT5wdXREaXJlY3Qodm0sIGlkZW50aWZpZXIsIEpTRnVuY3Rpb246OmNyZWF0ZSh2bSwgdGhpcywg YXJndW1lbnRzLCBpZGVudGlmaWVyLnN0cmluZygpLCBmdW5jdGlvbikpOworICAgICAgICBvYmpl Y3QtPnB1dERpcmVjdCh2bSwgaWRlbnRpZmllciwgSlNGdW5jdGlvbjo6Y3JlYXRlKHZtLCB0aGlz LCBhcmd1bWVudHMsIGlkZW50aWZpZXIuc3RyaW5nKCksIGZ1bmN0aW9uKSwgRG9udEVudW0pOwog ICAgIH0KIAogICAgIHZvaWQgYWRkRnVuY3Rpb24oVk0mIHZtLCBjb25zdCBjaGFyKiBuYW1lLCBO YXRpdmVGdW5jdGlvbiBmdW5jdGlvbiwgdW5zaWduZWQgYXJndW1lbnRzKQo=