214832 2020-07-27 09:28:04 -0700 [WPE] Gardening scroll gesture controller 2020-07-28 03:53:10 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Other Linux NEW P2 Normal --- 214141 1 m.felsch webkit-unassigned aperez bugs-noreply cgarcia m.felsch oldest_to_newest 1675271 0 m.felsch 2020-07-27 09:28:04 -0700 Gardening the WPE ScrollGestureController to get rid of unused members and functions. The patch applies to the current master and 2.29.1 branches. I've tested the patch on the 2.28.3 branch because the current master/2.29.1 branch fails during build. Note: This Bug depends on: https://bugs.webkit.org/show_bug.cgi?id=214141 Regards, Marco 1675272 1 405286 m.felsch 2020-07-27 09:31:12 -0700 Created attachment 405286 Gardening scroll gesture controller 1675544 2 m.felsch 2020-07-28 01:16:04 -0700 Hi, can you describe how I can add more than one patch to a open bug? Applying this patch will always fail if we don't apply https://bugs.webkit.org/show_bug.cgi?id=214141 first. Sorry for asking, I'm not very into this bugzilla workflow. Regards, Marco 405286 2020-07-27 09:31:12 -0700 2020-07-28 03:53:10 -0700 Gardening scroll gesture controller 0002-WPE-gardening-scroll-gesture-controller.patch text/plain 5777 m.felsch RnJvbSAzNzVjOGQ5YjcyYTNiYmUwMDg5OWY0NTY5YzU0YzM3MTdkZjQ2Y2VhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjbyBGZWxzY2ggPG0uZmVsc2NoQHBlbmd1dHJvbml4LmRl PgpEYXRlOiBNb24sIDI3IEp1bCAyMDIwIDE2OjI4OjM2ICswMjAwClN1YmplY3Q6IFtQQVRDSCAy LzJdIFtXUEVdIGdhcmRlbmluZyBzY3JvbGwgZ2VzdHVyZSBjb250cm9sbGVyCgpEZWxldGUgdGhl IG1fcGhhc2Ugc3RhdGUgdHJhY2tpbmcgYW5kIHRoZSBnZXR0ZXIgd2hpY2ggY2FuIGJlIGRvbmUK d2l0aG91dCB3b3JyaWVzIHNpbmNlIHdlIG1vdmVkIHRoZSBoYW5kbGVXaGVlbEV2ZW50IGludG8g dGhlCnNjcm9sbCBnZXN0dXJlIGNvbnRyb2xsZXIuCgpSZW1vdmUgdGhlIGlzSGFuZGxpbmcoKSBn ZXR0ZXIgc2luY2UgdGhlIGhhbmRsZUV2ZW50KCkgZ2V0cyBjYWxsZWQgb25seQpvbmNlIGR1cmlu ZyB0aGUgaW5wdXQgaGFuZGxpbmcuCgpNYWtlIGhhbmRsZUV2ZW50KCkgYSB2b2lkIGZ1bmN0aW9u IGJlY2F1c2UgdGhlIG5ldyBpbnB1dCBoYW5kbGluZyBkb24ndApuZWVkIHRoZSByZXR1cm4gdmFs dWUuCgpTaWduZWQtb2ZmLWJ5OiBNYXJjbyBGZWxzY2ggPG0uZmVsc2NoQHBlbmd1dHJvbml4LmRl PgotLS0KIFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8IDIz ICsrKysrKysrKysrKysrKysrKysKIC4uLi9BUEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVy LmNwcCAgICAgICB8IDIyICsrKysrKysrLS0tLS0tLS0tLQogLi4uL0FQSS93cGUvU2Nyb2xsR2Vz dHVyZUNvbnRyb2xsZXIuaCAgICAgICAgIHwgIDYgKy0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMzQg aW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBlNmYwNzA2MGFkOC4u ZjAwY2RhNzNhNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjAtMDctMjcgIE1hcmNv IEZlbHNjaCAgPG0uZmVsc2NoQHBlbmd1dHJvbml4LmRlPgorCisgICAgICAgIFtXUEVdIGdhcmRl bmluZyBzY3JvbGwgZ2VzdHVyZSBjb250cm9sbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICBE ZWxldGUgdGhlIG1fcGhhc2Ugc3RhdGUgdHJhY2tpbmcgYW5kIHRoZSBnZXR0ZXIgd2hpY2ggY2Fu IGJlIGRvbmUKKyAgICAgICAgd2l0aG91dCB3b3JyaWVzIHNpbmNlIHdlIG1vdmVkIHRoZSBoYW5k bGVXaGVlbEV2ZW50IGludG8gdGhlCisgICAgICAgIHNjcm9sbCBnZXN0dXJlIGNvbnRyb2xsZXIu CisKKyAgICAgICAgUmVtb3ZlIHRoZSBpc0hhbmRsaW5nKCkgZ2V0dGVyIHNpbmNlIHRoZSBoYW5k bGVFdmVudCgpIGdldHMgY2FsbGVkIG9ubHkKKyAgICAgICAgb25jZSBkdXJpbmcgdGhlIGlucHV0 IGhhbmRsaW5nLgorCisgICAgICAgIE1ha2UgaGFuZGxlRXZlbnQoKSBhIHZvaWQgZnVuY3Rpb24g YmVjYXVzZSB0aGUgbmV3IGlucHV0IGhhbmRsaW5nIGRvbid0CisgICAgICAgIG5lZWQgdGhlIHJl dHVybiB2YWx1ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL1Njcm9sbEdlc3R1cmVD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6U2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXI6 OmhhbmRsZUV2ZW50KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3dwZS9TY3JvbGxHZXN0dXJl Q29udHJvbGxlci5oOgorCiAyMDIwLTA3LTI3ICBNYXJjbyBGZWxzY2ggIDxtLmZlbHNjaEBwZW5n dXRyb25peC5kZT4KIAogICAgICAgICBbV1BFXSBGaXggdG91Y2ggYmFzZWQgZ2VzdHVyZSBoYW5k bGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9TY3JvbGxH ZXN0dXJlQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1Nj cm9sbEdlc3R1cmVDb250cm9sbGVyLmNwcAppbmRleCA1MWVmZjM5NTk3Yi4uMGExM2Y2NjNjYTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvU2Nyb2xsR2VzdHVy ZUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvU2Ny b2xsR2VzdHVyZUNvbnRyb2xsZXIuY3BwCkBAIC00MiwxOCArNDIsMTggQEAgYm9vbCBTY3JvbGxH ZXN0dXJlQ29udHJvbGxlcjo6cGVuZGluZ01vdXNlQ2xpY2tzKCkKICAgICByZXR1cm4gIW1fbW91 c2VDbGlja3MuaXNFbXB0eSgpOwogfQogCi1ib29sIFNjcm9sbEdlc3R1cmVDb250cm9sbGVyOjpo YW5kbGVFdmVudChjb25zdCBzdHJ1Y3Qgd3BlX2lucHV0X3RvdWNoX2V2ZW50X3JhdyogdG91Y2hQ b2ludCwgV2ViS2l0OjpXZWJQYWdlUHJveHkmIHBhZ2UpCit2b2lkIFNjcm9sbEdlc3R1cmVDb250 cm9sbGVyOjpoYW5kbGVFdmVudChjb25zdCBzdHJ1Y3Qgd3BlX2lucHV0X3RvdWNoX2V2ZW50X3Jh dyogdG91Y2hQb2ludCwgV2ViS2l0OjpXZWJQYWdlUHJveHkmIHBhZ2UpCiB7CiAgICAgc3dpdGNo ICh0b3VjaFBvaW50LT50eXBlKSB7CiAgICAgY2FzZSB3cGVfaW5wdXRfdG91Y2hfZXZlbnRfdHlw ZV9kb3duOgogICAgICAgICBpZiAobV9oYW5kbGluZykKLSAgICAgICAgICAgIHJldHVybiB0cnVl OworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIG1fc3RhcnQudGltZSA9IHRvdWNoUG9pbnQt PnRpbWU7CiAgICAgICAgIG1fc3RhcnQueCA9IHRvdWNoUG9pbnQtPng7CiAgICAgICAgIG1fc3Rh cnQueSA9IHRvdWNoUG9pbnQtPnk7CiAgICAgICAgIG1fb2Zmc2V0LnggPSB0b3VjaFBvaW50LT54 OwogICAgICAgICBtX29mZnNldC55ID0gdG91Y2hQb2ludC0+eTsKLSAgICAgICAgcmV0dXJuIGZh bHNlOworICAgICAgICBicmVhazsKICAgICBjYXNlIHdwZV9pbnB1dF90b3VjaF9ldmVudF90eXBl X21vdGlvbjoKICAgICAgICAgaWYgKCFtX2hhbmRsaW5nKSB7CiAgICAgICAgICAgICBpbnQzMl90 IGRlbHRhWCA9IHRvdWNoUG9pbnQtPnggLSBtX3N0YXJ0Lng7CkBAIC04MywxMSArODMsMTAgQEAg Ym9vbCBTY3JvbGxHZXN0dXJlQ29udHJvbGxlcjo6aGFuZGxlRXZlbnQoY29uc3Qgc3RydWN0IHdw ZV9pbnB1dF90b3VjaF9ldmVudF9yYXcKICNlbmRpZgogICAgICAgICAgICAgbV9vZmZzZXQueCA9 IHRvdWNoUG9pbnQtPng7CiAgICAgICAgICAgICBtX29mZnNldC55ID0gdG91Y2hQb2ludC0+eTsK LSAgICAgICAgICAgIG1fcGhhc2UgPSBXZWJXaGVlbEV2ZW50OjpQaGFzZTo6UGhhc2VDaGFuZ2Vk OwotICAgICAgICAgICAgcGFnZS5oYW5kbGVXaGVlbEV2ZW50KFdlYktpdDo6TmF0aXZlV2ViV2hl ZWxFdmVudChheGlzRXZlbnQoKSwgcGFnZS5kZXZpY2VTY2FsZUZhY3RvcigpLCBwaGFzZSgpLCBX ZWJXaGVlbEV2ZW50OjpQaGFzZTo6UGhhc2VOb25lKSk7Ci0gICAgICAgICAgICByZXR1cm4gdHJ1 ZTsKKyAgICAgICAgICAgIHBhZ2UuaGFuZGxlV2hlZWxFdmVudChXZWJLaXQ6Ok5hdGl2ZVdlYldo ZWVsRXZlbnQoYXhpc0V2ZW50KCksIHBhZ2UuZGV2aWNlU2NhbGVGYWN0b3IoKSwgV2ViV2hlZWxF dmVudDo6UGhhc2U6OlBoYXNlQ2hhbmdlZCwgV2ViV2hlZWxFdmVudDo6UGhhc2U6OlBoYXNlTm9u ZSkpOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuIGZhbHNl OworICAgICAgICBicmVhazsKICAgICBjYXNlIHdwZV9pbnB1dF90b3VjaF9ldmVudF90eXBlX3Vw OgogICAgICAgICBpZiAobV9oYW5kbGluZykgewogICAgICAgICAgICAgbV9oYW5kbGluZyA9IGZh bHNlOwpAQCAtMTA2LDE4ICsxMDUsMTcgQEAgYm9vbCBTY3JvbGxHZXN0dXJlQ29udHJvbGxlcjo6 aGFuZGxlRXZlbnQoY29uc3Qgc3RydWN0IHdwZV9pbnB1dF90b3VjaF9ldmVudF9yYXcKICAgICAg ICAgICAgIH07CiAjZW5kaWYKICAgICAgICAgICAgIG1fb2Zmc2V0LnggPSBtX29mZnNldC55ID0g MDsKLSAgICAgICAgICAgIG1fcGhhc2UgPSBXZWJXaGVlbEV2ZW50OjpQaGFzZTo6UGhhc2VFbmRl ZDsKLSAgICAgICAgICAgIHBhZ2UuaGFuZGxlV2hlZWxFdmVudChXZWJLaXQ6Ok5hdGl2ZVdlYldo ZWVsRXZlbnQoYXhpc0V2ZW50KCksIHBhZ2UuZGV2aWNlU2NhbGVGYWN0b3IoKSwgcGhhc2UoKSwg V2ViV2hlZWxFdmVudDo6UGhhc2U6OlBoYXNlTm9uZSkpOwotICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgICAgICAgICBwYWdlLmhhbmRsZVdoZWVsRXZlbnQoV2ViS2l0OjpOYXRpdmVXZWJX aGVlbEV2ZW50KGF4aXNFdmVudCgpLCBwYWdlLmRldmljZVNjYWxlRmFjdG9yKCksIFdlYldoZWVs RXZlbnQ6OlBoYXNlOjpQaGFzZUVuZGVkLCBXZWJXaGVlbEV2ZW50OjpQaGFzZTo6UGhhc2VOb25l KSk7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIGlm ICghbV9tb3VzZUNsaWNrcy50cnlBcHBlbmQoJm1fc3RhcnQsIDEpKSB7CiAgICAgICAgICAgICAg ICAgbV9tb3VzZUNsaWNrcy5yZW1vdmUoMCk7CiAgICAgICAgICAgICAgICAgbV9tb3VzZUNsaWNr cy5hcHBlbmQoJm1fc3RhcnQsIDEpOwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgICAg IHJldHVybiBmYWxzZTsKKyAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKLSAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgICAgICBicmVhazsKICAgICB9CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvU2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXIuaCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvU2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXIuaApp bmRleCA5MWVkOWFkOTU0OC4uMDNmYTJkM2U4MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS93cGUvU2Nyb2xsR2VzdHVyZUNvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1Njcm9sbEdlc3R1cmVDb250cm9sbGVyLmgKQEAgLTUz LDEwICs1Myw3IEBAIHB1YmxpYzoKICAgICAgICAgaW50MzJfdCB5IHsgMCB9OwogICAgIH07CiAK LSAgICBXZWJXaGVlbEV2ZW50OjpQaGFzZSBwaGFzZSgpIHsgcmV0dXJuIG1fcGhhc2U7IH0KLQot ICAgIGJvb2wgaXNIYW5kbGluZygpIGNvbnN0IHsgcmV0dXJuIG1faGFuZGxpbmc7IH0KLSAgICBi b29sIGhhbmRsZUV2ZW50KGNvbnN0IHN0cnVjdCB3cGVfaW5wdXRfdG91Y2hfZXZlbnRfcmF3Kiwg V2ViS2l0OjpXZWJQYWdlUHJveHkmKTsKKyAgICB2b2lkIGhhbmRsZUV2ZW50KGNvbnN0IHN0cnVj dCB3cGVfaW5wdXRfdG91Y2hfZXZlbnRfcmF3KiwgV2ViS2l0OjpXZWJQYWdlUHJveHkmKTsKICAg ICBib29sIHBlbmRpbmdNb3VzZUNsaWNrcygpOwogICAgIHN0cnVjdCBUb3VjaFBvaW50IGdldE1v dXNlQ2xpY2tUb3VjaElkKCk7CiAKQEAgLTc0LDcgKzcxLDYgQEAgcHJpdmF0ZToKICNlbHNlCiAg ICAgc3RydWN0IHdwZV9pbnB1dF9heGlzX2V2ZW50IG1fYXhpc0V2ZW50OwogI2VuZGlmCi0gICAg V2ViV2hlZWxFdmVudDo6UGhhc2UgbV9waGFzZSB7IFdlYldoZWVsRXZlbnQ6OlBoYXNlOjpQaGFz ZU5vbmUgfTsKICAgICBWZWN0b3I8c3RydWN0IFRvdWNoUG9pbnQsIDEwPiBtX21vdXNlQ2xpY2tz OwogfTsKIAotLSAKMi4yMC4xCgo=