214818 2020-07-27 00:58:10 -0700 Check m_connection in NetworkRTCProvider::createResolver/stopResolver 2020-07-27 08:10:16 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist webkit-bug-importer youennf oldest_to_newest 1675174 0 youennf 2020-07-27 00:58:10 -0700 Check m_connection in NetworkRTCProvider::createResolver/stopResolver 1675175 1 405262 youennf 2020-07-27 01:00:31 -0700 Created attachment 405262 Patch 1675234 2 405262 eric.carlson 2020-07-27 07:16:22 -0700 Comment on attachment 405262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405262&action=review > Source/WebKit/ChangeLog:8 > + We need to check for m_connection when hopping to main thread as the NetworkRTCProvider might get closed otherwise. s/might get closed otherwise/might already be closed/ 1675236 3 405272 youennf 2020-07-27 07:35:51 -0700 Created attachment 405272 Patch 1675243 4 ews-feeder 2020-07-27 08:09:45 -0700 Committed r264922: <https://trac.webkit.org/changeset/264922> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405272. 1675244 5 webkit-bug-importer 2020-07-27 08:10:16 -0700 <rdar://problem/66162876> 405262 2020-07-27 01:00:31 -0700 2020-07-27 07:35:47 -0700 Patch bug-214818-20200727100030.patch text/plain 1989 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdlMjM0N2IxMDM5NThjNTFk MGYzNTZhOWRiODhiMjc0ZTVmMGNjNTMuLjczMWRjMjg5Y2UwNGJhNTgxYTdkYmNlMTVmMDFlNTRh MGI1NTJhMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMjcgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIG1fY29ubmVjdGlvbiBp biBOZXR3b3JrUlRDUHJvdmlkZXI6OmNyZWF0ZVJlc29sdmVyL3N0b3BSZXNvbHZlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0ODE4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmVlZCB0byBjaGVj ayBmb3IgbV9jb25uZWN0aW9uIHdoZW4gaG9wcGluZyB0byBtYWluIHRocmVhZCBhcyB0aGUgTmV0 d29ya1JUQ1Byb3ZpZGVyIG1pZ2h0IGdldCBjbG9zZWQgb3RoZXJ3aXNlLgorCisgICAgICAgICog TmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHA6CisgICAgICAgIChX ZWJLaXQ6Ok5ldHdvcmtSVENQcm92aWRlcjo6Y3JlYXRlUmVzb2x2ZXIpOgorICAgICAgICAoV2Vi S2l0OjpOZXR3b3JrUlRDUHJvdmlkZXI6OnN0b3BSZXNvbHZlcik6CisKIDIwMjAtMDctMjUgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgU2Nyb2xsIFNu YXAgYnJva2VuIHdoZW4gdXNpbmcgUlRMIGxheW91dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcCBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKaW5kZXgg YTM4NjU5NGE2MmFhMzZlMGE4YTU4YjQwZWM0YjJlNjQyZmI4YjI3Ni4uYTRkYmNhMTA3ZmE4ODM4 ODVhNGQxOTMxYWFjMzdiNzNkMGM2M2NlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwCkBAIC0yNDMs NiArMjQzLDggQEAgdm9pZCBOZXR3b3JrUlRDUHJvdmlkZXI6OmNyZWF0ZVJlc29sdmVyKExpYldl YlJUQ1Jlc29sdmVySWRlbnRpZmllciBpZGVudGlmaWVyLAogewogICAgIGlmICghaXNNYWluVGhy ZWFkKCkpIHsKICAgICAgICAgY2FsbE9uTWFpblRocmVhZChbdGhpcywgcHJvdGVjdGVkVGhpcyA9 IG1ha2VSZWYoKnRoaXMpLCBpZGVudGlmaWVyLCBhZGRyZXNzID0gV1RGTW92ZShhZGRyZXNzKS5p c29sYXRlZENvcHkoKV0oKSBtdXRhYmxlIHsKKyAgICAgICAgICAgIGlmICghbV9jb25uZWN0aW9u KQorICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIGNyZWF0ZVJlc29sdmVyKGlk ZW50aWZpZXIsIFdURk1vdmUoYWRkcmVzcykpOwogICAgICAgICB9KTsKICAgICAgICAgcmV0dXJu OwpAQCAtMjc5LDYgKzI4MSw4IEBAIHZvaWQgTmV0d29ya1JUQ1Byb3ZpZGVyOjpzdG9wUmVzb2x2 ZXIoTGliV2ViUlRDUmVzb2x2ZXJJZGVudGlmaWVyIGlkZW50aWZpZXIpCiB7CiAgICAgaWYgKCFp c01haW5UaHJlYWQoKSkgewogICAgICAgICBjYWxsT25NYWluVGhyZWFkKFt0aGlzLCBwcm90ZWN0 ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGlkZW50aWZpZXJdIHsKKyAgICAgICAgICAgIGlmICgh bV9jb25uZWN0aW9uKQorICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIHN0b3BS ZXNvbHZlcihpZGVudGlmaWVyKTsKICAgICAgICAgfSk7CiAgICAgICAgIHJldHVybjsK 405272 2020-07-27 07:35:51 -0700 2020-07-27 08:09:45 -0700 Patch bug-214818-20200727163549.patch text/plain 1984 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdlMjM0N2IxMDM5NThjNTFk MGYzNTZhOWRiODhiMjc0ZTVmMGNjNTMuLmQ4NzNhYjQwNDk0ZmI0NmVmYmJkZDg5ZGM2Mzc4MGEy NWUzMjlkMmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMjcgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIG1fY29ubmVjdGlvbiBp biBOZXR3b3JrUlRDUHJvdmlkZXI6OmNyZWF0ZVJlc29sdmVyL3N0b3BSZXNvbHZlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0ODE4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIFdlIG5lZWQgdG8gY2hlY2sg Zm9yIG1fY29ubmVjdGlvbiB3aGVuIGhvcHBpbmcgdG8gbWFpbiB0aHJlYWQgYXMgdGhlIE5ldHdv cmtSVENQcm92aWRlciBtaWdodCBhbHJlYWR5IGJlIGNsb3NlZC4KKworICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrUlRDUHJvdmlkZXI6OmNyZWF0ZVJlc29sdmVyKToKKyAgICAgICAgKFdlYktpdDo6 TmV0d29ya1JUQ1Byb3ZpZGVyOjpzdG9wUmVzb2x2ZXIpOgorCiAyMDIwLTA3LTI1ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNjcm9sbCBTbmFwIGJy b2tlbiB3aGVuIHVzaW5nIFJUTCBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwCmluZGV4IGEzODY1 OTRhNjJhYTM2ZTBhOGE1OGI0MGVjNGIyZTY0MmZiOGIyNzYuLmE0ZGJjYTEwN2ZhODgzODg1YTRk MTkzMWFhYzM3YjczZDBjNjNjZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcApAQCAtMjQzLDYgKzI0 Myw4IEBAIHZvaWQgTmV0d29ya1JUQ1Byb3ZpZGVyOjpjcmVhdGVSZXNvbHZlcihMaWJXZWJSVENS ZXNvbHZlcklkZW50aWZpZXIgaWRlbnRpZmllciwKIHsKICAgICBpZiAoIWlzTWFpblRocmVhZCgp KSB7CiAgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtl UmVmKCp0aGlzKSwgaWRlbnRpZmllciwgYWRkcmVzcyA9IFdURk1vdmUoYWRkcmVzcykuaXNvbGF0 ZWRDb3B5KCldKCkgbXV0YWJsZSB7CisgICAgICAgICAgICBpZiAoIW1fY29ubmVjdGlvbikKKyAg ICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICBjcmVhdGVSZXNvbHZlcihpZGVudGlm aWVyLCBXVEZNb3ZlKGFkZHJlc3MpKTsKICAgICAgICAgfSk7CiAgICAgICAgIHJldHVybjsKQEAg LTI3OSw2ICsyODEsOCBAQCB2b2lkIE5ldHdvcmtSVENQcm92aWRlcjo6c3RvcFJlc29sdmVyKExp YldlYlJUQ1Jlc29sdmVySWRlbnRpZmllciBpZGVudGlmaWVyKQogewogICAgIGlmICghaXNNYWlu VGhyZWFkKCkpIHsKICAgICAgICAgY2FsbE9uTWFpblRocmVhZChbdGhpcywgcHJvdGVjdGVkVGhp cyA9IG1ha2VSZWYoKnRoaXMpLCBpZGVudGlmaWVyXSB7CisgICAgICAgICAgICBpZiAoIW1fY29u bmVjdGlvbikKKyAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICBzdG9wUmVzb2x2 ZXIoaWRlbnRpZmllcik7CiAgICAgICAgIH0pOwogICAgICAgICByZXR1cm47Cg==