214815 2020-07-26 20:24:19 -0700 DisallowVMEntryImpl should not have explicitly-declared copy constructor 2020-07-26 21:48:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 214809 P2 Normal --- 1 jh718.park jh718.park darin don.olmstead ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo oldest_to_newest 1675154 0 jh718.park 2020-07-26 20:24:19 -0700 In file included from DerivedSources/ForwardingHeaders/wtf/Seconds.h:29, from DerivedSources/ForwardingHeaders/wtf/WallTime.h:29, from DerivedSources/ForwardingHeaders/wtf/ThreadingPrimitives.h:37, from DerivedSources/ForwardingHeaders/wtf/MainThread.h:35, from DerivedSources/ForwardingHeaders/wtf/NeverDestroyed.h:31, from DerivedSources/ForwardingHeaders/wtf/text/AtomString.h:24, from DerivedSources/ForwardingHeaders/wtf/text/WTFString.h:690, from ../../Source/WebCore/dom/Exception.h:30, from ../../Source/WebCore/dom/ExceptionOr.h:29, from ../../Source/WebCore/bindings/js/JSDOMBinding.h:28, from ../../Source/WebCore/bindings/js/JSDOMMapLike.h:28, from ../../Source/WebCore/bindings/js/JSDOMMapLike.cpp:27, from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-6.cpp:1: DerivedSources/ForwardingHeaders/wtf/Optional.h: In instantiation of ‘WTF::Optional< <template-parameter-1-1> >& WTF::Optional< <template-parameter-1-1> >::operator=(const WTF::Optional< <template-parameter-1-1> >&) [with T = JSC::DisallowVMEntryImpl<JSC::VM>]’: DerivedSources/ForwardingHeaders/JavaScriptCore/PropertySlot.h:87:7: required from here DerivedSources/ForwardingHeaders/wtf/Optional.h:465:84: warning: implicitly-declared ‘constexpr JSC::DisallowVMEntryImpl<JSC::VM>& JSC::DisallowVMEntryImpl<JSC::VM>::operator=(const JSC::DisallowVMEntryImpl<JSC::VM>&)’ is deprecated [-Wdeprecated-copy] 465 | else if (initialized() == true && rhs.initialized() == true) contained_val() = *rhs; In file included from DerivedSources/ForwardingHeaders/JavaScriptCore/VM.h:38, from DerivedSources/ForwardingHeaders/JavaScriptCore/Identifier.h:24, from DerivedSources/WebCore/JSDOMBindingInternalsBuiltins.h:34, from DerivedSources/WebCore/WebCoreJSBuiltinInternals.h:39, from ../../Source/WebCore/bindings/js/JSDOMGlobalObject.h:29, from ../../Source/WebCore/bindings/js/DOMWrapperWorld.h:24, from ../../Source/WebCore/bindings/js/JSDOMWrapperCache.h:26, from ../../Source/WebCore/bindings/js/JSDOMBinding.h:29, from ../../Source/WebCore/bindings/js/JSDOMMapLike.h:28, from ../../Source/WebCore/bindings/js/JSDOMMapLike.cpp:27, from DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-6.cpp:1: DerivedSources/ForwardingHeaders/JavaScriptCore/DisallowVMEntry.h:46:5: note: because ‘JSC::DisallowVMEntryImpl<JSC::VM>’ has user-provided ‘JSC::DisallowVMEntryImpl<VMType>::DisallowVMEntryImpl(const JSC::DisallowVMEntryImpl<VMType>&) [with VMType = JSC::VM]’ 46 | DisallowVMEntryImpl(const DisallowVMEntryImpl& other) | ^~~~~~~~~~~~~~~~~~~ 1675155 1 405259 jh718.park 2020-07-26 20:28:22 -0700 Created attachment 405259 Patch 1675156 2 405259 mark.lam 2020-07-26 21:21:37 -0700 Comment on attachment 405259 Patch The copy constructor is needed by WebCore. 1675157 3 mark.lam 2020-07-26 21:23:17 -0700 See also https://bugs.webkit.org/show_bug.cgi?id=214809. I'm already working on the proper fix there. *** This bug has been marked as a duplicate of bug 214809 *** 1675160 4 jh718.park 2020-07-26 21:48:32 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 405259 [details] > Patch > > The copy constructor is needed by WebCore. I see. Thank you for your review. 405259 2020-07-26 20:28:22 -0700 2020-07-26 21:21:37 -0700 Patch bug-214815-20200727122821.patch text/plain 1791 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MjQwNjNiOTYzZjk3NjQxNWI0ZTRjMjkxNjcwMWJkZmUzNzFjOThjLi5jZDUwZmE0N2VhZGIwMDRh YmQ2MDcxZjhhMzMzMGQyMWM0Nzk1NjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMC0wNy0yNiAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgRGlzYWxsb3dWTUVudHJ5SW1wbCBzaG91bGQgbm90IGhhdmUgZXhw bGljaXRseS1kZWNsYXJlZCBjb3B5IGNvbnN0cnVjdG9yLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0ODE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWl0aGVyIG9uZSBvZiBjb3B5IGFzc2lnbm1lbnQg b3BlcmF0b3Igb3IgY29weSBjb25zdHJ1Y3RvciBpcyB1c2VyLXByb3ZpZGVkLAorICAgICAgICBH Q0MgOSB3YXJucyBhYm91dCB0aGUgYysrMTEgZGVwcmVjYXRpb24gb2YgaW1wbGljaXRseSBkZWNs YXJlZCBjb3B5CisgICAgICAgIGNvbnN0cnVjdG9yIG9yIGFzc2lnbm1lbnQgb3BlcmF0b3IgbGlr ZSBiZWxvdywgc28ganVzdCByZW1vdmUgaXQuCisKKyAgICAgICAgd2FybmluZzogaW1wbGljaXRs eS1kZWNsYXJlZCDigJhjb25zdGV4cHIgSlNDOjpEaXNhbGxvd1ZNRW50cnlJbXBsPEpTQzo6Vk0+ JgorICAgICAgICBKU0M6OkRpc2FsbG93Vk1FbnRyeUltcGw8SlNDOjpWTT46Om9wZXJhdG9yPShj b25zdCBKU0M6OkRpc2FsbG93Vk1FbnRyeUltcGw8SlNDOjpWTT4mKeKAmQorICAgICAgICBpcyBk ZXByZWNhdGVkIFstV2RlcHJlY2F0ZWQtY29weV0KKworICAgICAgICAqIHJ1bnRpbWUvRGlzYWxs b3dWTUVudHJ5Lmg6CisKIDIwMjAtMDctMjQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIHBsdWdpbkVsZW1lbnRDdXN0b21HZXRPd25Qcm9wZXJ0eVNsb3QoKSBzaG91 bGQgc3VwcG9ydCBWTUlucXVpcnkgcmVxdWVzdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9EaXNhbGxvd1ZNRW50cnkuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0Rpc2FsbG93Vk1FbnRyeS5oCmluZGV4IDBkYjhlN2Q2Y2QwYmEwNGRiZWUyZDM4 NDA3ODhlOWE0N2Y1YmMyODIuLmY2NTEzYWU0ZmQzMWFmZTdiNzRlMjE2NTAyYjFhMWJiYzVlOTVk OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Rpc2FsbG93Vk1F bnRyeS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Rpc2FsbG93Vk1FbnRy eS5oCkBAIC00MywxMiArNDMsNiBAQCBwdWJsaWM6CiAgICAgICAgIG1fdm0tPmRpc2FsbG93Vk1F bnRyeUNvdW50Kys7CiAgICAgfQogCi0gICAgRGlzYWxsb3dWTUVudHJ5SW1wbChjb25zdCBEaXNh bGxvd1ZNRW50cnlJbXBsJiBvdGhlcikKLSAgICAgICAgOiBtX3ZtKG90aGVyLm1fdm0pCi0gICAg ewotICAgICAgICBtX3ZtLT5kaXNhbGxvd1ZNRW50cnlDb3VudCsrOwotICAgIH0KLQogICAgIH5E aXNhbGxvd1ZNRW50cnlJbXBsKCkKICAgICB7CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKG1fdm0t PmRpc2FsbG93Vk1FbnRyeUNvdW50KTsK