214796 2020-07-26 01:43:10 -0700 Fix null pointer crash in NetworkRTCProvider::createServerTCPSocket 2020-07-27 00:49:33 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf darin eric.carlson ews-watchlist webkit-bug-importer youennf oldest_to_newest 1675078 0 youennf 2020-07-26 01:43:10 -0700 Fix null pointer crash in NetworkRTCProvider::createServerTCPSocket 1675079 1 youennf 2020-07-26 01:52:39 -0700 <rdar://problem/66051198> 1675080 2 405249 youennf 2020-07-26 01:53:45 -0700 Created attachment 405249 Patch 1675173 3 ews-feeder 2020-07-27 00:49:32 -0700 Committed r264909: <https://trac.webkit.org/changeset/264909> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405249. 405249 2020-07-26 01:53:45 -0700 2020-07-27 00:49:33 -0700 Patch bug-214796-20200726105344.patch text/plain 4403 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0MTkxYTdiYTU3MmQ2MjMw YmU0ZTg0YmIxODJlMmFlZTgxMzhmYTcuLmQ0MWM5OTAyZDA3ZTk5YjRmZDIyYjFiZDQ5NDJkMDNl NWM3NGUxZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDctMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBudWxsIHBvaW50ZXIgY3Jh c2ggaW4gTmV0d29ya1JUQ1Byb3ZpZGVyOjpjcmVhdGVTZXJ2ZXJUQ1BTb2NrZXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDc5NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGNhc2Ugb2YgY3JlYXRp bmcgYSBUQ1Agc29ja2V0LCBOZXR3b3JrUlRDUHJvdmlkZXIgd2lsbCBob3AgdG8gdGhlIG1haW4g dGhyZWFkIGJlZm9yZSBjcmVhdGluZyB0aGUgc29ja2V0LgorICAgICAgICBJbiB0aGF0IGNhc2Us IE5ldHdvcmtSVENQcm92aWRlciBtYXkgYWN0dWFsbHkgYmUgY2xvc2VkIGJldHdlZW4gdGhlIHRp bWUgb2YgcmVjZWl2aW5nIHRoZSBtZXNzYWdlIGFuZCBob3BpbmcgdG8gdGhlIG1haW4gdGhyZWFk LgorICAgICAgICBQcm90ZWN0IGZyb20gdGhpcyBieSBhZGRpbmcgbnVsbHB0ciBjaGVja3MuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcDoK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya1JUQ1Byb3ZpZGVyOjpjcmVhdGVTZXJ2ZXJUQ1BTb2Nr ZXQpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUlRDUHJvdmlkZXI6OmNyZWF0ZUNsaWVudFRD UFNvY2tldCk6CisKIDIwMjAtMDctMjEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc1dQRS5jbWFr ZSBhbmQgTkVXUyBmb3IgdGhlIDIuMjkuMSByZWxlYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Byb3ZpZGVyLmNwcAppbmRl eCBlOGU5M2MzNTRiOGQxMTI3OTE5ZDc0ZDk4NzMxOTAxMTZjZWUyZWViLi42NDI2ZGIzNjhhMDRj MmRlMDM4OTZmMmJkMDRlMjk4YTE4ZGNmYzQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDUHJvdmlkZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENQcm92aWRlci5jcHAKQEAgLTEz OSwxMyArMTM5LDE1IEBAIHZvaWQgTmV0d29ya1JUQ1Byb3ZpZGVyOjpjcmVhdGVTZXJ2ZXJUQ1BT b2NrZXQoTGliV2ViUlRDU29ja2V0SWRlbnRpZmllciBpZGVudGlmCiB7CiAgICAgQVNTRVJUKG1f cnRjTmV0d29ya1RocmVhZC0+SXNDdXJyZW50KCkpOwogICAgIGNhbGxPbk1haW5UaHJlYWQoW3Ro aXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgaWRlbnRpZmllciwgYWRkcmVzcywg bWluUG9ydCwgbWF4UG9ydCwgb3B0aW9uc10geworICAgICAgICBpZiAoIW1fY29ubmVjdGlvbikK KyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBpZiAoIW1faXNMaXN0ZW5pbmdTb2NrZXRB dXRob3JpemVkKSB7Ci0gICAgICAgICAgICBpZiAobV9jb25uZWN0aW9uKQotICAgICAgICAgICAg ICAgIG1fY29ubmVjdGlvbi0+Y29ubmVjdGlvbigpLnNlbmQoTWVzc2FnZXM6OkxpYldlYlJUQ05l dHdvcms6OlNpZ25hbENsb3NlKGlkZW50aWZpZXIsIDEpLCAwKTsKKyAgICAgICAgICAgIG1fY29u bmVjdGlvbi0+Y29ubmVjdGlvbigpLnNlbmQoTWVzc2FnZXM6OkxpYldlYlJUQ05ldHdvcms6OlNp Z25hbENsb3NlKGlkZW50aWZpZXIsIDEpLCAwKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQogCi0gICAgICAgIGNhbGxPblJUQ05ldHdvcmtUaHJlYWQoW3RoaXMsIGlkZW50aWZpZXIs IGFkZHJlc3MgPSBSVENOZXR3b3JrOjppc29sYXRlZENvcHkoYWRkcmVzcy52YWx1ZSksIG1pblBv cnQsIG1heFBvcnQsIG9wdGlvbnMsIGNvbm5lY3Rpb24gPSBtYWtlUmVmKG1fY29ubmVjdGlvbi0+ Y29ubmVjdGlvbigpKV0oKSBtdXRhYmxlIHsKKyAgICAgICAgY2FsbE9uUlRDTmV0d29ya1RocmVh ZChbdGhpcywgaWRlbnRpZmllciwgYWRkcmVzcyA9IFJUQ05ldHdvcms6Omlzb2xhdGVkQ29weShh ZGRyZXNzLnZhbHVlKSwgbWluUG9ydCwgbWF4UG9ydCwgb3B0aW9uc10oKSBtdXRhYmxlIHsKICAg ICAgICAgICAgIHN0ZDo6dW5pcXVlX3B0cjxydGM6OkFzeW5jUGFja2V0U29ja2V0PiBzb2NrZXQo bV9wYWNrZXRTb2NrZXRGYWN0b3J5LT5DcmVhdGVTZXJ2ZXJUY3BTb2NrZXQoYWRkcmVzcywgbWlu UG9ydCwgbWF4UG9ydCwgb3B0aW9ucykpOwogICAgICAgICAgICAgY3JlYXRlU29ja2V0KGlkZW50 aWZpZXIsIFdURk1vdmUoc29ja2V0KSwgU29ja2V0OjpUeXBlOjpTZXJ2ZXJUQ1AsIG1faXBjQ29u bmVjdGlvbi5jb3B5UmVmKCkpOwogICAgICAgICB9KTsKQEAgLTE2MiwxMiArMTY0LDE1IEBAIHJ0 Yzo6UHJveHlJbmZvIE5ldHdvcmtSVENQcm92aWRlcjo6cHJveHlJbmZvRnJvbVNlc3Npb24oY29u c3QgUlRDTmV0d29yazo6U29ja2V0CiB2b2lkIE5ldHdvcmtSVENQcm92aWRlcjo6Y3JlYXRlQ2xp ZW50VENQU29ja2V0KExpYldlYlJUQ1NvY2tldElkZW50aWZpZXIgaWRlbnRpZmllciwgY29uc3Qg UlRDTmV0d29yazo6U29ja2V0QWRkcmVzcyYgbG9jYWxBZGRyZXNzLCBjb25zdCBSVENOZXR3b3Jr OjpTb2NrZXRBZGRyZXNzJiByZW1vdGVBZGRyZXNzLCBTdHJpbmcmJiB1c2VyQWdlbnQsIGludCBv cHRpb25zKQogewogICAgIGNhbGxPbk1haW5UaHJlYWQoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBt YWtlUmVmKCp0aGlzKSwgaWRlbnRpZmllciwgbG9jYWxBZGRyZXNzLCByZW1vdGVBZGRyZXNzLCB1 c2VyQWdlbnQgPSBXVEZNb3ZlKHVzZXJBZ2VudCkuaXNvbGF0ZWRDb3B5KCksIG9wdGlvbnNdKCkg bXV0YWJsZSB7CisgICAgICAgIGlmICghbV9jb25uZWN0aW9uKQorICAgICAgICAgICAgcmV0dXJu OworCiAgICAgICAgIGF1dG8qIHNlc3Npb24gPSBtX2Nvbm5lY3Rpb24tPm5ldHdvcmtTZXNzaW9u KCk7CiAgICAgICAgIGlmICghc2Vzc2lvbikgewogICAgICAgICAgICAgbV9jb25uZWN0aW9uLT5j b25uZWN0aW9uKCkuc2VuZChNZXNzYWdlczo6TGliV2ViUlRDTmV0d29yazo6U2lnbmFsQ2xvc2Uo aWRlbnRpZmllciwgMSksIDApOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0gICAg ICAgIGNhbGxPblJUQ05ldHdvcmtUaHJlYWQoW3RoaXMsIGlkZW50aWZpZXIsIGxvY2FsQWRkcmVz cyA9IFJUQ05ldHdvcms6Omlzb2xhdGVkQ29weShsb2NhbEFkZHJlc3MudmFsdWUpLCByZW1vdGVB ZGRyZXNzID0gUlRDTmV0d29yazo6aXNvbGF0ZWRDb3B5KHJlbW90ZUFkZHJlc3MudmFsdWUpLCBw cm94eUluZm8gPSBwcm94eUluZm9Gcm9tU2Vzc2lvbihyZW1vdGVBZGRyZXNzLCAqc2Vzc2lvbiks IHVzZXJBZ2VudCA9IFdURk1vdmUodXNlckFnZW50KS5pc29sYXRlZENvcHkoKSwgb3B0aW9ucywg Y29ubmVjdGlvbiA9IG1ha2VSZWYobV9jb25uZWN0aW9uLT5jb25uZWN0aW9uKCkpXSgpIG11dGFi bGUgeworICAgICAgICBjYWxsT25SVENOZXR3b3JrVGhyZWFkKFt0aGlzLCBpZGVudGlmaWVyLCBs b2NhbEFkZHJlc3MgPSBSVENOZXR3b3JrOjppc29sYXRlZENvcHkobG9jYWxBZGRyZXNzLnZhbHVl KSwgcmVtb3RlQWRkcmVzcyA9IFJUQ05ldHdvcms6Omlzb2xhdGVkQ29weShyZW1vdGVBZGRyZXNz LnZhbHVlKSwgcHJveHlJbmZvID0gcHJveHlJbmZvRnJvbVNlc3Npb24ocmVtb3RlQWRkcmVzcywg KnNlc3Npb24pLCB1c2VyQWdlbnQgPSBXVEZNb3ZlKHVzZXJBZ2VudCkuaXNvbGF0ZWRDb3B5KCks IG9wdGlvbnNdKCkgbXV0YWJsZSB7CiAgICAgICAgICAgICBydGM6OlBhY2tldFNvY2tldFRjcE9w dGlvbnMgdGNwT3B0aW9uczsKICAgICAgICAgICAgIHRjcE9wdGlvbnMub3B0cyA9IG9wdGlvbnM7 CiAgICAgICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8cnRjOjpBc3luY1BhY2tldFNvY2tldD4gc29j a2V0KG1fcGFja2V0U29ja2V0RmFjdG9yeS0+Q3JlYXRlQ2xpZW50VGNwU29ja2V0KGxvY2FsQWRk cmVzcywgcmVtb3RlQWRkcmVzcywgcHJveHlJbmZvLCB1c2VyQWdlbnQudXRmOCgpLmRhdGEoKSwg dGNwT3B0aW9ucykpOwo=