214761 2020-07-24 14:43:36 -0700 Fix exception check handling below postMessage(). 2020-07-24 15:56:36 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam keith_miller webkit-bug-importer ysuzuki oldest_to_newest 1674839 0 mark.lam 2020-07-24 14:43:36 -0700 <rdar://problem/65932136> 1674843 1 405186 mark.lam 2020-07-24 14:47:12 -0700 Created attachment 405186 proposed patch. 1674844 2 405186 ysuzuki 2020-07-24 14:48:21 -0700 Comment on attachment 405186 proposed patch. r=me 1674845 3 405186 keith_miller 2020-07-24 14:48:57 -0700 Comment on attachment 405186 proposed patch. r=me. 1674884 4 mark.lam 2020-07-24 15:56:36 -0700 Thanks for the reviews. Landed in r264866: <http://trac.webkit.org/r264866>. 405186 2020-07-24 14:47:12 -0700 2020-07-24 14:48:21 -0700 proposed patch. bug-214761.patch text/plain 5248 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDg1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA3LTI0ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggZXhjZXB0aW9uIGNoZWNrIGhh bmRsaW5nIGJlbG93IHBvc3RNZXNzYWdlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ3NjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1OTMy MTM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3Q6IGpzL2RvbS9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay1iZWxvdy1wb3N0TWVzc2FnZS5odG1s CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUNvbnZlcnRTZXF1ZW5jZXMuaDoKKyAgICAg ICAgKFdlYkNvcmU6OkRldGFpbDo6U2VxdWVuY2VDb252ZXJ0ZXI6OmNvbnZlcnRBcnJheSk6Cisg ICAgICAgIChXZWJDb3JlOjpEZXRhaWw6OlNlcXVlbmNlQ29udmVydGVyOjpjb252ZXJ0KToKKwog MjAyMC0wNy0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBzdGVwcygpIHRpbWluZyBmdW5jdGlvbiBvbiBhIHRyYW5zZm9ybSBhbmltYXRpb24gdHJp Z2dlcnMgYSByZW5kZXIgZXZlcnkgZnJhbWUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTRE9NQ29udmVydFNlcXVlbmNlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTRE9NQ29udmVydFNlcXVlbmNlcy5oCShyZXZpc2lvbiAyNjQ4NTYpCisr KyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUNvbnZlcnRTZXF1ZW5jZXMuaAkod29y a2luZyBjb3B5KQpAQCAtMTk1LDggKzE5NSwxMCBAQCBzdHJ1Y3QgU2VxdWVuY2VDb252ZXJ0ZXIg ewogICAgIHVzaW5nIEdlbmVyaWNDb252ZXJ0ZXIgPSBHZW5lcmljU2VxdWVuY2VDb252ZXJ0ZXI8 SURMVHlwZT47CiAgICAgdXNpbmcgUmV0dXJuVHlwZSA9IHR5cGVuYW1lIEdlbmVyaWNDb252ZXJ0 ZXI6OlJldHVyblR5cGU7CiAKLSAgICBzdGF0aWMgUmV0dXJuVHlwZSBjb252ZXJ0QXJyYXkoSlND OjpKU0dsb2JhbE9iamVjdCYgbGV4aWNhbEdsb2JhbE9iamVjdCwgSlNDOjpUaHJvd1Njb3BlJiBz Y29wZSwgSlNDOjpKU0FycmF5KiBhcnJheSkKKyAgICBzdGF0aWMgUmV0dXJuVHlwZSBjb252ZXJ0 QXJyYXkoSlNDOjpKU0dsb2JhbE9iamVjdCYgbGV4aWNhbEdsb2JhbE9iamVjdCwgSlNDOjpKU0Fy cmF5KiBhcnJheSkKICAgICB7CisgICAgICAgIGF1dG8mIHZtID0gbGV4aWNhbEdsb2JhbE9iamVj dC52bSgpOworICAgICAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CiAg ICAgICAgIHVuc2lnbmVkIGxlbmd0aCA9IGFycmF5LT5sZW5ndGgoKTsKIAogICAgICAgICBSZXR1 cm5UeXBlIHJlc3VsdDsKQEAgLTI0OSwyMyArMjUxLDIwIEBAIHN0cnVjdCBTZXF1ZW5jZUNvbnZl cnRlciB7CiAKICAgICAgICAgSlNDOjpKU09iamVjdCogb2JqZWN0ID0gSlNDOjphc09iamVjdCh2 YWx1ZSk7CiAgICAgICAgIGlmIChDb252ZXJ0ZXI8SURMVHlwZT46OmNvbnZlcnNpb25IYXNTaWRl RWZmZWN0cykKLSAgICAgICAgICAgIHJldHVybiBHZW5lcmljQ29udmVydGVyOjpjb252ZXJ0KGxl eGljYWxHbG9iYWxPYmplY3QsIG9iamVjdCk7CisgICAgICAgICAgICBSRUxFQVNFX0FORF9SRVRV Uk4oc2NvcGUsIChHZW5lcmljQ29udmVydGVyOjpjb252ZXJ0KGxleGljYWxHbG9iYWxPYmplY3Qs IG9iamVjdCkpKTsKIAogICAgICAgICBpZiAoIUpTQzo6aXNKU0FycmF5KG9iamVjdCkpCi0gICAg ICAgICAgICByZXR1cm4gR2VuZXJpY0NvbnZlcnRlcjo6Y29udmVydChsZXhpY2FsR2xvYmFsT2Jq ZWN0LCBvYmplY3QpOworICAgICAgICAgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCAoR2Vu ZXJpY0NvbnZlcnRlcjo6Y29udmVydChsZXhpY2FsR2xvYmFsT2JqZWN0LCBvYmplY3QpKSk7CiAK ICAgICAgICAgSlNDOjpKU0FycmF5KiBhcnJheSA9IEpTQzo6YXNBcnJheShvYmplY3QpOwogICAg ICAgICBpZiAoIWFycmF5LT5pc0l0ZXJhdG9yUHJvdG9jb2xGYXN0QW5kTm9uT2JzZXJ2YWJsZSgp KQotICAgICAgICAgICAgcmV0dXJuIEdlbmVyaWNDb252ZXJ0ZXI6OmNvbnZlcnQobGV4aWNhbEds b2JhbE9iamVjdCwgb2JqZWN0KTsKKyAgICAgICAgICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29w ZSwgKEdlbmVyaWNDb252ZXJ0ZXI6OmNvbnZlcnQobGV4aWNhbEdsb2JhbE9iamVjdCwgb2JqZWN0 KSkpOwogICAgICAgICAKLSAgICAgICAgcmV0dXJuIGNvbnZlcnRBcnJheShsZXhpY2FsR2xvYmFs T2JqZWN0LCBzY29wZSwgYXJyYXkpOworICAgICAgICBSRUxFQVNFX0FORF9SRVRVUk4oc2NvcGUs IChjb252ZXJ0QXJyYXkobGV4aWNhbEdsb2JhbE9iamVjdCwgYXJyYXkpKSk7CiAgICAgfQogCiAg ICAgc3RhdGljIFJldHVyblR5cGUgY29udmVydChKU0M6OkpTR2xvYmFsT2JqZWN0JiBsZXhpY2Fs R2xvYmFsT2JqZWN0LCBKU0M6OkpTT2JqZWN0KiBvYmplY3QsIEpTQzo6SlNWYWx1ZSBtZXRob2Qp CiAgICAgewotICAgICAgICBhdXRvJiB2bSA9IEpTQzo6Z2V0Vk0oJmxleGljYWxHbG9iYWxPYmpl Y3QpOwotICAgICAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7Ci0KICAg ICAgICAgaWYgKENvbnZlcnRlcjxJRExUeXBlPjo6Y29udmVyc2lvbkhhc1NpZGVFZmZlY3RzKQog ICAgICAgICAgICAgcmV0dXJuIEdlbmVyaWNDb252ZXJ0ZXI6OmNvbnZlcnQobGV4aWNhbEdsb2Jh bE9iamVjdCwgb2JqZWN0LCBtZXRob2QpOwogCkBAIC0yNzYsNyArMjc1LDcgQEAgc3RydWN0IFNl cXVlbmNlQ29udmVydGVyIHsKICAgICAgICAgaWYgKCFhcnJheS0+aXNJdGVyYXRvclByb3RvY29s RmFzdEFuZE5vbk9ic2VydmFibGUoKSkKICAgICAgICAgICAgIHJldHVybiBHZW5lcmljQ29udmVy dGVyOjpjb252ZXJ0KGxleGljYWxHbG9iYWxPYmplY3QsIG9iamVjdCwgbWV0aG9kKTsKIAotICAg ICAgICByZXR1cm4gY29udmVydEFycmF5KGxleGljYWxHbG9iYWxPYmplY3QsIHNjb3BlLCBhcnJh eSk7CisgICAgICAgIHJldHVybiBjb252ZXJ0QXJyYXkobGV4aWNhbEdsb2JhbE9iamVjdCwgYXJy YXkpOwogICAgIH0KIH07CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDg1NikKKysrIExheW91dFRl c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTI0 ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggZXhjZXB0aW9u IGNoZWNrIGhhbmRsaW5nIGJlbG93IHBvc3RNZXNzYWdlKCkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ3NjEKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzY1OTMyMTM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICoganMvZG9tL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLWJlbG93LXBvc3RNZXNzYWdl LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICoganMvZG9tL21pc3NpbmctZXhjZXB0aW9u LWNoZWNrLWJlbG93LXBvc3RNZXNzYWdlLmh0bWw6IEFkZGVkLgorCiAyMDIwLTA3LTIzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIHN0ZXBzKCkgdGlt aW5nIGZ1bmN0aW9uIG9uIGEgdHJhbnNmb3JtIGFuaW1hdGlvbiB0cmlnZ2VycyBhIHJlbmRlciBl dmVyeSBmcmFtZQpJbmRleDogTGF5b3V0VGVzdHMvanMvZG9tL21pc3NpbmctZXhjZXB0aW9uLWNo ZWNrLWJlbG93LXBvc3RNZXNzYWdlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9qcy9kb20vbWlzc2luZy1leGNlcHRpb24tY2hlY2stYmVsb3ctcG9zdE1lc3NhZ2UtZXhw ZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2pzL2RvbS9taXNzaW5nLWV4 Y2VwdGlvbi1jaGVjay1iZWxvdy1wb3N0TWVzc2FnZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTAsMCArMSw1IEBACitDT05TT0xFIE1FU1NBR0U6IFR5cGVFcnJvcjogVHlwZSBlcnJv cgorRkFJTCBzdWNjZXNzZnVsbHlQYXJzZWQgc2hvdWxkIGJlIHRydWUgKG9mIHR5cGUgYm9vbGVh bikuIFdhcyB1bmRlZmluZWQgKG9mIHR5cGUgdW5kZWZpbmVkKS4KKworVEVTVCBDT01QTEVURQor CkluZGV4OiBMYXlvdXRUZXN0cy9qcy9kb20vbWlzc2luZy1leGNlcHRpb24tY2hlY2stYmVsb3ct cG9zdE1lc3NhZ2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9kb20vbWlzc2lu Zy1leGNlcHRpb24tY2hlY2stYmVsb3ctcG9zdE1lc3NhZ2UuaHRtbAkobm9uZXhpc3RlbnQpCisr KyBMYXlvdXRUZXN0cy9qcy9kb20vbWlzc2luZy1leGNlcHRpb24tY2hlY2stYmVsb3ctcG9zdE1l c3NhZ2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEyIEBACis8IURPQ1RZUEUgaHRt bD48IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIGpzY09wdGlvbnM9LS12YWxpZGF0ZUV4Y2VwdGlv bkNoZWNrcz10cnVlIF0gLS0+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3Jp cHQ+CisgICAgcG9zdE1lc3NhZ2UoMCwgMCwge30pOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0i Li4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0 bWw+Cg==