214715 2020-07-23 17:39:37 -0700 Null check frame in Document::dispatchDisabledAdaptationsDidChangeForMainFrame and a few other places 2020-07-24 20:11:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez esprehn+autocc ews-watchlist ggaren japhet kangil.han mkwst webkit-bug-importer oldest_to_newest 1674487 0 achristensen 2020-07-23 17:39:37 -0700 Null check frame in Document::dispatchDisabledAdaptationsDidChangeForMainFrame 1674923 1 405205 achristensen 2020-07-24 17:07:18 -0700 Created attachment 405205 Patch 1674934 2 405205 ggaren 2020-07-24 17:26:57 -0700 Comment on attachment 405205 Patch r=me 1674976 3 405205 achristensen 2020-07-24 20:08:50 -0700 Comment on attachment 405205 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405205&action=review > Source/WebCore/loader/SubframeLoader.cpp:335 > + document->decrementLoadEventDelayCount(); This line was committed in https://trac.webkit.org/changeset/264878/webkit Committing without it. 1674977 4 achristensen 2020-07-24 20:10:31 -0700 http://trac.webkit.org/r264880 1674979 5 webkit-bug-importer 2020-07-24 20:11:18 -0700 <rdar://problem/66087326> 405205 2020-07-24 17:07:18 -0700 2020-07-24 17:26:57 -0700 Patch bug-214715-20200724170717.patch text/plain 6929 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDg3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA3LTI0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVj ayBmcmFtZSBpbiBEb2N1bWVudDo6ZGlzcGF0Y2hEaXNhYmxlZEFkYXB0YXRpb25zRGlkQ2hhbmdl Rm9yTWFpbkZyYW1lIGFuZCBhIGZldyBvdGhlciBwbGFjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDcxNQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjU0Njc3MDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGVzdDogc2VjdXJpdHkvbXV0YXRpb24tb2JzZXJ2ZXItZnJhbWUtZGV0YWNoLmh0bWwK KworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVu dDo6ZGlkQmVjb21lQ3VycmVudERvY3VtZW50SW5GcmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudDo6aW5pdENvbnRlbnRTZWN1cml0eVBvbGljeSk6CisgICAgICAgICogbG9hZGVyL0Rv Y3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjb21t aXREYXRhKToKKyAgICAgICAgQWRkIHNvbWUgbnVsbCBjaGVja3MgYW5kIGVhcmx5IHJldHVybnMg aWYgdGhlIGZyYW1lIGRldGFjaGVzLgorICAgICAgICAqIGxvYWRlci9TdWJmcmFtZUxvYWRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6U3ViZnJhbWVMb2FkZXI6OmxvYWRT dWJmcmFtZSk6CisgICAgICAgIEJhbGFuY2UgdGhlIGNhbGwgdG8gaW5jcmVtZW50TG9hZEV2ZW50 RGVsYXlDb3VudCBpbiB0aGUgZWFybHkgcmV0dXJuIGNhc2Ugb3IgdGhpcyB0ZXN0IG5ldmVyIGZp bmlzaGVzIGxvYWRpbmcuCisKIDIwMjAtMDctMjQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIEZpeCBleGNlcHRpb24gY2hlY2sgaGFuZGxpbmcgYmVsb3cgcG9zdE1l c3NhZ2UoKS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gMjY0ODQxKQor KysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM4 NiwxNiArMjM4NiwyNCBAQCB2b2lkIERvY3VtZW50OjpjcmVhdGVSZW5kZXJUcmVlKCkKIAogdm9p ZCBEb2N1bWVudDo6ZGlkQmVjb21lQ3VycmVudERvY3VtZW50SW5GcmFtZSgpCiB7Ci0gICAgLy8g RklYTUU6IEFyZSB0aGVyZSBjYXNlcyB3aGVyZSB0aGUgZG9jdW1lbnQgY2FuIGJlIGRpc2xvZGdl ZCBmcm9tIHRoZSBmcmFtZSBkdXJpbmcgdGhlIGV2ZW50IGhhbmRsaW5nIGJlbG93PwotICAgIC8v IElmIHNvLCB0aGVuIG1fZnJhbWUgY291bGQgYmVjb21lIDAsIGFuZCB3ZSBuZWVkIHRvIGRvIHNv bWV0aGluZyBhYm91dCB0aGF0LgotCiAgICAgbV9mcmFtZS0+c2NyaXB0KCkudXBkYXRlRG9jdW1l bnQoKTsKIAorICAgIC8vIE1hbnkgb2YgdGhlc2UgZnVuY3Rpb25zIGhhdmUgZXZlbnQgaGFuZGxl cnMgd2hpY2ggY2FuIGRldGFjaCB0aGUgZnJhbWUgc3luY2hyb25vdXNseSwgc28gd2UgbXVzdCBj aGVjayByZXBlYXRlZGx5IGluIHRoaXMgZnVuY3Rpb24uCisgICAgaWYgKCFtX2ZyYW1lKQorICAg ICAgICByZXR1cm47CisKICAgICBpZiAoIWhhc0xpdmluZ1JlbmRlclRyZWUoKSkKICAgICAgICAg Y3JlYXRlUmVuZGVyVHJlZSgpOworICAgIGlmICghbV9mcmFtZSkKKyAgICAgICAgcmV0dXJuOwog CiAgICAgZGlzcGF0Y2hEaXNhYmxlZEFkYXB0YXRpb25zRGlkQ2hhbmdlRm9yTWFpbkZyYW1lKCk7 CisgICAgaWYgKCFtX2ZyYW1lKQorICAgICAgICByZXR1cm47CisKICAgICB1cGRhdGVWaWV3cG9y dEFyZ3VtZW50cygpOworICAgIGlmICghbV9mcmFtZSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAg Ly8gRklYTUU6IERvaW5nIHRoaXMgb25seSBmb3IgdGhlIG1haW4gZnJhbWUgaXMgaW5zdWZmaWNp ZW50LgogICAgIC8vIENoYW5naW5nIGEgc3ViZnJhbWUgY2FuIGFsc28gY2hhbmdlIHRoZSB3aGVl bCBldmVudCBoYW5kbGVyIGNvdW50LgpAQCAtMjQwNiw2ICsyNDE0LDggQEAgdm9pZCBEb2N1bWVu dDo6ZGlkQmVjb21lQ3VycmVudERvY3VtZW50SQogICAgIC8vIHVubGVzcyB0aGUgZG9jdW1lbnRz IHRoZXkgYXJlIHJlcGxhY2luZyBoYWQgd2hlZWwgZXZlbnQgaGFuZGxlcnMuCiAgICAgaWYgKHBh Z2UoKSAmJiBtX2ZyYW1lLT5pc01haW5GcmFtZSgpKQogICAgICAgICB3aGVlbEV2ZW50SGFuZGxl cnNDaGFuZ2VkKCk7CisgICAgaWYgKCFtX2ZyYW1lKQorICAgICAgICByZXR1cm47CiAKICAgICAv LyBFbnN1cmUgdGhhdCB0aGUgc2NoZWR1bGVkIHRhc2sgc3RhdGUgb2YgdGhlIGRvY3VtZW50IG1h dGNoZXMgdGhlIERPTSBzdXNwZW5zaW9uIHN0YXRlIG9mIHRoZSBmcmFtZS4gSXQgY2FuCiAgICAg Ly8gYmUgb3V0IG9mIHN5bmMgaWYgdGhlIERPTSBzdXNwZW5zaW9uIHN0YXRlIGNoYW5nZWQgd2hp bGUgdGhlIGRvY3VtZW50IHdhcyBub3QgaW4gdGhlIGZyYW1lIChwb3NzaWJseSBpbiB0aGUKQEAg LTYwOTgsNiArNjEwOCw4IEBAIHZvaWQgRG9jdW1lbnQ6OmluaXRTZWN1cml0eUNvbnRleHQoKQog CiB2b2lkIERvY3VtZW50Ojppbml0Q29udGVudFNlY3VyaXR5UG9saWN5KCkKIHsKKyAgICBpZiAo IW1fZnJhbWUpCisgICAgICAgIHJldHVybjsKICAgICBhdXRvKiBwYXJlbnRGcmFtZSA9IG1fZnJh bWUtPnRyZWUoKS5wYXJlbnQoKTsKICAgICBpZiAocGFyZW50RnJhbWUpCiAgICAgICAgIGNvbnRl bnRTZWN1cml0eVBvbGljeSgpLT5jb3B5VXBncmFkZUluc2VjdXJlUmVxdWVzdFN0YXRlRnJvbSgq cGFyZW50RnJhbWUtPmRvY3VtZW50KCktPmNvbnRlbnRTZWN1cml0eVBvbGljeSgpKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkocmV2aXNpb24gMjY0ODQx KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTA4Nyw3ICsxMDg3LDEwIEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OmNvbW1pdERh dGEoY29uc3QgY2gKICAgICAgICAgYm9vbCBoYXNCZWd1biA9IG1fd3JpdGVyLmJlZ2luKGRvY3Vt ZW50VVJMKCksIGZhbHNlKTsKICAgICAgICAgbV93cml0ZXIuc2V0RG9jdW1lbnRXYXNMb2FkZWRB c1BhcnRPZk5hdmlnYXRpb24oKTsKIAotICAgICAgICBhdXRvJiBkb2N1bWVudCA9ICptX2ZyYW1l LT5kb2N1bWVudCgpOworICAgICAgICBhdXRvKiBkb2N1bWVudE9yTnVsbCA9IG1fZnJhbWUgPyBt X2ZyYW1lLT5kb2N1bWVudCgpIDogbnVsbHB0cjsKKyAgICAgICAgaWYgKCFkb2N1bWVudE9yTnVs bCkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgYXV0byYgZG9jdW1lbnQgPSAqZG9jdW1l bnRPck51bGw7CiAKICAgICAgICAgaWYgKFNlY3VyaXR5UG9saWN5OjphbGxvd1N1YnN0aXR1dGVE YXRhQWNjZXNzVG9Mb2NhbCgpICYmIG1fb3JpZ2luYWxTdWJzdGl0dXRlRGF0YVdhc1ZhbGlkKSB7 CiAgICAgICAgICAgICAvLyBJZiB0aGlzIGRvY3VtZW50IHdhcyBsb2FkZWQgd2l0aCBzdWJzdGl0 dXRlRGF0YSwgdGhlbiB0aGUgZG9jdW1lbnQgY2FuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvU3ViZnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRl ci9TdWJmcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDI2NDg0MSkKKysrIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzMiw2ICszMzIs NyBAQCBSZWZQdHI8RnJhbWU+IEZyYW1lTG9hZGVyOjpTdWJmcmFtZUxvYWRlCiAgICAgYXV0byBm cmFtZSA9IG1fZnJhbWUubG9hZGVyKCkuY2xpZW50KCkuY3JlYXRlRnJhbWUobmFtZSwgb3duZXJF bGVtZW50KTsKICAgICBpZiAoIWZyYW1lKSAgewogICAgICAgICBtX2ZyYW1lLmxvYWRlcigpLmNo ZWNrQ2FsbEltcGxpY2l0Q2xvc2UoKTsKKyAgICAgICAgZG9jdW1lbnQtPmRlY3JlbWVudExvYWRF dmVudERlbGF5Q291bnQoKTsKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQogICAgIFJl ZmVycmVyUG9saWN5IHBvbGljeSA9IG93bmVyRWxlbWVudC5yZWZlcnJlclBvbGljeSgpOwpJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gMjY0ODQxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDctMjQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBOdWxsIGNoZWNrIGZyYW1lIGluIERv Y3VtZW50OjpkaXNwYXRjaERpc2FibGVkQWRhcHRhdGlvbnNEaWRDaGFuZ2VGb3JNYWluRnJhbWUg YW5kIGEgZmV3IG90aGVyIHBsYWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE0NzE1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NTQ2NzcwMj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNlY3Vy aXR5L211dGF0aW9uLW9ic2VydmVyLWZyYW1lLWRldGFjaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIHNlY3VyaXR5L211dGF0aW9uLW9ic2VydmVyLWZyYW1lLWRldGFjaC5odG1sOiBB ZGRlZC4KKwogMjAyMC0wNy0yNCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4K IAogICAgICAgICBbbWFjT1MgV0sxIEVXU10gY29tcG9zaXRpbmcvcmVwYWludC9pZnJhbWVzIHRl c3RzIGFyZSBmbGFreSBmYWlsdXJlcwpJbmRleDogTGF5b3V0VGVzdHMvc2VjdXJpdHkvbXV0YXRp b24tb2JzZXJ2ZXItZnJhbWUtZGV0YWNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9zZWN1cml0eS9tdXRhdGlvbi1vYnNlcnZlci1mcmFtZS1kZXRhY2gtZXhwZWN0ZWQu dHh0CShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL3NlY3VyaXR5L211dGF0aW9uLW9ic2Vy dmVyLWZyYW1lLWRldGFjaC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwy IEBACitBTEVSVDogdGVzdCBwYXNzZWQgYmVjYXVzZSBub3RoaW5nIGNyYXNoZWQKKwpJbmRleDog TGF5b3V0VGVzdHMvc2VjdXJpdHkvbXV0YXRpb24tb2JzZXJ2ZXItZnJhbWUtZGV0YWNoLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc2VjdXJpdHkvbXV0YXRpb24tb2JzZXJ2ZXItZnJh bWUtZGV0YWNoLmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvc2VjdXJpdHkvbXV0 YXRpb24tb2JzZXJ2ZXItZnJhbWUtZGV0YWNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCAr MSwyOSBAQAorPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBydW5UZXN0KCkgeworICAgICAgICB2YXIg b2JzZXJ2ZXIgPSBuZXcgTXV0YXRpb25PYnNlcnZlcigoKT0+e3AxLnJlcGxhY2VXaXRoKHAyKX0p OworICAgICAgICBvYnNlcnZlci5vYnNlcnZlKHNlbGVjdCx7Y2hpbGRMaXN0OnRydWV9KTsKKyAg ICAgICAgc2VsZWN0WzJdID0gb3B0aW9uOworICAgICAgICBkb2N1bWVudC5oZWFkLmFwcGVuZENo aWxkKHAyKTsKKyAgICAgICAgdmFyIG9iamVjdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoIm9i amVjdCIpOworICAgICAgICB2YXIgZnJhbWUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJmcmFt ZSIpOworICAgICAgICBhdWRpby5hcHBlbmRDaGlsZChvcHRpb24pOworICAgICAgICBwMS5hcHBl bmRDaGlsZChvYmplY3QpOworICAgICAgICBvYmplY3QuZGF0YSA9ICJhYmMiOworICAgICAgICBk b2N1bWVudC5hbGxbOV0uYXBwZW5kQ2hpbGQoZnJhbWUpOworCQlpZiAod2luZG93LnRlc3RSdW5u ZXIpIHsKKwkJCXRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCQkJYWxlcnQoInRlc3QgcGFzc2Vk IGJlY2F1c2Ugbm90aGluZyBjcmFzaGVkIik7CisJCX0KKyAgICB9Cis8L3NjcmlwdD4KKzxib2R5 IG9ubG9hZD1ydW5UZXN0KCk+CisgICAgPHAgaWQ9InAxIj4KKyAgICAgICAgPHAgaWQ9InAyIj4K KyAgICAgICAgICAgIDxhdWRpbyBpZD0iYXVkaW8iPgorICAgICAgICAgICAgICAgIDxzZWxlY3Qg aWQ9InNlbGVjdCI+CisgICAgICAgICAgICAgICAgICAgIDxvcHRpb24gaWQ9Im9wdGlvbiI+PC9v cHRpb24+CisgICAgICAgICAgICAgICAgPC9zZWxlY3Q+CisgICAgICAgICAgICA8L2F1ZGlvPgor ICAgICAgICA8L3A+CisgICAgPC9wPgorPC9ib2R5Pgo=