214708 2020-07-23 15:51:01 -0700 KeyframeEffect doesn't update after changing timing function 2020-07-31 08:39:27 -0700 1 1 1 Unclassified WebKit Animations Safari Technology Preview Unspecified Unspecified RESOLVED WORKSFORME https://bugs.webkit.org/show_bug.cgi?id=214712 InRadar P2 Normal --- 1 simon.fraser graouts dino graouts simon.fraser webkit-bug-importer oldest_to_newest 1674431 0 405088 simon.fraser 2020-07-23 15:51:01 -0700 Created attachment 405088 test In the attached test, hover the spinner. This should change the timing function, but the same KeyframeEffect persists, and KeyframeEffect::computeSomeKeyframesUseStepsTimingFunction() is never called. 1674440 1 simon.fraser 2020-07-23 16:02:16 -0700 KeyframeEffect::animationDidChangeTimingProperties() needs to call computeSomeKeyframesUseStepsTimingFunction(). 1676600 2 webkit-bug-importer 2020-07-30 15:51:18 -0700 <rdar://problem/66351796> 1676791 3 graouts 2020-07-31 04:20:27 -0700 The attached test works fine for me on a ToT build on macOS. When the spinner is not hovered, it progresses very slowly step-by-step while when it's hovered it has a linear animation. I didn't see any obvious difference between its behavior on a ToT build and recent Firefox and Chrome. 1676828 4 simon.fraser 2020-07-31 08:39:27 -0700 https://trac.webkit.org/changeset/264856/webkit fixed this. 405088 2020-07-23 15:51:01 -0700 2020-07-23 15:51:01 -0700 test instagram-spinner.html text/html 2359 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDxzdHlsZT4KICAgICAgICAKICAgICAg ICBzdmcgewogICAgICAgICAgICBhbmltYXRpb246IHNwaW5uZXIgNTBzIHN0ZXBzKDEyKSBpbmZp bml0ZTsgICAgIAogICAgICAgICAgICB3aWR0aDogMTAwcHg7CiAgICAgICAgICAgIGhlaWdodDog MTAwcHg7CiAgICAgICAgfQogICAgICAgIAogICAgICAgIHN2Zzpob3ZlciB7CiAgICAgICAgICAg IGFuaW1hdGlvbjogc3Bpbm5lciA1MHMgbGluZWFyIGluZmluaXRlOyAgICAgCiAgICAgICAgfQoK ICAgICAgICBAa2V5ZnJhbWVzIHNwaW5uZXIgewogICAgICAgICAgICAwJSB7CiAgICAgICAgICAg ICAgICB0cmFuc2Zvcm06cm90YXRlKDBkZWcpCiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIHRv IHsKICAgICAgICAgICAgICAgIHRyYW5zZm9ybTpyb3RhdGUoMzYwZGVnKQogICAgICAgICAgICB9 CiAgICAgICAgfQoKICAgICAgICBAa2V5ZnJhbWVzIHNwb25uZXIgewogICAgICAgICAgICAwJSB7 CiAgICAgICAgICAgICAgICB0cmFuc2Zvcm06cm90YXRlKDEwZGVnKQogICAgICAgICAgICB9Cgog ICAgICAgICAgICB0byB7CiAgICAgICAgICAgICAgICB0cmFuc2Zvcm06cm90YXRlKDM1MGRlZykK ICAgICAgICAgICAgfQogICAgICAgIH0KICAgIDwvc3R5bGU+CiAgICAKPC9oZWFkPgo8Ym9keT4K ICAgIDxzdmcgYXJpYS1sYWJlbD0iTG9hZGluZy4uLiIgY2xhc3M9IiAgQnk0bkEiIHZpZXdCb3g9 IjAgMCAxMDAgMTAwIj48cmVjdCBmaWxsPSIjNTU1NTU1IiBoZWlnaHQ9IjYiIG9wYWNpdHk9IjAi IHJ4PSIzIiByeT0iMyIgdHJhbnNmb3JtPSJyb3RhdGUoLTkwIDUwIDUwKSIgd2lkdGg9IjI1IiB4 PSI3MiIgeT0iNDciPjwvcmVjdD48cmVjdCBmaWxsPSIjNTU1NTU1IiBoZWlnaHQ9IjYiIG9wYWNp dHk9IjAuMDgzMzMzMzMzMzMzMzMzMzMiIHJ4PSIzIiByeT0iMyIgdHJhbnNmb3JtPSJyb3RhdGUo LTYwIDUwIDUwKSIgd2lkdGg9IjI1IiB4PSI3MiIgeT0iNDciPjwvcmVjdD48cmVjdCBmaWxsPSIj NTU1NTU1IiBoZWlnaHQ9IjYiIG9wYWNpdHk9IjAuMTY2NjY2NjY2NjY2NjY2NjYiIHJ4PSIzIiBy eT0iMyIgdHJhbnNmb3JtPSJyb3RhdGUoLTMwIDUwIDUwKSIgd2lkdGg9IjI1IiB4PSI3MiIgeT0i NDciPjwvcmVjdD48cmVjdCBmaWxsPSIjNTU1NTU1IiBoZWlnaHQ9IjYiIG9wYWNpdHk9IjAuMjUi IHJ4PSIzIiByeT0iMyIgdHJhbnNmb3JtPSJyb3RhdGUoMCA1MCA1MCkiIHdpZHRoPSIyNSIgeD0i NzIiIHk9IjQ3Ij48L3JlY3Q+PHJlY3QgZmlsbD0iIzU1NTU1NSIgaGVpZ2h0PSI2IiBvcGFjaXR5 PSIwLjMzMzMzMzMzMzMzMzMzMzMiIHJ4PSIzIiByeT0iMyIgdHJhbnNmb3JtPSJyb3RhdGUoMzAg NTAgNTApIiB3aWR0aD0iMjUiIHg9IjcyIiB5PSI0NyI+PC9yZWN0PjxyZWN0IGZpbGw9IiM1NTU1 NTUiIGhlaWdodD0iNiIgb3BhY2l0eT0iMC40MTY2NjY2NjY2NjY2NjY3IiByeD0iMyIgcnk9IjMi IHRyYW5zZm9ybT0icm90YXRlKDYwIDUwIDUwKSIgd2lkdGg9IjI1IiB4PSI3MiIgeT0iNDciPjwv cmVjdD48cmVjdCBmaWxsPSIjNTU1NTU1IiBoZWlnaHQ9IjYiIG9wYWNpdHk9IjAuNSIgcng9IjMi IHJ5PSIzIiB0cmFuc2Zvcm09InJvdGF0ZSg5MCA1MCA1MCkiIHdpZHRoPSIyNSIgeD0iNzIiIHk9 IjQ3Ij48L3JlY3Q+PHJlY3QgZmlsbD0iIzU1NTU1NSIgaGVpZ2h0PSI2IiBvcGFjaXR5PSIwLjU4 MzMzMzMzMzMzMzMzMzQiIHJ4PSIzIiByeT0iMyIgdHJhbnNmb3JtPSJyb3RhdGUoMTIwIDUwIDUw KSIgd2lkdGg9IjI1IiB4PSI3MiIgeT0iNDciPjwvcmVjdD48cmVjdCBmaWxsPSIjNTU1NTU1IiBo ZWlnaHQ9IjYiIG9wYWNpdHk9IjAuNjY2NjY2NjY2NjY2NjY2NiIgcng9IjMiIHJ5PSIzIiB0cmFu c2Zvcm09InJvdGF0ZSgxNTAgNTAgNTApIiB3aWR0aD0iMjUiIHg9IjcyIiB5PSI0NyI+PC9yZWN0 PjxyZWN0IGZpbGw9IiM1NTU1NTUiIGhlaWdodD0iNiIgb3BhY2l0eT0iMC43NSIgcng9IjMiIHJ5 PSIzIiB0cmFuc2Zvcm09InJvdGF0ZSgxODAgNTAgNTApIiB3aWR0aD0iMjUiIHg9IjcyIiB5PSI0 NyI+PC9yZWN0PjxyZWN0IGZpbGw9IiM1NTU1NTUiIGhlaWdodD0iNiIgb3BhY2l0eT0iMC44MzMz MzMzMzMzMzMzMzM0IiByeD0iMyIgcnk9IjMiIHRyYW5zZm9ybT0icm90YXRlKDIxMCA1MCA1MCki IHdpZHRoPSIyNSIgeD0iNzIiIHk9IjQ3Ij48L3JlY3Q+PHJlY3QgZmlsbD0iIzU1NTU1NSIgaGVp Z2h0PSI2IiBvcGFjaXR5PSIwLjkxNjY2NjY2NjY2NjY2NjYiIHJ4PSIzIiByeT0iMyIgdHJhbnNm b3JtPSJyb3RhdGUoMjQwIDUwIDUwKSIgd2lkdGg9IjI1IiB4PSI3MiIgeT0iNDciPjwvcmVjdD48 L3N2Zz4KPC9ib2R5Pgo8L2h0bWw+Cg==