<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214696</bug_id>
          
          <creation_ts>2020-07-23 12:08:39 -0700</creation_ts>
          <short_desc>Submission failure with &quot;make: *** No rule to make target `installsrc&apos;. Stop&quot;</short_desc>
          <delta_ts>2020-10-04 14:09:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Local Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Hostetler">rhost</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>darin</cc>
    
    <cc>jbedard</cc>
    
    <cc>krollin</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1674313</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 12:08:39 -0700</bug_when>
    <thetext>Submission as a single project fails with:

stderr:
make: *** No rule to make target `installsrc&apos;.  Stop.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674320</commentid>
    <comment_count>1</comment_count>
      <attachid>405066</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 12:39:43 -0700</bug_when>
    <thetext>Created attachment 405066
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674329</commentid>
    <comment_count>2</comment_count>
      <attachid>405066</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-07-23 12:54:56 -0700</bug_when>
    <thetext>Comment on attachment 405066
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405066&amp;action=review

&gt; Makefile:42
&gt; +clean:

Seems like we now have two `clean` targets?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674336</commentid>
    <comment_count>3</comment_count>
      <attachid>405066</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 13:21:45 -0700</bug_when>
    <thetext>Comment on attachment 405066
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405066&amp;action=review

&gt;&gt; Makefile:42
&gt;&gt; +clean:
&gt; 
&gt; Seems like we now have two `clean` targets?

Yes, we need a &quot;clean:\n\t&quot; as a fall-through for any projects not listed in MODULES.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674338</commentid>
    <comment_count>4</comment_count>
      <attachid>405071</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 13:30:30 -0700</bug_when>
    <thetext>Created attachment 405071
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674342</commentid>
    <comment_count>5</comment_count>
      <attachid>405071</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-07-23 13:40:36 -0700</bug_when>
    <thetext>Comment on attachment 405071
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405071&amp;action=review

&gt; Makefile:34
&gt; +	ditto Makefile $(SRCROOT)/Makefile
&gt; +	ditto Source $(SRCROOT)/Source
&gt; +	mkdir -p $(SRCROOT)/WebKitLibraries

Is modifying SRCROOT normal? It certainly sounds counter-intuitive.

Also, the flag is unnecessary in mkdir -p, and should be removed - first, SRCROOT always exists, and second, the preceding commands would have failed if it didn&apos;t.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674351</commentid>
    <comment_count>6</comment_count>
      <attachid>405071</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 13:57:06 -0700</bug_when>
    <thetext>Comment on attachment 405071
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405071&amp;action=review

&gt;&gt; Makefile:34
&gt;&gt; +	mkdir -p $(SRCROOT)/WebKitLibraries
&gt; 
&gt; Is modifying SRCROOT normal? It certainly sounds counter-intuitive.
&gt; 
&gt; Also, the flag is unnecessary in mkdir -p, and should be removed - first, SRCROOT always exists, and second, the preceding commands would have failed if it didn&apos;t.

Good catch on &apos;-p&apos; I&apos;ll remove it!

During project submission phase we fill the SRCROOT with content required for building, we do this so we don&apos;t submit the entire repository.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674362</commentid>
    <comment_count>7</comment_count>
      <attachid>405075</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 14:08:18 -0700</bug_when>
    <thetext>Created attachment 405075
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674364</commentid>
    <comment_count>8</comment_count>
      <attachid>405075</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2020-07-23 14:16:56 -0700</bug_when>
    <thetext>Comment on attachment 405075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405075&amp;action=review

&gt; Makefile:42
&gt; +clean:

We already have a clean phase, line 27</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674374</commentid>
    <comment_count>9</comment_count>
      <attachid>405075</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 14:25:16 -0700</bug_when>
    <thetext>Comment on attachment 405075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405075&amp;action=review

&gt;&gt; Makefile:42
&gt;&gt; +clean:
&gt; 
&gt; We already have a clean phase, line 27

You&apos;re right, see the comment to Tim Horton:
&quot;Yes, we need a &quot;clean:\n\t&quot; as a fall-through for any projects not listed in MODULES.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674375</commentid>
    <comment_count>10</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-07-23 14:26:34 -0700</bug_when>
    <thetext>(In reply to Ryan Hostetler from comment #9)
&gt; Comment on attachment 405075 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=405075&amp;action=review
&gt; 
&gt; &gt;&gt; Makefile:42
&gt; &gt;&gt; +clean:
&gt; &gt; 
&gt; &gt; We already have a clean phase, line 27
&gt; 
&gt; You&apos;re right, see the comment to Tim Horton:
&gt; &quot;Yes, we need a &quot;clean:\n\t&quot; as a fall-through for any projects not listed
&gt; in MODULES.&quot;

I admit I am not a Make expert, but the comment doesn&apos;t make sense to me. How are the phases different? They don&apos;t have different dependencies or anything, so should run at the same time. I&apos;m not even sure what happens if you have two identical targets!?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674391</commentid>
    <comment_count>11</comment_count>
      <attachid>405075</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-07-23 15:02:00 -0700</bug_when>
    <thetext>Comment on attachment 405075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405075&amp;action=review

&gt;&gt;&gt;&gt; Makefile:42
&gt;&gt;&gt;&gt; +clean:
&gt;&gt;&gt; 
&gt;&gt;&gt; We already have a clean phase, line 27
&gt;&gt; 
&gt;&gt; You&apos;re right, see the comment to Tim Horton:
&gt;&gt; &quot;Yes, we need a &quot;clean:\n\t&quot; as a fall-through for any projects not listed in MODULES.&quot;
&gt; 
&gt; I admit I am not a Make expert, but the comment doesn&apos;t make sense to me. How are the phases different? They don&apos;t have different dependencies or anything, so should run at the same time. I&apos;m not even sure what happens if you have two identical targets!?

I am pretty expert on make and it certainly does not make sense to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674424</commentid>
    <comment_count>12</comment_count>
    <who name="Keith Rollin">krollin</who>
    <bug_when>2020-07-23 15:45:03 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #11)
&gt; 
&gt; I am pretty expert on make and it certainly does not make sense to me.

I think you can specify a target multiple times to establish dependencies, but I think it makes sense to have only one target specify the build rules. Which means that it doesn&apos;t seem to make sense to have a bare &quot;clean:&quot; that doesn&apos;t establish any new dependencies or provide rules. If one types `make clean`, our existing first rule will get executed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674427</commentid>
    <comment_count>13</comment_count>
    <who name="Keith Rollin">krollin</who>
    <bug_when>2020-07-23 15:46:38 -0700</bug_when>
    <thetext>Is this Bug related to &lt;rdar://62268104&gt;?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674454</commentid>
    <comment_count>14</comment_count>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 16:30:22 -0700</bug_when>
    <thetext>(In reply to Keith Rollin from comment #13)
&gt; Is this Bug related to &lt;rdar://62268104&gt;?

Yes. Is there a good way to associate it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674456</commentid>
    <comment_count>15</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-07-23 16:33:11 -0700</bug_when>
    <thetext>3 things: 1) mention the radar # in a comment, 2) set the InRadar keyword 3) insert the radar # below the bugzilla URL in the ChangeLog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674457</commentid>
    <comment_count>16</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2020-07-23 16:33:28 -0700</bug_when>
    <thetext>(In reply to Tim Horton from comment #15)
&gt; 3 things: 1) mention the radar # in a comment, 2) set the InRadar keyword 3)
&gt; insert the radar # below the bugzilla URL in the ChangeLog

(as a URL; see other ChangeLog entries)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674471</commentid>
    <comment_count>17</comment_count>
    <who name="Keith Rollin">krollin</who>
    <bug_when>2020-07-23 16:55:19 -0700</bug_when>
    <thetext>(In reply to Tim Horton from comment #15)
&gt; 3 things: 1) mention the radar # in a comment, 2) set the InRadar keyword 3)
&gt; insert the radar # below the bugzilla URL in the ChangeLog

And add webkit-bug-importer to the CC list. And add the Bugzilla ID to the radar title.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674515</commentid>
    <comment_count>18</comment_count>
      <attachid>405114</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 18:35:04 -0700</bug_when>
    <thetext>Created attachment 405114
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674520</commentid>
    <comment_count>19</comment_count>
      <attachid>405117</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 19:01:29 -0700</bug_when>
    <thetext>Created attachment 405117
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674522</commentid>
    <comment_count>20</comment_count>
      <attachid>405119</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-23 19:09:46 -0700</bug_when>
    <thetext>Created attachment 405119
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674685</commentid>
    <comment_count>21</comment_count>
      <attachid>405119</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-07-24 09:26:19 -0700</bug_when>
    <thetext>Comment on attachment 405119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405119&amp;action=review

&gt; Makefile:34
&gt; +	ditto Makefile $(SRCROOT)/Makefile
&gt; +	ditto Source $(SRCROOT)/Source

I still think that this needs to recurse to actual projects.

Even though I questioned the content of installhdrs/install offline, it&apos;s not clear to me if they can be omitted completely. Are you doing end-to-end testing? I don&apos;t think that testing is blocked, maybe we should discuss it if you don&apos;t have a way to test now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674754</commentid>
    <comment_count>22</comment_count>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-07-24 11:03:57 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #21)
&gt; Comment on attachment 405119 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=405119&amp;action=review
&gt; 
&gt; &gt; Makefile:34
&gt; &gt; +	ditto Makefile $(SRCROOT)/Makefile
&gt; &gt; +	ditto Source $(SRCROOT)/Source
&gt; 
&gt; I still think that this needs to recurse to actual projects.
&gt; 
&gt; Even though I questioned the content of installhdrs/install offline, it&apos;s
&gt; not clear to me if they can be omitted completely. Are you doing end-to-end
&gt; testing? I don&apos;t think that testing is blocked, maybe we should discuss it
&gt; if you don&apos;t have a way to test now.

If we recurse the projects we end up copying the same content in more steps.

We have support for end to end testing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1674769</commentid>
    <comment_count>23</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-07-24 11:26:04 -0700</bug_when>
    <thetext>I don&apos;t expect the content to be the same. Have you compared what goes into SRCROOT before and after?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1675521</commentid>
    <comment_count>24</comment_count>
    <who name="Keith Rollin">krollin</who>
    <bug_when>2020-07-27 23:47:51 -0700</bug_when>
    <thetext>It&apos;s not apparent to me what these changes are for or why they&apos;re being made. It will probably not be apparent to future generations, either, so good explanatory comments (or directions to documentation) seem necessary.

For instance, the description of this bug is merely &quot;No rule to make target `installsrc&apos;&quot;. OK, so you added such a target. I can follow that much. But why are you updating the &quot;clean&quot; target? My first guess would be that it would clean up whatever was done by &quot;installsrc&quot;. But your change to &quot;clean&quot; effectively stubs it out under certain conditions. So it can&apos;t be the case that &quot;clean&quot; is cleaning up after &quot;installsrc&quot;. So what&apos;s the intent here?

And those &quot;certain conditions&quot; seem to involve building the WebKit project. What effect does your change have on the current process of building WebKit?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1675523</commentid>
    <comment_count>25</comment_count>
    <who name="Keith Rollin">krollin</who>
    <bug_when>2020-07-27 23:49:57 -0700</bug_when>
    <thetext>&gt; OK, so you added such a target. I can follow that much.

Though, actually, it&apos;s not clear to me why we need such a target now. We haven&apos;t needed one before. The reason for needing it now might be a good one, but it&apos;s not apparent what that reason is from the patch -- it&apos;s not self-apparent. So that reason will need to be made clear somehow and somewhere.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1677534</commentid>
    <comment_count>26</comment_count>
      <attachid>405896</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-08-03 17:39:02 -0700</bug_when>
    <thetext>Created attachment 405896
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1677643</commentid>
    <comment_count>27</comment_count>
      <attachid>405896</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-08-04 09:43:43 -0700</bug_when>
    <thetext>Comment on attachment 405896
Patch

Marking r- until there is evidence that copying everything is OK, or the patch is updated to recurse into modules and perform installsrc in each project.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1678165</commentid>
    <comment_count>28</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2020-08-05 18:16:16 -0700</bug_when>
    <thetext>As discovered while discussing offline, the EXCLUDED_INSTALLSRC_SUBDIRECTORY_PATTERNS rule in libwebrtc was added to fix the build, so bypassing it will likely break the build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1694243</commentid>
    <comment_count>29</comment_count>
      <attachid>410374</attachid>
    <who name="Ryan Hostetler">rhost</who>
    <bug_when>2020-10-02 14:52:50 -0700</bug_when>
    <thetext>Created attachment 410374
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1694571</commentid>
    <comment_count>30</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-10-04 14:09:18 -0700</bug_when>
    <thetext>Committed r267949: &lt;https://trac.webkit.org/changeset/267949&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410374.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405066</attachid>
            <date>2020-07-23 12:39:43 -0700</date>
            <delta_ts>2020-07-23 13:30:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20200723123942.patch</filename>
            <type>text/plain</type>
            <size>1382</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDc4
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3
LTIzICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNz
aW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3Rh
bGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0Njk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisJCisJ
aW5zdGFsbHNyYyBkZWZpbmVzIHdoaWNoIHNvdXJjZSBmaWxlcyB0byBpbmNsdWRlIGR1cmluZyBz
dWJtaXNzaW9uLgorCVdlYktpdExpYnJhcmllcyBjb250ZW50cyBpcyBub3QgcmVxdWlyZWQsIGJ1
dCBNT0RVTEVTIGV4cGVjdHMgdGhlIGRpcmVjdG9yeSB0byBleGlzdC4KKwlpbnN0YWxsaGRycywg
aW5zdGFsbCwgYW5kIGNsZWFuIHBoYXNlIGFyZSByZXF1aXJlZCBmb3Igc3VibWlzc2lvbiBhbmQg
YXJlIGNvbmZpZ3VyZWQgYXMgc3R1YnMuCisJCisgICAgICAgICogTWFrZWZpbGU6CisKIDIwMjAt
MDctMjEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAg
ICAgICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc1dQRS5jbWFrZSBhbmQgTkVXUyBmb3IgdGhl
IDIuMjkuMSByZWxlYXNlCkluZGV4OiBNYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBNYWtlZmlsZQko
cmV2aXNpb24gMjYzNjgxKQorKysgTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTI3LDMgKzI3
LDE3IEBAIGFuYWx5emU6CiBjbGVhbjoKIAlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBkbyAke01B
S0V9ICRAIC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKIAlpZiBbICQkZXhpdF9zdGF0dXMg
LW5lIDAgXTsgdGhlbiBleGl0ICQkZXhpdF9zdGF0dXM7IGZpOyBkb25lCisKK2luc3RhbGxzcmM6
CisJZGl0dG8gTWFrZWZpbGUgJChTUkNST09UKS9NYWtlZmlsZQorCWRpdHRvIFNvdXJjZSAkKFNS
Q1JPT1QpL1NvdXJjZQorCW1rZGlyIC1wICQoU1JDUk9PVCkvV2ViS2l0TGlicmFyaWVzCisKK2lu
c3RhbGxoZHJzOgorCW1rZGlyIC1wICQoRFNUUk9PVCkvdXNyL2xvY2FsCisKK2luc3RhbGw6CisJ
bWtkaXIgLXAgJChEU1RST09UKS91c3IvbG9jYWwKKworY2xlYW46CisJClwgTm8gbmV3bGluZSBh
dCBlbmQgb2YgZmlsZQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405071</attachid>
            <date>2020-07-23 13:30:30 -0700</date>
            <delta_ts>2020-07-23 14:08:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20200723133029.patch</filename>
            <type>text/plain</type>
            <size>1401</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDc4
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3
LTIzICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNz
aW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3Rh
bGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0Njk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaW5zdGFsbHNyYyBkZWZpbmVzIHdoaWNoIHNvdXJjZSBmaWxlcyB0byBpbmNsdWRlIGR1
cmluZyBzdWJtaXNzaW9uLgorICAgICAgICBXZWJLaXRMaWJyYXJpZXMgY29udGVudHMgaXMgbm90
IHJlcXVpcmVkLCBidXQgTU9EVUxFUyBleHBlY3RzIHRoZSBkaXJlY3RvcnkgdG8gZXhpc3QuCisg
ICAgICAgIGluc3RhbGxoZHJzLCBpbnN0YWxsLCBhbmQgY2xlYW4gcGhhc2UgYXJlIHJlcXVpcmVk
IGZvciBzdWJtaXNzaW9uIGFuZCBhcmUgY29uZmlndXJlZCBhcyBzdHVicy4KKworICAgICAgICAq
IE1ha2VmaWxlOgorCiAyMDIwLTA3LTIxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6
QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNXUEUuY21h
a2UgYW5kIE5FV1MgZm9yIHRoZSAyLjI5LjEgcmVsZWFzZQpJbmRleDogTWFrZWZpbGUKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gTWFrZWZpbGUJKHJldmlzaW9uIDI2MzY4MSkKKysrIE1ha2VmaWxlCSh3b3JraW5n
IGNvcHkpCkBAIC0yNywzICsyNywxNyBAQCBhbmFseXplOgogY2xlYW46CiAJQGZvciBkaXIgaW4g
JChNT0RVTEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0dXM9JCQ/OyBcCiAJ
aWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRfc3RhdHVzOyBmaTsg
ZG9uZQorCitpbnN0YWxsc3JjOgorCWRpdHRvIE1ha2VmaWxlICQoU1JDUk9PVCkvTWFrZWZpbGUK
KwlkaXR0byBTb3VyY2UgJChTUkNST09UKS9Tb3VyY2UKKwlta2RpciAtcCAkKFNSQ1JPT1QpL1dl
YktpdExpYnJhcmllcworCitpbnN0YWxsaGRyczoKKwlta2RpciAtcCAkKERTVFJPT1QpL3Vzci9s
b2NhbAorCitpbnN0YWxsOgorCW1rZGlyIC1wICQoRFNUUk9PVCkvdXNyL2xvY2FsCisKK2NsZWFu
OgorCQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405075</attachid>
            <date>2020-07-23 14:08:18 -0700</date>
            <delta_ts>2020-07-23 18:35:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20200723140818.patch</filename>
            <type>text/plain</type>
            <size>1398</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDc4
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3
LTIzICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNz
aW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3Rh
bGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0Njk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgaW5zdGFsbHNyYyBkZWZpbmVzIHdoaWNoIHNvdXJjZSBmaWxlcyB0byBpbmNsdWRlIGR1
cmluZyBzdWJtaXNzaW9uLgorICAgICAgICBXZWJLaXRMaWJyYXJpZXMgY29udGVudHMgaXMgbm90
IHJlcXVpcmVkLCBidXQgTU9EVUxFUyBleHBlY3RzIHRoZSBkaXJlY3RvcnkgdG8gZXhpc3QuCisg
ICAgICAgIGluc3RhbGxoZHJzLCBpbnN0YWxsLCBhbmQgY2xlYW4gcGhhc2UgYXJlIHJlcXVpcmVk
IGZvciBzdWJtaXNzaW9uIGFuZCBhcmUgY29uZmlndXJlZCBhcyBzdHVicy4KKworICAgICAgICAq
IE1ha2VmaWxlOgorCiAyMDIwLTA3LTIxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6
QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNXUEUuY21h
a2UgYW5kIE5FV1MgZm9yIHRoZSAyLjI5LjEgcmVsZWFzZQpJbmRleDogTWFrZWZpbGUKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gTWFrZWZpbGUJKHJldmlzaW9uIDI2MzY4MSkKKysrIE1ha2VmaWxlCSh3b3JraW5n
IGNvcHkpCkBAIC0yNywzICsyNywxNyBAQCBhbmFseXplOgogY2xlYW46CiAJQGZvciBkaXIgaW4g
JChNT0RVTEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0dXM9JCQ/OyBcCiAJ
aWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4aXRfc3RhdHVzOyBmaTsg
ZG9uZQorCitpbnN0YWxsc3JjOgorCWRpdHRvIE1ha2VmaWxlICQoU1JDUk9PVCkvTWFrZWZpbGUK
KwlkaXR0byBTb3VyY2UgJChTUkNST09UKS9Tb3VyY2UKKwlta2RpciAkKFNSQ1JPT1QpL1dlYktp
dExpYnJhcmllcworCitpbnN0YWxsaGRyczoKKwlta2RpciAtcCAkKERTVFJPT1QpL3Vzci9sb2Nh
bAorCitpbnN0YWxsOgorCW1rZGlyIC1wICQoRFNUUk9PVCkvdXNyL2xvY2FsCisKK2NsZWFuOgor
CQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405114</attachid>
            <date>2020-07-23 18:35:04 -0700</date>
            <delta_ts>2020-07-23 19:01:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20200723183503.patch</filename>
            <type>text/plain</type>
            <size>1446</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDc4
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3
LTIzICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNz
aW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3Rh
bGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0Njk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI2ODEwND4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpbnN0YWxsc3JjIGRlZmlu
ZXMgd2hpY2ggc291cmNlIGZpbGVzIHRvIGluY2x1ZGUgZHVyaW5nIHN1Ym1pc3Npb24uCisgICAg
ICAgIEZvciB0aGUgV2ViS2l0IHByb2plY3Qgd2Ugb25seSBuZWVkIHRoZSByb290IE1ha2VmaWxl
IGFuZCBTb3VyY2UgZGlyZWN0b3J5LgorCisgICAgICAgICogTWFrZWZpbGU6CisKIDIwMjAtMDct
MjEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAg
ICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc1dQRS5jbWFrZSBhbmQgTkVXUyBmb3IgdGhlIDIu
MjkuMSByZWxlYXNlCkluZGV4OiBNYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBNYWtlZmlsZQkocmV2
aXNpb24gMjYzNjgxKQorKysgTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTI1LDUgKzI1LDEw
IEBAIGFuYWx5emU6CiAJaWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4
aXRfc3RhdHVzOyBmaTsgZG9uZQogCiBjbGVhbjoKLQlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBk
byAke01BS0V9ICRAIC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKLQlpZiBbICQkZXhpdF9z
dGF0dXMgLW5lIDAgXTsgdGhlbiBleGl0ICQkZXhpdF9zdGF0dXM7IGZpOyBkb25lCisJQGlmIFtb
ICIkKFJDX1Byb2plY3ROYW1lKSIgPT0gIldlYktpdCIgXV07IHRoZW4gZXhpdCAwOyBmaTsgXAor
CWZvciBkaXIgaW4gJChNT0RVTEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0
dXM9JCQ/OyBcCisgICAgaWYgW1sgJCRleGl0X3N0YXR1cyAtbmUgMCBdXTsgdGhlbiBleGl0ICQk
ZXhpdF9zdGF0dXM7IGZpOyBkb25lCisKK2luc3RhbGxzcmM6CisJZGl0dG8gTWFrZWZpbGUgJChT
UkNST09UKS9NYWtlZmlsZQorCWRpdHRvIFNvdXJjZSAkKFNSQ1JPT1QpL1NvdXJjZQpcIE5vIG5l
d2xpbmUgYXQgZW5kIG9mIGZpbGUK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405117</attachid>
            <date>2020-07-23 19:01:29 -0700</date>
            <delta_ts>2020-07-23 19:09:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20200723190128.patch</filename>
            <type>text/plain</type>
            <size>1444</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDc4
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3
LTIzICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNz
aW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3Rh
bGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0Njk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI2ODEwND4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpbnN0YWxsc3JjIGRlZmlu
ZXMgd2hpY2ggc291cmNlIGZpbGVzIHRvIGluY2x1ZGUgZHVyaW5nIHN1Ym1pc3Npb24uCisgICAg
ICAgIEZvciB0aGUgV2ViS2l0IHByb2plY3Qgd2Ugb25seSBuZWVkIHRoZSByb290IE1ha2VmaWxl
IGFuZCBTb3VyY2UgZGlyZWN0b3J5LgorCisgICAgICAgICogTWFrZWZpbGU6CisKIDIwMjAtMDct
MjEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAg
ICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc1dQRS5jbWFrZSBhbmQgTkVXUyBmb3IgdGhlIDIu
MjkuMSByZWxlYXNlCkluZGV4OiBNYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBNYWtlZmlsZQkocmV2
aXNpb24gMjYzNjgxKQorKysgTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTI1LDUgKzI1LDEw
IEBAIGFuYWx5emU6CiAJaWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4
aXRfc3RhdHVzOyBmaTsgZG9uZQogCiBjbGVhbjoKLQlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBk
byAke01BS0V9ICRAIC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKLQlpZiBbICQkZXhpdF9z
dGF0dXMgLW5lIDAgXTsgdGhlbiBleGl0ICQkZXhpdF9zdGF0dXM7IGZpOyBkb25lCisJQGlmIFtb
ICIkKFJDX1Byb2plY3ROYW1lKSIgPT0gIldlYktpdCIgXV07IHRoZW4gZXhpdCAwOyBmaTsgXAor
CWZvciBkaXIgaW4gJChNT0RVTEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRpcjsgZXhpdF9zdGF0
dXM9JCQ/OyBcCisgICAgaWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4
aXRfc3RhdHVzOyBmaTsgZG9uZQorCitpbnN0YWxsc3JjOgorCWRpdHRvIE1ha2VmaWxlICQoU1JD
Uk9PVCkvTWFrZWZpbGUKKwlkaXR0byBTb3VyY2UgJChTUkNST09UKS9Tb3VyY2UKXCBObyBuZXds
aW5lIGF0IGVuZCBvZiBmaWxlCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405119</attachid>
            <date>2020-07-23 19:09:46 -0700</date>
            <delta_ts>2020-08-03 17:39:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20200723190945.patch</filename>
            <type>text/plain</type>
            <size>1442</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDc4
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3
LTIzICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNz
aW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3Rh
bGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0Njk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI2ODEwND4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBpbnN0YWxsc3JjIGRlZmlu
ZXMgd2hpY2ggc291cmNlIGZpbGVzIHRvIGluY2x1ZGUgZHVyaW5nIHN1Ym1pc3Npb24uCisgICAg
ICAgIEZvciB0aGUgV2ViS2l0IHByb2plY3Qgd2Ugb25seSBuZWVkIHRoZSByb290IE1ha2VmaWxl
IGFuZCBTb3VyY2UgZGlyZWN0b3J5LgorCisgICAgICAgICogTWFrZWZpbGU6CisKIDIwMjAtMDct
MjEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAg
ICBVbnJldmlld2VkLiBVcGRhdGUgT3B0aW9uc1dQRS5jbWFrZSBhbmQgTkVXUyBmb3IgdGhlIDIu
MjkuMSByZWxlYXNlCkluZGV4OiBNYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBNYWtlZmlsZQkocmV2
aXNpb24gMjYzNjgxKQorKysgTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTI1LDUgKzI1LDEw
IEBAIGFuYWx5emU6CiAJaWYgWyAkJGV4aXRfc3RhdHVzIC1uZSAwIF07IHRoZW4gZXhpdCAkJGV4
aXRfc3RhdHVzOyBmaTsgZG9uZQogCiBjbGVhbjoKLQlAZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBk
byAke01BS0V9ICRAIC1DICQkZGlyOyBleGl0X3N0YXR1cz0kJD87IFwKLQlpZiBbICQkZXhpdF9z
dGF0dXMgLW5lIDAgXTsgdGhlbiBleGl0ICQkZXhpdF9zdGF0dXM7IGZpOyBkb25lCisJQGlmIFsg
IiQoUkNfUHJvamVjdE5hbWUpIiA9PSAiV2ViS2l0IiBdOyB0aGVuIGV4aXQgMDsgZmk7IFwKKwlm
b3IgZGlyIGluICQoTU9EVUxFUyk7IGRvICR7TUFLRX0gJEAgLUMgJCRkaXI7IGV4aXRfc3RhdHVz
PSQkPzsgXAorICAgIGlmIFsgJCRleGl0X3N0YXR1cyAtbmUgMCBdOyB0aGVuIGV4aXQgJCRleGl0
X3N0YXR1czsgZmk7IGRvbmUKKworaW5zdGFsbHNyYzoKKwlkaXR0byBNYWtlZmlsZSAkKFNSQ1JP
T1QpL01ha2VmaWxlCisJZGl0dG8gU291cmNlICQoU1JDUk9PVCkvU291cmNlClwgTm8gbmV3bGlu
ZSBhdCBlbmQgb2YgZmlsZQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>405896</attachid>
            <date>2020-08-03 17:39:02 -0700</date>
            <delta_ts>2020-10-02 14:52:47 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20200803173901.patch</filename>
            <type>text/plain</type>
            <size>1389</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2NTIz
MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA4
LTAzICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNz
aW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3Rh
bGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MjE0Njk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI2ODEwND4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3Ig
WEJTIHNpbmdsZSBiYXNlIHByb2plY3QgYnVpbGQgZm9yIFdlYktpdCByZXBvc2l0b3J5LiAKKyAg
ICAgICAgVGhpcyBjaGFuZ2UgYWxsb3dzIGludGVybmFsIHRvb2xzIHRvIHN1Ym1pdCBhbmQgYnVp
bGQgZnJvbSB0aGUgcmVwb3NpdG9yeSByb290IGluIGEgc2luZ2xlIHN0ZXAuCisKKyAgICAgICAg
KiBNYWtlZmlsZToKKwogMjAyMC0wNy0xMyAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2
YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeGVkIGNvcHkmcGFzdGUg
dHlwb3Mgb2YgZ2NyeXB0IC0+IFRodW5kZXIKSW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t
IE1ha2VmaWxlCShyZXZpc2lvbiAyNjUyMzIpCisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpA
QCAtMjUsNSArMjUsMTAgQEAgYW5hbHl6ZToKIAlpZiBbICQkZXhpdF9zdGF0dXMgLW5lIDAgXTsg
dGhlbiBleGl0ICQkZXhpdF9zdGF0dXM7IGZpOyBkb25lCiAKIGNsZWFuOgotCUBmb3IgZGlyIGlu
ICQoTU9EVUxFUyk7IGRvICR7TUFLRX0gJEAgLUMgJCRkaXI7IGV4aXRfc3RhdHVzPSQkPzsgXAor
CUBpZiBbICIkKFJDX1Byb2plY3ROYW1lKSIgPT0gIldlYktpdCIgXTsgdGhlbiBleGl0IDA7IGZp
OyBcCisJZm9yIGRpciBpbiAkKE1PRFVMRVMpOyBkbyAke01BS0V9ICRAIC1DICQkZGlyOyBleGl0
X3N0YXR1cz0kJD87IFwKIAlpZiBbICQkZXhpdF9zdGF0dXMgLW5lIDAgXTsgdGhlbiBleGl0ICQk
ZXhpdF9zdGF0dXM7IGZpOyBkb25lCisKK2luc3RhbGxzcmM6CisJZGl0dG8gTWFrZWZpbGUgJChT
UkNST09UKS9NYWtlZmlsZQorCWRpdHRvIFNvdXJjZSAkKFNSQ1JPT1QpL1NvdXJjZQpcIE5vIG5l
d2xpbmUgYXQgZW5kIG9mIGZpbGUK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>410374</attachid>
            <date>2020-10-02 14:52:50 -0700</date>
            <delta_ts>2020-10-04 14:09:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214696-20201002145249.patch</filename>
            <type>text/plain</type>
            <size>5413</size>
            <attacher name="Ryan Hostetler">rhost</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY3ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggNmFmYTUxYmUz
ZjUxMTdjNTIwYjFkMGZhZDZhNzYwYzFlNjMxMjhhMC4uMjRkMTI0M2E0MGU3Y2Q5ZTIyODRmNjc5
MzlmMDdlNWFhNjIwMDlmOSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIw
LTEwLTAyICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJt
aXNzaW9uIGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGlu
c3RhbGxzcmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjE0Njk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI2ODEwND4KKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgaW5zdGFsbHNy
YyBwaGFzZSB0byBzdXBwb3J0IHhicyBzdWJtaXRwcm9qZWN0IGZvciBXZWJLaXQgcmVwb3NpdG9y
eS4KKyAgICAgICAgVGhpcyBjaGFuZ2UgYWxsb3dzIGludGVybmFsIHRvb2xzIHRvIHN1Ym1pdCBh
bmQgYnVpbGQgaW4gYSBzaW5nbGUgc3RlcC4KKworICAgICAgICAqIE1ha2VmaWxlOgorCiAyMDIw
LTA5LTIyICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KIAogICAgICAgICBVbmlm
eSBkZWJ1ZyBhbmQgcmVsZWFzZSB0YXJnZXQgYWxpYXNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL01h
a2VmaWxlIGIvU291cmNlL01ha2VmaWxlCmluZGV4IGJmY2E5MTI0NzA5MjYyZGJiOTI2ODg2NDMw
NjQ4ZmM1MDZlOTUyMDQuLmNlNDNmMTI2YWJkZmRjYWE0MjJhMDBiNzNmYjk5MTdmM2MxZjE4NWYg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9NYWtlZmlsZQorKysgYi9Tb3VyY2UvTWFrZWZpbGUKQEAgLTM4
LDMgKzM4LDYgQEAgYW5hbHl6ZToKIAogY2xlYW46CiAJQCQoYnVpbGRfdGFyZ2V0X2Zvcl9lYWNo
X21vZHVsZSkKKworaW5zdGFsbHNyYzoKKwlAJChidWlsZF90YXJnZXRfZm9yX2VhY2hfbW9kdWxl
KQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvTWFrZWZpbGUgYi9Tb3VyY2UvVGhpcmRQ
YXJ0eS9NYWtlZmlsZQppbmRleCBiMzg1Y2IyN2Q3Y2IwZTFjZmZkNDFmN2M2ZDRmNDlhNGE4MTcz
MmRjLi43MjQwZDZmMWZlZTRjYzg3NmY3ZGQ5ODQ5NDkyNjIzNTcwNDEyYmRjIDEwMDY0NAotLS0g
YS9Tb3VyY2UvVGhpcmRQYXJ0eS9NYWtlZmlsZQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9NYWtl
ZmlsZQpAQCAtNTIsMyArNTIsNiBAQCBhbmFseXplOgogCiBjbGVhbjoKIAlAJChidWlsZF90YXJn
ZXRfZm9yX2VhY2hfbW9kdWxlKQorCitpbnN0YWxsc3JjOgorCUAkKGJ1aWxkX3RhcmdldF9mb3Jf
ZWFjaF9tb2R1bGUpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM
b2cKaW5kZXggODM2ZDE5M2QxMzQ4YTQwZGY2OGRmMzFlMWJiNTVmMTMzYTI0ZWRlZS4uM2RmMjQ5
M2UzZDVmMzgwOGM1ZmExYzg0ZWZiNTI3YTI3Zjc5M2U3MSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh
bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTEwLTAy
ICBSeWFuIEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNzaW9u
IGZhaWx1cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3RhbGxz
cmMnLiBTdG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MjE0Njk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI2ODEwND4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgWEJT
IHNpbmdsZSBiYXNlIHByb2plY3QgYnVpbGQgZm9yIFdlYktpdCByZXBvc2l0b3J5LgorICAgICAg
ICBUaGlzIGNoYW5nZSBhbGxvd3MgaW50ZXJuYWwgdG9vbHMgdG8gc3VibWl0IGFuZCBidWlsZCBm
cm9tIHRoZSByZXBvc2l0b3J5IHJvb3QgaW4gYSBzaW5nbGUgc3RlcC4KKworICAgICAgICAqIE1h
a2VmaWxlOgorICAgICAgICBUb29scyBkb2VzIG5vdCBuZWVkIHRvIGJlIHN1Ym1pdHRlZCwgc28g
d2Ugc3R1YiBvdXQgdGhlIGluc3RhbGxzcmMgcGhhc2UuCisKIDIwMjAtMDktMzAgIFNhbSBXZWlu
aWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBjb2RlIGJlaGluZCBFTkFC
TEUoTUVESUFfU0VTU0lPTiksIG5vIHBvcnRzIGVuYWJsZSBpdApkaWZmIC0tZ2l0IGEvVG9vbHMv
TWFrZWZpbGUgYi9Ub29scy9NYWtlZmlsZQppbmRleCBlZThhMzM3ODAzZmZhYWRjODlkMGUzNWE2
MDkwNjllZTMwMWQ3MWJhLi5hMzhhNzdlMjZmMTM5ZWFkYmUyNzllNjExYzY4ZWEyYmYzNGYzOGEz
IDEwMDY0NAotLS0gYS9Ub29scy9NYWtlZmlsZQorKysgYi9Ub29scy9NYWtlZmlsZQpAQCAtNDgs
MyArNDgsNiBAQCBhbmFseXplOgogCiBjbGVhbjoKIAlAJChidWlsZF90YXJnZXRfZm9yX2VhY2hf
bW9kdWxlKQorCitpbnN0YWxsc3JjOgorCUB0cnVlCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9D
aGFuZ2VMb2cKaW5kZXggMzMwMDljZjUwNjBkOTZjODdhNDgyMTUwMDNmZmYwMDFiODBiODdkNC4u
ODQwOGFmZTBlYjc5MTk4NmM1MzIyYzhkY2QyZjQ3MzBhZTEyOTZiMCAxMDA2NDQKLS0tIGEvQ2hh
bmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTEwLTAyICBSeWFu
IEhvc3RldGxlciAgPHJob3N0QGFwcGxlLmNvbT4KKworICAgICAgICBTdWJtaXNzaW9uIGZhaWx1
cmUgd2l0aCAibWFrZTogKioqIE5vIHJ1bGUgdG8gbWFrZSB0YXJnZXQgYGluc3RhbGxzcmMnLiBT
dG9wIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0
Njk2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjI2ODEwND4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgaW5zdGFsbHNyYyBwaGFzZSB0byBz
dXBwb3J0IHhicyBzdWJtaXRwcm9qZWN0IGZvciBXZWJLaXQgcmVwb3NpdG9yeS4KKyAgICAgICAg
VGhpcyBjaGFuZ2UgYWxsb3dzIGludGVybmFsIHRvb2xzIHRvIHN1Ym1pdCBhbmQgYnVpbGQgaW4g
YSBzaW5nbGUgc3RlcC4KKworICAgICAgICAqIE1ha2VmaWxlOgorICAgICAgICAqIE1ha2VmaWxl
LnNoYXJlZDoKKyAgICAgICAgKiBTb3VyY2UvTWFrZWZpbGU6CisKIDIwMjAtMDktMzAgIFNhbSBX
ZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBjb2RlIGJlaGluZCBF
TkFCTEUoTUVESUFfU0VTU0lPTiksIG5vIHBvcnRzIGVuYWJsZSBpdApkaWZmIC0tZ2l0IGEvTWFr
ZWZpbGUgYi9NYWtlZmlsZQppbmRleCA4OWU1ZWFkNjc3MTQ2M2U2NTg2ZDllZWQ1MTE1NTI4ZTQz
ODc5NTU0Li5mZWJhMTVkZjRkYWRlMTRhYmVhM2NiYjZjOWY5MDg4MGM1N2JhOTRlIDEwMDY0NAot
LS0gYS9NYWtlZmlsZQorKysgYi9NYWtlZmlsZQpAQCAtMjgsMyArMjgsNiBAQCBhbmFseXplOgog
CiBjbGVhbjoKIAlAJChidWlsZF90YXJnZXRfZm9yX2VhY2hfbW9kdWxlKQorCitpbnN0YWxsc3Jj
OgorCSQoYnVpbGRfdGFyZ2V0X2Zvcl9lYWNoX21vZHVsZSkKZGlmZiAtLWdpdCBhL01ha2VmaWxl
LnNoYXJlZCBiL01ha2VmaWxlLnNoYXJlZAppbmRleCA0NWZiMTk5ZjQ4NDQwYzM0N2MzNDJkZDM5
ZDMzODYwODcxOTYwMjcyLi4yMTVkZjMxY2FlNTE2YTI2NTVhMjgxODc4MjYwZmQ2Mzg5NDFkNjk5
IDEwMDY0NAotLS0gYS9NYWtlZmlsZS5zaGFyZWQKKysrIGIvTWFrZWZpbGUuc2hhcmVkCkBAIC0x
MzksNCArMTM5LDcgQEAgZW5kaWYKIGNsZWFuOgogCUAkKGNhbGwgaW52b2tlX3hjb2RlLCwtYWxs
dGFyZ2V0cyBjbGVhbikKIAoraW5zdGFsbHNyYzoKKwlAJChjYWxsIGludm9rZV94Y29kZSwsLWFs
bHRhcmdldHMgaW5zdGFsbHNyYyBTUkNST09UPSIkKFNSQ1JPT1QpJChQQVRIX0ZST01fUk9PVCki
KQorCiBmb3JjZTogOwpkaWZmIC0tZ2l0IGEvV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZyBiL1dl
YktpdExpYnJhcmllcy9DaGFuZ2VMb2cKaW5kZXggMTYyNDQ2NDhkMmFhMzNhZDU3MmFkYjNjMzc0
YTMxYzc0NzBjMTU3NC4uOTc2ODZhMzk0ODk2MzcwNGQzNjVlZmYxNGIyNjMxYTBmY2Y3NDM3YiAx
MDA2NDQKLS0tIGEvV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZworKysgYi9XZWJLaXRMaWJyYXJp
ZXMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMTAtMDIgIFJ5YW4gSG9zdGV0bGVy
ICA8cmhvc3RAYXBwbGUuY29tPgorCisgICAgICAgIFN1Ym1pc3Npb24gZmFpbHVyZSB3aXRoICJt
YWtlOiAqKiogTm8gcnVsZSB0byBtYWtlIHRhcmdldCBgaW5zdGFsbHNyYycuIFN0b3AiCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ2OTYKKyAgICAg
ICAgPHJkYXI6Ly9wcm9ibGVtLzYyMjY4MTA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBYQlMgc2luZ2xlIGJhc2UgcHJv
amVjdCBidWlsZCBmb3IgV2ViS2l0IHJlcG9zaXRvcnkuCisgICAgICAgIFRoaXMgY2hhbmdlIGFs
bG93cyBpbnRlcm5hbCB0b29scyB0byBzdWJtaXQgYW5kIGJ1aWxkIGZyb20gdGhlIHJlcG9zaXRv
cnkgcm9vdCBpbiBhIHNpbmdsZSBzdGVwLgorCisgICAgICAgICogTWFrZWZpbGU6CisgICAgICAg
IFdlYktpdExpYnJhcmllcyBkbyBub3QgbmVlZCB0byBiZSBzdWJtaXR0ZWQsIHNvIHdlIHN0dWIg
b3V0IHRoZSBpbnN0YWxsc3JjIHBoYXNlLgorCiAyMDIwLTA3LTI2ICBXZW5zb24gSHNpZWggIDx3
ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNjQ2OTApOiBb
IGlPUyB3azIgXSBlZGl0aW5nL3NlbGVjdGlvbi9zaGlmdC1jbGljay1pbmNsdWRlcy1leGlzdGlu
Zy1zZWxlY3Rpb24uaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL1dlYktpdExp
YnJhcmllcy9NYWtlZmlsZSBiL1dlYktpdExpYnJhcmllcy9NYWtlZmlsZQppbmRleCA3M2FiOGUy
M2Q3NDM3MTI2OTk5YmVlOWM1ZDEzMDU0NDAwYTQ2MTNlLi5kOGMwYzk5NDc2NGE1NTQxNDYxOWI3
NjFhNDdlNzk1NzBmMjkwZDI1IDEwMDY0NAotLS0gYS9XZWJLaXRMaWJyYXJpZXMvTWFrZWZpbGUK
KysrIGIvV2ViS2l0TGlicmFyaWVzL01ha2VmaWxlCkBAIC0zNiwzICszNiw2IEBAIGFuYWx5emU6
CiAKIGNsZWFuOgogCUAkKE1BS0UpIGNsZWFubGlicworCitpbnN0YWxsc3JjOgorCUB0cnVlCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>